From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795711; cv=none; d=zohomail.com; s=zohoarc; b=M5rOhD0fRQF6g7LCsCtBX5G2P9u2V5tt7JSqTUgqXFGxce7mI52jpSHO8sbsCoy1XLHgxM8V5UyFN8ySIDOzfqoWCvYsxx4cLWt5tEgnmswpo+EmnRaRf3SRUpps+Y3sqaxmiMdsBispOCBvE3lHSh5Rq6UMBAWzbV4DD50sbsw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795711; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ntka8v41Zy5onalJgxtnwBqwcN06N2wRrhCeomWWnn0=; b=KzmVBNzo61f6a51mmeHGKfzQP4QbwBibHFMsDDWULRj59ujP2lo9XT2HJvZRt0OCHDlGShHlkEZrzSGlpE0cNQ0j5EPaNDcl5UJHR3KYfb9Pizfia7dIZgW6/gn+MOz4o2G93fs1i2sLVbTePEjTuMbzmU0m+Xq3HGPYtR4pdsM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626795711163303.57349140975555; Tue, 20 Jul 2021 08:41:51 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-290-1eFcNc-lOearIy_U-fLxzA-1; Tue, 20 Jul 2021 11:41:48 -0400 Received: by mail-wr1-f69.google.com with SMTP id h11-20020adffa8b0000b029013a357d7bdcso10469933wrr.18 for ; Tue, 20 Jul 2021 08:41:48 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id z6sm11222949wrw.9.2021.07.20.08.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ntka8v41Zy5onalJgxtnwBqwcN06N2wRrhCeomWWnn0=; b=PsZq5c0cR0HEv5n9/9IrvDTvTDr5f/48UYJdyx46EJ+z4rw7ZjJESW/pSRJyfNvBjUKZp7 LT1WKsNRsMrLMcUzWwZTeAtWkUu8DZgb4qxufJO+ocGT5QbUhYzxdr5lsccn5lpoXgdqI0 B6P0vnXa4u80dJbfMD2az17kWcDbIw0= X-MC-Unique: 1eFcNc-lOearIy_U-fLxzA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ntka8v41Zy5onalJgxtnwBqwcN06N2wRrhCeomWWnn0=; b=svVtUcu0n0qpteH7Mp0wvam1TG3z8f9eNJR3qqbdQzxthVahLPfwVamqeiqxLC0vrA nkgv6ZeR3yMycBiyybL/rMmzUqQqWPMghUdPkEJNy0kusvalKQDDHW4Vk90gEtmUZtG7 APvmZ2RZS5vdhL1jY+I2O2i2LBTFqZKNT1uMjaK1nQobCIFrpUhWVMxyuEUsL36UCfZl XEqxqkjQEZIynlJhSHCC9jxLt3T8/BQgVEOtrzEgi3QIDn3qKKuVNzP8NR2ht/LuFT/2 sd9biol2Kn3GFY+3orK8vHNHAPSFr/Kx81BukwakBT01i2WPUoqxm/uKxCdS4mwB9hPT oyHA== X-Gm-Message-State: AOAM530bWWPmfJLtR5NSHQcpCoxQD5JtOL9tRGzGCAYihhwVFee7fxG/ gVyaXt9uzTOBCF0EaInV6IuAyHMzoCQNJfKIcat4/gwC/EJNqla45bcFs03VRmtGuM/1FVtcf/o wHTqizu526Pd8qA== X-Received: by 2002:a5d:6d88:: with SMTP id l8mr28710633wrs.301.1626795707718; Tue, 20 Jul 2021 08:41:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRxhQEwGYr8mlkFYD/mnHGnX73BF/iJRYr2aEp6qXfuJeoTGbtEAjwiDwIXbvDwXc+uW+AYA== X-Received: by 2002:a5d:6d88:: with SMTP id l8mr28710625wrs.301.1626795707564; Tue, 20 Jul 2021 08:41:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 01/17] hw/mips: Add dependency MIPS_CPS -> MIPS_ITU Date: Tue, 20 Jul 2021 17:41:25 +0200 Message-Id: <20210720154141.3919817-2-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795713240100001 The Inter-Thread Communication Unit (ITU, introduced in commit 34fa7e83e11) is part of the Coherent Processing System (CPS), as describe in commit 408294352ad: Make ITU available in the system if CPU supports multithreading and is part of CPS. Have CPS select ITU in Kconfig to avoid the following build failure: /usr/bin/ld: libqemu-mips64el-softmmu.fa.p/hw_mips_cps.c.o: in function `= mips_cps_realize': hw/mips/cps.c:104: undefined reference to `mips_itu_get_tag_region' Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20190311005618.19007-5-philmd@redhat.com> --- hw/mips/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig index c245e881a2b..1d4051fcf07 100644 --- a/hw/mips/Kconfig +++ b/hw/mips/Kconfig @@ -47,6 +47,7 @@ config LOONGSON3V config MIPS_CPS bool select PTIMER + select MIPS_ITU =20 config MIPS_BOSTON bool --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795715; cv=none; d=zohomail.com; s=zohoarc; b=KpnCANKvKB46rr+yXcGnFX0HxafNl3h16pAcg4oQEPNMiHxLAvZqase9K4KIjCQfm9Bwk6FvY+YBRwEVwfTy52HeV8Mj4GvveLc9x4Il8m3AZ1ugSUG06vnWYm+jOI05LFVtVxXMc21hJ/i/EKTAHn4FhCZ8fEvR1L+X4eDRGh4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795715; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=0Sv/EUp4kMQE+EqA7VY37QPylkfosAwbv1NFxb3Vclk=; b=c2A4+o4JEp3OPveESKg6BXKQRqQ3dO8Vf4jMDH2SOXEIf4JxXJptohxyVwGFhQtIF+GyGy31MnADk0/vaZaYeuoGX9iLJCTbmxmhAXhNfZI2mVSdJvXxecV2aEiDHF6iWwP45sMUrLCc+o/lMy+xFrzaosjTXOOtj1MGO8SzyCU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626795715293966.1844712676778; Tue, 20 Jul 2021 08:41:55 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-374--wpBeomMMeGCeyh_nvhfBA-1; Tue, 20 Jul 2021 11:41:53 -0400 Received: by mail-wr1-f72.google.com with SMTP id i10-20020a5d55ca0000b029013b976502b6so10499389wrw.2 for ; Tue, 20 Jul 2021 08:41:52 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id p5sm26332572wrd.25.2021.07.20.08.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Sv/EUp4kMQE+EqA7VY37QPylkfosAwbv1NFxb3Vclk=; b=Gs+6QH4O1kK7lVJPbYG/olMbJM+KExvRm+MEdZ5awmNsFpoEURoswvkDazQAMwmoq4v+MS qMyUeXOg2qHwUAdvLEiy0zk18IOaZ6s8hmxlv9F8Fsl0ReGgQh+QLjzNqkgLNR/bRVRW8A sM0zaUJETgrtb213gYhvDRKL9SFelMU= X-MC-Unique: -wpBeomMMeGCeyh_nvhfBA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0Sv/EUp4kMQE+EqA7VY37QPylkfosAwbv1NFxb3Vclk=; b=DsX/Eqc467QePAQaYuVyw9kOryGErhXKzNDaezZG/47VXv0Hh6aDOKhny+DR9xCCLN FtvTFwwsDap5RPxWu97jYY3ZfcRh6ZVYN5ryDbCDz8M4QhGYM6UjG7L3a73TmhegmtJ9 0wErnukKN3BChiAI4W9Et6YWJmYUIvy6AWKbER7/Qm8ADw6HEYPyeSSVyzVFm1EticJM zPMj0xIdZWmRmNwW/axtDV2ru6SDJ/L5sGH3G4Cqm5YtePGvbeMbRbAsVWJhql3yAP6h WgBlpXpptrw+4uzAMoemhNo8P/0LPfTc5qRVXEZbmGzgeef18WFP6Jnvw6/i8/jDXAyy zcIQ== X-Gm-Message-State: AOAM533b2Og9ONgdVgc3cOVjIcy0z3pMD72ZqthzIQuAzQ1A5PWKVPpN PTYR41/csvczZ/HBM+ZYGw8S/5rlagKMQzpq7Q1pYIFRJ3e7vP76DcgPK4o7DjXV66BilHHz9bY 5GFP0z+dAen7a2Q== X-Received: by 2002:a1c:9d16:: with SMTP id g22mr32227904wme.152.1626795711977; Tue, 20 Jul 2021 08:41:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzRg9M3zR9NF/Xf/gwykEi5C3SPsvAGcBE2S1SL+S4ctbYqJZHvWSN4SX7o5Q9gNTeYTTwDRA== X-Received: by 2002:a1c:9d16:: with SMTP id g22mr32227889wme.152.1626795711855; Tue, 20 Jul 2021 08:41:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Paul Burton Subject: [PULL 02/17] hw/mips: Express dependencies of the Boston machine with Kconfig Date: Tue, 20 Jul 2021 17:41:26 +0200 Message-Id: <20210720154141.3919817-3-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795715712100002 Boston is built around a Xilinx FPGA, which includes a PCIe root port and an UART. An Intel EG20T PCH connects the I/O peripherals, but only the SATA bus is emulated. Reviewed-by: Thomas Huth Reviewed-by: Paul Burton Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20190311005618.19007-6-philmd@redhat.com> --- configs/devices/mips64el-softmmu/default.mak | 4 ---- hw/mips/Kconfig | 5 +++++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/configs/devices/mips64el-softmmu/default.mak b/configs/devices= /mips64el-softmmu/default.mak index c511a061bae..c610749ac13 100644 --- a/configs/devices/mips64el-softmmu/default.mak +++ b/configs/devices/mips64el-softmmu/default.mak @@ -8,8 +8,4 @@ CONFIG_ATI_VGA=3Dy CONFIG_RTL8139_PCI=3Dy CONFIG_JAZZ=3Dy CONFIG_VT82C686=3Dy -CONFIG_AHCI=3Dy CONFIG_MIPS_BOSTON=3Dy -CONFIG_FITLOADER=3Dy -CONFIG_PCI_EXPRESS=3Dy -CONFIG_PCI_EXPRESS_XILINX=3Dy diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig index 1d4051fcf07..b4c5549ce84 100644 --- a/hw/mips/Kconfig +++ b/hw/mips/Kconfig @@ -51,6 +51,11 @@ config MIPS_CPS =20 config MIPS_BOSTON bool + select FITLOADER + select MIPS_CPS + select PCI_EXPRESS_XILINX + select AHCI_ICH9 + select SERIAL =20 config FW_CFG_MIPS bool --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795719; cv=none; d=zohomail.com; s=zohoarc; b=QjsFXiKd6M6ggC+P661O546LZA6ndZaHqXLMiEUKgDmMKVxngj8CMN0zxJYg6W1tFhNPcCCBNjxIJ6u92cNH8GYAQrw9utPwc7NIwVx39Jv42VX2Nt9TaQwuiXlI1xSHAWs51sayBt3FG69HGTZiG4lqKhFomWQ61RGidIlUkxE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795719; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=FZ02lmCvE+St1io4CllH1PZSe61X92+HP6d2rWeRb4I=; b=HdI7LJvGZq1TLsCnQpWFpDb8MUerVQ+VMT9qurrKLXDf0GgSv/0cqcnkPVdZ3ayL2sZJ7ZgjYmDjg7PUOof4Cm7THg64nTivDODbB0wu4Q2kdugCUet0tfN9FwLzIB2ddLjZokmhon69a5dAyaxgSxiOOcoHDncNt24J+N02voc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 162679571994241.006510780269195; Tue, 20 Jul 2021 08:41:59 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-561-2ztdIWRXP6G4YzKtfeeu-g-1; Tue, 20 Jul 2021 11:41:57 -0400 Received: by mail-wr1-f72.google.com with SMTP id i12-20020adffc0c0000b0290140ab4d8389so10518454wrr.10 for ; Tue, 20 Jul 2021 08:41:57 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id s13sm23885232wrm.13.2021.07.20.08.41.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FZ02lmCvE+St1io4CllH1PZSe61X92+HP6d2rWeRb4I=; b=Ui2P958uRyyQ62t0cf1lWYzHui8dtShMldkbJqRK96LCBjwxNQlx8aiM50OIQiXq1j7Mjo b8SYx3kpoEJKd0jJ87I50RlIOIqzoISgBo/0tHGepvODvqtBUJdG0i/l/7FHwQDW31bIuE HPnnoTYyA19i0N2dE8YApoGuCZwQkbM= X-MC-Unique: 2ztdIWRXP6G4YzKtfeeu-g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FZ02lmCvE+St1io4CllH1PZSe61X92+HP6d2rWeRb4I=; b=fBnnUVQ7BE5YRs0vHPHLzIuEmFIlzOmxJLcKCJsnznduZk92nTs8S+wnKowAZLQIP4 GpOm1PBuBC7n4uMDSoBgPV+ADhTZpNxfP+gWWanEJUt6XaFsV1piXjNwWn2a3IZDgGZ6 GqrWal7WhgUkKmHAzVoGToR8E28ALzIPPcEIJxjEKk1ocz7xbhIJMLPiSmj6kyFdVQ4h 6Dx+q2h5CTINDpEZbndhfhYZGP9OBwL9hgM57YgEMOox5HUGGgNrCvq31DYDGRZW4pxa M19VKI5Pdy8xJqjMHTOh2/jo8QvBI5Bkbu3K2nB8N+RiZdESeCYuaY6jx3CEME6XLmVr mO3g== X-Gm-Message-State: AOAM532Gpo8/hY4hPV8+N6d4jZuj7coVaSvzlHlLLY+ABF/NwbaDixR2 EFoF1OPLhVEelcgNBkqYovltSdMXVb8okLCwg/9YYwwpCtsBtfZnvKEXgWXE7WrlezrXgAE3k0m lgJAkKMzbnP7BPw== X-Received: by 2002:adf:f411:: with SMTP id g17mr5289355wro.160.1626795716171; Tue, 20 Jul 2021 08:41:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxf0zJRy+VHWBcPCzu6hEgBR5k3+Y/Z79m3rH4pGqcs7vadum1UASt61vYDBNNSgEct+MVYkw== X-Received: by 2002:adf:f411:: with SMTP id g17mr5289346wro.160.1626795716061; Tue, 20 Jul 2021 08:41:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Michael S . Tsirkin" Subject: [PULL 03/17] hw/acpi: Do not restrict ACPI core routines to x86 architecture Date: Tue, 20 Jul 2021 17:41:27 +0200 Message-Id: <20210720154141.3919817-4-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795720323100001 ACPI core routines (in core.c) are not really x86-specific. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Michael S. Tsirkin Message-Id: <20210616204328.2611406-21-philmd@redhat.com> --- hw/acpi/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/acpi/meson.build b/hw/acpi/meson.build index 9b7fa75719c..29f804d13ea 100644 --- a/hw/acpi/meson.build +++ b/hw/acpi/meson.build @@ -3,6 +3,7 @@ 'acpi_interface.c', 'aml-build.c', 'bios-linker-loader.c', + 'core.c', 'utils.c', )) acpi_ss.add(when: 'CONFIG_ACPI_CPU_HOTPLUG', if_true: files('cpu.c')) @@ -14,7 +15,7 @@ acpi_ss.add(when: 'CONFIG_ACPI_HW_REDUCED', if_true: files('generic_event_= device.c')) acpi_ss.add(when: 'CONFIG_ACPI_HMAT', if_true: files('hmat.c')) acpi_ss.add(when: 'CONFIG_ACPI_APEI', if_true: files('ghes.c'), if_false: = files('ghes-stub.c')) -acpi_ss.add(when: 'CONFIG_ACPI_X86', if_true: files('core.c', 'piix4.c', '= pcihp.c'), if_false: files('acpi-stub.c')) +acpi_ss.add(when: 'CONFIG_ACPI_X86', if_true: files('piix4.c', 'pcihp.c')) acpi_ss.add(when: 'CONFIG_ACPI_X86_ICH', if_true: files('ich9.c', 'tco.c')) acpi_ss.add(when: 'CONFIG_IPMI', if_true: files('ipmi.c'), if_false: files= ('ipmi-stub.c')) acpi_ss.add(when: 'CONFIG_PC', if_false: files('acpi-x86-stub.c')) --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795723; cv=none; d=zohomail.com; s=zohoarc; b=bYe9gxQ9Jl9wEdkX5VrFg+qryDaJD8Lil/p+g9qJVicZOgRJGqWpln4ZFHXslwZ3nyop/hqi5CP+ef8fRF0OwXdLBlfoP9MHa3TGEA77px122lggWnfKDFEje/kRk1p3LLJvfvLw7yGAkcpx+pI5fPfSi9Gh48Wmz4BCdpbaITs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795723; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=NIRyzvMQuaJErMkX8WoS4zVpb7DIIEK+HZuTqe1W6SM=; b=n5/g98ZhxfpGggkTzm8qGCI0CqZQkYwNxLoxmcx21FZDkdwFIahcnRzmRwD/5ESE0kJbwwbEL/o9x612XsgilWhFShIRN5Dqy0kKYtBqzIDML/xnGgr3w3U7DrYDRlm8PF5EuYSkizfV7GRDf01zJoOvdeBYrzFqXa7X8BAN9DM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 162679572376692.19396311456228; Tue, 20 Jul 2021 08:42:03 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-233-RQJ-5QVqNHCq3AWSDRmCOg-1; Tue, 20 Jul 2021 11:42:01 -0400 Received: by mail-wm1-f72.google.com with SMTP id k16-20020a7bc3100000b02901d849b41038so592693wmj.7 for ; Tue, 20 Jul 2021 08:42:01 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id e11sm29629239wrt.0.2021.07.20.08.41.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:41:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NIRyzvMQuaJErMkX8WoS4zVpb7DIIEK+HZuTqe1W6SM=; b=FwuCFodq3MLhDWxiw+zGY4NDQPy1efdwaBDgo/yRxYSK9TR1TRatnFtj6nXb9JXz+MyVjQ RWKS/DjyHj0ZYwe+DjrLoUJVhJhZ475ZaI14AE8jQ90Qvi4QWmlp3UjTIwUxRueYIB0kO/ KA7/2veTR8sPzrHGjyL00pqFH9H5jdA= X-MC-Unique: RQJ-5QVqNHCq3AWSDRmCOg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NIRyzvMQuaJErMkX8WoS4zVpb7DIIEK+HZuTqe1W6SM=; b=aqyvTLScblwZ7PtRdkMkb696JKVnvk9dUcu/kvW/2w1otYH8aDcGUvEwsHOyR8+834 /AW57LZrW7WI3rJ4dG5b/UUej/GLCDi/Uf9Hb5KtFMC45QUrbUaF1gZapM+sanPrmYVF s8qoqdUUUKq36hPqdHTYSG0G8sPFIxHR24qxXm4eI05IbaMfxSgVRvFijdxYBLRhG0lN VSN5GKUHqXT9C/jc/mUHogsKn5qhQeKAhNSmNFZfTWqB+8goXEmhYq+6w1K4n/uExC2q GrAfouMYlmNpfm5/FBQ+ykEMP6o+bkLNrLKIiDNiPc5tgAktZgJ9oXugXt07anwHfVx5 28MQ== X-Gm-Message-State: AOAM5306nnvCjNGsT1O8ftvPx8cy6uHXgZ0mEA61CQM+7zudIjMVJCYH XAQAQvLfEaMgNrhRgug6HqceqVIp+AavBWMK/V/+u37ColPW+tspFj2VIr2zYb/qL5GQ8Sa+r+p 8vENAmy8J5BrsAA== X-Received: by 2002:a5d:4a43:: with SMTP id v3mr18718931wrs.194.1626795720406; Tue, 20 Jul 2021 08:42:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiv47LbIJtOeQ3ezPyWzWI5rKHj7W1ioa07D7gqNu+PfDAo0o5nvWnvyzmedKNq6cHDTHaSQ== X-Received: by 2002:a5d:4a43:: with SMTP id v3mr18718922wrs.194.1626795720268; Tue, 20 Jul 2021 08:42:00 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , "Michael S . Tsirkin" Subject: [PULL 04/17] hw/acpi/Kconfig: Add missing Kconfig dependencies (build error) Date: Tue, 20 Jul 2021 17:41:28 +0200 Message-Id: <20210720154141.3919817-5-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795724757100001 The 'microvm' machine misses various dependencies: /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in funct= ion `acpi_setup_microvm': hw/i386/acpi-microvm.c:247: undefined reference to `acpi_build_tables_ini= t' /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in funct= ion `acpi_build_microvm': hw/i386/acpi-microvm.c:192: undefined reference to `bios_linker_loader_al= loc' /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in funct= ion `build_dsdt_microvm': hw/i386/acpi-microvm.c:121: undefined reference to `init_aml_allocator' /usr/bin/ld: hw/i386/acpi-microvm.c:124: undefined reference to `acpi_dat= a_push' /usr/bin/ld: hw/i386/acpi-microvm.c:126: undefined reference to `aml_scop= e' /usr/bin/ld: hw/i386/acpi-microvm.c:129: undefined reference to `build_ge= d_aml' /usr/bin/ld: hw/i386/acpi-microvm.c:131: undefined reference to `acpi_dsd= t_add_power_button' /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in funct= ion `acpi_dsdt_add_virtio': hw/i386/acpi-microvm.c:77: undefined reference to `aml_string' /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in funct= ion `build_dsdt_microvm': hw/i386/acpi-microvm.c:138: undefined reference to `aml_scope' /usr/bin/ld: hw/i386/acpi-microvm.c:149: undefined reference to `build_he= ader' /usr/bin/ld: hw/i386/acpi-microvm.c:152: undefined reference to `free_aml= _allocator' /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in funct= ion `acpi_build_microvm': hw/i386/acpi-microvm.c:202: undefined reference to `acpi_add_table' /usr/bin/ld: hw/i386/acpi-microvm.c:203: undefined reference to `build_fa= dt' /usr/bin/ld: hw/i386/acpi-microvm.c:206: undefined reference to `acpi_add= _table' /usr/bin/ld: hw/i386/acpi-microvm.c:207: undefined reference to `acpi_bui= ld_madt' /usr/bin/ld: hw/i386/acpi-microvm.c:212: undefined reference to `build_xs= dt' /usr/bin/ld: hw/i386/acpi-microvm.c:224: undefined reference to `build_rs= dp' /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in funct= ion `acpi_setup_microvm': hw/i386/acpi-microvm.c:251: undefined reference to `acpi_add_rom_blob' /usr/bin/ld: hw/i386/acpi-microvm.c:253: undefined reference to `acpi_add= _rom_blob' /usr/bin/ld: hw/i386/acpi-microvm.c:255: undefined reference to `acpi_add= _rom_blob' /usr/bin/ld: hw/i386/acpi-microvm.c:258: undefined reference to `acpi_bui= ld_tables_cleanup' /usr/bin/ld: libqemu-i386-softmmu.fa.p/hw_i386_acpi-microvm.c.o: in funct= ion `acpi_dsdt_add_pci': hw/i386/acpi-microvm.c:105: undefined reference to `acpi_dsdt_add_gpex' collect2: error: ld returned 1 exit status ninja: build stopped: subcommand failed. Update the ACPI_HW_REDUCED symbol to select ACPI_MEMORY_HOTPLUG / ACPI_NVDIMM / ACPI. Fixes: 8045df14bcc ("microvm/acpi: add minimal acpi support") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Gerd Hoffmann Acked-by: Michael S. Tsirkin Message-Id: <20210616204328.2611406-23-philmd@redhat.com> --- hw/acpi/Kconfig | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/acpi/Kconfig b/hw/acpi/Kconfig index 1932f66af8d..cfc4ede8d91 100644 --- a/hw/acpi/Kconfig +++ b/hw/acpi/Kconfig @@ -42,3 +42,7 @@ config ACPI_VMGENID depends on PC =20 config ACPI_HW_REDUCED + bool + select ACPI + select ACPI_MEMORY_HOTPLUG + select ACPI_NVDIMM --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795728; cv=none; d=zohomail.com; s=zohoarc; b=HTTQIeq+7S8FGWwKDjunhD2RYdjJR5zgGHHe8XQRljXo5KNfpQg0KL6ZGgtUSW2HNIzwzUwnKaMW7FgxntCNB0NGdc47EtxKnKvci/smXng0jmJlLL3tau+ZAdZCl4ekYqgwcpgEitEVlp/R1tNv7i5EuGA5cvuyuJproCjhUtA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795728; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=FepJ2pJ0sSLlbKcPEXZPja0GO2DDIgofuJM+Bwm87F4=; b=OB4QGLcjrWH43EqsI7IPM/LEIsZxOeaOqBvby9qQgb7g74henkzAmX2/O1+mM7CdZu5fFX4og38hpzlTz9l5lcfD7qsmSvD2WSayIhlHSU/fsYsSnnG5J+0z6z37eIEVc1Z7vxn7Ut1CsO3L1AMEtmgyN5SkpvUSVhYIjTiEF6Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626795728055510.18839198386445; Tue, 20 Jul 2021 08:42:08 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-Wsn1j-8OOjSTDkh9oyNuXQ-1; Tue, 20 Jul 2021 11:42:05 -0400 Received: by mail-wm1-f69.google.com with SMTP id b26-20020a7bc25a0000b0290218757e2783so1378998wmj.7 for ; Tue, 20 Jul 2021 08:42:05 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id b16sm24247794wrw.46.2021.07.20.08.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FepJ2pJ0sSLlbKcPEXZPja0GO2DDIgofuJM+Bwm87F4=; b=J5HxWjfaF/k/PLachd9s95/hS4kVRR6H8REL9yYdqajybTlhpFqBigh9gwgmCeRtywWv/D sChWUhff17tjSH5J/2dI0hr8Pi3YqqQL1TviwYBSKjDb5xSFslSL4Q8YyJPVJSxKPpUBXU mmHTjCiGK34tEQ0DZ7XReTvludGPUVU= X-MC-Unique: Wsn1j-8OOjSTDkh9oyNuXQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FepJ2pJ0sSLlbKcPEXZPja0GO2DDIgofuJM+Bwm87F4=; b=OngmXwdRVNC43NP0hE4l0v0+Pqa9/p8CIRTQWPLS4NP/kKtP31TDSeqSpEk98nrMJc yo0aY1Hu3nJopCnXVgxBFqClxpiXjinL49l1znSlGkOZeI37snYCbfErkl6BqE69qykf Up423X98YiYBRMblwHzy7VQwaHunRtworJDhZCu7OYzxAJnlDhQp+iaZ3aVFG7I3E9IF yZxmS8aCBv1xPulZfLu/Nqsf/fbnucpIHHqJPrUvp7tmQtG7xnLATdUOo4IMXIc3nsHM yCJ4Por0nKaaUK/tLQHRmrsNZCmPj4iuQ4fDqwG9fBhMm8IAJpZWEcqeqYlKEmKhq0FX odsA== X-Gm-Message-State: AOAM532TbqZ93HT5s2Sw4mgHDl5tXi2Tfu59/47ZpC7LvIkdSmdGeHnw m5n8ouvY8PR6KjdX3w4jRnDn8TeSJ8HuHftIfY9J+Tyzviy2X5p6SyZQMhiiihcy2oG2HxD/Cvv y6nTo4HocRRARRw== X-Received: by 2002:adf:f949:: with SMTP id q9mr35490331wrr.178.1626795724765; Tue, 20 Jul 2021 08:42:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzAixotQRyJ7rsjEFh72SsGY61nGjEd2b+aAXgT4JCSpXPCA9QV0gawbFOpCHVP2562pxy7vw== X-Received: by 2002:adf:f949:: with SMTP id q9mr35490318wrr.178.1626795724635; Tue, 20 Jul 2021 08:42:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , "Michael S . Tsirkin" Subject: [PULL 05/17] hw/i386/Kconfig: Add missing Kconfig dependency (runtime error) Date: Tue, 20 Jul 2021 17:41:29 +0200 Message-Id: <20210720154141.3919817-6-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795729247100001 When building the 'microvm' machine stand-alone we get: $ qemu-system-x86_64 -M microvm ** ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type !=3D= NULL) Bail out! ERROR:qom/object.c:714:object_new_with_type: assertion failed: = (type !=3D NULL) Aborted (core dumped) Looking at the backtrace: (gdb) bt #3 0x00007ff2330492ff in g_assertion_message_expr () at /lib64/libglib-2= .0.so.0 #4 0x000055a878c18341 in object_new_with_type (type=3D) a= t qom/object.c:714 #5 0x000055a878c18399 in object_new (typename=3Dtypename@entry=3D0x55a87= 8dec36a "isa-pit") at qom/object.c:747 #6 0x000055a878cc8146 in qdev_new (name=3Dname@entry=3D0x55a878dec36a "i= sa-pit") at hw/core/qdev.c:153 #7 0x000055a878a8b439 in isa_new (name=3Dname@entry=3D0x55a878dec36a "is= a-pit") at hw/isa/isa-bus.c:160 #8 0x000055a878adb782 in i8254_pit_init (base=3D64, isa_irq=3D0, alt_irq= =3D0x0, bus=3D0x55a87ab38760) at include/hw/timer/i8254.h:54 #9 microvm_devices_init (mms=3D0x55a87ac36800) at hw/i386/microvm.c:263 #10 microvm_machine_state_init (machine=3D) at hw/i386/mic= rovm.c:471 #11 0x000055a878a944ab in machine_run_board_init (machine=3Dmachine@entry= =3D0x55a87ac36800) at hw/core/machine.c:1239 The "isa-pit" type (TYPE_I8254) is missing. Add it. Fixes: 0ebf007ddac ("hw/i386: Introduce the microvm machine type") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Gerd Hoffmann Acked-by: Michael S. Tsirkin Message-Id: <20210616204328.2611406-24-philmd@redhat.com> --- hw/i386/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index bad6cf5b4e6..ddedcef0b27 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -111,6 +111,7 @@ config MICROVM select ACPI_HW_REDUCED select PCI_EXPRESS_GENERIC_BRIDGE select USB_XHCI_SYSBUS + select I8254 =20 config X86_IOMMU bool --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795734; cv=none; d=zohomail.com; s=zohoarc; b=lDCdXtgQpWFWrIbOW2dguEsKiCKqT88CS9YN1wynXy4cxF2knHkMDcPHOkmZzEkw9a4i91sHszIhOUrd16Rk86APmrvBLZ+3z7MAym+khejSVy0vmf/UxDunFDeJDNIdu+9+F6+sOvR8+p1A4F631N+A6wmXn1JjMMstff9LtZY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795734; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=gVsmVb/ANphJ5S6TeR3I6otvtOxp3iNritQAJ9GWeeA=; b=DK+D2V1utK067B8xv/SeosjGE5S9O5uC0XScqIOWZHvSop58xDAqKU4TZR0pxrWKoheTC4haqGeDwa00/QH/8QCaXAhnP4htvlSSTCtSYmhSQSkMSUQKeKTzoxVmoAM+5lx8xQKlrSFXUzjv60lkdco30+JT4+2y6NTrWEEgr38= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626795734773142.8478582695791; Tue, 20 Jul 2021 08:42:14 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-0-y-JCOeOGuK-blFENI1qQ-1; Tue, 20 Jul 2021 11:42:10 -0400 Received: by mail-wr1-f69.google.com with SMTP id z6-20020a5d4c860000b029013a10564614so10495057wrs.15 for ; Tue, 20 Jul 2021 08:42:09 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id u2sm2883016wmm.37.2021.07.20.08.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gVsmVb/ANphJ5S6TeR3I6otvtOxp3iNritQAJ9GWeeA=; b=Kr85Z/Yix59hG0MGlM3KIdAJwvtmUO+AaEKTHv0O4NtR6MaJR6yFPqv0h5GSD4hGGvzhgQ AvOJHXiIiDA6UZDK7Rgt+vRXVXgGoF8XHgqnqeHiEpTsj/IkuBzk5APxYSP85mIjbiMMcO 0qgU3/EfFEG7m/s7RF2ROtwsdQKHhyw= X-MC-Unique: 0-y-JCOeOGuK-blFENI1qQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gVsmVb/ANphJ5S6TeR3I6otvtOxp3iNritQAJ9GWeeA=; b=B2V03+CSJY2ufQ60YjIuGMwDZnmL3WCsnOz1yvKbxt1mR3yHU/Dl5qTD09QAVihbjZ lGo2AUvfukD6ySFI3YUzFjptAKLZAxYpXJW+p7d8GdkH0oVXL9EZWCL8uUm6aOmn5L9v AvE9RUUOfKX/6MnmCZGgrFjs+Oe9VepK5dXKTUqmmBn02SYtY+R46P9fynZnZBPI+2hO ff72NBEp5SSOE0qKBMDHlfbYL+GfaprQo8ok+hEaj8b7H9JtfKFY7LUXBP6v5Hpbd1Lq /RKDLrFZ/yThnUmynnjhf0z9tdylaQPg/Ij0haiAhGPjXnAupzPGq1rP37CsJ7jSRqtJ 6Ytw== X-Gm-Message-State: AOAM531qvq3deEm8Ad9MmBD/Fgek9Oo/X9nuJJ2bhu8x5LHPkuXDLQww ZdNG4O/EIOE/5sHDz1OYV/q68OcUe7/QuwlwmzE4nKgwUl+B8+/+Or1ZswvIt7gm1FmE4/jpKYl O7e+wROAOHqpUEw== X-Received: by 2002:a05:600c:22d8:: with SMTP id 24mr31861283wmg.157.1626795729062; Tue, 20 Jul 2021 08:42:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlYzqcxpa7L8cQPJUqD0oXsOL6CLPFZmqvGCI59zo3XJr8ThRCFW9dscya4hK4HM3mq2OnUw== X-Received: by 2002:a05:600c:22d8:: with SMTP id 24mr31861272wmg.157.1626795728838; Tue, 20 Jul 2021 08:42:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Bin Meng , John Snow Subject: [PULL 06/17] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV Date: Tue, 20 Jul 2021 17:41:30 +0200 Message-Id: <20210720154141.3919817-7-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795735736100001 The pci_ide_create_devs() function is declared i hw/ide/qdev.c: $ git grep ide_create_drive hw/ide/pci.c:491: ide_create_drive(d->bus + bus[i], unit[i], hd= _table[i]); hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, Drive= Info *drive) include/hw/ide/internal.h:653:IDEDevice *ide_create_drive(IDEBus *bus, int= unit, DriveInfo *drive); Fix the correct symbol dependency to avoid build failure when deselecting some machines: /usr/bin/ld: libcommon.fa.p/hw_ide_pci.c.o: in function `pci_ide_create_d= evs': hw/ide/pci.c:491: undefined reference to `ide_create_drive' Fixes: 8f01b41e109 ("ide: express dependencies with Kconfig") Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210515173716.358295-3-philmd@redhat.com> Acked-by: John Snow --- hw/ide/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig index 8e2c8934549..dd85fa3619f 100644 --- a/hw/ide/Kconfig +++ b/hw/ide/Kconfig @@ -8,7 +8,7 @@ config IDE_QDEV config IDE_PCI bool depends on PCI - select IDE_CORE + select IDE_QDEV =20 config IDE_ISA bool --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795739; cv=none; d=zohomail.com; s=zohoarc; b=bqE7Dlp2KiYUW8UaJvjBT9t9u4s07yxqPEF40QeJSupz74IUVUoQE9vfdrOMFd+NMRiEm2HdG7UHhXnw5zW/lyhBEM22U1hdIOEfVYyuEXhyyH0oRK+BP8qclq/Rk9ltigMLgXNEkBpmsVcMC2c0WpmhUc2hjQtPENuZE6/HM2I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795739; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=TPsCTU8L4r8xb5MkbAmNgt4G1+BBMqLJLuOI80KFoMM=; b=UXtAdQMFbyJg6pc1281mMdJl5yDParZnSdcZoMP9cJkbpGvEaDLpK7b53H0TcjiCt9I257SuO+/9GnWsPCtEV5M8MHLst/GyPJ4ar35MyZZGHq5BQnq1f6+vXHlgKfW8G8Peav/sQWB+j++hERPzvlUJebnP31VS6t0EXLsV0WU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1626795739046306.5909410817868; Tue, 20 Jul 2021 08:42:19 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-561-TBYmV-ElOXq6IuwB5SmpvA-1; Tue, 20 Jul 2021 11:42:14 -0400 Received: by mail-wm1-f72.google.com with SMTP id 1-20020a05600c0201b029022095f349f3so945850wmi.0 for ; Tue, 20 Jul 2021 08:42:14 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id c2sm23892669wrs.60.2021.07.20.08.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TPsCTU8L4r8xb5MkbAmNgt4G1+BBMqLJLuOI80KFoMM=; b=AE7HoOYzffWwXEZM92ygeHc36VZAasufUo+Bg9SeoRGyyryAdFLrjD2KgNG2qrH3donHey N+D+xxapJWmflz8p7mskM3HMDOd2U0I6qO2TOyypb7ZB1+8V67cdhwERFcD6PwQVd6sBw3 hEYPNmeRi4Zs4hOe8rTovansnDykHAk= X-MC-Unique: TBYmV-ElOXq6IuwB5SmpvA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TPsCTU8L4r8xb5MkbAmNgt4G1+BBMqLJLuOI80KFoMM=; b=HrDsBl41FMtiux2OOiH5qoZ7nBLVLxuuvkOcJ5cAtgZ0YPoOKyQWcfThQvYIMWaagV 5Yq+5nxrScUpoM/PYs2vYQFYbdrDD9aoHB1lidH0Bp2i5oi+pcxr9D+LCtsI+eL5WnzL PqZwLPAE3qIxdAX26fQLVCJUsm7w8zcuH2ieVeGw0ZACI2Cfn0LAFa/j2xc2WmgWJVPW 5BrRfbxlimGlsTY/udE6XBk/8q89Ug8EPhfYozkJ0Nf4Nw82o+RtHzwqEKzxWHncW1+4 bJwJ8TY9JL+31Bax/ZFEhNB/prvE+t4/xJaZ6D86rR8klCdhslu4Y5D3MgAv4yrIiS+o mCDw== X-Gm-Message-State: AOAM5328aCFtalUI5hIGAKYdRGdjFSm1zd48HyQWnRYkPf6/cbLDdc57 X0gBObB3fHkdVhGa4hKpS581e3OgOrS/7+u5PHg2abKHgoW2F+fWgEubwFS93JeTsJugPrjzpbG NRXyxWzjG3kXFKg== X-Received: by 2002:a05:600c:b48:: with SMTP id k8mr39020860wmr.180.1626795733674; Tue, 20 Jul 2021 08:42:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzi7jNf/6tgIxJuaGgZuwygb8HcjM/iyjsAYT2v6JV5PaUbfJSY+6D9VzcfvW5BlFklN5BzLg== X-Received: by 2002:a05:600c:b48:: with SMTP id k8mr39020840wmr.180.1626795733450; Tue, 20 Jul 2021 08:42:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Hao Wu , Paolo Bonzini , Bin Meng Subject: [PULL 07/17] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS Date: Tue, 20 Jul 2021 17:41:31 +0200 Message-Id: <20210720154141.3919817-8-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795740042100001 The TYPE_NPCM7XX_SMBUS device model exposes an SMBus, but this isn't advertised with proper Kconfig symbol, leading to an early build failure when building NPCM7XX machines standalone: The following clauses were found for AT24C config AT24C depends on I2C select AT24C if NPCM7XX Fix by adding SMBUS to NPCM7XX. Fixes: 94e77879395 ("hw/i2c: Implement NPCM7XX SMBus Module Single Mode") Reviewed-by: Hao Wu Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210515173716.358295-4-philmd@redhat.com> --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 90b19c0861a..4a994f35e3b 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -388,6 +388,7 @@ config NPCM7XX select A9MPCORE select ADM1272 select ARM_GIC + select SMBUS select AT24C # EEPROM select MAX34451 select PL310 # cache controller --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795741; cv=none; d=zohomail.com; s=zohoarc; b=UiNT0dLtf6P5wiU8Pye4ASp6vRE500MuEiCYutK/kZXN+ZoV7lOekRM7eikC6QjcwNjSLT/6iQ62q91Xr1214CduCdt1Dbbs1Y0/pxJjMVaIWp62a2gEIyurT1YGWkI73emocovZfgzFQAkd5Xuwx6yfl1LmkRCxzdPbu1Eu7cU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795741; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=wA6+RtbQ7Um0MRpydXbUNAVoPmQJ36kPzcc30JTCS8A=; b=OBn3qXioJPMpSTQfqxW1vyaeX7/kw+zpPVVVg3fjE1IH9sED9PZ7z3VLe4+cx01591YqNTpJi4bmyGMfSc4SoxkOXwj7LDFBDLGesTI4ux7dUgA9ZZ8uNDWMB5jPwBRyp8Oe27HgtN5aNcfHu+iJgKBgPoGn0mstPDwjdPEmR2E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626795741019399.44762084497825; Tue, 20 Jul 2021 08:42:21 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-166-Hmqw10J5P6q_8rXwLhfzZA-1; Tue, 20 Jul 2021 11:42:18 -0400 Received: by mail-wr1-f72.google.com with SMTP id m4-20020adffa040000b02901404c442853so10479578wrr.12 for ; Tue, 20 Jul 2021 08:42:18 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id t5sm24166827wrw.38.2021.07.20.08.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wA6+RtbQ7Um0MRpydXbUNAVoPmQJ36kPzcc30JTCS8A=; b=MG6CWfZoqJHxap/aKy/QSiBOFoaW54zREbwPwM5wgEtmwdIKUtLYqYVUaLgTHmSh2oQlZR 1vvHaNC/rN5Hz8NHjffWGNW43z7UvEKnp8k0VePbdllj5sb9G9UFGpvys0F2oeL0ue6m7U 48CyzIl57oWs/4xjP9Ijnmy6lPbKk14= X-MC-Unique: Hmqw10J5P6q_8rXwLhfzZA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wA6+RtbQ7Um0MRpydXbUNAVoPmQJ36kPzcc30JTCS8A=; b=aQPKJsAsuXBo94t5U5HDkcuu+XaI9rM6jU1VsUDXre2AWTDzSjV9wK3tKmpqfLE2+L +4SBAPMzfX1/CZJ7jtnZwKlZphIihb/geY6Ev/BQz7JyPrKmH2ZFVaHl9uAICmf92gJY 3IDj4GZ5DD8OaCIlfh9MzcDDUXOhI/4WlYbPqwbpd/Z3IuXrJu9/VpP9/Ysaq2wHci6F R7NVwMBbaCeksO2b0/FHm9zfsIWC/KC4GNKtbCgTPkVMhGWDU3U8afEOcqbrXG6O9KOh LKnzfbG55MnrQe0BNYiTyYy7fbkC8yiwvyn/oRVDOvu6o2E/TNERhHfQ3Hcux2bGB0FS oZIw== X-Gm-Message-State: AOAM530pudPZmuChZjbt//gZIDEvCjPW4TjHwVQ4BXNJYYMV7gByEBPu WnOzIPkvort4k3UO8w39EbLcaLkl2SGnAPn87G5BlNx92nERP/oDva8gFLKleDl91ZJ6c+lAIw7 IoQY+dD0IDtwcWA== X-Received: by 2002:a1c:a709:: with SMTP id q9mr37998688wme.23.1626795737790; Tue, 20 Jul 2021 08:42:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIImfEo+T2BYV/lOyetPf0xj3lBrzSiHWRjkPCKwlXjT6+M5l73ZiIRXozJFAx5RlvACiZ/g== X-Received: by 2002:a1c:a709:: with SMTP id q9mr37998675wme.23.1626795737683; Tue, 20 Jul 2021 08:42:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Bin Meng Subject: [PULL 08/17] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board Date: Tue, 20 Jul 2021 17:41:32 +0200 Message-Id: <20210720154141.3919817-9-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795742182100001 In commit c4f00daa5b3 ("imx25-pdk: create ds1338 for qtest inside the test") we removed the DS1338 device from the i.MX25 machine but forgot to remove it in the machine Kconfig definitions, do it now. Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210515173716.358295-5-philmd@redhat.com> --- hw/arm/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 4a994f35e3b..30967da2e14 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -404,7 +404,6 @@ config FSL_IMX25 select IMX_FEC select IMX_I2C select WDT_IMX2 - select DS1338 =20 config FSL_IMX31 bool --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795745; cv=none; d=zohomail.com; s=zohoarc; b=hDfDvFkIJEK/lhZqk9C1c8C8mIoq1cdEfbE4lqJmtXyeO8w2gEUSeWoDZTf5BjTaThGW9RBYjVe7P+GVQh9uZdH9o5XD0jPyOQ9YwxwD9NCWpzU1Qtn8CKeMqe9tIrV4WRJZCxy6dWMc43AKwnOgmL+o2XOLs99RDItDN4TRVLw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795745; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Kvb5HpIjuRDlXZaWhDX69wXILzS1bxei8U/vFSO+RzE=; b=SR2+e78YyRkCrOqTLCSy6qr2jcrPPhVJ/q0rQyWsuWDVnJQkPe+gz8vhxQWKD2rIdXxvUv7wOZ440XxAONuf9jfyWWTFUJDz+ETkDv8bLU30fcF/Rt/xwME4lB0IbtJDEETmyv4DokIWVPnwQstdm9nPGl6QHz8VsvSU6iq7uEQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626795745474615.1695994752583; Tue, 20 Jul 2021 08:42:25 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-388-d3eXsg7jOLWH0Jbk5l2-_A-1; Tue, 20 Jul 2021 11:42:23 -0400 Received: by mail-wm1-f71.google.com with SMTP id 7-20020a05600c22c7b0290227b752f429so2290425wmg.4 for ; Tue, 20 Jul 2021 08:42:23 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id e6sm1836966wme.28.2021.07.20.08.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kvb5HpIjuRDlXZaWhDX69wXILzS1bxei8U/vFSO+RzE=; b=h9D1lHgzLY4GeeTpLsREobUOIx/dM+jdu8LaNKI5Xu7ZoYXnlcBGqfXoPW0AmMMeIx0Tzl LnbmgY47IU7VyqHVsdWFWyjJS85U0ytGAovw/MBdTVJGObrVlK0YBdew3fW5iI3gObDn0P YOMNZtRgfhto5AqkLJ5YIGslUVUA/pM= X-MC-Unique: d3eXsg7jOLWH0Jbk5l2-_A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kvb5HpIjuRDlXZaWhDX69wXILzS1bxei8U/vFSO+RzE=; b=IFM13iY6cSmhOGeKZ5KfqAobEInkbXZ9mKpL6N3kISKo9kj7eTIu6oTX2AJ8qVDx5o d9b7qtXNjJQ13BycZ7rfm4XYrXbZ7gsRfQ1ncKgoSPmio+mCJ+z2mUgUk3bn6qN/Gut8 e7cD1bQ2m5ied0SRqhMEisV7EtJnb603x1g59U7e8lesu4HxhgHHAFU2ClWGtnV+M2ai oeQQc2+X62W27I+qOJGkO2K8jfa5Bal86bPmzivxRF++4hrbO+cNXXSgNyPmWcpxyr+T Br6NDNR8WZi77oOZxp9fY/vWZNHt1OeQJkYLNMyp22FmvSKP2B2BAk/IPwW3zRI1ByiO vt0Q== X-Gm-Message-State: AOAM530Sp/tFowVI6JxFhGK3YqHqnRgbOW65sxGWA9LiD/LCWCxXrq8O rK5hPlieq5q81OJXoR26RF9NWmEolOrRNLJHNdyr42cH7octgCqhClz0JkkK9UexBcr7dhIVRdh pPHomu9DQjjL8yw== X-Received: by 2002:adf:f44d:: with SMTP id f13mr37125990wrp.353.1626795742215; Tue, 20 Jul 2021 08:42:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZjgtfL/v5yHofb20mFmS1MwCLRtE40RvGYa7PBui1a9H2r2Wx9RCr38aEZcH+eCYelffmaQ== X-Received: by 2002:adf:f44d:: with SMTP id f13mr37125978wrp.353.1626795742099; Tue, 20 Jul 2021 08:42:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Bin Meng Subject: [PULL 09/17] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25 Date: Tue, 20 Jul 2021 17:41:33 +0200 Message-Id: <20210720154141.3919817-10-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795746615100001 Commit bfae1772c43 ("hw/arm/fsl-imx25: Wire up eSDHC controllers") added a dependency on the TYPE_IMX_USDHC model, but forgot to add the Kconfig selector. Fix that to solve when built stand-alone: $ qemu-system-arm -M imx25-pdk qemu-system-arm: missing object type 'imx-usdhc' Aborted (core dumped) Fixes: bfae1772c43 ("hw/arm/fsl-imx25: Wire up eSDHC controllers") Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210515173716.358295-6-philmd@redhat.com> --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 30967da2e14..4ba0aca0676 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -404,6 +404,7 @@ config FSL_IMX25 select IMX_FEC select IMX_I2C select WDT_IMX2 + select SDHCI =20 config FSL_IMX31 bool --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795749; cv=none; d=zohomail.com; s=zohoarc; b=WtZmFZmbGZxSc7obgXUv7XYxrDIEuLXX1R34TNZUqRwOH5+MkJ0ov2AU7h8d/g5FXxH5cy2TWnLluvHlQ1jvw0rIe9+48AZBvSgH/yDWPQl+iI8Mm3djXEVoj/bDQT9S9U5HAcGGqRP5l2S0waGUn3zOi6oRL1LZr+YTrERfJ2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795749; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=rqXYU/PxcgPvoefVIbDKIx4Oq81EFF0UhzX0mVLsvu0=; b=IwB/1bwlz1WKKSqQHNC3A6fjmmAaNYVBJdQv2aLV+ztXXWXGxGkJKI6HGdUPBvv39LqPz2zbDib8VtYQJ4HasoSs4Sw/IiYyPCktrl5Sxe7otQrLkgM9WWZbAKx1Yxn3xUWpUgrMGOYJ+X99fJcCLbN2SbbFaWBfuzu1DfVfAJM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626795749927171.52102839949123; Tue, 20 Jul 2021 08:42:29 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-KZE0e4M7Oka2Dt2AyHPVXg-1; Tue, 20 Jul 2021 11:42:27 -0400 Received: by mail-wr1-f72.google.com with SMTP id h15-20020adffd4f0000b0290137e68ed637so10412102wrs.22 for ; Tue, 20 Jul 2021 08:42:27 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id n5sm2737607wmd.4.2021.07.20.08.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rqXYU/PxcgPvoefVIbDKIx4Oq81EFF0UhzX0mVLsvu0=; b=QOo7+luBXcPOGyApTSPWd8GgXKE7FfiYTPxfsEV5J671S9XMH/H1PpzrmJpMFYC9HPHxle dTLGyrm6Ce5usZ+/fOPsfXHCBBpnR8SPxP7HOR9pIQJiBXGY9b5uYbr18IRbdfqTlsO9B0 6NP+MehMUdd9qarLt2AXHzLal4d45Gg= X-MC-Unique: KZE0e4M7Oka2Dt2AyHPVXg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rqXYU/PxcgPvoefVIbDKIx4Oq81EFF0UhzX0mVLsvu0=; b=a9SAMBqDMp8L80h0SvpR2V6f+LFdVn6p1MZ2Jc8yslABKtvYkFxpfVkx+fHU+fWT4d 1o77rmHFSqQjBOLEQ+00ueo+b3+RcXB/bwe5x4zw+ZHfsEoSZcANDl9wa10vWNyYf/Lu SNlUfM5zDQSrnsqzkdWVSRG6nkKmi8LTsmrEo5XiNPFLh8ipSe/SHBFLRnNTYU8EMBMS q03niBb+2TZn9oWBP8LFiXQE4ElH3ZxitUUKmQyQUcC0UVP7Sj+aMOROFuZYmgn1gYjo 8qcRKjjJvsYtj2PNFT8F6YlEQc9n4RLN4MurYL2ITVXyeC62Jwh57RdMw61kDkYGa4jS 9ZLw== X-Gm-Message-State: AOAM531S2P0NuzQHhODmaha3DuH4GQ0NhBDsgd3DiREMjAY3NBENoxGN 3lUftUGiW2yXaKhLzBKU1pSf/nCdhkio9lJfUTuHgyg5Bp10mckTYDExLqXHbtAYZOwJ4ATDD1B LQwcKayIcqNvpew== X-Received: by 2002:a7b:c013:: with SMTP id c19mr37621489wmb.158.1626795746458; Tue, 20 Jul 2021 08:42:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxx4iylR7B4RFdXbmNcxwsmOYdvDAmZeJlTVlqOoF7Gt8h7JNXj4eMb1w4uNPQqGyhSKr5Q9Q== X-Received: by 2002:a7b:c013:: with SMTP id c19mr37621478wmb.158.1626795746328; Tue, 20 Jul 2021 08:42:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Alistair Francis , Bin Meng Subject: [PULL 10/17] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL Date: Tue, 20 Jul 2021 17:41:34 +0200 Message-Id: <20210720154141.3919817-11-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795751004100001 Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") added a dependency on the SERIAL model, but forgot to add the Kconfig selector. Add the dependency to the MCHP_PFSOC_MMUART symbol to fix when building the MICROCHIP_PFSOC machine stand-alone: /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function `m= chp_pfsoc_mmuart_create': hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init' Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") Acked-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210515173716.358295-7-philmd@redhat.com> Reviewed-by: Alistair Francis Reviewed-by: Bin Meng --- hw/char/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/Kconfig b/hw/char/Kconfig index 4cf36ac637b..2e4f620b13e 100644 --- a/hw/char/Kconfig +++ b/hw/char/Kconfig @@ -61,6 +61,7 @@ config AVR_USART =20 config MCHP_PFSOC_MMUART bool + select SERIAL =20 config SIFIVE_UART bool --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795754; cv=none; d=zohomail.com; s=zohoarc; b=H/oaFItTeeQIHy47l9xJkvdfI8wAi4DFqVXU4ocuNq8vLFq0D7Dpg1h0q4e4SbUu1to9g10OMkWDobpl+VHNtTXEyJ43lmTdDmxidSzro9gHBNLXEMUPoNg3PkAtvrXEXC/5QdYYf6RzNjmXjeFipmTEDwILQO6azXss0PyWONQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795754; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=OTWqF5j01lrfXdYS+sckUTHsMubMM9qF0ZRvuOGu5Ko=; b=TSa8WHMS0kvBo/si+1CdhBHV7xaVHck8Tec8AOXs5Cd06JiVqEpBQQAdO6LQH7R9j2MnTiqM1v2Crl+t+a2ah1mxh51GE7ujCMgt/hXv/lI6ifNJrSgQy6k9aexVgCQ49KjJUZEcRC1Bil02JlEWJ3Vtg6RaKFwKRsB5/FcOPzM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 16267957543871016.2388491838307; Tue, 20 Jul 2021 08:42:34 -0700 (PDT) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-SDwkGEl9MbqQ8ixu8f54-w-1; Tue, 20 Jul 2021 11:42:32 -0400 Received: by mail-wr1-f71.google.com with SMTP id h11-20020adffa8b0000b029013a357d7bdcso10470673wrr.18 for ; Tue, 20 Jul 2021 08:42:31 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id l14sm22911607wrs.22.2021.07.20.08.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OTWqF5j01lrfXdYS+sckUTHsMubMM9qF0ZRvuOGu5Ko=; b=SF8iUYLEOJKIGxK1wPbMMue+8aeUp7i+yZHZSsE/43LB+NHGInZVdWSPy5tTs1Yh5t263o zaxrfD2/8s0EM7l9SgxgzfG2CaI7nQpcRl1Uv8rFXewRz1ReSqYwubTgZuxCnCPY66AsUl 7S4P90D59G2ojEMOa4nfWW4FGb7C6Oc= X-MC-Unique: SDwkGEl9MbqQ8ixu8f54-w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OTWqF5j01lrfXdYS+sckUTHsMubMM9qF0ZRvuOGu5Ko=; b=pwDtSV8EMnLZ3+UR8LE5TsyXGf3DVCe6HReEFYdXOR6W4e18VJVO2OOzZOQmI0hc7y hSYSz4Lip6iWo4LJIr8Af1CKNmLjTwTd0DBHFqS/d6ECfySejh2gRSaf1wf9fgkpJFlz MDrP3BeSVsMaLxFXy8xGaRE6sne3C7/MwwwkdtYzGO4BRHvf8b31jeIkepRyeCb4cPDR BPdLpZLAv+T03MmmyRviI2eWJKVH645ZlBWBkZ1hPuDxhZqJfXdfuKvs6nJNZSJGdnY/ iYd4Z0CjZoawZzbJA5uYvHMq1LBqmieCi6nvcP6y8lrcrdJXtBfnrTW0EUeWqz0MvVRK T3fg== X-Gm-Message-State: AOAM5338mKQEBy7ZU6enpxIDVBJ08H/xhh5K/k7qzbTmdkmamjbrhDiD DGzbl5IQqy3nkf8A5PcnptgLhBQWyB8sbERzAcxOvUJMaYHqex0tPNmKkuMLD4PGJzWLur3CtIh 9TOc4QO+OFOCXug== X-Received: by 2002:a5d:464b:: with SMTP id j11mr37090923wrs.356.1626795750894; Tue, 20 Jul 2021 08:42:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz190psKarMH+XfCol/svTKqPjB2NfoQv0LhjU1apj1SGhTxuLEAkSIhaCDeCUDV0n+XQde9w== X-Received: by 2002:a5d:464b:: with SMTP id j11mr37090906wrs.356.1626795750728; Tue, 20 Jul 2021 08:42:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , Bin Meng , Alistair Francis Subject: [PULL 11/17] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines Date: Tue, 20 Jul 2021 17:41:35 +0200 Message-Id: <20210720154141.3919817-12-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795755345100001 Only the Virt and Spike machines use NUMA. Add a RISCV_NUMA Kconfig symbol and only have these machines select it. Adapt the Meson file to only built it if required. Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210515173716.358295-8-philmd@redhat.com> Reviewed-by: Alistair Francis --- hw/riscv/Kconfig | 5 +++++ hw/riscv/meson.build | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig index 86957ec7b06..0590f443fdf 100644 --- a/hw/riscv/Kconfig +++ b/hw/riscv/Kconfig @@ -1,3 +1,6 @@ +config RISCV_NUMA + bool + config IBEX bool =20 @@ -34,6 +37,7 @@ config RISCV_VIRT imply PCI_DEVICES imply VIRTIO_VGA imply TEST_DEVICES + select RISCV_NUMA select GOLDFISH_RTC select MSI_NONBROKEN select PCI @@ -74,6 +78,7 @@ config SIFIVE_U =20 config SPIKE bool + select RISCV_NUMA select HTIF select MSI_NONBROKEN select SIFIVE_CLINT diff --git a/hw/riscv/meson.build b/hw/riscv/meson.build index a97454661c0..ab6cae57eae 100644 --- a/hw/riscv/meson.build +++ b/hw/riscv/meson.build @@ -1,6 +1,6 @@ riscv_ss =3D ss.source_set() riscv_ss.add(files('boot.c'), fdt) -riscv_ss.add(files('numa.c')) +riscv_ss.add(when: 'CONFIG_RISCV_NUMA', if_true: files('numa.c')) riscv_ss.add(files('riscv_hart.c')) riscv_ss.add(when: 'CONFIG_OPENTITAN', if_true: files('opentitan.c')) riscv_ss.add(when: 'CONFIG_RISCV_VIRT', if_true: files('virt.c')) --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795758; cv=none; d=zohomail.com; s=zohoarc; b=AQLB4K+054nHcaw6SjQA5kKXhX8+CMNUFEcSWl0JEj552DQhnqaMowhCBMNniO83Gx2pBbz5UDD8T9gz90ib57rjiC9U/7DDfn2b+PJ6mN4TbbxgEzRLGaBw5FMXJkCGRP7AXZRFt2OrYIO5OAZOc1EheZpeQbwxpvpNcSy7Rpg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795758; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=GzDQgdGV/hfvQP6GwfosBu6lb8Nm+mns6f7nRKorcs0=; b=Isvo5zbH+oP8vgoD7i+Aw2LRR7DRquezTjKUBYsJJ/8T07gnvHFngLZM3bEMgPMW3w5ldP59iyijW9EknmqrZzg5kQC7VUWMCsQdlahCAP+jDPiw4N0pOPwdbHw2Lm2tAcdhRlZkqXq9FLfETt2vxJbdNVqKcdKgTxAPlbUuLgk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1626795758718452.5862960875876; Tue, 20 Jul 2021 08:42:38 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-221-aJ6kLjOmM5aQZGWEr3hV5g-1; Tue, 20 Jul 2021 11:42:36 -0400 Received: by mail-wr1-f69.google.com with SMTP id a4-20020adffb840000b02901304c660e75so10359096wrr.19 for ; Tue, 20 Jul 2021 08:42:36 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id 139sm3026875wma.32.2021.07.20.08.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GzDQgdGV/hfvQP6GwfosBu6lb8Nm+mns6f7nRKorcs0=; b=DoM5j1H1BBkxVKnVzguF9VK68DkbTqsoSoW2t54hjzSqQBXBg+eScZYWYUvIVi+5Lx6Re/ DP9Q7T8MfyPXfOMWTa3rcapZQPNTmD/n6aiOR+QakV9EwgrOY9vZIbtcTZV55FgvWN98yq hsIr93rpf00ftU6qrBho8JlswgPIKZ8= X-MC-Unique: aJ6kLjOmM5aQZGWEr3hV5g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GzDQgdGV/hfvQP6GwfosBu6lb8Nm+mns6f7nRKorcs0=; b=VJ/7dBtPaXC511LtwWD/IFNMPmL6cC9eXoJKylXR2BAOqkO4kdE9r8xgavfjKQ9g9d gsgXAr7x8i1Z/R3NiAkYKazu3HZFrAIAw8/Mr1cuxHqu2VviuavSZIf3/BRAVdbySj1S pfDl5/Ko2maEM6YkYOGHTH9iTpNGmhWR+h0/vAypl+eWsruDXSbA8JQOxwEO9jwwYozw d+YZsFjRq6TfohZ6w6tEqKsyoy7EvrzJYMIFFNyGw58clV5XUXXZeS/PUVD8+3cu1tlb qsfdS0Q7orvQ85lYphojff5qUO+j8/1YHokv5MKP60Fog3iLqhOFqSlxO8OXzRd4F6gA TGKw== X-Gm-Message-State: AOAM533NGLvE5cBnUe7knG2BBl6l/sN9LCLIVx1xDQhGBM0wIJLK7uXj 8J24ujMh6tSnQLeluvRoxJwkd9ZaudJTqx+mDpRLzyS0vZx7ttr5eVo0OZXNintabisaKfM0o42 ZXx8ACAN65kcS3g== X-Received: by 2002:a1c:1c7:: with SMTP id 190mr31917260wmb.170.1626795755296; Tue, 20 Jul 2021 08:42:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBzaB3BJia38L3FVAqToQixpO9qEad8p3gYH6AAanfD9ToVvQPnzaWz5TGy/ucGnZtEgkE0g== X-Received: by 2002:a1c:1c7:: with SMTP id 190mr31917251wmb.170.1626795755119; Tue, 20 Jul 2021 08:42:35 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , David Gibson , Bin Meng Subject: [PULL 12/17] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC Date: Tue, 20 Jul 2021 17:41:36 +0200 Message-Id: <20210720154141.3919817-13-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795760023100001 Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") added a global dependency on the DS1338 model, instead of a machine one (via Kconfig). This gives trouble when building standalone machines not exposing I2C bus: The following clauses were found for DS1338 CONFIG_DS1338=3Dy config DS1338 depends on I2C Fix by selecting the DS1338 symbol in the single machine requiring it, the E500. Fixes: 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC wi= th it") Acked-by: Paolo Bonzini Acked-by: David Gibson Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210513163858.3928976-9-philmd@redhat.com> --- configs/devices/ppc-softmmu/default.mak | 1 - hw/ppc/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/devices/ppc-softmmu/default.mak b/configs/devices/ppc-= softmmu/default.mak index 4535993d8d5..658a454426e 100644 --- a/configs/devices/ppc-softmmu/default.mak +++ b/configs/devices/ppc-softmmu/default.mak @@ -1,7 +1,6 @@ # Default configuration for ppc-softmmu =20 # For embedded PPCs: -CONFIG_DS1338=3Dy CONFIG_E500=3Dy CONFIG_PPC405=3Dy CONFIG_PPC440=3Dy diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index 322a7eb031e..85b9c93f02e 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -130,6 +130,7 @@ config E500 select SERIAL select MPC_I2C select FDT_PPC + select DS1338 =20 config VIRTEX bool --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795763; cv=none; d=zohomail.com; s=zohoarc; b=YMtrEpBoyvPRF+koVWCE5DTX3o48bIPGJHhgUE4TWcEMk8Oy3zlcVN11AJ6qK+/BeMf1LdnhbCXRLKa1rY+Vc1BQX5aO8WqLWrElJb3w5oZZuac37ffqZb2T5pV80a5UGOcQdQf+sCYnJiihsRcxUG4LrOVPqKuDwcivMAEdDZo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795763; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=m2q8B88WKdmDTY0Ntr/x46Vm417E92okf4Gv3DLjALU=; b=h6kQ52VUFWJ+gYYakASheHpEFPL5LwqX7YJqH9DdY+UnQjilr57eNbJtO4vKi1ZbDi6bZmeVrikxlMz7THknFlYj3peDnsbviVzivUtn7n+H2YoCqOSAGjJcGdZtcD8mbpRs7JJNyo4RrGSygu9sYgXesHP3XMWjmXY6Hu6T2f4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1626795763427424.9759755749211; Tue, 20 Jul 2021 08:42:43 -0700 (PDT) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-lTupufZnMOavGesd6YBSGQ-1; Tue, 20 Jul 2021 11:42:41 -0400 Received: by mail-wm1-f70.google.com with SMTP id k5-20020a7bc3050000b02901e081f69d80so2286375wmj.8 for ; Tue, 20 Jul 2021 08:42:40 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id d8sm25089772wra.41.2021.07.20.08.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m2q8B88WKdmDTY0Ntr/x46Vm417E92okf4Gv3DLjALU=; b=Yeh3CKMeg+SxRQKfdv0bxxlEpvmJo73cjH4peaY+6RxG24eATEjL5DrVmfg+HRHlgkB1FM 6abLqlUNxquf+suSImCDF5benmf53Rj02f56zNyp/kKGH6o5ktQ8b2ASBtoDMm3b35ipTh 22kCotVPRWxi2k2++Yv7NmRDJKi+5ss= X-MC-Unique: lTupufZnMOavGesd6YBSGQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=m2q8B88WKdmDTY0Ntr/x46Vm417E92okf4Gv3DLjALU=; b=CRUPhqR/G9zvcrr8DxVvLND4GGUUt3r25KlKfJV6wG3txj5IGceiIAEe7r6iyPnBve mhFuXzZggYDC0A0K8y1argZHTlJRGWkxGDFwo4riivk8Jk0Cx4/ppu/TON1ZQLt4U0KI A+hvdzHPWqnzDJVx3aoiS/r5ndN7CWjDp/3Ys0LYEu1AhKsIoaOoKh7VN2PrisAwJTJI RSO8rNmO+SvXQIHMba1IKeI1iWymwlvIWaPd72FkDwc+7WnLUm5SVC651EF0L+Ysby14 SEsvmQsOdxT+R9zYZxd1qJh6yo/EgPk2VNUXY0owuzobrrd1fqA1PqBecnuTAabEM+6x jW2A== X-Gm-Message-State: AOAM5328XQIaaYB9JSRgWvWOFG8kJtNt5hOLk0eR0ZuBiu+s1meAazmz Xm8t76P2+VVTBcmz8Eoaav9KxfLU/Q5oRtRCqOfS9ab9VjQxm4jcwvMangtFacST1Kd3Z/7POmE vrEgGifircdShUg== X-Received: by 2002:a05:6000:10c3:: with SMTP id b3mr36898425wrx.271.1626795759570; Tue, 20 Jul 2021 08:42:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJybMDFDLzKmiQKQvhCjuwl/2oCqC2YEn2TmcK4OGT+xZno02pNjz+rlm4JEZvWK2jHWFE+U5Q== X-Received: by 2002:a05:6000:10c3:: with SMTP id b3mr36898412wrx.271.1626795759408; Tue, 20 Jul 2021 08:42:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , BALATON Zoltan , Bin Meng , David Gibson Subject: [PULL 13/17] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259 Date: Tue, 20 Jul 2021 17:41:37 +0200 Message-Id: <20210720154141.3919817-14-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795764484100001 From: Philippe Mathieu-Daud=C3=A9 Looking at the MV64340 model source, there is a dependency on the 8259 interrupt controller: 523 case MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG: 524 /* FIXME: Should this be sent via the PCI bus somehow? */ 525 if (s->gpp_int_level && (s->gpp_value & BIT(31))) { 526 ret =3D pic_read_irq(isa_pic); 527 } 528 break; Add it to Kconfig to avoid the following build failure: /usr/bin/ld: libcommon.fa.p/hw_pci-host_mv64361.c.o: in function `mv64361= _read': hw/pci-host/mv64361.c:526: undefined reference to `isa_pic' /usr/bin/ld: hw/pci-host/mv64361.c:526: undefined reference to `pic_read_= irq' Fixes: dcdf98a9015 ("hw/pci-host: Add emulation of Marvell MV64361 PPC syst= em controller") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: BALATON Zoltan Reviewed-by: Bin Meng Acked-by: David Gibson Message-Id: <20210515173716.358295-10-philmd@redhat.com> --- hw/pci-host/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig index 84494400b86..2b5f7d58cc5 100644 --- a/hw/pci-host/Kconfig +++ b/hw/pci-host/Kconfig @@ -76,3 +76,4 @@ config SH_PCI config MV64361 bool select PCI + select I8259 --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795769; cv=none; d=zohomail.com; s=zohoarc; b=nb5ObgEXFCvHOfngU1dqQ2EuJhuHcilQnVSkfeNC6DCsSxW2YuT6gcz1DnMz76RTbpYNs2ODoBhPNGfW7+SHm2JrE/ck61+DkRp2HQA+z9/fpli9igqX2rw12KvKCH5J6WSoyZhOxLNMnWX/zVDET14cdmAC5CZtyLVE/Nrle0Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795769; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=+EpP9cqqfCS+Ot9ShPaMqErBIc8w+8RJbLCEIxxcLRw=; b=R0DFkUUMZS6CanWmFAgSPdVtKBsIYnNpkKaVnuE3CvF/gvcCTMvs09EET0mwKWPCbrn/YoIFVVo5RGLf/vAvDuecy7tld+xGROkcg/CdrHsJZD13gpYLA9oGxIc2GBzlyAi+gdJa02pK2ZRc8i8lbJB6rD2tdiEZIRYKhRAu4PA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626795769269793.4245422502148; Tue, 20 Jul 2021 08:42:49 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-336-O0p5iywiPkCfbHCD2j2fUg-1; Tue, 20 Jul 2021 11:42:44 -0400 Received: by mail-wm1-f69.google.com with SMTP id 7-20020a05600c22c7b0290227b752f429so2290516wmg.4 for ; Tue, 20 Jul 2021 08:42:44 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id o7sm28065464wrv.72.2021.07.20.08.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+EpP9cqqfCS+Ot9ShPaMqErBIc8w+8RJbLCEIxxcLRw=; b=EXwcNmzLyBynR6GIpC+YmmzEsimhSY22jfRuWRB89xIeZhJHPG0mMER5KX7CrEEsGPq+i4 DzuWjW4BQ3TTLDtVGiPJ0HJ5+ErkvE7BGUH+27YyUXOAmPf/Jj2+e6meV3vN65aqjnEPQ7 VjDKK29oGaAXwF9uA7aT9pObeTmJxIk= X-MC-Unique: O0p5iywiPkCfbHCD2j2fUg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+EpP9cqqfCS+Ot9ShPaMqErBIc8w+8RJbLCEIxxcLRw=; b=r5+NApvgMy6+i2veDWwD6T0+QUglOoieHkbcQldjU+GBwBw/8iQcwm8MUXkVbp20d1 V6RGuTYTjDggurGECqsCSwXKuvCnrMI8mWJzH7/9xq2CSZo4ETsfrsiFn81UBeLEGo8l pz9AWbHDJyN01tAOmRSV6TRPJNrcsD5xVV68iMNYQQ5ONgxDurtLT3GiVUWiQOz0Shpj deiYPT2i1O2q7Yo2zZ9XwrKYbsU/LPQMpgEv707lNce7LVLgqNjxnW+3iMtLlVP9azY2 /iMZ5F0iAn4MRWZebBPAUIXZ8T6AjlnI32Bw4kSoNvhsdbp2mHvIZc4TFVjH99FJ2VzD 8uMQ== X-Gm-Message-State: AOAM533EVyI2/w0jlD3s0oVeeTh0qFZJrzt5K6bZbYv1ccFaek99VC8+ UEk60OTForN36kUkzOUTmSizUbRP4OmQqCfZyUItiJfKvb7pWvT/xCLM0kzErMptxnsTk1SvKm4 vSh/iX+ntf61aog== X-Received: by 2002:a7b:ce95:: with SMTP id q21mr38024421wmj.101.1626795763863; Tue, 20 Jul 2021 08:42:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxEJRPMetME02nR7dUiuZkkK5YBr36WoalP1VIyjg/H5AIYJuHnc/RpddsX4veDYtGiyc66Ow== X-Received: by 2002:a7b:ce95:: with SMTP id q21mr38024410wmj.101.1626795763692; Tue, 20 Jul 2021 08:42:43 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , BALATON Zoltan , Bin Meng Subject: [PULL 14/17] hw/isa/vt82c686: Add missing Kconfig dependencies (build error) Date: Tue, 20 Jul 2021 17:41:38 +0200 Message-Id: <20210720154141.3919817-15-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795771077100001 From: Philippe Mathieu-Daud=C3=A9 The VT82C686 device model misses various dependencies: /usr/bin/ld: libcommon.fa.p/hw_isa_vt82c686.c.o: in function `vt82c686b_r= ealize': hw/isa/vt82c686.c:622: undefined reference to `i8259_init' /usr/bin/ld: hw/isa/vt82c686.c:624: undefined reference to `i8257_dma_ini= t' /usr/bin/ld: hw/isa/vt82c686.c:627: undefined reference to `mc146818_rtc_= init' Add them. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: BALATON Zoltan Reviewed-by: Bin Meng Message-Id: <20210515173716.358295-11-philmd@redhat.com> --- hw/isa/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 96db170eff3..f99df0e20b1 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -50,6 +50,9 @@ config VT82C686 select FDC_ISA select USB_UHCI select APM + select I8257 + select I8259 + select MC146818RTC =20 config SMC37C669 bool --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795771; cv=none; d=zohomail.com; s=zohoarc; b=BIzAfK/tiGF0C7gbyj8cKbZKeuKNk+ps/Ns3Dwe5dE7wzo7lIjlNFUGwA/UT1KgcB12trq4El/CbGqueydlIFcxt7hFGoUTF3g1NSBpyMoh3D4xg1svEC//4wOup4YloZde62C5uaIGh75hex2rSSUy8IKU0Z+qUVobCx6nWMes= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795771; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ke+K8CUdvIjT9wDwvnpP72CHpJjDbX0XKOULAYpAuTc=; b=ju2SQTC3M3VOkec1J4rxnJNYbrZya6bYe58KhWOzSKQMhIQ4FMobFGwlZkBWOeoLCxxar8It0oGrrhLuFEP/6V+46Obq2h6TGM7NWyo7HgfzglmS7t2/+B0HgHd4ydJcASl7u7P2IHiQ8jRqe/B8xp6rCht8GYvhojptGwk/2HM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626795771695456.4853656774128; Tue, 20 Jul 2021 08:42:51 -0700 (PDT) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-540-cX-6Uq8dM7WEyQ_6BgwlJQ-1; Tue, 20 Jul 2021 11:42:49 -0400 Received: by mail-wm1-f70.google.com with SMTP id l17-20020a05600c4f11b0290225ef65c35dso597691wmq.2 for ; Tue, 20 Jul 2021 08:42:49 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id o3sm24165228wrm.5.2021.07.20.08.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ke+K8CUdvIjT9wDwvnpP72CHpJjDbX0XKOULAYpAuTc=; b=L4li5YXWRkSNHfTwSP//FAiElMq9pLK2aGYBJ5c1T4TuX7+I/QzPzpEXTqpxEddldLVJvY iHsY2mjT9Ere/UTZSHf3uzGQwVEO5VaeBcCG3YswO1dBniS1lKl7WL6gtJb1HnZq/G2aSa GIJEqLf1Cf7yQHNJ7tp2W2d0xNQ8FeU= X-MC-Unique: cX-6Uq8dM7WEyQ_6BgwlJQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ke+K8CUdvIjT9wDwvnpP72CHpJjDbX0XKOULAYpAuTc=; b=GJd5ggX7Xra67Qv9gU8RRSLSA0L8/AOAbTwbp/WsFXRTYamdt7HlfxjPhPneRKiazw CT4uyU6Of+q4TM6s/jQEGFEOw4QmVYV8GSG55oYdgHTYj6wmAJAWK4MAM8JmYhkHVf+h Xna/LZZwvLzYwgVbZvrCjxVgUeWf3ugNVWtYyHmowRmChH7T62LAweMXAa7O3B5vJVrw i7HI9CUqpWNCzCH0Wmg/nJ9ty+X/DtBuY8WrKKaPznGBsGlwkvU0REYTYg4ysvDWqEEM f2HcZ6M2ITAE8diFdiJQlbD/HKgyIL7WuN3vCTmDSYX5uimGrNHjYHxHFytmFFkyNXaq 994A== X-Gm-Message-State: AOAM531X1REUSjrayDzIrkCZLQSRQUv03HExrX6hsltfS3cIX19lVR4R uH4TqYYTSGMXfSSjx8UAwqPQo2AzhKpkdTqKBRVJIAmRcYVthW+Olg5X13MdIP4VvJd3rlPsTTS WZ1uNGheMPTHq9A== X-Received: by 2002:adf:e5ce:: with SMTP id a14mr35740314wrn.226.1626795768094; Tue, 20 Jul 2021 08:42:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFjbDELn9PlVoMETbMcfKgU2MpoocKRAUMvu9ehxkvDcZjGQAk7yjfnceBxktfN5Y4tvyqXg== X-Received: by 2002:adf:e5ce:: with SMTP id a14mr35740295wrn.226.1626795767907; Tue, 20 Jul 2021 08:42:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , BALATON Zoltan , Bin Meng Subject: [PULL 15/17] hw/isa/vt82c686: Add missing Kconfig dependency (runtime error) Date: Tue, 20 Jul 2021 17:41:39 +0200 Message-Id: <20210720154141.3919817-16-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795773209100001 From: Philippe Mathieu-Daud=C3=A9 When building the Pegasos2 machine stand-alone we get: $ qemu-system-ppc -M pegasos2 -bios pegasos2.rom ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type !=3D= NULL) Bail out! ERROR:qom/object.c:714:object_new_with_type: assertion failed: = (type !=3D NULL) Looking at the backtrace: Thread 1 "qemu-system-ppc" received signal SIGABRT, Aborted. (gdb) bt #0 0x00007ffff53877d5 in raise () at /lib64/libc.so.6 #1 0x00007ffff5370895 in abort () at /lib64/libc.so.6 #2 0x00007ffff6dc4b6c in g_assertion_message_expr.cold () at /lib64/libg= lib-2.0.so.0 #3 0x00007ffff6e229ff in g_assertion_message_expr () at /lib64/libglib-2= .0.so.0 #4 0x0000555555a0c8f4 in object_new_with_type (type=3D0x0) at qom/object= .c:714 #5 0x0000555555a0c9d5 in object_new (typename=3D0x555555c7afe4 "isa-pit"= ) at qom/object.c:747 #6 0x0000555555a053b8 in qdev_new (name=3D0x555555c7afe4 "isa-pit") at h= w/core/qdev.c:153 #7 0x00005555557cdd05 in isa_new (name=3D0x555555c7afe4 "isa-pit") at hw= /isa/isa-bus.c:160 #8 0x00005555557cf518 in i8254_pit_init (bus=3D0x55555603d140, base=3D64= , isa_irq=3D0, alt_irq=3D0x0) at include/hw/timer/i8254.h:54 #9 0x00005555557d12f9 in vt8231_realize (d=3D0x5555563d9770, errp=3D0x7f= ffffffcc28) at hw/isa/vt82c686.c:704 #10 0x00005555557e1340 in pci_qdev_realize (qdev=3D0x5555563d9770, errp= =3D0x7fffffffcca0) at hw/pci/pci.c:2116 #11 0x0000555555a06a84 in device_set_realized (obj=3D0x5555563d9770, valu= e=3Dtrue, errp=3D0x7fffffffcda8) at hw/core/qdev.c:761 #12 0x0000555555a0ff9e in property_set_bool (obj=3D0x5555563d9770, v=3D0x= 5555563da090, name=3D0x555555cd7881 "realized", opaque=3D0x5555560acf80, er= rp=3D0x7fffffffcda8) at qom/object.c:2257 #13 0x0000555555a0e098 in object_property_set (obj=3D0x5555563d9770, name= =3D0x555555cd7881 "realized", v=3D0x5555563da090, errp=3D0x555555fc3fa0 ) at qom/object.c:1402 #14 0x0000555555a12271 in object_property_set_qobject (obj=3D0x5555563d97= 70, name=3D0x555555cd7881 "realized", value=3D0x5555563cf0a0, errp=3D0x5555= 55fc3fa0 ) at qom/qom-qobject.c:28 #15 0x0000555555a0e3fb in object_property_set_bool (obj=3D0x5555563d9770,= name=3D0x555555cd7881 "realized", value=3Dtrue, errp=3D0x555555fc3fa0 ) at qom/object.c:1472 #16 0x0000555555a05b15 in qdev_realize (dev=3D0x5555563d9770, bus=3D0x555= 5563d32b0, errp=3D0x555555fc3fa0 ) at hw/core/qdev.c:389 #17 0x0000555555a05b42 in qdev_realize_and_unref (dev=3D0x5555563d9770, b= us=3D0x5555563d32b0, errp=3D0x555555fc3fa0 ) at hw/core/qdev.c= :396 #18 0x00005555557e160f in pci_realize_and_unref (dev=3D0x5555563d9770, bu= s=3D0x5555563d32b0, errp=3D0x555555fc3fa0 ) at hw/pci/pci.c:21= 81 #19 0x00005555557e165b in pci_create_simple_multifunction (bus=3D0x555556= 3d32b0, devfn=3D96, multifunction=3Dtrue, name=3D0x555555c9b63b "vt8231-isa= ") at hw/pci/pci.c:2189 #20 0x0000555555867730 in pegasos2_init (machine=3D0x5555560427a0) at hw/= ppc/pegasos2.c:105 The "isa-pit" type (TYPE_I8254) is missing. Add it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210515173716.358295-12-philmd@redhat.com> Reviewed-by: BALATON Zoltan Reviewed-by: Bin Meng --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index f99df0e20b1..e4db60ed580 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -50,6 +50,7 @@ config VT82C686 select FDC_ISA select USB_UHCI select APM + select I8254 select I8257 select I8259 select MC146818RTC --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795822; cv=none; d=zohomail.com; s=zohoarc; b=L3cMilqQ1RR5dd7DwS/3HziuHM8aHMUy11+CSHYEMR0TWCfNOQznBZF5o9ioMGSMqPCogSnpgAVzNLL7E3ZlPAq7qmCgzWEFvAyZT08jcWCnSk68LoBVxiS8Is0lKkQNdHdWODb1QcD7wY7pZfdNst6/zKx2qaCFc7CF8HbOHF0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795822; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ayhsRddHReRSICrLmRl62O2leez/9W0/J5F8AflVyQk=; b=YZzsbsB3XLKvnMrCgAjBqPPzlV4JtIzueujLP1PgOY6tf8BLJICwubCJ7zeU/R2IW0wGEhbN/Xy1UgBsaCLuFRO4fgyqlpEhYtr7L1SV49u8ozmFlBM/FdAGs/UMAMRT9ovt5mt9mZx4IRpgQZ7iFYP+SgxnH2l3/1E4Z3HxqvU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1626795822501927.9218252017704; Tue, 20 Jul 2021 08:43:42 -0700 (PDT) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-19-lv7fZInbP92XauoxBJwxPQ-1; Tue, 20 Jul 2021 11:42:53 -0400 Received: by mail-wr1-f70.google.com with SMTP id z6-20020a5d4c860000b029013a10564614so10495833wrs.15 for ; Tue, 20 Jul 2021 08:42:53 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id p18sm2672018wmg.46.2021.07.20.08.42.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ayhsRddHReRSICrLmRl62O2leez/9W0/J5F8AflVyQk=; b=eV0DgMICf+25RyPDJy9k9t9Glji2CKmbpsniOAaWDMArHAypYHdoG875nT38fSd4lhIShA AOwdoGyYLylVCJLmVJnFOSfqBaIrR2upBQM7kCDmRN4bzFRqKQVTuIdkfqPPeegC7wAcWJ XfBgs4BK3sbQDaubhpnVa3AZW+0nzgM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ayhsRddHReRSICrLmRl62O2leez/9W0/J5F8AflVyQk=; b=OBHjVmn/y9D7hZS8Uh/sbst3JfMApyCiqxDnqpwltBg5rT99FCQDE9BO/wkY2H31bYOJjV 37rfzoO9mJ+qd09PSIBtuPkSZPJXbNZ7WOCOwL/Hz3zyJ+jFOcmxCN5sLlSnRRyDhoT3IY Kwc6DFVvbcBHi2n5iT0rmBpKAZoXFTg= X-MC-Unique: lv7fZInbP92XauoxBJwxPQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ayhsRddHReRSICrLmRl62O2leez/9W0/J5F8AflVyQk=; b=qooPhq59HeZL4J6jC11Upt0eN1tBsg49Pc9OhaQuQEtpXSk/g77hFDrcUWSCEWCEu3 3j1iADLxmC+U3n83TR4G1mMJyfiv9E47LZoAVtkKhQcAhVKj2dYkpqRakIsQheXYfKtl R9Jjcd50sccoWnxfZ19QhpzXuDIkM46zQLZwxrpfUfqG5sP8XFDspfWbNsRnqJ4vlL1V KiVwngBwBdknNV/QX8vJ49lzoW7NKY+y9i/9cEIrNa9EZ9Hqg1NZ8CWqRfxyhDAU4DIv 7/PKerdoYqRTg1e2V5QoAPCxyVRAHqTHDef7tw7f5wtyadKKuO+jOOM8H19+6lyc2n0G R5hw== X-Gm-Message-State: AOAM532hIhf/tr9OVvcGvd6q7qcJJe7h0zhEwL+r8sKqBJWvWBavPQzM DGUjruUlPe4Qqo8hhoAKXjBnGYqz7C+elbbObLCyZDv2g3aLEAPUZ6iMvAB1tqhcJr7frGEQ6PN gxiPt1Qqtzc74qQ== X-Received: by 2002:a05:6000:1544:: with SMTP id 4mr37531273wry.288.1626795772458; Tue, 20 Jul 2021 08:42:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwn82OYkN17aG3BwG8a6zIvixzMAvkvK5QD7g/y7gQnrQYJ+xDdv/y7lxFoIoPQtCbK+JZKkw== X-Received: by 2002:a05:6000:1544:: with SMTP id 4mr37531261wry.288.1626795772335; Tue, 20 Jul 2021 08:42:52 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , BALATON Zoltan , Bin Meng , David Gibson Subject: [PULL 16/17] hw/ppc/Kconfig: Add dependency PEGASOS2 -> ATI_VGA Date: Tue, 20 Jul 2021 17:41:40 +0200 Message-Id: <20210720154141.3919817-17-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) (identity @redhat.com) X-ZM-MESSAGEID: 1626795824601100005 From: Philippe Mathieu-Daud=C3=A9 The ATI VGA device isn't a requisite for the Pegasos2 machine because Linux only uses the serial console; see commit ba7e5ac18e7 ("hw/ppc: Add emulation of Genesi/bPlan Pegasos II") for rationale. Using the default devices we don't have any problem: $ qemu-system-ppc -M pegasos2 qemu-system-ppc: standard VGA not available But when trying to explicitly use the ATI device we get an error: $ qemu-system-ppc -M pegasos2 -vga none -bios pegasos2.rom -device ati-vg= a,romfile=3D qemu-system-ppc: -device ati-vga,romfile=3D: 'ati-vga' is not a valid dev= ice model name Add it as an implicit Kconfig dependency. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210515173716.358295-13-philmd@redhat.com> Acked-by: BALATON Zoltan Reviewed-by: Bin Meng Acked-by: David Gibson --- hw/ppc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index 85b9c93f02e..400511c6b70 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -79,6 +79,7 @@ config PEGASOS2 select VOF # This should come with VT82C686 select ACPI_X86 + imply ATI_VGA =20 config PREP bool --=20 2.31.1 From nobody Sat May 18 12:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626795786; cv=none; d=zohomail.com; s=zohoarc; b=crayHzcoDgiIU/ZCJJ+Qxri5A3s+ixyXlqyLAa+ZpHh26QC1IFJzHL/amJeIZB3eRvyZn3XKn+luOfPvG96Ex7Z+X3hqEO3MNidxOkB5fGK3XEbCw1EapJ1k1AmzULALHUeZVhfXcqDZcxDbQCxsqygw5OERMw4LXKUuKarNHQk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626795786; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=1seFm9k4hBvj3dV8pqZnTfUxP5CfPuhkGJILwrP/ssI=; b=Pqrot1Rfd4Gr4Ch4UEnSJIyrr54yqDFTHULyhRbR6KXqkIth9vzMQ/u9PXJaWPL9A8VtFumAr0V6oSGInfurcdIdMMmxiqMQaa+AHmnIufsqRM3p57PKg6Vt1k/U0qITAH/DoZWT73BcJOXiv/BiZnQELYtJVvlPHUo8xR3kRIQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1626795786782298.5392711182151; Tue, 20 Jul 2021 08:43:06 -0700 (PDT) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-EhnObZO4NU-mXnvmPLa57g-1; Tue, 20 Jul 2021 11:42:58 -0400 Received: by mail-wr1-f71.google.com with SMTP id r9-20020a5d49890000b02901524df25ad7so781368wrq.8 for ; Tue, 20 Jul 2021 08:42:57 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id g138sm24019610wmg.32.2021.07.20.08.42.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jul 2021 08:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626795779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1seFm9k4hBvj3dV8pqZnTfUxP5CfPuhkGJILwrP/ssI=; b=YZYuOYNUYfLFr4qCDNSsQfTuS6yVpKx2j+2g/G4pDZXXbGyVCsQviM9Z5qKKRafESbWBpW KuxJhODAY3NkqbtlDoLIWD+RO+JMkc7Cg/Ouy//j9M5Y8gUycAhHpN3C7e7f0NbyqZLv6W Kf3HVUzY/vUIM+xaZiZWB4txBiih2wg= X-MC-Unique: EhnObZO4NU-mXnvmPLa57g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1seFm9k4hBvj3dV8pqZnTfUxP5CfPuhkGJILwrP/ssI=; b=fAfElPlMsJfwEPlt6h2Mf6J1RNBR0oSIUOHp/WdzQ4O8QqCuaPDOomlveY9LyY0LYk Oggvxs8+T+1HdfxtdjceWD4GEha+9SxzlqEBGcp1kyKKdWOSrn5Ws03kbq0aRJWmkLWg OeTRbSc0wGPO3Rus3vK0LRj1+6+XMelKDOyZo1UygyLf2Rag82r+KXp2Z+WUjM3PDrqx fidejTmXdSxxri3ijAUPN2utrz6Q7N8wi7Hn6fr63yn/NEE+RvnWjDiPV15LHLME3jGx mcw5TQGq+tN/G1yyJj3aDQSa3D/A+lpsnGEXaD2OdLU85DCXcfaNiTvPXg+9h5rChCGl 94Ag== X-Gm-Message-State: AOAM530JyVOSh797ErAAUGZXbR/Sea5wrm1NVIWNG5Up5XFyT6fOC9q0 Xz9Dc3E4EtXk3nbSRwPykKmrpDhbD3wLqub5DJLPbwLSBcAmEerVrOpS67mZmCzuTcImCcA60nI nDmNn8Hd3w5IByw== X-Received: by 2002:a7b:c1c2:: with SMTP id a2mr31004361wmj.15.1626795776899; Tue, 20 Jul 2021 08:42:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzG8A/XIMJ/ADxcZWxG6BmwhT7HbRSF0XnnTa9EQN3+kJrwgloCRWG+TVsgwAmnsTguRjXUjA== X-Received: by 2002:a7b:c1c2:: with SMTP id a2mr31004345wmj.15.1626795776755; Tue, 20 Jul 2021 08:42:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 17/17] hw/tricore: fix inclusion of tricore_testboard Date: Tue, 20 Jul 2021 17:41:41 +0200 Message-Id: <20210720154141.3919817-18-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210720154141.3919817-1-philmd@redhat.com> References: <20210720154141.3919817-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626795788014100001 From: Alex Benn=C3=A9e Because commit f4063f9c319e39 ("meson: Introduce target-specific Kconfig") ended being merged after commit 582079c9d27fc8cfff9f49 ("hw/tricore: Add testdevice for tests in tests/tcg/"), we inadvertently added a symbol clash causing the build not to include the testboard needed for check-tcg. Fixes: f4063f9c31 ("meson: Introduce target-specific Kconfig") Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e Message-Id: <20210720114057.32053-2-alex.bennee@linaro.org> [PMD: Updated description mentioning commits merged] Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- configs/devices/tricore-softmmu/default.mak | 1 + hw/tricore/Kconfig | 3 +-- hw/tricore/meson.build | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configs/devices/tricore-softmmu/default.mak b/configs/devices/= tricore-softmmu/default.mak index 5cc91cebce7..cb8fc286eb2 100644 --- a/configs/devices/tricore-softmmu/default.mak +++ b/configs/devices/tricore-softmmu/default.mak @@ -1 +1,2 @@ +CONFIG_TRICORE_TESTBOARD=3Dy CONFIG_TRIBOARD=3Dy diff --git a/hw/tricore/Kconfig b/hw/tricore/Kconfig index 506e6183c17..33c1e852c33 100644 --- a/hw/tricore/Kconfig +++ b/hw/tricore/Kconfig @@ -1,9 +1,8 @@ -config TRICORE +config TRICORE_TESTBOARD bool =20 config TRIBOARD bool - select TRICORE select TC27X_SOC =20 config TC27X_SOC diff --git a/hw/tricore/meson.build b/hw/tricore/meson.build index 47e36bb0778..7e3585daf8f 100644 --- a/hw/tricore/meson.build +++ b/hw/tricore/meson.build @@ -1,6 +1,6 @@ tricore_ss =3D ss.source_set() -tricore_ss.add(when: 'CONFIG_TRICORE', if_true: files('tricore_testboard.c= ')) -tricore_ss.add(when: 'CONFIG_TRICORE', if_true: files('tricore_testdevice.= c')) +tricore_ss.add(when: 'CONFIG_TRICORE_TESTBOARD', if_true: files('tricore_t= estboard.c')) +tricore_ss.add(when: 'CONFIG_TRICORE_TESTBOARD', if_true: files('tricore_t= estdevice.c')) tricore_ss.add(when: 'CONFIG_TRIBOARD', if_true: files('triboard.c')) tricore_ss.add(when: 'CONFIG_TC27X_SOC', if_true: files('tc27x_soc.c')) =20 --=20 2.31.1