From nobody Mon Feb 9 16:19:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626785781; cv=none; d=zohomail.com; s=zohoarc; b=YHvLIBkA4dPfTlT+erbxgKyUnqcdRzOu4MkhJs5KEcr9GEmRLOC8iMaKmRFuAa6MLa1URqxHDCcL6I+pe8oMii8/oFLq4xjIK53dj7gVDaLnVVq258sprRuF0zRMIqvA51Ix5doxfPC+KhCqFwr12GRGpX/YOr1S7sa8EYDHgLY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626785781; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GS1Z57kHAgWZRtOO6uxALRKUYy2PtHX4ycWEiudgAS8=; b=a25i4xZ3nYyKnoCEXnBLoYlCy7qYyVznNy0Q4XSp9p7SKMC+8iDE4WoF853sXk1SkRubTYdRmH3HGp+Cq8cxX5uegqZtGwANcRgyVVsaROwhY6pDlKfBchNpon1XLrn0aYB/3PbHw4YrZgoJApByqtf3ff035h9/ydoM6yc++ZU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626785781842966.7132228653139; Tue, 20 Jul 2021 05:56:21 -0700 (PDT) Received: from localhost ([::1]:47932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5pIK-0007oZ-Ki for importer@patchew.org; Tue, 20 Jul 2021 08:56:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5pGM-0004eb-QY for qemu-devel@nongnu.org; Tue, 20 Jul 2021 08:54:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5pGK-0008G5-0o for qemu-devel@nongnu.org; Tue, 20 Jul 2021 08:54:17 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-c0W4a7JHON6_FMzxA8PiFA-1; Tue, 20 Jul 2021 08:54:12 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B5C4E800050; Tue, 20 Jul 2021 12:54:10 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-187.ams2.redhat.com [10.36.114.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 858F45C1D1; Tue, 20 Jul 2021 12:54:10 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id EC30D112D842; Tue, 20 Jul 2021 14:54:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626785653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GS1Z57kHAgWZRtOO6uxALRKUYy2PtHX4ycWEiudgAS8=; b=EhhkDHCewa+M0CdbmP31/o4VUWuGufFB+yBOmvalVZPJk80pRd0/l0g5ItCRtd83XTil3r 4AVPtllQIJnlflJ78a6NSf4P3rjaGlT0/u3DAflYSPjJBV1Y2kEWCCt63dX50O8VSjU49F pr0o6/HcHS5lRTR8lGb/W64gs7/RqNs= X-MC-Unique: c0W4a7JHON6_FMzxA8PiFA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH 02/16] spapr: Plug memory leak when we can't add a migration blocker Date: Tue, 20 Jul 2021 14:53:54 +0200 Message-Id: <20210720125408.387910-3-armbru@redhat.com> In-Reply-To: <20210720125408.387910-1-armbru@redhat.com> References: <20210720125408.387910-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.474, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aravinda Prasad , Ganesh Goudar , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626785783977100001 Content-Type: text/plain; charset="utf-8" Fixes: 2500fb423adb17995485de0b4d507cf2f09e3a7f Cc: Aravinda Prasad Cc: Ganesh Goudar Cc: David Gibson Signed-off-by: Markus Armbruster Acked-by: David Gibson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/ppc/spapr_events.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 0cfc19be19..a8f2cc6bdc 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -872,7 +872,6 @@ void spapr_mce_req_event(PowerPCCPU *cpu, bool recovere= d) SpaprMachineState *spapr =3D SPAPR_MACHINE(qdev_get_machine()); CPUState *cs =3D CPU(cpu); int ret; - Error *local_err =3D NULL; =20 if (spapr->fwnmi_machine_check_addr =3D=3D -1) { /* Non-FWNMI case, deliver it like an architected CPU interrupt. */ @@ -912,7 +911,7 @@ void spapr_mce_req_event(PowerPCCPU *cpu, bool recovere= d) } } =20 - ret =3D migrate_add_blocker(spapr->fwnmi_migration_blocker, &local_err= ); + ret =3D migrate_add_blocker(spapr->fwnmi_migration_blocker, NULL); if (ret =3D=3D -EBUSY) { /* * We don't want to abort so we let the migration to continue. --=20 2.31.1