From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626781755; cv=pass; d=zohomail.com; s=zohoarc; b=PVkixt1GcbDu4Cbl7g6vENMATQtetn7be5yTgE99Y5SROvfcCx9z+UZVUKc+uWEw+5oxJzmLZLk3r5vyp9zv4oFnacRdM470grc1Z/KsEkue4TgHX5XYXZr8nl+1zyK6CU83DTX+99J69Q99C40qCKRZprz2TneGhpaSuHs101Q= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626781755; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PQFwhf6pGn34NyRC8BfsW0+5E419pGbK/XoBAc/SozM=; b=PEQVZiMAsK0nzUjedXvW9K3kJe63ifEUJ9UXD7U6DojV+rIrP/8RMn94fJBnWITKszbO347VMu24tdDatK+oeJhhfTUaciTqMxNk1niNdEeGbWy28bsCunwfPQHFXNyNKYSy1uJM6ZM9okfSFM+e6YGR+/1+VxC4GSGt8l1rnVw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626781755403909.7071243898214; Tue, 20 Jul 2021 04:49:15 -0700 (PDT) Received: from localhost ([::1]:34636 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oFO-0001qs-6o for importer@patchew.org; Tue, 20 Jul 2021 07:49:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5Z-0003D1-Rl; Tue, 20 Jul 2021 07:39:07 -0400 Received: from mail-db8eur05on2091.outbound.protection.outlook.com ([40.107.20.91]:40417 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5T-0007CC-Qt; Tue, 20 Jul 2021 07:39:05 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:38:51 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:38:51 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:38:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mdUYVjGeYhk17XxMzjCSbhXfKhP1edJ0XyyCxGUvyWqR2n8W1QtLUp/RSuut8PCKw/HW5rAfGBtlIJ4Zqbc3derL7MpCvnYzTigq8n+8KWvOCRQWv2g11QV7Vl4lAtr1PAwPS4SKptVylFV22HY1QldcHR+lBxxT0Exn+tgOADfKQ7GPyxpSEpgY/mZ51Hr+7JWKUEmZhJ6v1Uk2yQD6S01QpirCLrBz2nP4xbQVZcbkrrM+qMlzvO+ldETFr0Q3+z4JEnRadwJRWH94DG5zCeLw1dDzapd5S+iWGq6JUUramTRGmmKH/YyI7FB1oBQF6Pcc0HgRM2qZa7LL9PkeNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PQFwhf6pGn34NyRC8BfsW0+5E419pGbK/XoBAc/SozM=; b=WSrK/H8rPC9ebYSwKUHeBl8AB5TwyAT5IVFI0obbcf4f9UUFZIuIHk7jb+T5K0oGHCKs3b9llM7sSdqVAchAj65skRGTEvsI9ygXDgodVr1MvNsvP87qI8cNwwPss4dI4NH2w73kixUIi0d3sVniAZOb2oHkwg7NOyu/VywYJ4ENMJOllURV3fJYYd7ixvTwllavAlEL/pzuGymhdrS7FiCUN/B0zqas9G+Nu5BJHAf55yiLUueyx4ODbhhTgDTnSjYsGOyaWYtQ8ekv/LUoNiMm7+Q5qoaKnj150RNfbceXIMmwSWa+gylvvL6Rck5dNHwKE/77pqR4mJTxqMzWmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PQFwhf6pGn34NyRC8BfsW0+5E419pGbK/XoBAc/SozM=; b=Hlq4TjuMOVejuFfrWUj92hrLS7p63i7ef9l2+Sao+7Y6IOpLunaeeTwiICoQ5ZoKJ9sSyI6VO+b8/flUAYBTz0ZXbPpoFvTTA0p0WNdb4YzAMTL1Y9mJXEXrwJS/fpwojNPQjuCslh9y31rjKF81BZeLMYP8nl1HvtSqo0fm+Pg= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 01/17] iotests.py: img_info_log(): rename imgopts argument Date: Tue, 20 Jul 2021 14:38:16 +0300 Message-Id: <20210720113832.586428-2-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 29840e97-26c4-48da-be7c-08d94b72f24f X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:400; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gvxYAHlhiJ7KJKPfCGZQxxYc6RKWk5PQjF6tXpYOk2ptwXEwwe27tl+KGfZyXIv6PjQX2+i5dDXsOESm8g+nCRMUmWF/BPergdYZabIbu82aGt/ZTO0bTU3Yd6weOPUk3H/YyXpP8sLFyga+eGJV+ht5drwYenefsuhOwwyQW8YNG+klGIy0GB60YUXBkduud5S/X0YFcBypfl+Iz5NbfIPsQvRE+3Jf7rptnrLXllXY880wv+4kynH5UwbLwTcXN1x2PVd4Or/z1oFgh9R2xur6vCyfjELhbQVo688/SxudEHSQc/981QcapWh4t0f7F3AR2Bb0zfyDCibvb/5H2STFsdtSv/dquSTGgD6ovP0rwFC6jBJ+39zr65HABHfYNOOy97r0r2I7EkANzsu4eKLwR4bzcVxb2RFdD8/vc2lYCV8djumokuW7VIMOw1JaXXlOpF0RBACHTpMERHdgK5wKlyyrvi7c0z0s7yQEVQ1edb1D926SDb9eSZ3oVdVYKE2uXV+xLWBpZAAZuIt0GssZ37Mn8Alp2FXx7fzkjGPK52Pm6jDumkkKJVPb0jGBfiA7QRG9MQ7R3NTGdxgsLA4m2BVKW8OaqRsRGBeP5xcV6Yb+3Mnhc3gz0ISv/LUD5B29KKHjwFzjCP8lQKeNuYztppHkbl4YPSp+j9UXbY9aQmsbm7z+CNCNuILDjcnSZY8DiGfy9mEMiRRBvTz0+A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?boPnUWMnBzLdEkB3j2B2VxYCtWjknAgIKzeTbL2ILAG49meIlfj0ivA7QOLv?= =?us-ascii?Q?Ty3SWI6k5juMOhYQiH94iJl4Gh0hJseXPoiK7zs/csR2FHpUQIWI+fbdzAIQ?= =?us-ascii?Q?WH2N0iY/ZCoAW/KyyfYk0HAR42+6cXf5OHp/kU+rGnCyXWooFAdlO6WXxEeq?= =?us-ascii?Q?AN+quixP5MR8y1fooVJh2Z3mRMas+RVNl8MGBhAkILC8BaQSrPPc9c2cYRPW?= =?us-ascii?Q?q3BxqSh5R4Wk9ziGsW07Y1Ol2lRQx2YbAv7jvesvqlgKJO01o2SmGVRQ9l6N?= =?us-ascii?Q?0HKhy3rwL08VvcDnM1tkhadsdxtvdn+Tdd/N0kGdLsoWEeUvRfUNcgK300i3?= =?us-ascii?Q?xGn/SDXSJM318Dfi+XOu8xOlr7As70/azyZP0k4PSiKBSGdoQkNVoHjIEvRI?= =?us-ascii?Q?m7UIvNVzeC4ztkNHRjol1Q/Isx1V4NHrrAP9zwZruI4g8M7+qFzoy2Dh8H6I?= =?us-ascii?Q?S7aI0rX5EyK4JEYS9whqeTyzLOie+13OC2sCB+fGLldOvQ/CGj7p2ccdsuiM?= =?us-ascii?Q?CocqFCI6kO8+BhAIpF2XeUhlQkHJSeAxRplqI6yWJqWlqhfbEat8eoeZxNsU?= =?us-ascii?Q?KvS/bVhBEd8h+UZbx5oGRMmYmLxfoQKRxbFnqN43BwHpjls7HAuxB835uO2K?= =?us-ascii?Q?G8x7oBbS1wGxavvGxTP9SHL9qUpoViYCGnPKDVQGAEejunoMN+4U2aKHVgnx?= =?us-ascii?Q?gjlFNTg8+aErCAg/tSIeVMFlj62ni+FVkiAzqDZzE6N3NKPumqk1InJJhRpG?= =?us-ascii?Q?uiACpX4g/EN69mNtLsob4Kl3Jxh9UhSanyCn3u4OdwaGYblJOMNGTW/cB1xd?= =?us-ascii?Q?3YKdTIQrRe+VRepyqbTUJDdpwDsLzJqmMJFfa23h2Y1ZNIkkIEEcM0IQ0UxZ?= =?us-ascii?Q?Mtx37u6qsSW9wLbDPpCOwIeFhriQriWCwWmQtVt6wu1UPAqIxzsJEjOt8Mmc?= =?us-ascii?Q?an+nhXMtN/8w2W6i5dRWo2z0QfOd1q2vkBY96oXM7NnnsWOSllMjEEjDZkN1?= =?us-ascii?Q?2y5WLkYIMrNJ0lgbJ6x2eVfshBx8hMJqXljowNkaos/b2hTnzzyMZjyEKdZg?= =?us-ascii?Q?BnQoCE0zzZC9e43++STQBqXBUUZgdi/8fcuG4EZ/MtNeOvDd5wlJoRrdfd1E?= =?us-ascii?Q?m3+IAC9GEq55CxpdnrbmksV+MN/PS7K7irf0qsWfEr7Ba3776HTr7iJI3Rrj?= =?us-ascii?Q?wfB0rVNqLN/HJaaO7yzxrTgwLr1vpiS9p9ZvLMYb4knPY479+m2AjoyROgyR?= =?us-ascii?Q?WTb/ynpursK2odSUIhn0hTezITSsnc6DW5x9NrCW2+irjGnvHYP3RH1Z6fTR?= =?us-ascii?Q?9i31OWIjJoGA4xC7bCFkygDe?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29840e97-26c4-48da-be7c-08d94b72f24f X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:38:51.5025 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P62Hp67yU2t6yzcSfTk+sw8HUni+jJKsLIjPTropAgdWFD6o8cVA+3xyKzXh3BekZg+c0xE7tgYTH+CJLUzeb/XLrb2Wy5T7Tfjp4Z4OEuI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.91; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626781755879100001 Content-Type: text/plain; charset="utf-8" We are going to support IMGOPTS environment variable like in bash tests. Corresponding global variable in iotests.py should be called imgopts. So to not interfere with function argument, rename it in advance. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/210 | 8 ++++---- tests/qemu-iotests/iotests.py | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/qemu-iotests/210 b/tests/qemu-iotests/210 index 5a62ed4dd1..79b4967225 100755 --- a/tests/qemu-iotests/210 +++ b/tests/qemu-iotests/210 @@ -62,7 +62,7 @@ with iotests.FilePath('t.luks') as disk_path, \ 'driver=3Dluks,file.driver=3Dfile,file.filename=3D%s,key-secret=3D= keysec0' % (disk_path), filter_path=3Ddisk_path, extra_args=3D['--object', 'secret,id=3Dkeysec0,data=3Dfoo'], - imgopts=3DTrue) + use_image_opts=3DTrue) =20 # # Successful image creation (with non-default options) @@ -96,7 +96,7 @@ with iotests.FilePath('t.luks') as disk_path, \ 'driver=3Dluks,file.driver=3Dfile,file.filename=3D%s,key-secret=3D= keysec0' % (disk_path), filter_path=3Ddisk_path, extra_args=3D['--object', 'secret,id=3Dkeysec0,data=3Dfoo'], - imgopts=3DTrue) + use_image_opts=3DTrue) =20 # # Invalid BlockdevRef @@ -132,7 +132,7 @@ with iotests.FilePath('t.luks') as disk_path, \ 'driver=3Dluks,file.driver=3Dfile,file.filename=3D%s,key-secret=3D= keysec0' % (disk_path), filter_path=3Ddisk_path, extra_args=3D['--object', 'secret,id=3Dkeysec0,data=3Dfoo'], - imgopts=3DTrue) + use_image_opts=3DTrue) =20 # # Invalid sizes @@ -176,4 +176,4 @@ with iotests.FilePath('t.luks') as disk_path, \ 'driver=3Dluks,file.driver=3Dfile,file.filename=3D%s,key-secret=3D= keysec0' % (disk_path), filter_path=3Ddisk_path, extra_args=3D['--object', 'secret,id=3Dkeysec0,data=3Dfoo'], - imgopts=3DTrue) + use_image_opts=3DTrue) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 89663dac06..0d99dd841f 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -187,9 +187,10 @@ def qemu_img_log(*args): log(result, filters=3D[filter_testfiles]) return result =20 -def img_info_log(filename, filter_path=3DNone, imgopts=3DFalse, extra_args= =3D()): +def img_info_log(filename, filter_path=3DNone, use_image_opts=3DFalse, + extra_args=3D()): args =3D ['info'] - if imgopts: + if use_image_opts: args.append('--image-opts') else: args +=3D ['-f', imgfmt] --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626781536; cv=pass; d=zohomail.com; s=zohoarc; b=Glb5dfSMJY1HdcQJU4QjnqIs8UrGY/ORrzWmxxliVVSaynRnlCkRmI5HMYx8PFzzxzkxRaTDCeL3j36OAXoHwrsltVS7RLcDmZ5moly3RoHc00izwtGNQeV7ouhaQUYijMOluLHtRYjsI4o5CIJfdLdWWbNVylMLWnR+L+eMW7k= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626781536; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TAViqR+MKQeHKejPrJh81g3QDmpDY0X1jSzTOrl57MM=; b=f/nxEzT+dDzqQVlvLnsUBZBMHMTEmV9uz2h1j2gLWlOjLkYPDFOwo8Bv+fwgkY5YBR5kQqZfDLNb7zPHzIbc0dDoajClyV9FIOXbysxXDOZlU9hxgtYLGYBJ2aGFhlwZQDn5csyi7OeoN/vq0KFKHI8TvIDZSMVq6nqRQMu7eSI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626781536676760.570854078551; Tue, 20 Jul 2021 04:45:36 -0700 (PDT) Received: from localhost ([::1]:53674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oBr-0003vd-FR for importer@patchew.org; Tue, 20 Jul 2021 07:45:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5V-0003C7-U9; Tue, 20 Jul 2021 07:39:02 -0400 Received: from mail-db8eur05on2136.outbound.protection.outlook.com ([40.107.20.136]:65205 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5U-00077C-6b; Tue, 20 Jul 2021 07:39:01 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:38:53 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:38:53 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:38:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=errzxPq70FmgV1o05xtnJtXFlpNQamxzISG0w8lvwvMwGqxqY99BzoSLwJJSgBnJwBRVLRSyaauhIPD7P8/FQ8hkGHIrydVLXjcCO6JP0WXo46yfqOH90UZPxHca2hZdtDBLTXGEDZOAGGzdepAYwXTRveecFkfoqoS+9SCU/Wvh3pHW6B47PV8mHSz0K7lstQV64LHE8aXPdRF3EnzBREms5Qxv4Ec+68I37Rn2N104H1BmDNw+gsCjiP0fhwZ+kXUbrsPpu+7xLJd9zJhZhSl9nkV3CnSsJtw+mGRjJCg0I3nFFVBIjk5sPqud7s7PWh3aHJiVEDDrGIzvsLKwVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TAViqR+MKQeHKejPrJh81g3QDmpDY0X1jSzTOrl57MM=; b=bZgTUZ9d6Ucz/yqZ0W+slm+1oDuDiJKv9pa00kJ/NJ7HwKLQjVS4rlYNsJB6vs8a+ogSLnqQHAFqckqwmahRkYov7zKw/oLTr10lkjOFKFLz1AU9P2NiDjlI/k69RZoMYx4OyHMv1eP11ygGUETaBj8tVV5DGgPjZiCmwrSW4tVpRU3sDG6LT172ufmA2lmmEZu30Rp1h3xDyVWGzj09MJZxIIhbr+o1IL82jXnNmntGphQ/ozgykmX+8ZWT7PXVbZI0SgQrV9QDxHCdopzDDyRcN5BMpl+DuI74l7QhI64tVbYp2MStAjTo44OUMYhi81/ifhdbSi/KfqFBzq5XuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TAViqR+MKQeHKejPrJh81g3QDmpDY0X1jSzTOrl57MM=; b=ZMa/9YT8lg39kB0fr1F7FV6uBn+EBjB5dwM/QZLFyxeAkPDz0oRvfiMaZD1m8Ns2TxqYu249+1M721sgYrVqJ/l/AoESQaEvLG1/tCyTF9wiBQCsuVYsuDvIdx4QEdgIyWrGKoAjWYJ3TAzPMWt+c2R95bLVn06cwd7IMAf5xCg= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 02/17] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd' Date: Tue, 20 Jul 2021 14:38:17 +0300 Message-Id: <20210720113832.586428-3-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d58fa475-7806-48b3-1b51-08d94b72f332 X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DmHp9bb5WSk0iZk62JE/Gohlht1vMIlfa8lLK6vDtJERety1gt4UYZKjxvfP2hBa9BegTl3sYLqT0WMihd9LUwsHhAomtkMGorTVfiHWTIhqxuoqEiKCBbwssTt4qboeH5ydIJXaM4fQ0/7xuTxwDCbWoeEnVPBl/IJlCzXE2HyF0panCu80RV9PcP7UJheRqrKmSDnAj50eQZN6JgoIuP3CLH1HfsEkl1uoLVVS9GWwdqOf5zokAFOtLW6Z1cwMcX/JwMsvobvTWo+QUb4na5IIMu9A5QZyFslcrDG2jeOfZyQMtoBEELBoqSNzjwFsvVEIIHjEQqVWRmCvy9lu57Tjq0ZM75ejwVFYkuScdJ2Zmko3XeqzK0Equg5i5wU2vzvjs4vJFEHK1tb9XR6OCYY2v3JTpvQ8CWpKUfAOetBpSPErasDEcKFRZz3usnsCGYd7oEizgq8kkRKqwu/Zb8rdjdTY+vcQkOS/sEmy9Ii9cLimRKfbNmnxw2llrZXOAAjJ82L7cJOtez9r3aG+uS7YceSLGO6Srf4knoIpIwmikmzCw4Q1DZ9M6/P2Z24p+WkQCS/iMQT3/Zs8EIEqKqw85bLccMsKZlgaX7BGj8tcFuwgGpoe/3iwVhmEuU3G2uxK+qCDhYD2g4Gp+NITH97EA1Sa7zyGj2mqeT9qtXGk2GNoE0cNQ/9xfj0acDO+qZEjNq6T9TpJbPtMbhZg9M8j9JeIwCMGUZ3mpRgcLfh8yoMgelFGZqF4BUgHLcYfg420HiZ3JOukx/0FpS2E+28OyoHLtwITc+MT0c2mpfg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yeCf4wsXXXTL/KLHhQQ7Ox8fl7wMrggFWeh7GsW5ENSM6TYNU7jaNIe5tEp7?= =?us-ascii?Q?971LweYd/+gKMhQRT4mK/8o0z14h0jyxG4f20NLS+NoUN5l9iVq25EgcdApf?= =?us-ascii?Q?tBxZt0j6vCpdCHeQw2cItDug76qfFPVXTEgO32usc7Qu2XzImG1FKl8GVuyh?= =?us-ascii?Q?kCwHm9b7Hn/Oxrr3sYvCVhB/r0C7o7BnDACgskIci9JKUT/5cugx+aXtOuMF?= =?us-ascii?Q?ZSi9k8ySxhXFScV6GzufFiuGxGEpC+waF0g+j51nLwVFlNNS2eY41iGurs+f?= =?us-ascii?Q?eL5krIKdpToKXPA4AFbccrt0ry9njVlpZPgULndPjG+lQqrBTxhomubrmZp2?= =?us-ascii?Q?qAHMAEzPU+Beh14d92AfB/X0xw78yWks51fbLmwOOEod2+CHUAPKx5ZhzWda?= =?us-ascii?Q?kZxYslFnNdCVNNslSRUOnUY6PTRpBlCcW29sM+9B+rVWFhGIU79IUPlbV2Vj?= =?us-ascii?Q?32zt0pLNL5GVqX7tniIC/Mo8HYl8hxoZqn8PcG4TWcdDFToph55uKXWFaYDJ?= =?us-ascii?Q?gz4SY9axnSTqwNQVC2gw0VXf6mnj8sxLZL6taNmbITflmymtHYfvo3CG3ItF?= =?us-ascii?Q?gBUVPn9W+/b1YMb100LqKULAfFltD4b7nKRNqk7OqzxbJM47R2lXUZvC3drh?= =?us-ascii?Q?KmAYV/GDeOayJTipsTDb5olzEQFKfD3Fz47qVJH1e5QyG1TOMpfP7w8Mk+d1?= =?us-ascii?Q?sxRd3YZXtmO9+GDnruTfamGPoy4ykzvmTCXl0xmDnjwJhjSZkfaat903pNUW?= =?us-ascii?Q?RDU0Sf7Gz1xx+1CsZptYZ8DkmRrI/nMj2K5KaZxCbezxCdKOSWX4mXpw3+oV?= =?us-ascii?Q?BhdswcmWf69C+EY4ZPFMg2WSfmjWh7YmHPPdVQN8PYdu3/vQSM6GFVbGdJ4k?= =?us-ascii?Q?mn2z71t2tw35ZCCzduUCCnhmadxTDWhfVw+rXfUIUJTs8kkhv1Ug5CeSayTu?= =?us-ascii?Q?z+UrcgO4nR9O1hS2u/GHcd1EUxm7X8ab3guS8vk6BJx+cmqxxlHj4/ZMpMkx?= =?us-ascii?Q?IOCcXRTAMO+yzDa+BsF/Tww398hMR9LRWOtPtzMqFCJd0zxKCRd8qeQItxkV?= =?us-ascii?Q?6uKCiFi15HcuXPI97DFdTUB4RV6VOfEf5uxAL88NoWlANYVxWNmwPWS1LHEU?= =?us-ascii?Q?RuYI9pGGT4tX1MRWvLUR8GJ9mxW6maqowgWMuoy5dW2vyaA2IFoRZ0gT1qXo?= =?us-ascii?Q?n1vPeDGRunT63QxoVBI/M8fTIlEanMCAi2PVrK0zqZ1h/P7ACW39F4Qc01cU?= =?us-ascii?Q?Uh9NBpPtxguEym8q5vqaSw9uoqI+t4VnXa9t2C76aNqdPgwhUTmKwvKTJr2q?= =?us-ascii?Q?E7/nvknYuzNYUTR2+a3MCliE?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: d58fa475-7806-48b3-1b51-08d94b72f332 X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:38:52.9830 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Db1/6T+3XrlxJnWQFysnl0pydtOgn76aHb1Pjh/ceN7uwqB9ySfg914EB5wc8yOFeqQKeiGhf/n0MswJsUaqK2MitV8CFc+9hLmQfHqHxfQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.136; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626781539032100001 Content-Type: text/plain; charset="utf-8" Adding support of IMGOPTS (like in bash tests) allows user to pass a lot of different options. Still, some may require additional logic. Now we want compression_type option, so add some smart logic around it: ignore compression_type=3Dzstd in IMGOPTS, if test want qcow2 in compatibility mode. As well, ignore compression_type for non-qcow2 formats. Note that we may instead add support only to qemu_img_create(), but that works bad: 1. We'll have to update a lot of tests to use qemu_img_create instead of qemu_img('create'). (still, we may want do it anyway, but no reason to create a dependancy between task of supporting IMGOPTS and updating a lot of tests) 2. Some tests use qemu_img_pipe('create', ..) - even more work on updating 3. Even if we update all tests to go through qemu_img_create, we'll need a way to avoid creating new tests using qemu_img*('create') - add assertions.. That doesn't seem good. So, let's add support of IMGOPTS to most generic qemu_img_pipe_and_status(). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/qemu-iotests/iotests.py | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 0d99dd841f..03cc00366e 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -16,6 +16,7 @@ # along with this program. If not, see . # =20 +import argparse import atexit import bz2 from collections import OrderedDict @@ -121,11 +122,35 @@ def qemu_tool_pipe_and_status(tool: str, args: Sequen= ce[str], {-subp.returncode}: {cmd}\n') return (output, subp.returncode) =20 +def qemu_img_create_prepare_args(args: List[str]) -> List[str]: + if not args or args[0] !=3D 'create': + return list(args) + args =3D args[1:] + + p =3D argparse.ArgumentParser(allow_abbrev=3DFalse) + p.add_argument('-f') + parsed, remaining =3D p.parse_known_args(args) + + result =3D ['create'] + if parsed.f is not None: + result +=3D ['-f', parsed.f] + + # IMGOPTS most probably contain options specific for the selected form= at, + # like extended_l2 or compression_type for qcow2. Test may want to cre= ate + # additional images in other formats that doesn't support these option= s. + # So, use IMGOPTS only for images created in imgfmt format. + if parsed.f =3D=3D imgfmt and 'IMGOPTS' in os.environ: + result +=3D ['-o', os.environ['IMGOPTS']] + + result +=3D remaining + + return result + def qemu_img_pipe_and_status(*args: str) -> Tuple[str, int]: """ Run qemu-img and return both its output and its exit code """ - full_args =3D qemu_img_args + list(args) + full_args =3D qemu_img_args + qemu_img_create_prepare_args(list(args)) return qemu_tool_pipe_and_status('qemu-img', full_args) =20 def qemu_img(*args: str) -> int: --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626781540; cv=pass; d=zohomail.com; s=zohoarc; b=Xep/d+QosR0H8b7vl0ym/tLRLUmk1+xZZ2pUC2lU9Rd/B8JWmOZqEaA+3wJy/P68BddRkRxrdqnRk3S8vtNrjjdIA/W92ynj/ZUd6kA3qUeAIcEGfjRTJ3apF9PN3083u6RnGZwE+3FcpB+qDLSksjFMh+YoA0/KlcZDClMylJA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626781540; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zA/Gu77NoBQeRniJUzkpdyP+hrbdPlO/RIth6ktKGLM=; b=Jased/nAuMJcl9ZzpVHAhYgM+tqHonRfwapXknef+JDdLxM7Ak97riJiBYH+Qf3TVek0677bs3qaNJh5DyyxTxjJBLYM4wYUEx5T1lzThB4X3I64hYHYqeaEOIcI3zMfu4ztI8RX0uEDxYj1vsgLxdhmDMCrPbnKVgjbYdhLC6U= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626781540675517.161015303168; Tue, 20 Jul 2021 04:45:40 -0700 (PDT) Received: from localhost ([::1]:54008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oBv-00049g-GV for importer@patchew.org; Tue, 20 Jul 2021 07:45:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5c-0003DP-5m; Tue, 20 Jul 2021 07:39:09 -0400 Received: from mail-db8eur05on2136.outbound.protection.outlook.com ([40.107.20.136]:65205 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5Z-00077C-0C; Tue, 20 Jul 2021 07:39:07 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:38:54 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:38:54 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:38:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KWVspqhJZ9qtXftk0espoargnhSg5UhPnepO0F6mtdxDdV5FHMV/c0RCQL+/4ti5YxZtN+qE743UJy45VmOCex0KRKEkh8WAh6uDab/QRDNj1pBJMviqc66SnhwnWvBbzDKXBINuz6cs9BF+NxcUse/b1y1zcdhIyMdcIucsPaTJlK3OA8ikLKyfknHdXA0EftRLWwmGqLlJtBAOh3Ihm6WNZQXOMlcRmaui+Us0T/7JKFLDXc1+01yMPhggGNk9k5B2RtXyc2wJzTTQt3PKfh8pHrtvTnacb1YRoT1GkCr+vZqhiDDKshlogjeE4mM8Mx+CVF7LZxjmjeddqdUfkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zA/Gu77NoBQeRniJUzkpdyP+hrbdPlO/RIth6ktKGLM=; b=CxR5OWIGXuYekUdtSS80lMUMyL1c9+xhELROyaigHVyTjbJBMpgoBJ51nRyaE9MtItMawbo/S6frdZpGQl1q2tipJqUmEz2CHBUkyyJukFTJO8nu7wTEQNso681jJhujA9yoPAcFRZoHbHn3mxLruq9Hlz14KZkF5HlynPDSj5I+HXBDJQu6hqTru+C6Rpc5YEoXwE80YZgFHGtWLN7F4vX+IcexYk0XI+sLPclOtLyo7oizhIoq3zOBRtsVUNbcfQsD6pS3qfbadR8+Cbp48XkQMsgSS6p7lv1o3vpCR+5HpLQtvRGT5+ZtbFZz92tFXYJqz+gKjZemc31eSbP0Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zA/Gu77NoBQeRniJUzkpdyP+hrbdPlO/RIth6ktKGLM=; b=p77uCvJNTb2ZRmc5fWxZHpvjRLesuW/syi7w0+bCELy+yuHUDqqxTE4yDlzwEGEJwPyWBOLXB/od7CLHp5RdHUGDlAgScGsiDFbf1RKifNdIv+i5gW0M5ByoVQJEOWbvCx8rBx8lRaNCClnN0M3D2seAywCC9CoJ95y1QYEbeoU= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 03/17] iotests: drop qemu_img_verbose() helper Date: Tue, 20 Jul 2021 14:38:18 +0300 Message-Id: <20210720113832.586428-4-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 67120a20-57e5-4b97-c284-08d94b72f40f X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1923; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NmQ6Cna8GckXb0jG7iqtbNFdQ2a1jZsZ8ri3TabaGyI5bb2fzOLSfjwBmPoW6yFGcpu7bIYabOSymykFetP0SVl5o06VnVxH6+e9d2X4ljBbGI9W8GHZqKpuLAoLehhTWvWdX/+ZUvFn5PNg1wO9IKReQoMNxoTgIXGNGg6grA5XG6RjRjhM1SBobpl1geT/ZcCiuR6cUwqi9W6U8gD0TCAUsOiH4WNrqW6HwsGpv6NU5WUL6JyFLKx2BrSiwmV7ucmFbytGiIrpzFcBFKbdkQBB82a1OlCor5tiJCHVC4ElPDa5rKFbI+QbX4J+WC3zK/Fdll7CsoQPfPq9lwkEwj8AcUo6p8EKqMzJeHIDiHcVf5+FI4f4uLwZYZhc12Xdu3sAf6FTaNmFE/vI5V1/Lt0Y6GV2RpNhEWilpyr+vOXOogcGiTl9h5W8wz1pbUFftJvkCS/E77+6rUEWeD9kB1qaSfzPOTt6lSBScK7kPiyIVz2N3RjA9nfs7nUkqnO8xLfgfp4y1NXAjfj/qvWA7MF98/WhM1Q3JBDwdBfqY+ZY7aBpVs2sVS7qBCiYRg7aCd7CMZTpBYwmSw9VUbh01FeqomWSHWUsNVyIG4IkkK3Nyy08fvY75aWmTs9q7y7kM6MKkHoZUf04q+PRvn7lqzqvVtuwJIqXDMSITkTKcvjeMeqs7sKefPWL82iUMbBONaXX/UCIvIrSDQFzi0fRCg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bQ6/s3skLOEDpB/BAiJjWd/urX+2bJgmzk0AtAdrFOUeNsM2quY6oEeWkYpm?= =?us-ascii?Q?li1oI86AMUcPDY/XPBvI5CshG7A4roeQNyc39Xh1dyJyL23+rd2HdSNHk3uE?= =?us-ascii?Q?pgErqwJSdprZAl+Ko7yj3LQT6+gn21Cc31Z2GgNyAW3WG87chCsRzowDaGWw?= =?us-ascii?Q?aTMd+h8K1dKVkYT6XQfvqs+YpoKXRTeCvPBAr34qEBfEIh62G/bwWAdpZhqb?= =?us-ascii?Q?Hb9gTBoBX+XkzzZLWuwfQRNAW8i7TSH+KFNsJJaoy1ipN+F8lj0C+XbPYDUD?= =?us-ascii?Q?II3la0YiW1oh4fpDJuTnqWkZNYGr/eeAaAtzbnhBFHmENhzMjJPw8ZjoJOTV?= =?us-ascii?Q?1Di5TV7UAK9A899EzBGO9ZEcRtdSYcYVMGOAHt4SiBJpvS8D58+uw2/u9CEi?= =?us-ascii?Q?oapp0u31NqxHUQHLeX2gnX29FK5TOLQxs1lgx9jJgQ0IBwlMBQyvRPsq86BK?= =?us-ascii?Q?ZxDlAk7AArxILtjFELtFF2ctKItaXh/dIJZUkJPZdYAfh7LaU0vBi7Ou6Cvm?= =?us-ascii?Q?p4TTkZ3ZxnKxvKKzMYR0PtUp8c+oaaltzZw+g3CNmS4KBcaZvT9SAqYdawRi?= =?us-ascii?Q?khhICozSYhXqKN9HuXj0X486whZj4XyT+KYilOxBlXtenQKgkhm0mhwtnRPu?= =?us-ascii?Q?mIC8bvQmw0sKjIw+ZcpCt9iWHW8pH5kH0goljf3AeZ5UFQ2ysA5cQ6p9R0Ha?= =?us-ascii?Q?lMoEJVfesoXyO7DX8vM/iDyTqKUXRG3obdaVrGVbu015JvAjR935aMIIPZkE?= =?us-ascii?Q?ej6S2Rer/n6vWJWLtiIIt4yuxo93kjPd2myqMR5kWg6M9D2/8wccLyHg7UfN?= =?us-ascii?Q?bxwdIGENWKGG3mFSn8KoYJmkYhg31nZfp4Kk3BJ2Gkd1QbDE4swF6KxETSdA?= =?us-ascii?Q?eTm0pAMU6rSatRpW7SqvGGDGsqnXp6V16FwY6svM2v9TiUYdcph8NL1l1I5W?= =?us-ascii?Q?93OD/gxnK1bnNJGqcy5UalwkjvLOyby3mWky3ICDZ6D0YgGMpsXxWsgfl9TH?= =?us-ascii?Q?N3WxvkV+UkBJySFxgTse0v0j04gajQhkS5rY4kMyghW7BXTavnjcqzSkDY5y?= =?us-ascii?Q?nXuqgdYsZz+uqjWgdpw812bTVN0/AlRuI0MkOLPQ2CN3f6K4R0Djy6m0FJ7y?= =?us-ascii?Q?ZP015EguXJaubb4JhGwahpcKJ3y0YeI3MIyLYynfiPLl1XzkDauYulh4mGsw?= =?us-ascii?Q?tJEJ5/z/a2/EeemktkAvDCjW5eFeRKLLJBU3WFjqLZ8DnZudR2MOo0HTcuBC?= =?us-ascii?Q?KTBGUZM8PAH7rKsGi+EazrDI1K+Rn4yaY9kfIL/QqfRW9wjv5g8HQngECMnA?= =?us-ascii?Q?TQviRy32Z1FIfdnow0PJ/P4r?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67120a20-57e5-4b97-c284-08d94b72f40f X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:38:54.4177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WK8JnMdtmDHQHtnvjTyoAw6CjXlUYXMb+9ajDLMVe/RkJXRyfRAJuN49JKLp7Mo8QV9WLL9xfSZi2E5OS8rq8PEaqs/5VzCM9vfBoQ9knbI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.136; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626781541513100001 Content-Type: text/plain; charset="utf-8" qemu_img_verbose() has a drawback of not going through generic qemu_img_pipe_and_status(). qemu_img_verbose() is not very popular, so update the only two users to qemu_img_log() and drop qemu_img_verbose() at all. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/qemu-iotests/044 | 5 +++-- tests/qemu-iotests/044.out | 1 + tests/qemu-iotests/209 | 7 ++++--- tests/qemu-iotests/209.out | 2 ++ tests/qemu-iotests/iotests.py | 8 -------- 5 files changed, 10 insertions(+), 13 deletions(-) diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044 index 64b18eb7c8..714329eb16 100755 --- a/tests/qemu-iotests/044 +++ b/tests/qemu-iotests/044 @@ -24,7 +24,7 @@ import os import qcow2 from qcow2 import QcowHeader import iotests -from iotests import qemu_img, qemu_img_verbose, qemu_io +from iotests import qemu_img, qemu_img_log, qemu_io import struct import subprocess import sys @@ -112,9 +112,10 @@ class TestRefcountTableGrowth(iotests.QMPTestCase): =20 def test_grow_refcount_table(self): qemu_io('-c', 'write 3800M 1M', test_img) - qemu_img_verbose('check' , test_img) + qemu_img_log('check' , test_img) pass =20 if __name__ =3D=3D '__main__': + iotests.activate_logging() iotests.main(supported_fmts=3D['qcow2'], supported_protocols=3D['file']) diff --git a/tests/qemu-iotests/044.out b/tests/qemu-iotests/044.out index 703cf3dee1..ff663b17d7 100644 --- a/tests/qemu-iotests/044.out +++ b/tests/qemu-iotests/044.out @@ -1,6 +1,7 @@ No errors were found on the image. 7292415/33554432 =3D 21.73% allocated, 0.00% fragmented, 0.00% compressed = clusters Image end offset: 4296217088 + . ---------------------------------------------------------------------- Ran 1 tests diff --git a/tests/qemu-iotests/209 b/tests/qemu-iotests/209 index ff7efea11b..f6ad08ec42 100755 --- a/tests/qemu-iotests/209 +++ b/tests/qemu-iotests/209 @@ -20,8 +20,8 @@ # =20 import iotests -from iotests import qemu_img_create, qemu_io, qemu_img_verbose, qemu_nbd, \ - file_path +from iotests import qemu_img_create, qemu_io, qemu_img_log, qemu_nbd, \ + file_path, log =20 iotests.script_initialize(supported_fmts=3D['qcow2']) =20 @@ -33,4 +33,5 @@ qemu_img_create('-f', iotests.imgfmt, disk, '1M') qemu_io('-f', iotests.imgfmt, '-c', 'write 0 512K', disk) =20 qemu_nbd('-k', nbd_sock, '-x', 'exp', '-f', iotests.imgfmt, disk) -qemu_img_verbose('map', '-f', 'raw', '--output=3Djson', nbd_uri) +qemu_img_log('map', '-f', 'raw', '--output=3Djson', nbd_uri) +log('done.') # avoid new line at the end of output file diff --git a/tests/qemu-iotests/209.out b/tests/qemu-iotests/209.out index f27be3fa7b..515906ac7a 100644 --- a/tests/qemu-iotests/209.out +++ b/tests/qemu-iotests/209.out @@ -1,2 +1,4 @@ [{ "start": 0, "length": 524288, "depth": 0, "present": true, "zero": fals= e, "data": true, "offset": 0}, { "start": 524288, "length": 524288, "depth": 0, "present": true, "zero": = true, "data": false, "offset": 524288}] + +done. diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 03cc00366e..def6ae2475 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -195,14 +195,6 @@ def qemu_img_measure(*args): def qemu_img_check(*args): return json.loads(qemu_img_pipe("check", "--output", "json", *args)) =20 -def qemu_img_verbose(*args): - '''Run qemu-img without suppressing its output and return the exit cod= e''' - exitcode =3D subprocess.call(qemu_img_args + list(args)) - if exitcode < 0: - sys.stderr.write('qemu-img received signal %i: %s\n' - % (-exitcode, ' '.join(qemu_img_args + list(args)= ))) - return exitcode - def qemu_img_pipe(*args: str) -> str: '''Run qemu-img and return its output''' return qemu_img_pipe_and_status(*args)[0] --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626781367; cv=pass; d=zohomail.com; s=zohoarc; b=PSpx0WeR3iGeVp51dlfNVBPSG/zNxg654pErz5Zv8T0Lb7D1vC4tM0JHXRW5NylnBV1vtaQpPfN63YiYploxXD7+fock6VqJIWnb++BgFmKIbSu4I3gacuZwmwpsgYxV6Gi+tB7E+E7VHLHhURVxirr2+OTU2HOeT1AlAfJvkFU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626781367; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=D8cmTDJcjiL7ldlibJc3KkBBRAfKQ97MiCAmsda9bdg=; b=Y8doAKL0uX3jbHaltTzlqxgu0fOaZQiYMvH2wA9llahdk+VkeUikk4PM8IDQ45BIobJpe00i+1GHoKBhk3gPV0wVp6oF/QeZdMK99tp0qDJMKs/Bp6h9CKca/JXiErFW/ebOvBivy6jyhoZxhfxvI+0kARAtm6RXL5WuteNggLU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626781367705470.9340070364092; Tue, 20 Jul 2021 04:42:47 -0700 (PDT) Received: from localhost ([::1]:46516 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5o98-0007TS-Hl for importer@patchew.org; Tue, 20 Jul 2021 07:42:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5d-0003DS-ID; Tue, 20 Jul 2021 07:39:09 -0400 Received: from mail-db8eur05on2091.outbound.protection.outlook.com ([40.107.20.91]:40417 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5a-0007CC-Ho; Tue, 20 Jul 2021 07:39:09 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:38:55 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:38:55 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:38:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MSCDGglyJuipqVved3gLOEshOchNo+wYCCTrBVKAwO5mIycu3TAuvmKYnJrHlIBB2CZHV1/qK0G6ElzIj83+XspgdJmUuHq9yZG+zBJVcNqf7vwXl1mt8sZhiH/1zWfAo0p8CRL8EQxP4N/PU7n8Um2BstBhFwLAkjiIvObDrPzRtWqBqxKU7IIyFk9F4mWdKTd8jdqhS45zJq0vwTL4DMhGEarBnkWt1G5g3Rb5qa20/8inY2GkcRu591g4O5A+1e9lB8F2vBa0nstBc8+gRFmfyG9Gllh7wCcW3Thtvr4vGyVMitLC3ZTsKwb9tgUEzvyCcqwU6IUpp12kMSzgoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D8cmTDJcjiL7ldlibJc3KkBBRAfKQ97MiCAmsda9bdg=; b=kozBVbGS8CNWPGztFYEPDb5GGHfxNcf6UQDQFenZFqbfrVm/98NuPnal6jh48aEHjjqrqt6rTTet5sOQm3VP05gd0/Yge6E6DYKLyFU0QXQgudltNhh0I+n8tCqwYOQbM69KGRR13/imcn5PN90ban04+xncsfMCEdokgVH0hlhG3qnpLtxOEatsCdYVCpao9iHcgDOjWxdITt8HeL8+1C1uGvZzIZY/iu1jDe+2yvDbFOKBG53WJOz++6NrvxUgMIAwpAGsVSKuApRD+mQGnHW4DeM17eRj2f25N7W7s7vxF6JzR39qrZks0+B4w0O33YVQTqBZGzWuQQ6aAkSxVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D8cmTDJcjiL7ldlibJc3KkBBRAfKQ97MiCAmsda9bdg=; b=HWSNEyaGDI7yJK4Mrn+IJmp8wS2sbDx7C/zASNCCeeLjW9nnEhUR/xuWUxUg/xIBeQrOgggbpzRVawCnFkNeUunyAIgR2p0wQu2NZoPgf/SQS1Xsj6gd9MHv9d+BabIEYcMnNL/bVjYCR3dPl1YVRDKQSVbaI4K+uyC3kDu8+g8= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 04/17] iotests.py: rewrite default luks support in qemu_img Date: Tue, 20 Jul 2021 14:38:19 +0300 Message-Id: <20210720113832.586428-5-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 020a310f-8846-485a-d122-08d94b72f4e5 X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gNb9J3pi8z19TNHnY6aDp9qjn9wjX7yfA/VtKzE0RxR7FvY4N+6ZLXWvT4t/WxU3K9uDSm/HBb8JuvchO7Dh86WXSObM45QOGX0hom8XaIRvwAGCrKbYEqETNModCOYVO/JZy6fnV8XAf3GXTFKfB3hJzD63PblLD1R2jbyw2KDlyemJ9iZOFHtJJqag47weXIY7vjTJDoj+/LRrLF+/G1/DXbEyxdQpUgVdzJ/71zyKQp2TtLUebP1cGBh+/f7LDy5oIEoyzFkNlLtB2RHVqKJzxpc//mrGESSDVyJRM8tMa5962qwBDLr7hQESUDyfEncg2HtYUJVkC1+c/1Jz5fEmsE4qJu8OqgRX4crRaHR2B1McMlydCYS6MwHXzZ7kKnAwhjQ4HvtdMabNmxrUtC/ASHoITxsnNoWVWoVbj6KLHvh2kwMARIcIP8R15G9XVP5QXdig5TD/5SpHMu3JgiiXGppx+UkyZ3kp8e6HVnl7j6RhZ+StLfe6nQf3VDHh48xjk480/Nuf07MiZ++Q7VUnRn+QDGbJcWuGbdF3GIoG8CMWtuWtswVgdqyqYFKqW3QyrnjQWfkG9fFj0FwJPAemgBmDNUAZtmjiVT0mzf5M0w7zrrtMhxYJw1YNqsY8sqVryq04muF/OzbgR2Zy78I+p6sISa8TaOKEhlAN8QDq4Wlg4xJM/TI4w7MWzX1d8MnZvuMS9EwFontzPD1ZFQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OvKMmNnTyuimrWGQeeGzly3tPSwwC2GVTmLm+y+HeIwAYorNA23Pp7HtTuSP?= =?us-ascii?Q?CVR1sDZ9NEHU0/fJ2Dh49aUaFMXfjrTycUmXjGI9O0lRXiZV9ZeQw/krMih6?= =?us-ascii?Q?6LrDTFq0rOdbV/109VxqhQCHG+Fv5fMg0l2qGwFfXjOPvQip+HTb4PvjGFIj?= =?us-ascii?Q?9J9dLo1o4CvK2CnWNFhFvuEIPQVBWzytI1DwkYlLlfB52Ifz5CIadgEENVg+?= =?us-ascii?Q?IrSm6q2aE1m78UX3w/m1npt4nj7OLSpPTuxEmwVj+4cFIr5U0YWM1WkAWsgG?= =?us-ascii?Q?71MWQOctmwbVVFTz6/jGCA/F5es/0gLAFfzpZS0yHwHWCY9s+8NDY05aK+YC?= =?us-ascii?Q?BXxFun5E6ssTOwIa0MIK+SVb1dKLGZ7ugZKvPNLtAMt+INbRaFKchp0DhzeD?= =?us-ascii?Q?s5b54ddSLBVF9oIHpTNDMykoMLOQ1Hj2lpAHkE0np45GszsjZaDmWkRpgN50?= =?us-ascii?Q?Czp7IWCGYjXSTbBaXJ3cn0QknnTuPDD1zMeCzNsIL9Sv3d/SOOh780Yxk+vx?= =?us-ascii?Q?rmYU1YUUhGBEbBZU46cXFCzVKroDkRP7xju9C08P5UJ+MYK3mYRgkz75C7dd?= =?us-ascii?Q?CtwR9Uepk3XLINEio9bSVaeversIGdn10Hv0I9GlELVdZwjPNBFuqMI82WbV?= =?us-ascii?Q?XuCgPsjAPDOU9g9YxZn5EYt9QcbCOw0/dS3WcbKt+goqY1dHYed6hjoGzZ5V?= =?us-ascii?Q?nblcz/n/TnOHH0PYEyEjgKV82vVJmjmWXxKP94bFRi3zn/k2tFz6jUWGateB?= =?us-ascii?Q?fF5M5mee+ciqf6cq8ShSyTZRYajVoCShgPp00laevwPqTPOFYoKMkLeDbl0a?= =?us-ascii?Q?9zkUmdgAw8EOSjozbYv8oAcwEluB/rkXhhE2lV6apctlC+RaKWkTOBKUxdhx?= =?us-ascii?Q?MtUyBC1+bJLoORpz7CeI3bufPdI+jY2eo9zepJPZnpnLJchI0cVHbrQDKEf9?= =?us-ascii?Q?MSTp/vKOpYNR4XN89bwqNRZBfKXzTG3+nAgA8ogUt0vc+pnDRt9EekpIqs1g?= =?us-ascii?Q?c89jCM4zSfTWmbq8f6wbu8qOfzdzHN92/A3jCcw9elc/ln1gkYl/F1/dT6NB?= =?us-ascii?Q?ai9QihbsCtaAcDymuwkU3KBJ0ZXREthO1AGZrSeqnp6mDd4sRFgrgxe2WlgY?= =?us-ascii?Q?9jG/nucjwwWspzftNCHNNah8Uw0xgP5wpOU0GGiAm2qodZuqwoUqe+dSHmBO?= =?us-ascii?Q?uJOwGnw5xWRUOkpAPPOTTD0wMz2VxGwA+k98TaTQ4DasoYXOvEN7MJGiUoDu?= =?us-ascii?Q?m2Zn0c4DMedbpV+J1U5+4TSq1XFtaActELKnvDc6O0SvTIBQodHzkpgBasaL?= =?us-ascii?Q?5sc3MwH7ezuVNeb74B16QfOk?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 020a310f-8846-485a-d122-08d94b72f4e5 X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:38:55.8385 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZslmSy7rokeDstNk7f4Qr1rYzg2gthEDBBcT2BZadVJcbfrcJg6PBoMo4TVXWHsoeMoItbA+aYUmyfzBEbdyM9N2FsMNIiuECeExBwhtGa0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.91; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626781368469100001 Content-Type: text/plain; charset="utf-8" Move the logic to more generic qemu_img_pipe_and_status(). Also behave better when we have several -o options. And reuse argument parser of course. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/qemu-iotests/iotests.py | 36 +++++++++++++++++------------------ 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index def6ae2475..484f616270 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -128,9 +128,13 @@ def qemu_img_create_prepare_args(args: List[str]) -> L= ist[str]: args =3D args[1:] =20 p =3D argparse.ArgumentParser(allow_abbrev=3DFalse) + # -o option may be specified several times + p.add_argument('-o', action=3D'append', default=3D[]) p.add_argument('-f') parsed, remaining =3D p.parse_known_args(args) =20 + opts_list =3D parsed.o + result =3D ['create'] if parsed.f is not None: result +=3D ['-f', parsed.f] @@ -139,8 +143,18 @@ def qemu_img_create_prepare_args(args: List[str]) -> L= ist[str]: # like extended_l2 or compression_type for qcow2. Test may want to cre= ate # additional images in other formats that doesn't support these option= s. # So, use IMGOPTS only for images created in imgfmt format. - if parsed.f =3D=3D imgfmt and 'IMGOPTS' in os.environ: - result +=3D ['-o', os.environ['IMGOPTS']] + imgopts =3D os.environ.get('IMGOPTS') + if imgopts and parsed.f =3D=3D imgfmt: + opts_list.insert(0, imgopts) + + # default luks support + if parsed.f =3D=3D 'luks' and \ + all('key-secret' not in opts for opts in opts_list): + result +=3D ['--object', luks_default_secret_object] + opts_list.append(luks_default_key_secret_opt) + + for opts in opts_list: + result +=3D ['-o', opts] =20 result +=3D remaining =20 @@ -171,23 +185,7 @@ def ordered_qmp(qmsg, conv_keys=3DTrue): return qmsg =20 def qemu_img_create(*args): - args =3D list(args) - - # default luks support - if '-f' in args and args[args.index('-f') + 1] =3D=3D 'luks': - if '-o' in args: - i =3D args.index('-o') - if 'key-secret' not in args[i + 1]: - args[i + 1].append(luks_default_key_secret_opt) - args.insert(i + 2, '--object') - args.insert(i + 3, luks_default_secret_object) - else: - args =3D ['-o', luks_default_key_secret_opt, - '--object', luks_default_secret_object] + args - - args.insert(0, 'create') - - return qemu_img(*args) + return qemu_img('create', *args) =20 def qemu_img_measure(*args): return json.loads(qemu_img_pipe("measure", "--output", "json", *args)) --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626781913; cv=pass; d=zohomail.com; s=zohoarc; b=DO56KznAa7Lcs/B/x7xu5XxseF1z3UrKDONY6Qpj11XTSfS/BpDzGpPwczQ6usFFNTFmvpxFqCF8YKVMU4/9lTZKGGz2wvHlHp5IBNr+FpUOEZyo+ZZvW7+FJlusrtuXKEUB0eI4HO1LNIa693SJVlVZ03Bl2SMegxyZDmOEkNQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626781913; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Apb2arpVeOqHDJs+z7RI3HGryl/2mDzB8TMmoyJ/ksU=; b=P6aakmBBrHgA06plimbwvxtYvMf1NDWRnFtnQuB7ra4ojFNqdrnOEj8ILoxnqztvHbEfCzlpKA+/XaJUqpDDNDg0dQWuOTKwi42i+jJbOzWQeH7nTAL5L3M2XTwFb/4Wn8zv0X2ihMnUWo+V+LFLsMK16SR7zLv2JyudM3JXjlM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626781913444974.4826356033504; Tue, 20 Jul 2021 04:51:53 -0700 (PDT) Received: from localhost ([::1]:43294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oHw-0007c8-AG for importer@patchew.org; Tue, 20 Jul 2021 07:51:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35724) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5f-0003EG-Uy; Tue, 20 Jul 2021 07:39:13 -0400 Received: from mail-db8eur05on2136.outbound.protection.outlook.com ([40.107.20.136]:65205 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5d-00077C-Ks; Tue, 20 Jul 2021 07:39:11 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:38:57 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:38:57 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:38:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oQ9X+djZJEuEF0Kxjr+FxT4HZO0NzWVmF0wqBXAOK/CKAfas9hOqOJ0eAEitvup6jEzyt2htGP0OV+vSDTM/X9SjwncgV3UIULbplmO4INXu+YTF0BH/qWSo1QhWoR/Vh21nqVLRWP50QgDMFsHqxtw/7umJXLj5Gm/5C57SDtzk3iyzONjXCCBOt3Z/W1jRVobZl9TK+Ix6XpcMsvU7fz10t+Y6u8cuNKM5uLlxNAy+xETDu5OJLFaIZYrFebAzB9vK+SMSyGaOsgz1AWn1I8BPq2meAGmyPlcV/3aHaR9uI3KiSi6zkP4wO/knNiyq3BhNJu9jjegUSo3dXGsq7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Apb2arpVeOqHDJs+z7RI3HGryl/2mDzB8TMmoyJ/ksU=; b=d2AZ/4VOD8ImZftwr2vnFjGXVNi4/Ghv2R8Q5JvWV//5j9E61qjIsmusbb0ZjSYlk12mV80r3oyXYWJWZwfvCcjjFVmwnCjoU8mQEHoPbfbYC5OH2M94ebqD5EtyvP3lkWi0Iym8rVbhKSVV5SVkQyd9EKPnyC331uHbfh9TR2OHruTXCrP47xVRXzZfIXFRai0HXBox2n0Rbx613tPPURUYd9gaKQA9tY5wZzDXQ3syGOIPQbCGl39XOaA4AQacwqprE/fLpLC3xGfgDTHEfQDG68Pkekt4wCUTCKf1RXO69DBOFrqkl+M89qy/7q2y2cidzIEEkuvMGoKDdTJBaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Apb2arpVeOqHDJs+z7RI3HGryl/2mDzB8TMmoyJ/ksU=; b=NSVPW+2UMl8oKJkjkIWQb8+mNRl6jZUjtieaIVsq23LJWWppoP/BIvvfb68gdSqPUHfhKxVF/dUtWMnyl9sXItcV+8mUKYUpt6V47D4WeYCsQFBf2B0ycx73xItDdYzk5LVDMPSlZR9HjR1APCEFjg34h3pwYRxuOxPNO/ZsMqk= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 05/17] iotest 303: explicit compression type Date: Tue, 20 Jul 2021 14:38:20 +0300 Message-Id: <20210720113832.586428-6-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f722fe0-72e9-44e1-881c-08d94b72f5b8 X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qbJ8jR0eyiYsT2X25vdRZmK4Ripq+2YoQlIfm1PHLhUVXcgDKj5sLWha1e89ppsNa1RXz4DnU9XmO3YX4Bh31hsvfcSM3LEe9Cdt/oVBgYBRsjq6/zN0uVrvaXKKrqi2WxyoKYuTLcUyaDx1MXqGoKQy0UmfkFJEkXcAL9cggRPsGwQzV+bh21YiaqDDEZNj8D8EdtAEN7vPFQMzQPlBGZVAL5+80WtAqew9oloi035CooH0JkVMCOWm3uByvXKUT9kCL+rQzUcCQRh8ZXjtyVUa/0fLdEVUnL5ftgk9dV6MjdAN+46cuWnpKTvIj00aGnhWgdO0szz5i2vgqm9nxQ/1uRDwgxonhHds+W7Y4gCiQmbEvZFRCh5mvXcKdCv/TDhL0iSVAG+cLMgDHOmIQVKV6hj+uUNYeZAm3xQhlmrlxdFAqcQSvZuzo3HI75uTbSO4GzXt9oyRo5CG/UV6DTrYUDBKA2TOY+AwaYF0qC46a2f5sSt054EqcT1ujvYl7RHRq8fjA4CpBKRNglCJtXV8Q5ppYC+VSH2TVafpOp+TVz4famEr8cQO56Gzk3XLqFTkMiOQ8ZhrlUsOOYtxIy0qmImr8wfV2lwW77npw+1MUQLaF73T3uMQCAULoG7g4JbASdtdmozNR4kBDfWGBoytOGDjRcP2i2HbLUKlw+ZE/s2JrIfB/f5IOM5cnU8klH5yO6dMhY2k+p6KseMYB4IAlGWTA740H1kulmEH+ow= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007)(21314003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3M33AATSkWFhZOmsQ3RcL/FigehS2o8/6gbjY/IN4O8mssI8LUX/VJzBaqAJ?= =?us-ascii?Q?P3WXWIzW0LsU0LpDHHwkJhBzirSkaLkNsMNMDSOA+JuzKNlxWxX+suE47Plg?= =?us-ascii?Q?sPxbDFwXZgPbFPkBf5M8A1KgZKh/TMpzFkUOYbGfTn3x4i1SmUcWKeqHCpsn?= =?us-ascii?Q?F0K+/LbI/D8EAHl6M/v5n82DkVHAdjyen8BUg7mLnyAl64cu083q91I8P6kQ?= =?us-ascii?Q?5rWgvV+1HlGZv6adeaeWo8E+R23PS/h2qKiUUHcOY/teUfLBiyp+jhRUzjV3?= =?us-ascii?Q?IBjPHlvLmCCa44Lfcc+XRM08mXV2bL5D0EQgHU76pFYMHuT2TLgsKoFlTsS8?= =?us-ascii?Q?f+BmTc32xbPtapBS61nSBm2IjgA+Qm2qtxrIK3tlL5fe1Kue8RO2Y0a1H8wf?= =?us-ascii?Q?PB0hUd4qGbmK+iyTk/3JPlxKr2qkI/vX1rPepPw2DLpS0Twq/IxwspD7tz5f?= =?us-ascii?Q?4ICkujcQFApAjt7EPnkxU7jI8cd4b25ErN0h63rPfHUJf/yaEwKFJtMCLEC+?= =?us-ascii?Q?MDOXSGW9EgPnmLStUR+nUyy86h8OOPBTm/JKoqpP8UILHF2aulZR+BUQgZoU?= =?us-ascii?Q?YDUuukcXydZPJlwgxogBMoYBMMNGIZ2YRJPvilMfr7BZ5dmjYBx8YtKZay3S?= =?us-ascii?Q?Cdx9Pr9UVF0jijT7sH1DtAxOFO0rlfalmg2rFNrT/EiYLUwlMX8/A3paTF2w?= =?us-ascii?Q?QSHCvFgzFV7mPDkci/kc6nPoj0s8RSVGwphpDaeBl3Z7fRFLcRe7YxMAzMnK?= =?us-ascii?Q?BZvHfCX/XEzaFVrWMuqLfwvdgNEfhNBp6yi2uy6Ctv6rkz1mmYpdLhQ5XZhR?= =?us-ascii?Q?i9IBSBR4WzBq7WelpvJ3EZhwqOoQvvVoeOvdjgUS5nhvH46Ly3v+oGZPAmyd?= =?us-ascii?Q?+tNopJqUjkLbs4QFq+DrvyyExc0XW6JxA/4HX9KpmAiMbSx/qAmskQyXSQJD?= =?us-ascii?Q?yoxZZB6BNynLE9LxXfs72UiFLDWkHM4FabVOkrQqJEoQAQJmzOg2GU8Ot0bh?= =?us-ascii?Q?CXSZ15QI4ux+4Zmnm4HwbZ4jOxPEs3cvrCitCxnaXf+4lJpPL7pLMYYjRx32?= =?us-ascii?Q?iHGOZYlJWZJ00D06f2XfuvFgoa34ahxNHSuTIpmNU2fmfWvesRrCrcm75Ajx?= =?us-ascii?Q?Zx4tkoIhech+lMWxKaJ7h1AKwbcuSm9Ps16AIqRBTjnUcpgnrIRXvhZpPkFi?= =?us-ascii?Q?pnUKCI7YR6DxE1nnjWq/URIlsYn1vIdAMIxXP3VNrcFBkWHnPN0O6aJJEc0O?= =?us-ascii?Q?nTMqtpgKgXWoo+dKuriNVhuxsLsMUQWwb0a6JFWOjId2+Zb/tnLG0gyAbHZr?= =?us-ascii?Q?D5mafyd503qxc6UnQj6G2KRm?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f722fe0-72e9-44e1-881c-08d94b72f5b8 X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:38:57.2244 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SJWNAjl5+JsbwikL9WFM1R9GWTTBkx1L9/2MFU5vMtYWHscbFtOLd7s2gBXFAQsxEtOGn+mnXPAc3uwajxnEwPfS1rPgb/2K/jOAvUg/ASI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.136; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626781915466100001 Content-Type: text/plain; charset="utf-8" The test prints qcow2 header fields which depends on chosen compression type. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/303 | 25 ++++++++++++++++--------- tests/qemu-iotests/303.out | 30 +++++++++++++++++++++++++++++- 2 files changed, 45 insertions(+), 10 deletions(-) diff --git a/tests/qemu-iotests/303 b/tests/qemu-iotests/303 index 425544c064..9dee2bdfb8 100755 --- a/tests/qemu-iotests/303 +++ b/tests/qemu-iotests/303 @@ -53,12 +53,19 @@ def add_bitmap(num, begin, end, disabled): log('') =20 =20 -qemu_img_create('-f', iotests.imgfmt, disk, '10M') - -add_bitmap(1, 0, 6, False) -add_bitmap(2, 6, 8, True) -dump =3D ['./qcow2.py', disk, 'dump-header'] -subprocess.run(dump) -# Dump the metadata in JSON format -dump.append('-j') -subprocess.run(dump) +def test(compression_type: str, json_output: bool) -> None: + qemu_img_create('-f', iotests.imgfmt, + '-o', f'compression_type=3D{compression_type}', + disk, '10M') + add_bitmap(1, 0, 6, False) + add_bitmap(2, 6, 8, True) + + cmd =3D ['./qcow2.py', disk, 'dump-header'] + if json_output: + cmd.append('-j') + + subprocess.run(cmd) + + +test('zlib', False) +test('zstd', True) diff --git a/tests/qemu-iotests/303.out b/tests/qemu-iotests/303.out index 7c16998587..b3c70827b7 100644 --- a/tests/qemu-iotests/303.out +++ b/tests/qemu-iotests/303.out @@ -80,6 +80,34 @@ extra_data_size 0 Bitmap table type size offset 0 all-zeroes 0 0 =20 +Add bitmap 1 +wrote 1048576/1048576 bytes at offset 0 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) + +wrote 1048576/1048576 bytes at offset 1048576 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) + +wrote 1048576/1048576 bytes at offset 2097152 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) + +wrote 1048576/1048576 bytes at offset 3145728 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) + +wrote 1048576/1048576 bytes at offset 4194304 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) + +wrote 1048576/1048576 bytes at offset 5242880 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) + + +Add bitmap 2 +wrote 1048576/1048576 bytes at offset 6291456 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) + +wrote 1048576/1048576 bytes at offset 7340032 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) + + { "magic": 1363560955, "version": 3, @@ -94,7 +122,7 @@ Bitmap table type size offset "refcount_table_clusters": 1, "nb_snapshots": 0, "snapshot_offset": 0, - "incompatible_features": 0, + "incompatible_features": 8, "compatible_features": 0, "autoclear_features": 1, "refcount_order": 4, --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626781570; cv=pass; d=zohomail.com; s=zohoarc; b=L/UtoxG1j0n9ZXyUipv/HyRZSY5zxlK6dZwu6ba+z1VcMEnP3C+08ujQ4EJ0ozudwzTFxNvHf7oqDbbCtXUNuywwu+8IBqkl5JY/beFlZXWzuXYmlnnO/15UO/ES5cPHrz0JMwsnGFzDuvcr4nyuAk57qxUp+nyBLCJYErsLCpo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626781570; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gY/t8id5XdxpwSV5oBw1czyUbckrm0T4fK3jWEl1gqc=; b=ZZ1DofVFpTTpSVuE2uWO4LDvGKSkYpiNJ7RwtGhFlZZ/Ak5KCmUQ8DRRZL+3cY/p32qwIZ73e4jJBsBF3JTuvUqQctzHAb4fKt/9NboKIpM7IUi20qF+aD5vfe93e2G4pGMj7pOCUD3geEQMKWnIa+y94a/58CO1cYoHA4zF648= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626781570684195.17766579633007; Tue, 20 Jul 2021 04:46:10 -0700 (PDT) Received: from localhost ([::1]:55086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oCP-0004rb-HA for importer@patchew.org; Tue, 20 Jul 2021 07:46:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35736) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5k-0003Ew-U5; Tue, 20 Jul 2021 07:39:20 -0400 Received: from mail-db8eur05on2091.outbound.protection.outlook.com ([40.107.20.91]:40417 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5e-0007CC-6S; Tue, 20 Jul 2021 07:39:14 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:38:58 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:38:58 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:38:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WX9p7kWmbEjCxqUKby6UUPstzvO3EE8ATO7DfRy0OzjK7G0ng2ZzCfxO2W7uxYYMuaKz2/OR4D0veBkUqnJM5Uq/gdb+v6KlVKoU1t/ysUHxU6s461iYcPxVMiDC10b6kCcFbMu7Qk0NJsGjS+TOplRjrFciGxjMgTfFef6shKUEbRckByG8REqi3XCgrKChGO1HKGkp93KOiNDwSpMP4GBP+pLaMNf1B1nc6YPNRuJyTNSIi8+s5QLD8ljjsyVwc+V6mas8FdKq1Q05c/E2e9Efb3p7AAf+SjX6t31Hu5XP3Cp5TItutj+1cW5sQ1/qc+VTClVDW3vQwGkoh4O3sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gY/t8id5XdxpwSV5oBw1czyUbckrm0T4fK3jWEl1gqc=; b=JOtW+bb9kSBt3gWEIP+/0oD5TpnD1eoujbureBDxMOewiV28Zwip3sF4ErB9NERXcb7wNP5bX/HfRKSBVW16oqRpgBOxGcg25T9kNNSFP0pxbp8lvsq3oiq9fEIn3u+LmtmjZicrn9YfyWgxQp2STB8CjUEJCOj/LCChRMt7De1gzjsqUBVJtTysrLg9KfgkosY9avnc+jUlfmxI4rq3RSP4X9a8rScm1KzvF/rjyH+PwEx8RVLaXz442HVfj7kSrtYdI6BJfu2gPwQ10TebsiJ1W4j3bAPOWg4XGhv2Q2pumkzqDmLaB+hdRfMQW1KjHBEvsI1zuHAuUamBwtJzCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gY/t8id5XdxpwSV5oBw1czyUbckrm0T4fK3jWEl1gqc=; b=VTRatgsPSe0FNZ+ylmfEiVl/SFMgxnp0yUFiAyEJz2ErHEtEpez8XjpkAm3JiDTBz83H5UyYUhBD7EHWtCNM4FI8DLKS2FTV6J5cYSolECWN4QNnb3opjDhmd/vmAh/Wp3RHlQ1L7ZKuA6IkQFtq+PVGxTX0a1XjaTYyAfHXzFg= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 06/17] iotest 065: explicit compression type Date: Tue, 20 Jul 2021 14:38:21 +0300 Message-Id: <20210720113832.586428-7-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04ab898a-3faa-472c-3c1c-08d94b72f692 X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2887; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4y6Xoo28WqE5GLOh6k/bqopt3UVQynrYNp/J6oYMW7gjMnK16T3eSbd0M3RH0PoKBcxoOQ4YhUeMCK/zCV/guUqHfKkkS3oIO1yHy8d+VyZ5hlLamy0JfyrKEAmHaRM+GV2ZrPZ/+q7yFkUBX5XC41YoKankyMaZblFign8445VKlBQ7qeaWIYZCnW/SG0QCXvCMCyJKcqTVW0MLn+Jqm1N7lGj7NTLmj2V2hzUF/KkhZoDel0gA7JZeYOGWaqJEjhU/M655b8uNvtkafA3bxOSrtGtVTDTx6nmJGZF4XZzVpj2FPk50UC8q7a+OBcTnLOtlSueW2koAo1Y6VNGaa1GreXSgv6QKzieCPOJFNwDq6IiLWWi/U7dxlv+BLGkwuyd8d4ZS91VEbcJ63w44/wJy+cjmHJ4AD/ErAddZn1NpLKqIC8x66QCZAC3DT8QNRCRd2WAtX2QMceN6cs5SB7bKbTgQdHwEiNh57boosLOcgnnYeBheP+9oUK8hjiSpSsXHu5y1+M6EA2KvtSjAaC7Q5/PdiTtrlJTVvTTX2svgLU5vJdphZIZsWDNQJN+uiJdhFnB2p8IDCRlB0jvsNLD+wciWjGBYCeRnis1orm7qWL+ItdKs1449wKhvKY04MfoVKoy2BIqIJJ1bXc1q+l7Ozdvl9hRzbnml+kZuUfVY6/6LDHtPQMvH1xRRkm0+GA2DfM0Uj7BTI//ziE4qaQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?McNhZzqdt/uy50bjvngkxNWTkbmRnIUX/6aDqMkeRCgOGThMSwlj3XH0WiXm?= =?us-ascii?Q?jbqPILaQLXIjw6zY9mI/yqsgkBBa/eBWWUJtcO6JfuRDe+R0aPYFt2zUGNol?= =?us-ascii?Q?ysdrQZQVwhlfYChuvubUWbW/seK5K/uYC87ITgZHUbWQ8PM/1fMau6sJekgP?= =?us-ascii?Q?P2RXH6784mWLudsJO6CRLClNWNmNW8c7KbnOzWZrZ5BHUrJdpOkawIfh48vN?= =?us-ascii?Q?2IFtXSC9MX3J8/sEeg/4RSeiXGzYuh/gOSiW0pADVcx3InhmeMaeUMlBID7O?= =?us-ascii?Q?q9+HgvQyxYnHFkuoJvYSoqK841JQrGmHRYovLpMFNGRySdMDLKxt2AHKCVjO?= =?us-ascii?Q?WioZy+CXNilmYtm04D/shNAgzq1cMxNWI4YyHWJzM3CkJrAyAV9EK0kvqCiS?= =?us-ascii?Q?ar5vpk4oVTjL6CdnAYWuHAC8hDnrxnynO9dEMfsMl7ol2ihjFM2a6d3vDb1i?= =?us-ascii?Q?UI5O4j0ckSCWDLL0sArBaBrDPTk+IkSLkvMYm6OZbmUvu6Eki1nGCfxevBWm?= =?us-ascii?Q?8ZPUH87fMWcVtk8DucmnUFASWMq/0A/hiTaqsSo0STMHsHYWJfLXD5ur+RXi?= =?us-ascii?Q?tL84DrapWJDquvG2PXk/lGHJ2Aao0MjdfrOpEcHbfSG0YOnQgvXlkLLbmwAe?= =?us-ascii?Q?th7GajAs+8KMMM2erMxXIstAVw0si3l/RX81wOW2SpzZbfkTrHNCuDq6tnKb?= =?us-ascii?Q?JPtoMA5r7enuZDONA26tWMOmkVfB3oX/fMKTMzaPNreOYl3TDi90l9F/CJqG?= =?us-ascii?Q?4LxybCvBzpyT/G6A8zLwteh6rAtSeVGa90abjDeXmoK54UyWbaybRIV31elp?= =?us-ascii?Q?z8ldcdiAQNogUxJ4dfLpg/vAH//WE00580PQZ9Ulbw7gQLAnmv2vOh4fa4W0?= =?us-ascii?Q?mbpQNMY0oU1f33b+5nxuKMhwdXVWqdmRvW+dgdfEjsWLaBw9U8PR2lj6r63b?= =?us-ascii?Q?OIxz0nAg6U3f+RhN7hKNdCvbj9TJwZapdp2PPvhpg8HVSUBY1v/ldNtmzxuZ?= =?us-ascii?Q?BZRLUafYmU92+ORCS7siCm7eXN31o9mGfpCLY/HAM4fTeiqNME54VCuMJ/Bu?= =?us-ascii?Q?umYHmOTukJl0dpMp7uIVhQlK20OJXiyuT3BsuxbxGRrSS+SbkxqNVPA86eua?= =?us-ascii?Q?/SjzwVpJx8PlGONMwvRCudz9xx8oNbn2m0JuWj5uD/d1jIqw9XFb0/RE/7/Q?= =?us-ascii?Q?Y8N+AdK7/sx62GZ//T2h5OYaGRP8l4sa+Y9rBQr1aVCiVe4Li0HwvauGwKWt?= =?us-ascii?Q?yzhAJcHy7JS9jaz3y8zuUZO5y/E21NKq2iOzznzzypf6CpMSJTzMKnubRybn?= =?us-ascii?Q?IU6yjbTwBaxMVlkHja/euJex?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04ab898a-3faa-472c-3c1c-08d94b72f692 X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:38:58.6312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X4zo/npb2krbaJTonoVDUP/hcjr6dEG8xvvDTpqqxS5BXeIl1+l49ZPPuE/Q7mssLSnEtG2ifk7q/UAQy8vuL0BLdtomMg60fDO4ymIPUBU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.91; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626781572227100003 Content-Type: text/plain; charset="utf-8" The test checks different options. It of course fails if set IMGOPTS=3D'compression_type=3Dzstd'. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/qemu-iotests/065 | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/qemu-iotests/065 b/tests/qemu-iotests/065 index 3c2ca27627..4b3c5c6c8c 100755 --- a/tests/qemu-iotests/065 +++ b/tests/qemu-iotests/065 @@ -88,7 +88,7 @@ class TestQMP(TestImageInfoSpecific): =20 class TestQCow2(TestQemuImgInfo): '''Testing a qcow2 version 2 image''' - img_options =3D 'compat=3D0.10' + img_options =3D 'compat=3D0.10,compression_type=3Dzlib' json_compare =3D { 'compat': '0.10', 'refcount-bits': 16, 'compression-type': 'zlib' } human_compare =3D [ 'compat: 0.10', 'compression type: zlib', @@ -96,17 +96,17 @@ class TestQCow2(TestQemuImgInfo): =20 class TestQCow3NotLazy(TestQemuImgInfo): '''Testing a qcow2 version 3 image with lazy refcounts disabled''' - img_options =3D 'compat=3D1.1,lazy_refcounts=3Doff' + img_options =3D 'compat=3D1.1,lazy_refcounts=3Doff,compression_type=3D= zstd' json_compare =3D { 'compat': '1.1', 'lazy-refcounts': False, 'refcount-bits': 16, 'corrupt': False, - 'compression-type': 'zlib', 'extended-l2': False } - human_compare =3D [ 'compat: 1.1', 'compression type: zlib', + 'compression-type': 'zstd', 'extended-l2': False } + human_compare =3D [ 'compat: 1.1', 'compression type: zstd', 'lazy refcounts: false', 'refcount bits: 16', 'corrupt: false', 'extended l2: false' ] =20 class TestQCow3Lazy(TestQemuImgInfo): '''Testing a qcow2 version 3 image with lazy refcounts enabled''' - img_options =3D 'compat=3D1.1,lazy_refcounts=3Don' + img_options =3D 'compat=3D1.1,lazy_refcounts=3Don,compression_type=3Dz= lib' json_compare =3D { 'compat': '1.1', 'lazy-refcounts': True, 'refcount-bits': 16, 'corrupt': False, 'compression-type': 'zlib', 'extended-l2': False } @@ -117,7 +117,7 @@ class TestQCow3Lazy(TestQemuImgInfo): class TestQCow3NotLazyQMP(TestQMP): '''Testing a qcow2 version 3 image with lazy refcounts disabled, openi= ng with lazy refcounts enabled''' - img_options =3D 'compat=3D1.1,lazy_refcounts=3Doff' + img_options =3D 'compat=3D1.1,lazy_refcounts=3Doff,compression_type=3D= zlib' qemu_options =3D 'lazy-refcounts=3Don' compare =3D { 'compat': '1.1', 'lazy-refcounts': False, 'refcount-bits': 16, 'corrupt': False, @@ -127,11 +127,11 @@ class TestQCow3NotLazyQMP(TestQMP): class TestQCow3LazyQMP(TestQMP): '''Testing a qcow2 version 3 image with lazy refcounts enabled, opening with lazy refcounts disabled''' - img_options =3D 'compat=3D1.1,lazy_refcounts=3Don' + img_options =3D 'compat=3D1.1,lazy_refcounts=3Don,compression_type=3Dz= std' qemu_options =3D 'lazy-refcounts=3Doff' compare =3D { 'compat': '1.1', 'lazy-refcounts': True, 'refcount-bits': 16, 'corrupt': False, - 'compression-type': 'zlib', 'extended-l2': False } + 'compression-type': 'zstd', 'extended-l2': False } =20 TestImageInfoSpecific =3D None TestQemuImgInfo =3D None --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626781761; cv=pass; d=zohomail.com; s=zohoarc; b=hduW6P2QFATgESNFsJkBkCqgHGP3JVl4vBbp92c5X9B05umW5CDBp65E275bvlShHorXtWx+qrWT3TPuN03ZSOuOw4n4Pxv6okfhmVPCM19NMUgbAoE2EWCynZysfWyUZc1I0zKg4WfoVbL6rOgqwXn9Ha/wekHnZELF1LqaB50= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626781761; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lKOw0YucH6EqXoLykl1ICgkIhGu3RQ/1v3rslXcmr70=; b=IcpBtgkPMSsavK3L0ejwatJKtFA6x0kMMxzAaZLG1km669ci/LCvs4sHLsUBLnSRwrHtgHnqf0xICGil+qIr/WG7hZCLfk4rbOEGuChSopTFxS+PaZTmYC696w1SBXm98lrPx78b0IZZVJN1W9LN7HAAOYPym7oD5NzDPn5XtFo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626781761991397.82483810661074; Tue, 20 Jul 2021 04:49:21 -0700 (PDT) Received: from localhost ([::1]:35186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oFU-0002CS-NO for importer@patchew.org; Tue, 20 Jul 2021 07:49:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5q-0003Gn-K0; Tue, 20 Jul 2021 07:39:22 -0400 Received: from mail-db8eur05on2136.outbound.protection.outlook.com ([40.107.20.136]:65205 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5j-00077C-8k; Tue, 20 Jul 2021 07:39:19 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:39:00 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:39:00 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:38:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TFYlgP+tw4Lg67oHlgsvBGPCFQI3xRUtOKnoPPNvO9L71IDjCtsFgOjFflFp/IIwaGtXqtt/dKwV3FPvZMQbbcv/NJPvxwdDCTYSBn3A6f2MKZp2RyzXdgbFDDZxxO/qdmB/v2STb64umcvfn7ClPD4EOVbqRxFSjJFpxxYnrcau/rymp1v1RtrLFbqg+HUfN9Tyvel0d7hqbFf2a1wM67NzMOzCdIE+5wWuwzCghVKhdUuKVa5x6QDO7p+Whi01ve/4kF8VhoYIMQ0h5IsuTU492MGs7Ql+6jhDSLA07BL8Q87J1fxSrzRFCwd5F2aKtYfZjftFUH8KdzASXvpSrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lKOw0YucH6EqXoLykl1ICgkIhGu3RQ/1v3rslXcmr70=; b=L3nSkAemQQNTlOTSAypSMytmh3g95rvuy92ItSgIV3MBuByOWcUOKQe/A/zk9w5f3SH7ecS2PNr3R8IvK/9tjuUaKaTk2OqiD3DTBU5PrU95TL/4RC6FjlduwOmAaaoZrUuhMSpErtqwkTmqN0x/CR6EJLrRU8pgRb4AqEXe0Yn3bjiCbK+EDSPnFrn1hw7z4WBvk5NbuvEfBcSFQizTjvfs/vkzkoBZz9gUU63ZWvr8yw8OAvTwYEtFoX/DCD+xT9cIHpRAHcZkN+o0d2KrlUI7OXRSZ+dbsvv8lsPBHIur3b1HrEkDfyGbWkLL/4z7oQW6FBnKiWnBlILMiDxk1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lKOw0YucH6EqXoLykl1ICgkIhGu3RQ/1v3rslXcmr70=; b=aRcb75iLneanxAkubVHAkXlCM6eIH+DrquSnMLQfwaAErWMfHD/JSGRjsOK6wuK4cY/Ugim6WooXO2z7QE0FNSSxtQQCnVTR8JgSUBgOQsRb1ZJBWv1KE0r5zEcf1uegX/zLjYUeesIs/BehG3SgGMZa/QaFKv4FXu9kO2tqFxA= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 07/17] iotests.py: filter out successful output of qemu-img crate Date: Tue, 20 Jul 2021 14:38:22 +0300 Message-Id: <20210720113832.586428-8-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 27776778-8096-46f7-511c-08d94b72f766 X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:327; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aOUMg8hn5qRTv1udd1HoMQmYfxAhWrwhnGr4C3IdHwbDCK/VIbtLVAIMT3dX9N2jmUpuJPK0LxtacM/B2Ob/iMf9phYhUZ/pHgUcX+LbqVC5leeo4qjLWjYSwwPx3uFOIFgarVlobQ+OnhbQ4HlJaerqy3kpa29zCHzqJGC8Y3m1maTxpH9r4OJWOf77bahcUD9lSAy/6LCxlhf3EgoEskH2EOUKyWAwJNJnaoky32/QjPFixznp7fsY736vqHe6GNer5pCnWSnjtnJPZlMliFeajPbwC/IfC09GU5YSiCoXSElLpHcU2eY/1kk5uHa5keUYeewX4Xetsut/psOxKiowmFcBDEUoY+XzaG32IMm7fUCtEe3Q2iwLNR1TDwCGv3SzGgt2i0kY9HoQXAAvrlrJ0XUf/8IGDQBxePY3fqk2MkTegzwuXeBvOxMJAxzRZv6qrJYIgoMlM7meNzhNtFVO3nkl/RSBF0Oj9L63p+Vg+Vqf/YWOfcDtXIGK9SReqWZHRjbvUj2unbug4XT23Hp6nl42Ry04eMdxsqb1+zPqYO2wDiHOWRIq2uwdM6gVwelqcFwn4Ry5bUGmcguQB424bp8zVBb/BTPndZoIUafdDWCnfYyfIZ9QEScWAZfv6W38n+RmdfK++jp/y+2bvX0Cfo17HgIOMFYV9tzzwBY+WFvjoTgXtvQUfDr83kumDs5Bdz91sc9dWGxxp/wwIrBV24KqA6RWoNiwzpGF4xs= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(1076003)(478600001)(5660300002)(30864003)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007)(21314003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uKYyyGW4BO8/u12cHx88FOa+BsocxuZwDH6Q2miq47cHv4INnv4L9iGmWjc2?= =?us-ascii?Q?oT01nH9M35HNvr7gtWMnzygSS8V3BJM+Rfo3I/BURYKrciu9JzTcKNiRxDaQ?= =?us-ascii?Q?rw7DXwNHUQZ68+5xEkrprF5aW+KtqRx60c/PqVtuhzHOqi+SLWKwlmZS/kxw?= =?us-ascii?Q?r0sNwr6TeG+Xim6+ECju/5FKi1uNAIHCI8vP19Nlgry3BukjAloKETShlCFB?= =?us-ascii?Q?m7K3StnH4VlsMdV1Tw0aL3vcDoX/5gKIZE12G/9pdafVOubBee0g4csFs58q?= =?us-ascii?Q?OOYugppVgXqr1cfzSRtOSVzwF8HslwaUY7zuNHKYrEdOOrBDAuE5h1WytQrN?= =?us-ascii?Q?aSr0qYZXSqFnMPPKiG7UBnXN5qchB+Am+YNYtIhhV/C3GRKsCBwtQtm9YSJY?= =?us-ascii?Q?geEMHjQkMOsfB7AQAvv78D4zgDd4GE8oDzIMfFfEV4O7xfB9eKCQZx8kzf4F?= =?us-ascii?Q?CnFqh609TZcVYoSSlqO+zSWHp3Kz1ANM1KM+5XBoCGVtGAk8mvXKNI/niWw9?= =?us-ascii?Q?XsgPNry1Dm1sGoLVBCsZKmf7XN6JTwwlnQJJEAkE+eMNSwKLxGlvcSht2MWQ?= =?us-ascii?Q?EWwUrg7gScYeywnBYQjQE0QFD/bHjQF5krwVevv+shSqbI51rnBy0ID4aryA?= =?us-ascii?Q?r5sQ8AFVm6EtUkzz4yhMNkjVhTdDCdKFLSzuHOFwBvKHhriUzkbH/Z5G5tgy?= =?us-ascii?Q?zgU3Z93vjggtRFw3OBL2Caf8OyLJmQ8oQpFRQ5RRVnpr0RTinulv4e4tDksT?= =?us-ascii?Q?N39BBzpV2IJgTE9qIsE/62LH9MF8mCLkE0eSyvn2cU0lPAHMqbBUWJrk3AbV?= =?us-ascii?Q?FWaG+u1O5kqK+yKN+DOlNLm77WtDecFRe89MtDhk9HDOYiE8FHyk6B8msZjv?= =?us-ascii?Q?UNKPJk0ZmIMVRqwiiG7QAiTHOadNW0SKaYxv1caMWZttjC/JdHLKi+D6whf3?= =?us-ascii?Q?Otd07/TyPSNYUP+SnKHd1I5q6qS6L6Xs8ZaaQyjlzwkjBZqvzUnfT6e1OS96?= =?us-ascii?Q?lU2ccS2CS7FZKDqr1CEmAXefIVlbbY+jx/JXHpFnRomaLNrCVei1WyDWNJTJ?= =?us-ascii?Q?tIT3Js3tMfBs841CVmy3O1kwKw/xB/EWUJgCccPh+HsHePzlFkJf46+NBocy?= =?us-ascii?Q?tDlP9Cd+4ek1KanX41Tyhacsv1dNKtHONx3mG95BdpnMIDOyjKBRGj3KoQGH?= =?us-ascii?Q?iTKuAWBG9qR4AHkY0i7+AVYiOsSltOOHorrvM98zjwm2sUx4hxNEDhfIDR6I?= =?us-ascii?Q?S2NlVYU5HxDjx3p1fIDePsJX/WaDeb4/0LPgJfzjHGCUrx6ZDjphNTJBFDXF?= =?us-ascii?Q?AJvE1Y//0E547kokMxwgH1Yj?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27776778-8096-46f7-511c-08d94b72f766 X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:39:00.2003 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jQqFsCc8Th6Nq32g+g1BNeRdNXmjDAppLAUDlLVPiuZAtisp+nyRmYM+abKYa6ntqoW/GUsq9/nDg8/Yi7XSX+NvwMAqvJS+uX0MwDYUK1E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.136; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626781762757100001 Content-Type: text/plain; charset="utf-8" The only "feature" of this "Formatting ..." line is that we have to update it every time we add new option. Let's drop it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/255.out | 4 ---- tests/qemu-iotests/274.out | 29 ----------------------------- tests/qemu-iotests/280.out | 1 - tests/qemu-iotests/iotests.py | 10 ++++++++-- 4 files changed, 8 insertions(+), 36 deletions(-) diff --git a/tests/qemu-iotests/255.out b/tests/qemu-iotests/255.out index 33b7f22de3..11a05a5213 100644 --- a/tests/qemu-iotests/255.out +++ b/tests/qemu-iotests/255.out @@ -3,9 +3,7 @@ Finishing a commit job with background reads =20 =3D=3D=3D Create backing chain and start VM =3D=3D=3D =20 -Formatting 'TEST_DIR/PID-t.qcow2.mid', fmt=3Dqcow2 cluster_size=3D65536 ex= tended_l2=3Doff compression_type=3Dzlib size=3D134217728 lazy_refcounts=3Do= ff refcount_bits=3D16 =20 -Formatting 'TEST_DIR/PID-t.qcow2', fmt=3Dqcow2 cluster_size=3D65536 extend= ed_l2=3Doff compression_type=3Dzlib size=3D134217728 lazy_refcounts=3Doff r= efcount_bits=3D16 =20 =3D=3D=3D Start background read requests =3D=3D=3D =20 @@ -23,9 +21,7 @@ Closing the VM while a job is being cancelled =20 =3D=3D=3D Create images and start VM =3D=3D=3D =20 -Formatting 'TEST_DIR/PID-src.qcow2', fmt=3Dqcow2 cluster_size=3D65536 exte= nded_l2=3Doff compression_type=3Dzlib size=3D134217728 lazy_refcounts=3Doff= refcount_bits=3D16 =20 -Formatting 'TEST_DIR/PID-dst.qcow2', fmt=3Dqcow2 cluster_size=3D65536 exte= nded_l2=3Doff compression_type=3Dzlib size=3D134217728 lazy_refcounts=3Doff= refcount_bits=3D16 =20 wrote 1048576/1048576 bytes at offset 0 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) diff --git a/tests/qemu-iotests/274.out b/tests/qemu-iotests/274.out index 16a95a4850..1d2928e14d 100644 --- a/tests/qemu-iotests/274.out +++ b/tests/qemu-iotests/274.out @@ -1,9 +1,6 @@ =3D=3D Commit tests =3D=3D -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D2097152 lazy_refcounts=3Doff refcou= nt_bits=3D16 =20 -Formatting 'TEST_DIR/PID-mid', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D1048576 backing_file=3DTEST_DIR/PID-= base backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 -Formatting 'TEST_DIR/PID-top', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D2097152 backing_file=3DTEST_DIR/PID-= mid backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 wrote 2097152/2097152 bytes at offset 0 2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) @@ -66,11 +63,8 @@ read 1048576/1048576 bytes at offset 1048576 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) =20 =3D=3D=3D Testing HMP commit (top -> mid) =3D=3D=3D -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D2097152 lazy_refcounts=3Doff refcou= nt_bits=3D16 =20 -Formatting 'TEST_DIR/PID-mid', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D1048576 backing_file=3DTEST_DIR/PID-= base backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 -Formatting 'TEST_DIR/PID-top', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D2097152 backing_file=3DTEST_DIR/PID-= mid backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 wrote 2097152/2097152 bytes at offset 0 2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) @@ -98,11 +92,8 @@ read 1048576/1048576 bytes at offset 1048576 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) =20 =3D=3D=3D Testing QMP active commit (top -> mid) =3D=3D=3D -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D2097152 lazy_refcounts=3Doff refcou= nt_bits=3D16 =20 -Formatting 'TEST_DIR/PID-mid', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D1048576 backing_file=3DTEST_DIR/PID-= base backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 -Formatting 'TEST_DIR/PID-top', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D2097152 backing_file=3DTEST_DIR/PID-= mid backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 wrote 2097152/2097152 bytes at offset 0 2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) @@ -136,11 +127,8 @@ read 1048576/1048576 bytes at offset 1048576 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) =20 =3D=3D=3D Testing qemu-img commit (top -> base) =3D=3D=3D -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D2097152 lazy_refcounts=3Doff refcou= nt_bits=3D16 =20 -Formatting 'TEST_DIR/PID-mid', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D1048576 backing_file=3DTEST_DIR/PID-= base backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 -Formatting 'TEST_DIR/PID-top', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D2097152 backing_file=3DTEST_DIR/PID-= mid backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 wrote 2097152/2097152 bytes at offset 0 2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) @@ -166,11 +154,8 @@ read 1048576/1048576 bytes at offset 1048576 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) =20 =3D=3D=3D Testing QMP active commit (top -> base) =3D=3D=3D -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D2097152 lazy_refcounts=3Doff refcou= nt_bits=3D16 =20 -Formatting 'TEST_DIR/PID-mid', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D1048576 backing_file=3DTEST_DIR/PID-= base backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 -Formatting 'TEST_DIR/PID-top', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D2097152 backing_file=3DTEST_DIR/PID-= mid backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 wrote 2097152/2097152 bytes at offset 0 2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) @@ -205,9 +190,7 @@ read 1048576/1048576 bytes at offset 1048576 =20 =3D=3D Resize tests =3D=3D =3D=3D=3D preallocation=3Doff =3D=3D=3D -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D6442450944 lazy_refcounts=3Doff ref= count_bits=3D16 =20 -Formatting 'TEST_DIR/PID-top', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D1073741824 backing_file=3DTEST_DIR/P= ID-base backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 wrote 65536/65536 bytes at offset 5368709120 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) @@ -224,9 +207,7 @@ read 65536/65536 bytes at offset 5368709120 { "start": 1073741824, "length": 7516192768, "depth": 0, "present": true, = "zero": true, "data": false}] =20 =3D=3D=3D preallocation=3Dmetadata =3D=3D=3D -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D34359738368 lazy_refcounts=3Doff re= fcount_bits=3D16 =20 -Formatting 'TEST_DIR/PID-top', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D32212254720 backing_file=3DTEST_DIR/= PID-base backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 wrote 65536/65536 bytes at offset 33285996544 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) @@ -248,9 +229,7 @@ read 65536/65536 bytes at offset 33285996544 { "start": 34896609280, "length": 536870912, "depth": 0, "present": true, = "zero": true, "data": false, "offset": 2685075456}] =20 =3D=3D=3D preallocation=3Dfalloc =3D=3D=3D -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D10485760 lazy_refcounts=3Doff refco= unt_bits=3D16 =20 -Formatting 'TEST_DIR/PID-top', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D5242880 backing_file=3DTEST_DIR/PID-= base backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 wrote 65536/65536 bytes at offset 9437184 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) @@ -267,9 +246,7 @@ read 65536/65536 bytes at offset 9437184 { "start": 5242880, "length": 10485760, "depth": 0, "present": true, "zero= ": false, "data": true, "offset": 327680}] =20 =3D=3D=3D preallocation=3Dfull =3D=3D=3D -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D16777216 lazy_refcounts=3Doff refco= unt_bits=3D16 =20 -Formatting 'TEST_DIR/PID-top', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D8388608 backing_file=3DTEST_DIR/PID-= base backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 wrote 65536/65536 bytes at offset 11534336 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) @@ -286,9 +263,7 @@ read 65536/65536 bytes at offset 11534336 { "start": 8388608, "length": 4194304, "depth": 0, "present": true, "zero"= : false, "data": true, "offset": 327680}] =20 =3D=3D=3D preallocation=3Doff =3D=3D=3D -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D393216 lazy_refcounts=3Doff refcoun= t_bits=3D16 =20 -Formatting 'TEST_DIR/PID-top', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D259072 backing_file=3DTEST_DIR/PID-b= ase backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 wrote 65536/65536 bytes at offset 259072 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) @@ -306,9 +281,7 @@ read 65536/65536 bytes at offset 259072 { "start": 262144, "length": 262144, "depth": 0, "present": true, "zero": = true, "data": false}] =20 =3D=3D=3D preallocation=3Doff =3D=3D=3D -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D409600 lazy_refcounts=3Doff refcoun= t_bits=3D16 =20 -Formatting 'TEST_DIR/PID-top', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D262144 backing_file=3DTEST_DIR/PID-b= ase backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 wrote 65536/65536 bytes at offset 344064 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) @@ -325,9 +298,7 @@ read 65536/65536 bytes at offset 344064 { "start": 262144, "length": 262144, "depth": 0, "present": true, "zero": = true, "data": false}] =20 =3D=3D=3D preallocation=3Doff =3D=3D=3D -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D524288 lazy_refcounts=3Doff refcoun= t_bits=3D16 =20 -Formatting 'TEST_DIR/PID-top', fmt=3Dqcow2 cluster_size=3D65536 extended_l= 2=3Doff compression_type=3Dzlib size=3D262144 backing_file=3DTEST_DIR/PID-b= ase backing_fmt=3Dqcow2 lazy_refcounts=3Doff refcount_bits=3D16 =20 wrote 65536/65536 bytes at offset 446464 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) diff --git a/tests/qemu-iotests/280.out b/tests/qemu-iotests/280.out index 09a0f1a7cb..e39164c579 100644 --- a/tests/qemu-iotests/280.out +++ b/tests/qemu-iotests/280.out @@ -1,4 +1,3 @@ -Formatting 'TEST_DIR/PID-base', fmt=3Dqcow2 cluster_size=3D65536 extended_= l2=3Doff compression_type=3Dzlib size=3D67108864 lazy_refcounts=3Doff refco= unt_bits=3D16 =20 =3D=3D=3D Launch VM =3D=3D=3D Enabling migration QMP events on VM... diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 484f616270..857676a329 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -108,7 +108,9 @@ def unarchive_sample_image(sample, fname): =20 =20 def qemu_tool_pipe_and_status(tool: str, args: Sequence[str], - connect_stderr: bool =3D True) -> Tuple[str,= int]: + connect_stderr: bool =3D True, + drop_successful_output: bool =3D False) \ + -> Tuple[str, int]: """ Run a tool and return both its output and its exit code """ @@ -120,6 +122,8 @@ def qemu_tool_pipe_and_status(tool: str, args: Sequence= [str], cmd =3D ' '.join(args) sys.stderr.write(f'{tool} received signal \ {-subp.returncode}: {cmd}\n') + if drop_successful_output and subp.returncode =3D=3D 0: + output =3D '' return (output, subp.returncode) =20 def qemu_img_create_prepare_args(args: List[str]) -> List[str]: @@ -164,8 +168,10 @@ def qemu_img_pipe_and_status(*args: str) -> Tuple[str,= int]: """ Run qemu-img and return both its output and its exit code """ + is_create =3D bool(args and args[0] =3D=3D 'create') full_args =3D qemu_img_args + qemu_img_create_prepare_args(list(args)) - return qemu_tool_pipe_and_status('qemu-img', full_args) + return qemu_tool_pipe_and_status('qemu-img', full_args, + drop_successful_output=3Dis_create) =20 def qemu_img(*args: str) -> int: '''Run qemu-img and return the exit code''' --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626781921; cv=pass; d=zohomail.com; s=zohoarc; b=QK28UTeAHSbdCiOxxVb8jFrbR5mQ/EGmCNvIcccfZlXJuxGvl3/zLB4Xwm17RnRImcB8m8yZRL2huMyZTQam3B6qnF1LWKW96JYP61aLWWBTn+vBUOQKTNGmOrblZChgQaWkIz6fdxaVUKVHq5gL7J+ijv3skBZCzo4RSpr96Gg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626781921; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=w7QIanrwSMC8OFA2eDOu3OJyKo4DCPluFencZ3dlj9Q=; b=VZWS6DOtW06xMt8a3shTyx0wRQB9G5uAkgJ4NgOsymI+s8LbZJo48VeH9bgcDUpvXBdFOp4PDySx7nEhhg6nfa/KA7UqoRA338eEOGsegKIKsPn2Qirm0DUGcf+LNFbNjG9BSre4JUvRK3lDTRJ3J9T1pLh6M4heyOjXENyUVLo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 162678192103771.66145481963463; Tue, 20 Jul 2021 04:52:01 -0700 (PDT) Received: from localhost ([::1]:43940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oI3-00088o-QQ for importer@patchew.org; Tue, 20 Jul 2021 07:51:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5s-0003K7-Il; Tue, 20 Jul 2021 07:39:24 -0400 Received: from mail-db8eur05on2091.outbound.protection.outlook.com ([40.107.20.91]:40417 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5n-0007CC-U3; Tue, 20 Jul 2021 07:39:24 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:39:02 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:39:02 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:39:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hwmNLVV8Zb+CGFZXeN2ZPYs2TPe0rHlmBoIGmB9WKDbfYYabiVp7KQzkP78nNNOXEc185rKjnTFSXZ6U2Stl31on1wJS/0M8TfQyqrfvbQZKW7qmb5IHoGOLDGdcszMFII0bJ9+mPueNWjzA+3z6f8yr2bDEb4f23AVEYTjLiQzOKixl4SYZMhx68sXurRT/bcNp+KCph2UF5ls8q3FumLyPA9qc2zEDTgkWsxUNIZJXMH5I7WpuxHqiWadu29IpomDEEigpS2HE03fzez7GNogGxq7OQ9svNliF9DSbVbr+95CurOyVoEW9tgHerFQnPltzvIr1XBcOWY1NqVYqYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w7QIanrwSMC8OFA2eDOu3OJyKo4DCPluFencZ3dlj9Q=; b=RLtSEZi7P/kNFjw1hpA/GIfXz1iKalScmZyV1Pz39DZARyVh6yiMBOnzke/oB1RDONEq0VX/wbRf1+xrHlnpx65oNl/91F4nuiA/mSOizSJo9pLu79AiaorSXrQtKWrLafv4pieo9vkq9IUdegCQD9pUBHThdEm3NfJNy2C26Ws8g52TFrmzvJ4tVpimdVRJEeDrPhsOSZ+WnOTzbb7Ttv+ENzJTbr1N5T3kuvnX+OUyYkbKYmZO4WFt1th85rQO/qozUqJ/FFU2Lo0D58WTL7qZ6ttWY/f+HpnMwomfeb6o6fjTT8PgLOnNtLrQC98VqUyn3Yfml9h8h4+zALg8ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w7QIanrwSMC8OFA2eDOu3OJyKo4DCPluFencZ3dlj9Q=; b=ZoZSZWHAF+zi0GZhVoGz73iCsRudtl1Jz9zqFnAeLMW2dqdGJ0SpZNh4GW40qOAiyJKWfKji++Ij2bOYq8kwn0QtDMTCLELPaiDdeeUBaE4cBsK9ll4Po6AR6exGbiC5IaYMsOXGFPozAv9gopCc5/3N1hcrrRWnQhIX/Wk2dTg= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 08/17] iotests.py: filter compression type out Date: Tue, 20 Jul 2021 14:38:23 +0300 Message-Id: <20210720113832.586428-9-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 79a76094-7252-45ae-fc2f-08d94b72f854 X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v8NH+XHOZt59z7JNRNoqGJL9Wxd5L79R8d58MGb4niF3Tau8pwD2D+bfD7tcjNxCCBniJLSfVk3mim4oywyioU1DAMRN2thnprhGbS3WskqZuH18G2uTIX3bdS2l5IwiEUcgmth1dHzzDW5ufQAq79XfwMBAnlYZUZYjRkyAAYeuEotCYLT85JoC2YaM6tRlVp8b5QGRlkfPWskK4FM3KE4xj60c5X5VdMXslBhZ/RobyCzOLDwJJ3QDOC8eWKyOiVNfHrELBYURIlYfdeNgnzJIFB/sB26WJHfaGGgqeggJkWL257p+i6ZKd0rjGHo2MPS/0UJqw8E6ruoKGVZw7v95VyTtbQ2g4uGuLoBuOP+lO0qc62Qv0QJtdh8HVSYsDqbqD4fA1Byi4LqPXdWD7IdWlZTm55IVpA39P8h5O+LkVAGkHcC7Lsdj3Kl/qirTiawP2OUsyo0KB/gT2hjQJLftO5Ls/7VQXfc7EwUAi0iF6Lso/DY3ApKH1P9XUkFWxE2KODDZG0k06yzbZ3gLvGoucpKPvsIbAyCbdSNCiT0cGbAFaRgBVZcr42cSKY7iVuXgsaxEA+A7dcM2t+CNIXp8FVJMeIdwkTeg8Kv+M1CwaU3x3xHJEjnQmRXF/NHW0yXvDbhnX83TEyf1MGSOuFelskaZMzjh6QvQbeqdnaCBZU1f//A2P4Ifb3dp9LmRCSISPPiW8iPHVRfRRuSLAw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?K1Q5I5VDgoigD+t3xRIoeEBP2J6s/tUt4vZv9JIsiDkp/pEjepdaVbD9ZVY8?= =?us-ascii?Q?H+i3tIPmQvp5nU9MeBf1vK+4PSOmgzigpjhSIt3kfgtmROqMKpaP2Bwz49Us?= =?us-ascii?Q?BSt9mbih1A8kBvfcja0Ro90FkkA23He9O8FAKjZyfwOU6UmOhLN0fRiggJwd?= =?us-ascii?Q?/umGRCJZtnLyytoSR9f5CqDtr+WQz6HVLIJ3Izoeym3L3iWDU+bffukAAdg1?= =?us-ascii?Q?nKUqc3mEW4nn//ak+FEsBB8XIRLo+kYIwrFwI4ZkWbt5wpu126tBnfYI37DR?= =?us-ascii?Q?xPZJdajoeSTHG+2NDu+OfwkjldGuSqt20CjgJDmpEzSBMFL9pIflrnu6UgAU?= =?us-ascii?Q?dURakWmFZXGQZuQ9C9lsGa2l1hKZ3xVDEbnzesSFu+Iua24QIFA6M6Eghsct?= =?us-ascii?Q?PxfdU6uFdoWaxeyyNoBkg/D8xvw94JyaF+DL7qafXN5Wm6lO2tmA8WH4g3xW?= =?us-ascii?Q?Or4KAa4Sn8wyn1hxhE0PZgiB1vQTk+G7Cljpx5+iacnb+xarJYWdlPXRv53G?= =?us-ascii?Q?w/dUtQ+iAR3iHGzlJ6oajpkEXAJRaudYMj5Z7ybeUiftrcIorWtaGXAqWFa9?= =?us-ascii?Q?2cutaebTBrMtfsd3Ql2/CvmkrG7FVkPnHeDVXqfCmSmhkhaHBwSTP2KZAVu1?= =?us-ascii?Q?bzcQ9o27yuluUO4sjDT6VhyAUID8o/7Dwlbm8hiJcYLBdtiZG50BjLiQc8Uw?= =?us-ascii?Q?NyV9m/vw58ZWLVekEr+NMX4eidPyvpbQwFaL7WbetyXxJuXOOTsxBnCefqe6?= =?us-ascii?Q?5uvlD2ju9Hh6RskYIeo1mBKf5jJKtTn2LVLXe+Zvse/vDshzqOGyeL0BBKBe?= =?us-ascii?Q?m/WIP+JKrTiRHcaVOwajpMfriW1XoPmT0Mw6DOADogSXG8vtB/dV7vwiSZtp?= =?us-ascii?Q?RS8LpAYFS6sbBo/OBdoW71uf7kt16lcwjXnERkVBNlaGH4uIpMYJ2/5Gm0sr?= =?us-ascii?Q?/yfC/yl9811pmYWtZPmlK9ZNJoHC6DG66vBjXIJw5BoXld6+raRHCCdJg0eW?= =?us-ascii?Q?enri/mbhVIKWR7dFe5/goPrKzNNuItAxV8EzBl1/Ao63JxRT2wBzeABRiiQh?= =?us-ascii?Q?9bKOSTNwDTCYhViNjYyvK2uenlcyRfm7UhQb8Q8u4r+4LyMSES7SDmvni76y?= =?us-ascii?Q?+1N+LQMFRuMDPZF4TjvuB/5wFZEGy9NkJubYe+D36b5E4A6GlWDWJx4U1UFK?= =?us-ascii?Q?QuNLc5jrPxBqt28rYT+BFk50KmT0+qycBFoIS21lUeYInI1arKGWr9egXrAj?= =?us-ascii?Q?+L2G62jW+VEyzf3qXdUZVkSs4TJMppWfVIwEsHyW5uXMGRKx3ZPbuTXJ3Fmq?= =?us-ascii?Q?spwhv0gxFNph1GN/5Aq1F9a0?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79a76094-7252-45ae-fc2f-08d94b72f854 X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:39:02.0174 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9wBv4DZwNvF7Cjo0zX1vbt3TUTnOIiJti8Dwz09QA8SBBvsOUNAbWmJ7hRDis7fCTnoptF0ID5QP9XhAOQWegvA0PF70xf5zblNeEmVJd68= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.91; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626781922160100001 Content-Type: text/plain; charset="utf-8" We want iotests pass with both the default zlib compression and with IMGOPTS=3D'compression_type=3Dzstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type) and it's in bash. So for now we can safely filter out compression type in all qcow2 tests. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/qemu-iotests/206.out | 10 +++++----- tests/qemu-iotests/242.out | 10 +++++----- tests/qemu-iotests/274.out | 10 +++++----- tests/qemu-iotests/iotests.py | 2 ++ 4 files changed, 17 insertions(+), 15 deletions(-) diff --git a/tests/qemu-iotests/206.out b/tests/qemu-iotests/206.out index b68c443867..253209eca9 100644 --- a/tests/qemu-iotests/206.out +++ b/tests/qemu-iotests/206.out @@ -18,7 +18,7 @@ virtual size: 128 MiB (134217728 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 corrupt: false @@ -42,7 +42,7 @@ virtual size: 64 MiB (67108864 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 corrupt: false @@ -66,7 +66,7 @@ virtual size: 32 MiB (33554432 bytes) cluster_size: 2097152 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: true refcount bits: 1 corrupt: false @@ -92,7 +92,7 @@ backing file: TEST_IMG.base backing file format: IMGFMT Format specific information: compat: 0.10 - compression type: zlib + compression type: COMPRESSION_TYPE refcount bits: 16 =20 =3D=3D=3D Successful image creation (encrypted) =3D=3D=3D @@ -109,7 +109,7 @@ encrypted: yes cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 encrypt: diff --git a/tests/qemu-iotests/242.out b/tests/qemu-iotests/242.out index 3759c99284..ce231424a7 100644 --- a/tests/qemu-iotests/242.out +++ b/tests/qemu-iotests/242.out @@ -12,7 +12,7 @@ virtual size: 1 MiB (1048576 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 corrupt: false @@ -34,7 +34,7 @@ virtual size: 1 MiB (1048576 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false bitmaps: [0]: @@ -68,7 +68,7 @@ virtual size: 1 MiB (1048576 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false bitmaps: [0]: @@ -110,7 +110,7 @@ virtual size: 1 MiB (1048576 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false bitmaps: [0]: @@ -161,7 +161,7 @@ virtual size: 1 MiB (1048576 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false bitmaps: [0]: diff --git a/tests/qemu-iotests/274.out b/tests/qemu-iotests/274.out index 1d2928e14d..1ce40d839a 100644 --- a/tests/qemu-iotests/274.out +++ b/tests/qemu-iotests/274.out @@ -50,7 +50,7 @@ backing file: TEST_DIR/PID-base backing file format: IMGFMT Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 corrupt: false @@ -79,7 +79,7 @@ backing file: TEST_DIR/PID-base backing file format: IMGFMT Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 corrupt: false @@ -114,7 +114,7 @@ backing file: TEST_DIR/PID-base backing file format: IMGFMT Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 corrupt: false @@ -141,7 +141,7 @@ virtual size: 2 MiB (2097152 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 corrupt: false @@ -176,7 +176,7 @@ backing file: TEST_DIR/PID-base backing file format: IMGFMT Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 corrupt: false diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 857676a329..43c1e723a6 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -454,6 +454,8 @@ def filter_img_info(output, filename): 'uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX', line) line =3D re.sub('cid: [0-9]+', 'cid: XXXXXXXXXX', line) + line =3D re.sub('(compression type: )(zlib|zstd)', r'\1COMPRESSION= _TYPE', + line) lines.append(line) return '\n'.join(lines) =20 --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626782030; cv=pass; d=zohomail.com; s=zohoarc; b=kGPv8BDlDBTtRB3omeZLXHQOeNLQrukCm3gWi8DE9nSI+N88/5i7+717VWYKF2HXZDB0k9E1hl9qcyeasqLJu3qIiD8tuqpYlMpNFNta138VwRWAQrGCgGtoCRo/i6mH/z9LXSKZK+MLKZGSUTIzgI1uVx8vMHxamWLlHmurq5Q= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626782030; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jG2ggPQVmfAAMk4zmRJKA5ti4bwdu8H5a2BGZYFPCiQ=; b=Hw97AOTsI+JV8fh0l/8YmCIXaXejV65rEYk6wppgtIsO3YRFIUDOK8RnUEQXQx8OhWAjbn1WoAaDACZa5UPd7MpCntCD6qnUJVHM1z4H84nC2421uzerwsUwIhkRsDWUlM7NvFYh0lC5yH28yajzK1XehsWiuS+GrCw0tnySUgU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626782030390715.6636780612264; Tue, 20 Jul 2021 04:53:50 -0700 (PDT) Received: from localhost ([::1]:51714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oJp-0004qu-5n for importer@patchew.org; Tue, 20 Jul 2021 07:53:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5y-0003PW-K0; Tue, 20 Jul 2021 07:39:30 -0400 Received: from mail-db8eur05on2136.outbound.protection.outlook.com ([40.107.20.136]:65205 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5s-00077C-Lw; Tue, 20 Jul 2021 07:39:27 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:39:03 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:39:03 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:39:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I5BJ7zdt1bB0GyvvTmlXmSlUbrWr3D6bPnlteLkqk8/DZ6u5I108EsU9jhfqN8e4r6ew3mtvvsCmMVD2JPH0s3cLUeEIqw+vw347M488vgLl/nFQYA0jXBggCKyaHr0Km6JHKpx/LwM94ttlnmT9epOuJ3lJjXxcAhMDJSRUNKeTdJwneJmBqwej0wR7Sa1T5y7bFPeM7a/x6vsQ8+8buJ0dxJSlecdx3UQedoRrhfPuUt93ZnPQHjaQaM/9t5sTyMUD2pk4yDoB37CpiTh2ByeMa7EUVHRZJ8/b6KeU9dkk7h2nFswppOB3yq2Wj1/UNaJK8DRKgyju84LTG9UOeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jG2ggPQVmfAAMk4zmRJKA5ti4bwdu8H5a2BGZYFPCiQ=; b=OjHAS4OT1BZZiECerML/x915ufWodk6YxeKn8i6VTZJZgpD63uLW9khHKt1d2pFFzcG787HWpfzx0JMDPtk4gj6MRYiYgHn0U9vGRsZ3wbruw86hyvkDnJXLgs0Qh9/K5Ffcunsd+hW2MFpkKFU9McWEUJUHL7zQ2NlJ/hiPh+jkps7blde6TEKsOUHlFqOvFh4p3AxN0gpDIU+CrImaJH087FusIg+fKOqec7JwQw9b7YgV6jnCbFICBtwWhZM7FEmXmmwGcmOzT0ZEVKfX1wiSGbksnWr66fMqG2SYvTcFlKtxFVo8DAwCwwGckQdWU116wUV7LNUhjQ7oZtNeZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jG2ggPQVmfAAMk4zmRJKA5ti4bwdu8H5a2BGZYFPCiQ=; b=lei8MCRbUZxb81o0e+lmQkxb3KvReJ3DevSm4MfnMDOt8VkM6iENhq9GZPOhiSZRbKlDzhIXvPAEXydqj5517u+Hx7bhKBZiiJUP7zQgk0PjcF8eKQgWqINKjiCJ2MUShopHYXaaq2ax4wclqKKL9sTJdc8JtMJScEJazVp4L6M= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 09/17] iotest 302: use img_info_log() helper Date: Tue, 20 Jul 2021 14:38:24 +0300 Message-Id: <20210720113832.586428-10-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6347ba96-e2a5-4cd0-8f75-08d94b72f97b X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6xKFak7xAtE4yaIh4iergDELkQLuuuAD9FL489rc/XPAHS0leXBV9ycYKSivY1ELrkEWLeCouDIX1/Zs/XFYhUUEdx4NnP113TDHehCjZt2DNH3t11/LgSlmkQjAh05CbONaH9LJnO8m+dHQMscBRD3Gs/tzbFW3l+0EMbp5lGxlI0vXmxEutVYByEk9vO/fncecoickSFqORButqzhEwBlMmjuRyzQhdrD1oqxvfpd42vdyPRzkahFy8jiOYx9Ib+PuQulMjllW5gaA5sHcgq4eq0zWt5wDvrWFAZp7jsK/Qgee0GK3itP5lmoM+wG7dw1F4HsaxbalobvVoAITmJEv5OOQ8avOJUzEx/JIzjC59koEMrp7FUDLBlaxLoVOThWSs1YkayJqXa0lnDhcZpAXeiXaM/ANaSD89VoUQXAsqlEj+wQLhk8XqyWTEo/5GK3czJUu1TzUMMFYXp+uMhpqi5S0DMkrpA2XLZgPtdlAaorv4GYC+f/HsXTe9eSDA4iiPuDJKKPcPBxieADvWBq2Uoq6jxnBiSBv1OJvZeD+Kngd0YVpDW0plhP7OOZ5fdIuSZw+UWCJ7cEl9REinbJr9IRZpTkbBf99lt3U/q92ui7T9tx3lRelD1d7akjh3FrrD6+NELXl/9kGZx1RKkNLXt6y4eRzfaxPOe8IgNQO5+pG3g64eyGAMAsd2EHiF4TkFJ0P+Br0gsh8hQkV0w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Orey2h7gUfjLTq08GNJFMXEfRfnr86XXCsBJMICNNCBKBL1mckNvoqaPoEuL?= =?us-ascii?Q?1FaoU0gJTCi5rcoZncGbGyW7/NPxsFg/1waYplw7H8L2VKDkwY482qK3w6Jt?= =?us-ascii?Q?ZrhwvS79tDsiQHDm/8ipSvn9D6VrnFmDCT12m2A/wqoyIGszNgxoOspRjT/S?= =?us-ascii?Q?v1GmVEH5ew3WJgUL/ik9LTVZ63U3h+L8i5iER9HBwETE72AwlVfWHEKCTjmM?= =?us-ascii?Q?PcRFuejKRvPKIC3e9bywIXfhDZm/3Ie08hdELjTQIoKKJ00C3wD1P070YCQc?= =?us-ascii?Q?8AMT7MxwpXOVrV+dvsgfWDa0hE5BblInVEIljuwe9JnNCKyqALugqT0wUAij?= =?us-ascii?Q?kN6Q+aFPGiMVO8dj4v24dAXEWLUWRn3dBnZxECoaI19xO1veUTaT3J1EIslm?= =?us-ascii?Q?W+RCaYj/jn+93bIXUUxsDFuFahKsa4bGKP34fM0HIqIQxakgYzPogMuxAk0v?= =?us-ascii?Q?4jR0ZAYf/PIKMk6MqsS3aTRy0DD7hYi/ITm7CgK2yZVJlpcgmf6P78TGp2pP?= =?us-ascii?Q?wCr792tf/6KKkcrmJLW8LtFmfGcNri1YzKKAM7cUO3yD6YFprZiGhL9VAfny?= =?us-ascii?Q?mm7jjEh0u9GPS6su/y3ev5TZxdeRv69iAXzf/K3x8t1WFrqiVMAukrSRfiEs?= =?us-ascii?Q?yU6jHvnfVAk6Pl7bIZ58rZvTg9iNFRgcHu1iESwTkVK2zVrX3UCnm5PIhbAr?= =?us-ascii?Q?SVhrZs1tjuyFFUB+m3QfhX0C1TWtVAT0iW1pRlEG5r+y99PEt0Q6rHm9tRne?= =?us-ascii?Q?73A1qqwSngz5bm8rqbOT7EchKlP+zCKBnqZqTTYH1KF6WbuqlAdJ5qtmnVGN?= =?us-ascii?Q?iN+iwn8WGgBI5IVN6rY5r3mD2ckstqmW3vpwXwMcK4GFlNa7jvti76Chm7Hl?= =?us-ascii?Q?SEOZkVDZLb66iVSlwZDtBlr/Zm6m0pEuDXA2kywxB3fH+w1RUh/susP5Z9Jx?= =?us-ascii?Q?9C0I/xBHMV4zp2dP2rifngXQ2Ohi2JizUyDMRzgjG1wljnNWMcvlR6iOv8RD?= =?us-ascii?Q?QJO5M9khBHeDuLtr8hm4srteMQnhBeDhpteC+vytcoRxgx92hOJqH+T4Ow+P?= =?us-ascii?Q?i0e5vFj78JdgPfEUdnrxR8YKfiYOQBxRhLYOnCXyWJ8luWKNVEVPGatpgLu+?= =?us-ascii?Q?dtMcGnHt2EExYtcypf6xRvIrQak2DNUPlpBbtgweHOKrZeMvHlw4erkqsAjZ?= =?us-ascii?Q?2/4mXxP7/zpKgAjNK/lPf8V6WNmBhdVUYY1RchD7QkgufK5in2F4srRJRPoF?= =?us-ascii?Q?Pr4SI1AqyjmgiIYoNAnT/tFD29ZCzcHfulOQHjExxEdd7oB7MF0n07f8sStS?= =?us-ascii?Q?m2OVOFelO6OoW9c3kZcIqERg?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6347ba96-e2a5-4cd0-8f75-08d94b72f97b X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:39:03.5566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uZhQnXOlBJ8Xd13xM1Y6JxDFhNwWUmusIS9YkANW4fupEZ4lIhVhFW18A+eehqOWVzcT3bWvEh5QdKgKuh7br34M6CQC0tFAU0+8zelDiVw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.136; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626782031488100001 Content-Type: text/plain; charset="utf-8" Instead of qemu_img_log("info", ..) use generic helper img_info_log(). img_info_log() has smarter logic. For example it use filter_img_info() to filter output, which in turns filter a compression type. So it will help us in future when we implement a possibility to use zstd compression by default (with help of some runtime config file or maybe build option). For now to test you should recompile qemu with a small addition into block/qcow2.c before "if (qcow2_opts->has_compression_type": if (!qcow2_opts->has_compression_type && version >=3D 3) { qcow2_opts->has_compression_type =3D true; qcow2_opts->compression_type =3D QCOW2_COMPRESSION_TYPE_ZSTD; } Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/302 | 4 +++- tests/qemu-iotests/302.out | 7 +++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/302 b/tests/qemu-iotests/302 index 5695af4914..a6d79e727b 100755 --- a/tests/qemu-iotests/302 +++ b/tests/qemu-iotests/302 @@ -34,6 +34,7 @@ from iotests import ( qemu_img_measure, qemu_io, qemu_nbd_popen, + img_info_log, ) =20 iotests.script_initialize(supported_fmts=3D["qcow2"]) @@ -88,6 +89,7 @@ with tarfile.open(tar_file, "w") as tar: tar_file): =20 iotests.log("=3D=3D=3D Target image info =3D=3D=3D") + # Not img_info_log as it enforces imgfmt, but now we print info on= raw qemu_img_log("info", nbd_uri) =20 qemu_img( @@ -99,7 +101,7 @@ with tarfile.open(tar_file, "w") as tar: nbd_uri) =20 iotests.log("=3D=3D=3D Converted image info =3D=3D=3D") - qemu_img_log("info", nbd_uri) + img_info_log(nbd_uri) =20 iotests.log("=3D=3D=3D Converted image check =3D=3D=3D") qemu_img_log("check", nbd_uri) diff --git a/tests/qemu-iotests/302.out b/tests/qemu-iotests/302.out index e2f6077e83..3e7c281b91 100644 --- a/tests/qemu-iotests/302.out +++ b/tests/qemu-iotests/302.out @@ -6,14 +6,13 @@ virtual size: 448 KiB (458752 bytes) disk size: unavailable =20 =3D=3D=3D Converted image info =3D=3D=3D -image: nbd+unix:///exp?socket=3DSOCK_DIR/PID-nbd-sock -file format: qcow2 +image: TEST_IMG +file format: IMGFMT virtual size: 1 GiB (1073741824 bytes) -disk size: unavailable cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 corrupt: false --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626781398; cv=pass; d=zohomail.com; s=zohoarc; b=aTA0vwkJVbdnKqxLXP4nTPsvWaoXaak0wKHscqKiJ6h6kQ3cUxVpuluWQqKRqfI6QIhdbgy3w0HANgBK4ctld28bIS4VgsSUENCOSiBElWRc/IsClC8znYYLCzxyZno5KuvCwAIKEHInUwXQoad6zV4gHUnLwvBICeD+jJ9sG8o= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626781398; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Jli+GD9A24jlE3s8WTSFyIu7FrhAimoplmvans/jOLQ=; b=J28kZukxgmxa7zGvyibjuSDeTF4Jv+RCc222CMPvRGmG8k/GXK8eLvDd/B3R18hKTwgMiu0znNAea+l+jJ1rXxrTDCqNqbyxEZWwAHekSjfWhqk2IJhQxPFAOzkAcXQAlHKEuMrD4NsPJkLI+ue0yIsipK38edb5GSU+0OumzZ0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626781398748928.2684313648314; Tue, 20 Jul 2021 04:43:18 -0700 (PDT) Received: from localhost ([::1]:47302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5o9d-0007zN-LC for importer@patchew.org; Tue, 20 Jul 2021 07:43:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5y-0003Pl-NL; Tue, 20 Jul 2021 07:39:34 -0400 Received: from mail-db8eur05on2091.outbound.protection.outlook.com ([40.107.20.91]:40417 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5u-0007CC-SY; Tue, 20 Jul 2021 07:39:30 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:39:05 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:39:05 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:39:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a5ST6/4IdNNJs+Jy+fVxY++ePcDyeKbQ9LFchEXd8VNjrL4f/g9niBGQv7ywKKNZBTQZyYRFNgm0MUm1+knk1ClP6MSGbWAdVUbBO4RrOIXStK2HpwZij4uSFI/Rivcaj+GzWSTBIo5rNFkuPSrnT789G1KPuVjSw99/TuaBalv36pd1WoxFtIlY7+hCtxAx+zmTY9uElDvg+aTD3GMLcp39ehQbtMI6Xk6QS8UVferzfDhrg6vNdRmZitdQ6Akue9ppcycA88y2jSMnS4N4LQbLBkg1NLtw+grWSiiYKSjDTQVo/FpkOKrxgb4K/Hcv0Z5Wzy8xgcEa2PmP1LJ/LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jli+GD9A24jlE3s8WTSFyIu7FrhAimoplmvans/jOLQ=; b=gEUh/16H2FMLDYqKzkjzFFj7gijN8OqlVNIjQ+s5nQz/sWR5Jpqjf9d7fqd9yZQLDT7+4c00E2Po2an7FXINMegc1TvvL6Gg24EsUNEjZ0zCtSIFOFO9XxAlKLF+V+rgYARAXLUSm67eN2qABslLYoj32Whf4kAwaoY9SMCTzFEjc7od5EvbonStgJevVIvnzuCnCv4YNri1MlLeB3/rptz5rzzZ2AHuxKbYMo/Hw6GRH+i5LUrM8VoVeFsh/VnVLph19x+6FdcuZvbCW/iOy5HCnhBOq7x0c8BkHJyxwZpi3pIpbRqhPRE9NhlGUK2HnMGniLwFeETGDdXh8fIWIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jli+GD9A24jlE3s8WTSFyIu7FrhAimoplmvans/jOLQ=; b=F3gjByq/RQJ2ndtTNWEUKfvEWCKImqOKdqCzDA6x1XB2daN7d3XPHYWmuHGRXox/La8KnwEVXzUbAfAZWqiVAJZe8Ir9aLrQxI780DjtORIXnTPx8CudfGkpDHSmkXL3slCIXwd7NP7jhQxaLsSLGV1pjwMYtHiTR5ofN4upWCM= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 10/17] qcow2: simple case support for downgrading of qcow2 images with zstd Date: Tue, 20 Jul 2021 14:38:25 +0300 Message-Id: <20210720113832.586428-11-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 785e8422-949d-41c9-d234-08d94b72fa59 X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1247; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h5xj37AYO9jx0ofRxZhGPuesgVOCdfWhml2A4XqDWD4VwSxKwvgKW4G6665vtSjmMxH+N6nxXaduNqjhzoEJk38j9seq/0TlsQyMYjqrCLJpUb957JB9u4f4EKlPOnH9BrTRmiaN9nqNu1wTDDG3eBLG1Dlh+06npHInwN9UQpvy2qCIQnVV6L0yazxPzbxB+TBzMRd2/BJLZRzv5TpZW8MaFAH+yi5OGTsfdWBxid1Yz1iRoZonrI85KuNNuOi5SlqSgqJ6O4qH2UfDGV+8maTldswxVrTL1HJ6Oi+RUg++WxM+iwxbtAMUHSsangfoSKMvAplXX1BYS3XabEUJ5RK9XN3JG1Xbol/Js24x3M8FnJvS59qcOk3QvfT20vWQZcUk3E9qViLC9+5lX6V4KwClCu1gYg5ZWth9OQH+ADdbY2q3Gp+Y4MMQyhJdkLP9rp3bwQgNHgFmY2y0sdcPzoqt1XXDruNgQH40zV/1yk2gd1irTZluDAS82yvAhxmScT2qzsgJQ/0995TGoOH7ZEGBXjsAp2BZQfBoOCQbk4ks5S0yYxIhBmws1eZo758ILGUFSwiOr3ZuFbN4dvd+5DjAUKgTgUSTPq4UeWBEl9xlL2agqEUFY8jnTd7Zw+wl/gD0GLuaqtkj+VkMm9ZANbMf+Oel47+ehIxWYEmG3F/4lJOO0/CbT6lDRurWEg/AuMNk3bsyM35MPm+0o5vmVA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(19627235002)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xDP4ExlTx9G/rqUeowhD1gSqdP4sPHLzHEZuLyeaJ6LM4JPtlAK4aSJH1vjK?= =?us-ascii?Q?z05+XyeN84XL0rrclxYBWaSeCT1WXj/YMrn2JIEgcOAY2GhZ/Jy6RSj0UGvU?= =?us-ascii?Q?f1PuHR9ohD6KPIVpLOvyIK6djKj8X5pRc82+M9Aw88rVTU5PRP81PblXvfAL?= =?us-ascii?Q?dUv10J01bJkI3Mz7K4F+AEjIfSUcoknPAQV36MV0rjrm3SJgyl3gPphON2Kr?= =?us-ascii?Q?CEIzgv1Kdw4pKxjExShDTHhbl5PuU3iEzcIuEvOcs2j9ho6D3hHlC9F8ODLk?= =?us-ascii?Q?wpmrgPdjQUXCPoJ/SNGHwaOR6xdWfJvnog2Xodlfr5lh2W01e8d1Csl0ShJF?= =?us-ascii?Q?Snau8Ynex/fo6IWTgelhWC8XRrqyIxO7ZF4X8muhXYANrvNNBW3wyNg+jmPU?= =?us-ascii?Q?5+5y8CFVwK4p6JkXGaGLpkbQ2DnwPDfZP+qjBKL8G/3iTtKxWCAbNB2gM7tJ?= =?us-ascii?Q?UfGOehGeedfvvm51iuFfl+rcXwYGno3fL0ArzfbcRi3qp2HdmndOHMZ5QT/J?= =?us-ascii?Q?4hG+4cmPimlhyTwQCE+h2HVG8yygvG/zTPUwSSZ0UAJZyukJNPCDy34U80PG?= =?us-ascii?Q?iA1BhWVEewdtwHDw/Zgr4D4gKv3qASHvIpFawq0THO0i88FiZ5Fq+aXhwqa2?= =?us-ascii?Q?YgKJdNMOIfuF+db//vAvRMEh2CLH7qp3DJ1MKAddM4wV5aI7WIi1TLl1F3ET?= =?us-ascii?Q?PrKxzXMVWU0P+1VTQ91DsFn7NF45PkT5SabuWMvdEQT03AS7o/QSeguPkXKa?= =?us-ascii?Q?3A9P2xkPNpxi92xHIQjkLhF20KdmOUhewMyStDPLrME1C3vNGWTt5yqspoAZ?= =?us-ascii?Q?TIBeQPcZZrFJkRuxv1wERRQ6WFfM/2uuvlZOVPYel0i0czleLHvpPiXP4GJY?= =?us-ascii?Q?1lbkhZ5hX6nDSu2ZMwjWrSXFjXxw47DEnHqslxn7bE+JzpCClG/zDzVsu7SV?= =?us-ascii?Q?D+QB01pfo09LINS2ltpwITaGobMMd6hsBLgS0fLL4dhE6hf7c8sHYZYFqZMr?= =?us-ascii?Q?CcuMIQ8DyxbEupBOjbYUjyz54myVkCSewcYaqjnpCPCWPko/rdIjBOkfYRpF?= =?us-ascii?Q?no8rfnQGTjwXzNDxbKz8OUA3Mvg27Xtz4eB2eEtFm47V8Rz+Za5IzMIvLqIy?= =?us-ascii?Q?ciug7dQvD/gQ4aJiiFUjET0zXv5S4+HF5iBI45X8xL/LJKqwdr/WCfvyWM6S?= =?us-ascii?Q?QE4ySVtR8snq86quS9YDNjA0FU8aByUF4mVWEYbFtecS5XWiyjOHQc3N6GxG?= =?us-ascii?Q?Mv3MmmQdw5/WTKmWfjXNkog4oLM0iNEXcaSs6gFS/j/OeghZ5wCRFPNdMzJ8?= =?us-ascii?Q?vq5FwS9pzSvE1Bx7952mGTW1?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 785e8422-949d-41c9-d234-08d94b72fa59 X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:39:04.9804 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ITbkO63DkOpHef72Fducy3U5LG9rlIjTvOiU4wrZTR0/BNG+aX+3xeuG+t6Qpr/JJQiBchaDd0ttJLROICAn7Wjt1g6qNJITvPoPi29TJSM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.91; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626781399243100001 Content-Type: text/plain; charset="utf-8" If image doesn't have any compressed cluster we can easily switch to zlib compression, which may allow to downgrade the image. That's mostly needed to support IMGOPTS=3D'compression_type=3Dzstd' in some iotests which do qcow2 downgrade. While being here also fix checkpatch complain against '#' in printf formatting. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 56 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 9f1b6461c8..a841fa4c72 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -5250,6 +5250,38 @@ static int qcow2_load_vmstate(BlockDriverState *bs, = QEMUIOVector *qiov, qiov->size, qiov, 0, 0); } =20 +static int qcow2_has_compressed_clusters(BlockDriverState *bs) +{ + int64_t offset =3D 0; + int64_t bytes =3D bdrv_getlength(bs); + + if (bytes < 0) { + return bytes; + } + + while (bytes !=3D 0) { + int ret; + QCow2SubclusterType type; + unsigned int cur_bytes =3D MIN(INT_MAX, bytes); + uint64_t host_offset; + + ret =3D qcow2_get_host_offset(bs, offset, &cur_bytes, &host_offset, + &type); + if (ret < 0) { + return ret; + } + + if (type =3D=3D QCOW2_SUBCLUSTER_COMPRESSED) { + return 1; + } + + offset +=3D cur_bytes; + bytes -=3D cur_bytes; + } + + return 0; +} + /* * Downgrades an image's version. To achieve this, any incompatible featur= es * have to be removed. @@ -5307,9 +5339,10 @@ static int qcow2_downgrade(BlockDriverState *bs, int= target_version, * the first place; if that happens nonetheless, returning -ENOTSUP is= the * best thing to do anyway */ =20 - if (s->incompatible_features) { + if (s->incompatible_features & ~QCOW2_INCOMPAT_COMPRESSION) { error_setg(errp, "Cannot downgrade an image with incompatible feat= ures " - "%#" PRIx64 " set", s->incompatible_features); + "0x%" PRIx64 " set", + s->incompatible_features & ~QCOW2_INCOMPAT_COMPRESSION); return -ENOTSUP; } =20 @@ -5327,6 +5360,27 @@ static int qcow2_downgrade(BlockDriverState *bs, int= target_version, return ret; } =20 + if (s->incompatible_features & QCOW2_INCOMPAT_COMPRESSION) { + ret =3D qcow2_has_compressed_clusters(bs); + if (ret < 0) { + error_setg(errp, "Failed to check block status"); + return -EINVAL; + } + if (ret) { + error_setg(errp, "Cannot downgrade an image with zstd compress= ion " + "type and existing compressed clusters"); + return -ENOTSUP; + } + /* + * No compressed clusters for now, so just chose default zlib + * compression. + */ + s->incompatible_features &=3D ~QCOW2_INCOMPAT_COMPRESSION; + s->compression_type =3D QCOW2_COMPRESSION_TYPE_ZLIB; + } + + assert(s->incompatible_features =3D=3D 0); + s->qcow_version =3D target_version; ret =3D qcow2_update_header(bs); if (ret < 0) { --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626781830; cv=pass; d=zohomail.com; s=zohoarc; b=XOrYQwuVKJzRrYxRs9TNVBcBfCW5yuSNOzsoESZXRkyvhan2A7FPyikqrNz08ctNACBdAZyamuUiu9bm8B1VIbW4tdTKVw85PKQf9gWy/fcHf9JA91PLYwUanqqHdcZanFbFKO4xriZGNhYUahgsKoSY1wVMJOgmeAfYFsv0SUQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626781830; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SWLNWnHFARs5TXC5ze7q3ABmuKQErLn7Id2sJilRgDo=; b=N9bSRwqElzURNZY5Kx8aGtpi0Ntr4h11cryrl4PbSXcZL3Agrldb82jxntgwvaUGtqKtmJqxn7Dy3uBVVbOs6j5t4pdmrK+tGS4q57/2IJXpQjL6YyOl1mCzgpKiIS+pHZpKBfZY13/VZMaFe/VE3Bwsxg7vEmaJ/96L6WnQSvc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 162678183083391.82524286456055; Tue, 20 Jul 2021 04:50:30 -0700 (PDT) Received: from localhost ([::1]:39972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oGb-0005Mv-Qb for importer@patchew.org; Tue, 20 Jul 2021 07:50:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o63-0003SP-3R; Tue, 20 Jul 2021 07:39:35 -0400 Received: from mail-db8eur05on2136.outbound.protection.outlook.com ([40.107.20.136]:65205 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5z-00077C-8A; Tue, 20 Jul 2021 07:39:34 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:39:06 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:39:06 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:39:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bPTmkhLY4xqDsNCsCWltX6Zq5sIyfQ7ofIWUIfQC0EbPE31Au91SiM+zBOxRlWSH0f8nKBObuswOR4XdyBuji7gPxla8MsF7asKwAxWtntqzRAV/gwxbk+30beZsR3lg1wIPNURIj9/1QleINQyZnfVTVrDwMx+dtb/AYgVwYbSjbv7FEyBa9XhqPHXN3fP1cVSjUzwa5Ay3KfhJbqWuh5u/AqhuweA0h+rW9TGOYEGRYFoJOH2V8M9SeVeWbQxLgtrgoSDWZPMtMY3qxMN/E+auynvM/5QOvRXrkc4cG+hgae/+I/1ehw0FkSQVZ31K9cdstKqFS95/BwqHfu1hhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SWLNWnHFARs5TXC5ze7q3ABmuKQErLn7Id2sJilRgDo=; b=UyK36n+46BfXrXtzsQTjRXIxUr7418siioXCzK3r69TQ6yr6XMBPr9eKr4PXD7G2npa+cIGSysnPbUqsU606yM7ItO8EUKtBd9OWSVUZ+0TdV/j0ve4wVHa2+tU930lN9jsyZuIJfaP1f6ovOA1dRnW6haq6Of/v3TuEyEYX9Bcnl1mM6nqCXe/HtT7JY14WEHIcYAvOp8gWbtitf8MwOC8B4qxh6AeNURi0g5utUfFQZkYLCRiUhw2jE5qFTXI+tpw+zMBiPCgVxWva8oStcoIHprCeDfZeq+xtE7GAyHFCS/afjSo4exXox5uIawo0E/d6LYOKaqIR2vc+1dKCrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SWLNWnHFARs5TXC5ze7q3ABmuKQErLn7Id2sJilRgDo=; b=D3uLDCAQ5gxPLEv0SxNgrlXp1e6lT/ygiBQPK2HGh9cdZycx9fevI2WPxf11EG5Qz2g2yBpVFfJ/AG37TxLR+enHIvNBRbLA5uGwbIpRh6mdLkmMHk+9L4lXAPisCvUyzonK7e6c0IlTdIu7T5K4JV/uKX5vumuC08ELHqDuiu8= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 11/17] iotests/common.rc: introduce _qcow2_dump_header helper Date: Tue, 20 Jul 2021 14:38:26 +0300 Message-Id: <20210720113832.586428-12-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 283a8fc9-7044-4c09-b007-08d94b72fb2c X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3513; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5u7jljygh5ZiWwG5QkEpLPtaTZx7/yUCDXyVBlzSku8IwfcAGH/R3E34HHjPuVuMGDV9uUKp5/nlUZ7ZHKKnLrXD2QIuMaNUIKUyOQNxI9zADU0DOZhQECAK51ym7kbl42hBmwmADEVsJs4sdYAXUPMb0xc+WlYhIYT/feg7frxfRFTVLB1oMOvXqrc/mq8NLSo7cW/nk9u+BvjQEQX4PpxXFpRDcjfvMEjAQyqndWZKfq9iLP5szdSOmvChiqHf+sSMZHEAVGLaLBR3NeO0dYuge1qNejXe6+o7Y7RxjnyBlbriOiilN9itADy3Yq1z8ibgXMPKLm8La1gJTaSOG5HuRHA1BC9usmXvi3c4y+FEPykO61on0wiwMsyx5TrpNWOTc5i4gRcGKhENAxkBH/Cz1sYNMcpVyEMFoKZ4KWEXTD5xGwpMUIMFEs/KqE8ppTy5ciPFiqu6NM6rKmpFoNZ0ta3kSoPHjQAfBX0xpxwTgLJ96XGwQskExnZ8+nz+8k9vbIayWBvTb0LNdOvf7IHX5UjzONhsHMxcSvAogDuJ7YmnJZPGtSBDkvn4vUrzwgGNWeWFA/7Dfoz6EjcMDxwnCHjlh5FtIXeK3/LhbB+XIiIv+QKEgZSjByI0NvlmtQqQIQJLaxGV8hPCXJJo0/OUV8HLq/h24R6olE1YxIFpSZX849uZo5fonVmtKonSB8amDYSKcA84sYotZAZm5w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(4744005)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6oNwb+Cwd7goEOkbKOl7MxMm4Uzr+MPYmySE8NihQDy8MYwNrGDGYzGkM8R8?= =?us-ascii?Q?WhA5d3+UMmMG1NSXkna8vuUTfLtj9HtquVH6clMAY3wcPCKXzqaDH0TDdIZP?= =?us-ascii?Q?FN+Wv9ELfBkDlUHPAB+PvZkEPoc9MeM7J9ROiJXqWKNxRC2gGdG669aQvnMl?= =?us-ascii?Q?iPxKfOJrnLD5UCeEcEjFZpPvCxT6hjhHGI/lZMIVYNMiAaYkvzb4ep8yPRx/?= =?us-ascii?Q?BcJhVcRh9l1OSVlTRD/XHRaootLFM1VdRm3K8WJgOQCEp0iU/fFIbHKcEb1t?= =?us-ascii?Q?GBP7hbwPEwt3hq85AeJpCcH5K3DNSRBFZMWBcJDevfxtbWYuJm4xbKT1ZD1k?= =?us-ascii?Q?hncnwW/QMJRNFbqZN88/i0BRbDITwiNuolaxPdshbcKtYYGQLErT44xJ/lOW?= =?us-ascii?Q?6g91LCYOHuy7aTQ5ADjektP9W1mF4J08UsV4zjnrSZ4uSSS0zbPcCK+nzWoO?= =?us-ascii?Q?BMdJK7qrPGSTw0t8JxB4lJt4JVDjtv8GsZYJcvssirSuGZsEcnHszKEH67bW?= =?us-ascii?Q?lyNZTo65vDg3wlo7IitY9fjLS59VzY9Rz0RF+IASslDLth4f6qKsZiOt0EoO?= =?us-ascii?Q?dETABLTg1ZmLCwXq9B9rGOmSUn7m1Q7kX59St3+XO9mEigV3PbC1uN0Ffp+X?= =?us-ascii?Q?V2eBCTtLidRce0dK3SSI/dgSGwp6iTIwq3HO4bZUiZ6FWsxGUazL4KyiODz5?= =?us-ascii?Q?3Yj+H/DIIv6e+7Bw5E0uwT++3AWNz5B04IMINuUQTZJVlLIv/g+K9dZ/qHGp?= =?us-ascii?Q?r3zA29BH6C+6MqWjVjGBKnVFDa8KOPBebN04RfGssZasqayglUOt/8T53G5F?= =?us-ascii?Q?LSj3KHvL30Y0S6TrQ79HfqpDTmn3wu6a0Tl7ZrHLdh9b1L2/S6vHNh3ewjoP?= =?us-ascii?Q?LgMjs/JCzLFGU24tfWpgFmhZhU5qtK8LYzgTiEVsW2bHPSWWPdV4aWa/EjBy?= =?us-ascii?Q?wHVY8qnIb5g2B2PAdW0SHTVe9ZxrPQzs39TfFbXgbhDN5fuNqC1YjdipIklR?= =?us-ascii?Q?U01lLJ3Uw21eEcGdvhOGe4nfjh0gHRLFvFiAF2I3rNPhqjBFk1KjVJR59KXT?= =?us-ascii?Q?13kFj478i+Db6K/TciYmrWrE6Npd+snkkGhQbqw1gI4Ny1lRPZ7E8HKyQD4B?= =?us-ascii?Q?Rt5cu497cqniPkr3XKbH/ukA/zOp+g454ACzvy+SqqhhP9+O8KdaASaFTpot?= =?us-ascii?Q?GSIs05B6jQE/wq3i4MA8Aoo2eVV1r8QlKKCMmi2Z177yzsmDOtl6e/wWdj3I?= =?us-ascii?Q?J9hwwvqUvsIXsnkuOg+SPPi11Xlp80OmTqOFLRuPHDqI7WTIUUsH75gRkAXI?= =?us-ascii?Q?yUU/LdZsJqutL0cT4oOSB8la?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 283a8fc9-7044-4c09-b007-08d94b72fb2c X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:39:06.3723 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PgWPv2wLdeMjNBBbS3mTq8PmDJ0aA1nIJ4h4odft7e9aG9tPJGVfwtCt9z6QromeiZW67HszBEryjxDsOu4pjlf/Xj6THbolY/QJaCaDxA8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.136; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626781831628100001 Content-Type: text/plain; charset="utf-8" We'll use it in tests instead of explicit qcow2.py. Then we are going to add some filtering in _qcow2_dump_header. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/common.rc | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index 609d82de89..8ffeb8692f 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@ -990,5 +990,15 @@ _require_one_device_of() _notrun "$* not available" } =20 +_qcow2_dump_header() +{ + img=3D"$1" + if [ -z "$img" ]; then + img=3D"$TEST_IMG" + fi + + $PYTHON qcow2.py "$img" dump-header +} + # make sure this script returns success true --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626781987; cv=pass; d=zohomail.com; s=zohoarc; b=nCfbaN0mcj3PfV6i+SxU0OGAdvpE2RjZyJAj3401YCSAmyucRcoYNfU6EPkrCci5AHeCMRGlsj5By8cNbDnSbUYh3xPHfk3XvirLzSwvB8sPZSdzY5aGH+OZmvCht1DXzVqlTbLs360Ztxizi+SZ34GVEkLJ0vINfCkgmVWci4Q= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626781987; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=J1j0tfa4dqplR197C7cueCRvfxSWt4GHVx3+nwnhavc=; b=QuHdbrkqjh1zzj9WkWtpnXt0mD6lWpTnAFFHiuSN6IkiQc6eLYC2lCfrB6RYS2/CMSFbVINXDj/GKDux7M2/eUtepmrOYZSSUJgh9kiBKlLWKoOHoB8cg6cL3jZJ/DYPwwsfxQGNZHbAKJbmwZAig0B4oAl8lShsYpGE4LEQ5QQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626781987348394.9457914863417; Tue, 20 Jul 2021 04:53:07 -0700 (PDT) Received: from localhost ([::1]:48536 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oJ8-0002kb-2n for importer@patchew.org; Tue, 20 Jul 2021 07:53:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o63-0003UR-IH; Tue, 20 Jul 2021 07:39:35 -0400 Received: from mail-db8eur05on2091.outbound.protection.outlook.com ([40.107.20.91]:40417 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5z-0007CC-VC; Tue, 20 Jul 2021 07:39:35 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:39:08 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:39:08 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:39:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DpD/PJWYAv6HLu92MllmQ+r8uMVyl9HlPQiqbYd6nCBTKLDvYI4CsOWeNZTvEoQdm2YhWg5ito7bZ+VPIzxHBp7wa84ycILL+WdL1M5ebW6ioU5z5yECWvxTEv6Seme2IhnuiFyRSKzbyX3bainoxx9QG7X7+PR3K7OTXE37VhQEw4nS8vREGMobDWzFFzQ5K1Im8nERRmtcnhZqffi3R5zyP78W/2xAst9ZOQ6swF6VgpzN+Ez2xFKnv29Vfn6vju/rsrY9A2TFCzqz5dF0/raHNzfzUaCICZaild/5W35+B6QKc8TB0mCLEDVsysNd7DRihyJWhWv6Kd8+++k7YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J1j0tfa4dqplR197C7cueCRvfxSWt4GHVx3+nwnhavc=; b=TJt0Y8lkWeU1Is9PYfRWkgWqgyhLyx3Hpcjk9e+Nd31e9i6/rWMPsW00BgsFA2jYZQlXMEmvk3MKal4h4nFk1k4mkbfUu7HFRkt2AA5en0oy7XuWNBtD3b/Z1Jr7JHNaXENW+Nmi25o02z05HEuk8CVyHudIgfFZ3xcXeqma0iWEjhvmHZSunsdZg/Nk+IrmgENp2K7G78KrDTkvcMDgG3m+P3GTx6f/fmnaah2EEF5qre5YtAeF7TBSSwxg32qZkhVAEP1uhTnEpbL1HMPJHgg+I0EjKAZp902Ciu3fQxic2EpPTsC6jsip4yEYvKRkM08nBxjlWFIk2W3+/Cd1VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J1j0tfa4dqplR197C7cueCRvfxSWt4GHVx3+nwnhavc=; b=X8WWxidx1rbGoEdyJNhe2uQNzvrpTRjJ6Y3zwsgmJXnq6L69fY/T1SVxovXr9yewX0dWqO6bUMCxcrGPgpNtPWP5JTrCuBnCColvPc9FQuX2fSEqTpmiMHx6bpTkhxP0J/rJHmbzlemQsuN8PXBcOoviBvUwGc9rGcey4mNspw4= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 12/17] iotests: massive use _qcow2_dump_header Date: Tue, 20 Jul 2021 14:38:27 +0300 Message-Id: <20210720113832.586428-13-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6f7f69e7-0084-491d-3058-08d94b72fc0a X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:55; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mAaAZytx1eWNRKfHMd3FDSrS7cobETKMoSITeI2vRK2AiQWkuZX4u7oOzcDM36MhRhoLlJKxPP0iBnDVXgc0xK6UeYd/DIzXM5J2Fa4ZHyJj8iEN1oHDAjQm5oUoQUJewdfQ8SYXpLL2oQv8RnFwwWNh/sc6S1u0ow1xN6ACzfkRE5W0OPL8mOnA1OaWOmGOu0ySW70Czj2jXBpBATEjBL+TbdmE65at8j160GiBuU7ch66Xg/jMob/fD8BgdDjaYthSSRGl+xcoPnsIxif1+H0KDlqjEcgZygQ+JxjE1wvqn0BTteVvbxWlNhl3lfLl7XTF1N5Z/FHvUcj8VqeuY9XrynhgSDXvDtE7SSbBwmsiGW/+rQaOJGjsMxYiWSV3AIgbRMadIn3cG6LVQCyzCTnSk3UBMDUnMwSBQfGHiNxhzYvtT/qtWh/i+7RrE7iewO/Q+6Jwyo1hcgthiTmmPd2qn85d5NBUF7ym4PN3HTrpNrsLNUm4a7AyMyVKMRq3rbZHS/5AqBNKRVmrfCVBpMAE6lPFYwvSThpcF7JI+Xj5Vk9Us75ve9k+GTsigUVWoQAnqcMRn1vtFf9Tjhzvc+FoWMw+hjTBAKZqez/NzksIMoqhlpSynKMj/zZnp341CKbaEEsd66Tq2gpRFJ1q14oAOI30cF+O0+5SC4LmtfqEPooiV2rWWRnl5jQIrP8SHHmErROtnSL/k64093mA7A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(1076003)(478600001)(5660300002)(30864003)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007)(14583001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q8DcX+tco7tGFagTrYc0/RmQMvmA5LdVSEA33AhAVa7oytuUdMJjDZqmwSTh?= =?us-ascii?Q?7xje8J74astvD6GfJnGY0QhJWMO2OyAgoRF74yAYRvFFI75+34QkpZCkysKq?= =?us-ascii?Q?QpJYDU/Zgwo6kGix89o3gmirIKouC45DIXda9AdyhT2xgiTpKtmoh3Wd+CQw?= =?us-ascii?Q?Y+lPuPZurJ6JJF3ZwvM0cYjcXHYfeB+RS3Gh9WdPXvHpIrTb0o2GtyPA7UXY?= =?us-ascii?Q?h+0GBooivws2KnvOtPk2xHpKY4aZif2NqyMvUxGLQim1Km/7B1F+is9amRWX?= =?us-ascii?Q?7CwAWYzijCL/hk8jGdszKDXd6/zphxFGHtaULKl9+eCxKka2MC4hWmlu2Ha+?= =?us-ascii?Q?ctoInk/CotGI/HcKYOAEp06IhJKjOTWWzG0sHT2iTY7Q+QpvqN6ruZjpiZ5b?= =?us-ascii?Q?etuOFTgFdY1i1QRfXuKxyWH9PC1XRemFyWZ5iy+mR6nFtV0bNkdV3JTqdSVx?= =?us-ascii?Q?BiUCaGi1cyUGibNMntfegQzv5v5SPhqTNsmKnrNwlEcYdnmwBG10sNHpqIKf?= =?us-ascii?Q?f29EZgFmQXOXIh/nypchrY7NqBaXrurnrjctEZn9ulbpnWD7I3FEPbDYOk3N?= =?us-ascii?Q?KUBuEnqVY4hhEQCxqalsC5YqWpCTpXn8OKL+PnhoJ5aQJ8rewAHVeNBoTHhE?= =?us-ascii?Q?ZuGHfA/LKyUZGkE3umBZV6v5FUSrBPuGr53OeMdo3xNxi6RjgsSX6S3lU1QM?= =?us-ascii?Q?AwKMM3E5KBngdLBVpBoXbM3O2g+XhP21q03lTei4TLXFsRXOFvoRA6SXnc4G?= =?us-ascii?Q?TXa1Wi/j4kBIJ25OC5lnFOnBs2rpIuIpw9LfdvVwxlAfaMiCPbmFbqv+/skv?= =?us-ascii?Q?xrWl/sOxBYcB3hu1Mil9N2xPhJEigD/iqzdTk6PM7Lr5mZfa+5DM8rUP6RGc?= =?us-ascii?Q?BIG/lTXPkkjv5obGhekdV2hNuFsA25tHiymi1aW4KtjmfLASdM8KLUL397l5?= =?us-ascii?Q?HAEZoVnfCRxweurmeAUXz75eyXsvizD4UmsfLl+NTzKSfABwaFPBmnVB1lIS?= =?us-ascii?Q?HzSTnOdofnmkGy47eKyu2x7BbgHIDkoJ58f44OHD/v4hogKPjFW/kMM/W/Rl?= =?us-ascii?Q?3tV2KkX4oZh4WUloQMEir1YAGNS9YR9/5nJj0cgkcDQ1y3mBoFgRcPAvJ2Yj?= =?us-ascii?Q?WidOgxGppN61qRm37URiHq+hE53yOsrN03bMHHgfR4JmdKbyiktX/ZfThIJl?= =?us-ascii?Q?D7IS7qFwkRPnthfDVosNVBgSkXrnXTS8Pduh9PiiQFXN0aN9X69GB9Jtv4wL?= =?us-ascii?Q?zFpBzQ/MxFp6c5oneyQiBBAZPbXyLUCiYYX3DtSKTqOynuD/AuaTdCLTfVcY?= =?us-ascii?Q?Jg0PEHcwFFScwbmrQa0m08Ot?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f7f69e7-0084-491d-3058-08d94b72fc0a X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:39:08.0240 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aLOmwvKlt7g8kys7aXgQGnvsl2GoJm58strVec9aFDvxwUN93magSDWaSv682JZkFxsB+GuqsrNORgGF3BSecpFdyrjeQ6j6R7gzI0fAc/k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.91; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626781987788100001 Content-Type: text/plain; charset="utf-8" We are going to add filtering in _qcow2_dump_header and want all tests use it. The patch is generated by commands: cd tests/qemu-iotests sed -ie 's/$PYTHON qcow2.py "$TEST_IMG" dump-header\($\| \)/_qcow2_dump_h= eader\1/' ??? tests/* (the difficulty is to avoid converting dump-header-exts) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/031 | 6 +++--- tests/qemu-iotests/036 | 6 +++--- tests/qemu-iotests/039 | 20 ++++++++++---------- tests/qemu-iotests/060 | 20 ++++++++++---------- tests/qemu-iotests/061 | 36 ++++++++++++++++++------------------ tests/qemu-iotests/137 | 2 +- tests/qemu-iotests/287 | 8 ++++---- 7 files changed, 49 insertions(+), 49 deletions(-) diff --git a/tests/qemu-iotests/031 b/tests/qemu-iotests/031 index 58b57a0ef2..648112f796 100755 --- a/tests/qemu-iotests/031 +++ b/tests/qemu-iotests/031 @@ -58,21 +58,21 @@ for compat in "compat=3D0.10" "compat=3D1.1"; do echo _make_test_img -o $compat 64M $PYTHON qcow2.py "$TEST_IMG" add-header-ext 0x12345678 "This is a test= header extension" - $PYTHON qcow2.py "$TEST_IMG" dump-header + _qcow2_dump_header _check_test_img =20 echo echo =3D=3D=3D Rewrite header with no backing file =3D=3D=3D echo $QEMU_IMG rebase -u -b "" "$TEST_IMG" - $PYTHON qcow2.py "$TEST_IMG" dump-header + _qcow2_dump_header _check_test_img =20 echo echo =3D=3D=3D Add a backing file and format =3D=3D=3D echo $QEMU_IMG rebase -u -b "/some/backing/file/path" -F host_device "$TEST= _IMG" - $PYTHON qcow2.py "$TEST_IMG" dump-header + _qcow2_dump_header done =20 # success, all done diff --git a/tests/qemu-iotests/036 b/tests/qemu-iotests/036 index 5e567012a8..f703605e44 100755 --- a/tests/qemu-iotests/036 +++ b/tests/qemu-iotests/036 @@ -58,7 +58,7 @@ $PYTHON qcow2.py "$TEST_IMG" set-feature-bit incompatible= 63 =20 # Without feature table $PYTHON qcow2.py "$TEST_IMG" del-header-ext 0x6803f857 -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep features +_qcow2_dump_header | grep features $PYTHON qcow2.py "$TEST_IMG" dump-header-exts _img_info =20 @@ -107,7 +107,7 @@ echo =3D=3D=3D Create image with unknown autoclear feat= ure bit =3D=3D=3D echo _make_test_img 64M $PYTHON qcow2.py "$TEST_IMG" set-feature-bit autoclear 63 -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep features +_qcow2_dump_header | grep features $PYTHON qcow2.py "$TEST_IMG" dump-header-exts =20 echo @@ -115,7 +115,7 @@ echo =3D=3D=3D Repair image =3D=3D=3D echo _check_test_img -r all =20 -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep features +_qcow2_dump_header | grep features $PYTHON qcow2.py "$TEST_IMG" dump-header-exts =20 # success, all done diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039 index 12b2c7fa7b..8e783a8380 100755 --- a/tests/qemu-iotests/039 +++ b/tests/qemu-iotests/039 @@ -59,7 +59,7 @@ _make_test_img -o "compat=3D1.1,lazy_refcounts=3Don" $size $QEMU_IO -c "write -P 0x5a 0 512" "$TEST_IMG" | _filter_qemu_io =20 # The dirty bit must not be set -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features _check_test_img =20 echo @@ -73,7 +73,7 @@ $QEMU_IO -c "write -P 0x5a 0 512" \ | _filter_qemu_io =20 # The dirty bit must be set -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features _check_test_img =20 echo @@ -82,7 +82,7 @@ echo "=3D=3D Read-only access must still work =3D=3D" $QEMU_IO -r -c "read -P 0x5a 0 512" "$TEST_IMG" | _filter_qemu_io =20 # The dirty bit must be set -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 echo echo "=3D=3D Repairing the image file must succeed =3D=3D" @@ -90,7 +90,7 @@ echo "=3D=3D Repairing the image file must succeed =3D=3D" _check_test_img -r all =20 # The dirty bit must not be set -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 echo echo "=3D=3D Data should still be accessible after repair =3D=3D" @@ -108,12 +108,12 @@ $QEMU_IO -c "write -P 0x5a 0 512" \ | _filter_qemu_io =20 # The dirty bit must be set -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 $QEMU_IO -c "write 0 512" "$TEST_IMG" | _filter_qemu_io =20 # The dirty bit must not be set -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 echo echo "=3D=3D Creating an image file with lazy_refcounts=3Doff =3D=3D" @@ -126,7 +126,7 @@ $QEMU_IO -c "write -P 0x5a 0 512" \ | _filter_qemu_io =20 # The dirty bit must not be set since lazy_refcounts=3Doff -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features _check_test_img =20 echo @@ -141,7 +141,7 @@ $QEMU_IO -c "write 0 512" "$TEST_IMG" | _filter_qemu_io $QEMU_IMG commit "$TEST_IMG" =20 # The dirty bit must not be set -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features $PYTHON qcow2.py "$TEST_IMG".base dump-header | grep incompatible_features =20 _check_test_img @@ -159,7 +159,7 @@ $QEMU_IO -c "reopen -o lazy-refcounts=3Don" \ | _filter_qemu_io =20 # The dirty bit must be set -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features _check_test_img =20 _make_test_img -o "compat=3D1.1,lazy_refcounts=3Don" $size @@ -171,7 +171,7 @@ $QEMU_IO -c "reopen -o lazy-refcounts=3Doff" \ | _filter_qemu_io =20 # The dirty bit must not be set -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features _check_test_img =20 =20 diff --git a/tests/qemu-iotests/060 b/tests/qemu-iotests/060 index db26c6b246..d1e3204d4e 100755 --- a/tests/qemu-iotests/060 +++ b/tests/qemu-iotests/060 @@ -80,13 +80,13 @@ poke_file "$TEST_IMG" "$l1_offset" "\x80\x00\x00\x00\x0= 0\x03\x00\x00" _check_test_img =20 # The corrupt bit should not be set anyway -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 # Try to write something, thereby forcing the corrupt bit to be set $QEMU_IO -c "$OPEN_RW" -c "write -P 0x2a 0 512" | _filter_qemu_io =20 # The corrupt bit must now be set -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 # This information should be available through qemu-img info _img_info --format-specific @@ -114,19 +114,19 @@ poke_file "$TEST_IMG" "$(($rb_offset+8))" "\x00\x01" # Redirect new data cluster onto refcount block poke_file "$TEST_IMG" "$l2_offset" "\x80\x00\x00\x00\x00\x02\x00\x00" _check_test_img -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features $QEMU_IO -c "$OPEN_RW" -c "write -P 0x2a 0 512" | _filter_qemu_io -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 # Try to fix it _check_test_img -r all =20 # The corrupt bit should be cleared -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 # Look if it's really really fixed $QEMU_IO -c "$OPEN_RW" -c "write -P 0x2a 0 512" | _filter_qemu_io -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 echo echo "=3D=3D=3D Testing cluster data reference into inactive L2 table =3D= =3D=3D" @@ -139,13 +139,13 @@ $QEMU_IO -c "$OPEN_RW" -c "write -P 2 0 512" | _filte= r_qemu_io poke_file "$TEST_IMG" "$l2_offset_after_snapshot" \ "\x80\x00\x00\x00\x00\x04\x00\x00" _check_test_img -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features $QEMU_IO -c "$OPEN_RW" -c "write -P 3 0 512" | _filter_qemu_io -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features _check_test_img -r all -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features $QEMU_IO -c "$OPEN_RW" -c "write -P 4 0 512" | _filter_qemu_io -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 # Check data $QEMU_IO -c "$OPEN_RO" -c "read -P 4 0 512" | _filter_qemu_io diff --git a/tests/qemu-iotests/061 b/tests/qemu-iotests/061 index 9507c223bd..70edf1a163 100755 --- a/tests/qemu-iotests/061 +++ b/tests/qemu-iotests/061 @@ -55,9 +55,9 @@ echo "=3D=3D=3D Testing version downgrade with zero expan= sion =3D=3D=3D" echo _make_test_img -o "compat=3D1.1,lazy_refcounts=3Don" 64M $QEMU_IO -c "write -z 0 128k" "$TEST_IMG" | _filter_qemu_io -$PYTHON qcow2.py "$TEST_IMG" dump-header +_qcow2_dump_header $QEMU_IMG amend -o "compat=3D0.10" "$TEST_IMG" -$PYTHON qcow2.py "$TEST_IMG" dump-header +_qcow2_dump_header $QEMU_IO -c "read -P 0 0 128k" "$TEST_IMG" | _filter_qemu_io _check_test_img =20 @@ -68,10 +68,10 @@ _make_test_img -o "compat=3D1.1,lazy_refcounts=3Don" 64M $QEMU_IO -c "write -z 0 128k" "$TEST_IMG" | _filter_qemu_io $QEMU_IO -c "write -z 32M 128k" "$TEST_IMG" | _filter_qemu_io $QEMU_IO -c map "$TEST_IMG" | _filter_qemu_io -$PYTHON qcow2.py "$TEST_IMG" dump-header +_qcow2_dump_header $QEMU_IMG amend -o "compat=3D0.10" --image-opts \ driver=3Dqcow2,file.filename=3D$TEST_IMG,l2-cache-entry-size=3D4= 096 -$PYTHON qcow2.py "$TEST_IMG" dump-header +_qcow2_dump_header $QEMU_IO -c "read -P 0 0 128k" "$TEST_IMG" | _filter_qemu_io $QEMU_IO -c "read -P 0 32M 128k" "$TEST_IMG" | _filter_qemu_io $QEMU_IO -c map "$TEST_IMG" | _filter_qemu_io @@ -84,9 +84,9 @@ _make_test_img -o "compat=3D1.1,lazy_refcounts=3Don" 64M _NO_VALGRIND \ $QEMU_IO -c "write -P 0x2a 0 128k" -c flush \ -c "sigraise $(kill -l KILL)" "$TEST_IMG" 2>&1 | _filter_qemu_io -$PYTHON qcow2.py "$TEST_IMG" dump-header +_qcow2_dump_header $QEMU_IMG amend -o "compat=3D0.10" "$TEST_IMG" -$PYTHON qcow2.py "$TEST_IMG" dump-header +_qcow2_dump_header $QEMU_IO -c "read -P 0x2a 0 128k" "$TEST_IMG" | _filter_qemu_io _check_test_img =20 @@ -96,9 +96,9 @@ echo _make_test_img -o "compat=3D1.1" 64M $PYTHON qcow2.py "$TEST_IMG" set-feature-bit compatible 42 $PYTHON qcow2.py "$TEST_IMG" set-feature-bit autoclear 42 -$PYTHON qcow2.py "$TEST_IMG" dump-header +_qcow2_dump_header $QEMU_IMG amend -o "compat=3D0.10" "$TEST_IMG" -$PYTHON qcow2.py "$TEST_IMG" dump-header +_qcow2_dump_header _check_test_img =20 echo @@ -106,9 +106,9 @@ echo "=3D=3D=3D Testing version upgrade and resize =3D= =3D=3D" echo _make_test_img -o "compat=3D0.10" 64M $QEMU_IO -c "write -P 0x2a 42M 64k" "$TEST_IMG" | _filter_qemu_io -$PYTHON qcow2.py "$TEST_IMG" dump-header +_qcow2_dump_header $QEMU_IMG amend -o "compat=3D1.1,lazy_refcounts=3Don,size=3D128M" "$TEST_I= MG" -$PYTHON qcow2.py "$TEST_IMG" dump-header +_qcow2_dump_header $QEMU_IO -c "read -P 0x2a 42M 64k" "$TEST_IMG" | _filter_qemu_io _check_test_img =20 @@ -120,29 +120,29 @@ $QEMU_IO -c "write -P 0x2a 24M 64k" "$TEST_IMG" | _fi= lter_qemu_io $QEMU_IMG snapshot -c foo "$TEST_IMG" $QEMU_IMG resize "$TEST_IMG" 64M && echo "unexpected pass" -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap= \)' +_qcow2_dump_header | grep '^\(version\|size\|nb_snap\)' =20 $QEMU_IMG amend -o "compat=3D1.1,size=3D128M" "$TEST_IMG" || echo "unexpected fail" -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap= \)' +_qcow2_dump_header | grep '^\(version\|size\|nb_snap\)' =20 $QEMU_IMG snapshot -c bar "$TEST_IMG" $QEMU_IMG resize --shrink "$TEST_IMG" 64M || echo "unexpected fail" -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap= \)' +_qcow2_dump_header | grep '^\(version\|size\|nb_snap\)' =20 $QEMU_IMG amend -o "compat=3D0.10,size=3D32M" "$TEST_IMG" && echo "unexpected pass" -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap= \)' +_qcow2_dump_header | grep '^\(version\|size\|nb_snap\)' =20 $QEMU_IMG snapshot -a bar "$TEST_IMG" || echo "unexpected fail" -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap= \)' +_qcow2_dump_header | grep '^\(version\|size\|nb_snap\)' =20 $QEMU_IMG snapshot -d bar "$TEST_IMG" $QEMU_IMG amend -o "compat=3D0.10,size=3D32M" "$TEST_IMG" || echo "unexpected fail" -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap= \)' +_qcow2_dump_header | grep '^\(version\|size\|nb_snap\)' =20 _check_test_img =20 @@ -154,9 +154,9 @@ _make_test_img -o "compat=3D1.1,lazy_refcounts=3Don" 64M _NO_VALGRIND \ $QEMU_IO -c "write -P 0x2a 0 128k" -c flush \ -c "sigraise $(kill -l KILL)" "$TEST_IMG" 2>&1 | _filter_qemu_io -$PYTHON qcow2.py "$TEST_IMG" dump-header +_qcow2_dump_header $QEMU_IMG amend -o "lazy_refcounts=3Doff" "$TEST_IMG" -$PYTHON qcow2.py "$TEST_IMG" dump-header +_qcow2_dump_header $QEMU_IO -c "read -P 0x2a 0 128k" "$TEST_IMG" | _filter_qemu_io _check_test_img =20 diff --git a/tests/qemu-iotests/137 b/tests/qemu-iotests/137 index 4680d5df3d..52ee135184 100755 --- a/tests/qemu-iotests/137 +++ b/tests/qemu-iotests/137 @@ -140,7 +140,7 @@ $QEMU_IO \ =20 # The dirty bit must not be set # (Filter the external data file bit) -if $PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features \ +if _qcow2_dump_header | grep incompatible_features \ | grep -q '\<0\>' then echo 'ERROR: Dirty bit set' diff --git a/tests/qemu-iotests/287 b/tests/qemu-iotests/287 index 22ce9ff0e4..6716419da4 100755 --- a/tests/qemu-iotests/287 +++ b/tests/qemu-iotests/287 @@ -61,13 +61,13 @@ echo echo "=3D=3D=3D Testing compression type incompatible bit setting for zlib= =3D=3D=3D" echo _make_test_img -o compression_type=3Dzlib 64M -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 echo echo "=3D=3D=3D Testing compression type incompatible bit setting for zstd= =3D=3D=3D" echo _make_test_img -o compression_type=3Dzstd 64M -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 echo echo "=3D=3D=3D Testing zlib with incompatible bit set =3D=3D=3D" @@ -75,7 +75,7 @@ echo _make_test_img -o compression_type=3Dzlib 64M $PYTHON qcow2.py "$TEST_IMG" set-feature-bit incompatible 3 # to make sure the bit was actually set -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 if $QEMU_IMG info "$TEST_IMG" >/dev/null 2>&1 ; then echo "Error: The image opened successfully. The image must not be open= ed." @@ -87,7 +87,7 @@ echo _make_test_img -o compression_type=3Dzstd 64M $PYTHON qcow2.py "$TEST_IMG" set-header incompatible_features 0 # to make sure the bit was actually unset -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features +_qcow2_dump_header | grep incompatible_features =20 if $QEMU_IMG info "$TEST_IMG" >/dev/null 2>&1 ; then echo "Error: The image opened successfully. The image must not be open= ed." --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626782218; cv=pass; d=zohomail.com; s=zohoarc; b=dN8UkV0mMHf0UbPOpSwz255Bh50+DoMnP4qWthYDkdNTJDBnXwPTPO0u5p358WNgVsBKnuMZbc/9Tmds5mBgPbn94VGde5KK77I6XsB7EqnLYYmv6bxB47JiwVcXdPARoPLhVdQRNLpPaB14OiRNFKi2KyXqG4YZtZURuk0bQuE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626782218; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6J+dwDpCysg/7qyJjv5QTvew3DzMfuZNessktrypt4w=; b=R7+exivbCmXcyDw4WXMWeUmA4r8NNN9Jc8LdigoPREoGRPuqMkEZXJRcFoftDk3mehDl9MfkdB8yJDtRWl6nu4fpBIaQrWLG2hRDuZlyXWWaW0lpA+Dzr8YcFXEK8z/1LlqmxHjsfNUmMcoUT5g3XZMJ2N+7lGnnBv3ZX6jw0Tg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626782218160693.5696208562651; Tue, 20 Jul 2021 04:56:58 -0700 (PDT) Received: from localhost ([::1]:33690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oMq-0003UC-TD for importer@patchew.org; Tue, 20 Jul 2021 07:56:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o65-0003aZ-Jl; Tue, 20 Jul 2021 07:39:37 -0400 Received: from mail-db8eur05on2136.outbound.protection.outlook.com ([40.107.20.136]:65205 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o63-00077C-ON; Tue, 20 Jul 2021 07:39:37 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:39:09 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:39:09 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:39:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JOW2B3q2sc9ud6Jo1z6pyT4sxTIefbBuVJLRc7E3W92aJUfGtBc1ZhawOES77dSPPJEeIgcquwd9y0bVHpW0wAKLNrt1bIZEFe66tsTIbZ/qD8qRgxlUOUBd181q90RruqHAfxpEnBNKagHLqWuJOW83ZD06PmJ8nmwI9LTaAZAz16D1vfLaT8kQOEEzPbkxOQn2IrLps8SBi8mc2lb5bZYaBfczaZelKRvdEVFqpn/ZMloa+vLZJvmTu113gC3MNRhDfRB70qKeg0cxEj3MC8frHhX2/vnUEObfMNrdA5jIjTKMvGgVmC4v3wGfB3Q8zhojrDn/WeE93pfij5zzkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6J+dwDpCysg/7qyJjv5QTvew3DzMfuZNessktrypt4w=; b=FRvLPgg/JR7k9klfeKHuZDSMr0B+MJ6LxrFdmT1pu3+Lw5iqUtdWeZ65ujZTohUbsbGkQvXiWq3yGg71G1J/srnAL4lg0F/Ww3Wf0mqYs5VZVWFWEog3NVTBgiq6FIWgtT4avx2Z1MHcLR2TDnYjW9M36bhS6lfQyU9UbskwobtRwtnAKBY5P2FYWOPnyKYUDEVen4Nx5eVnJYn5o+uv2qLbwJijZ8LQb/ETQVOJc0StoIKSUU2aH/79tvSxilgRk/hMsVGDmrPgHwOE5MctiiOcf5zYIAxzSTbltR05cuUq4tWRX4o19WhEW8FNEwcLns9odaI51X6kzQ8ylPeWHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6J+dwDpCysg/7qyJjv5QTvew3DzMfuZNessktrypt4w=; b=qRj2Ei/LHnM7Li9YpCsYtv7MKDZBrbDker/JO6pfhLBuIXg3tdkLN4iw3JGKSBdbMesnmP4pHUC9KT1wL4ivSSXq8EPEzVt58fPDNpDQOtat5giPBesJHYAPZSnzVqdi0mlThvUnR2Gh8+cjqMkap8TECa0F0FGi2xi46OaoMk8= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 13/17] iotest 39: use _qcow2_dump_header Date: Tue, 20 Jul 2021 14:38:28 +0300 Message-Id: <20210720113832.586428-14-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 82ef6d5c-1f0b-40dc-d86b-08d94b72fcff X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:47; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5mHvpz7iMRzNRasqCpOTG7rTOoHk76qxyn3TMyl6f5lGD22244C+HFFraYBjUauWeaOcZQjqMAeGU5e+pbFigBVpbeRiClRazcZzZiEc+dzY3/HrUfc6dX7SlKzHXyrc7x5sY/JyYja8Eb+qf3B3tH7Xmlo3GA+EnX64+7Bmy/EGddYq7guQOuDgCKgH3+JpiOe98V2LdSOLuTL168jNBm7EZy0qmbSG99N7bfSMcMbkpGESyLFS5bPxzivevJkceNaU6n9kCdGN4dbXom1cQezpzQwAlKTL3B3rzZ1VH+WigBksv1Rd9O+qBYuwVM/R2RVgsvGIsqLtqFr59721AIRR9FZKWP7X3SRv3W/AXTZhhoRqfOMBl+UXcGlJCsB5KAHjCHOjQaE++TJXLPHCWaETdAw0YYbl+XzNSmXADRvYknA5DtAIxpidRRG8lMoKEuYOg5uvnCEkZDImkDqmfcNuIKo5n4+nhBzW8vjdUjVmTREeWxO3VYJK0nsIXvuAEvPsrIGBNCIXCpKpw5E83L7cd144KIjUXB/YNyWCeklWPLXb3RlT6qm1P4ooZ3qv9nRVGw19q5SqVk243TU7k+0eVhQgz1Czz2k+XzuedMSzqJ3lO+cU7fsNxF5ePP9EelLS1Be3Ojk4yw8l1fvqUGoZiyIz/vj9xwawAnxg6jK8ike6704hHZacz8BhUacZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(4744005)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?h/WgqnGV7i6jpSoBeXkIP/lKE6WHyJ8MA2tElpVElnDASpyHcKzK7pnlSaAA?= =?us-ascii?Q?i+tNJWYA7zTgLpQ+l4K4QnmtH695I+qjDA3+vcJYtGER6p3d8cUygLTE3MvH?= =?us-ascii?Q?2W/+wS154IffdoNrg6CDB044Q+hVvF41qScPSiD7BrI/Z9fH03UC6lwX9Lqa?= =?us-ascii?Q?eKjALZfpvfAWEoTp+qw2L0qKK3uC2XEVL0BnLNBe4jvFpFb2sF690n8Fh/2F?= =?us-ascii?Q?jciEdLJ/ZYBVYO+Mxb72aDq5uoZTtM2gn5Wwvm+Q6LhRLWiDnZYYmuQtUSId?= =?us-ascii?Q?epThfqT2gboQLNl2HcQlnRYhCrvJVFyTLurllpXjTL6iAtYGEmGoZxD3L+9d?= =?us-ascii?Q?iOPwa/SJSNOLrSEGPvyu03Qoh/tazxHdYwf82nfvAm96habNl52F7JFTcIql?= =?us-ascii?Q?RCGeZpUTHbLyPX25QxTTHj6mZBShjoOB5hbR4ZSs4L8CgTdiDO2H0v9VbRsB?= =?us-ascii?Q?85xDC01dlRsOcjyPpguC9W/IJ26JF1eH/dTiEjP0AcocGlp+tuETqOGi3YqR?= =?us-ascii?Q?7SavDMoN6g8E9kXYbluvRm0v7gNZxrxidf8+TERV3sccWYRvweJ478d7129Q?= =?us-ascii?Q?Y31UZftcXLHxcbtPSp+56d35JMI+Fn83kvkFarSsFy7PQD5w/5Vpa/4AQPeF?= =?us-ascii?Q?4iWu/5X4Pzy8HSS1eTj73ou+bMErWbi7RS9PeCFhlSGuXniC5Ly1Rjt37zDS?= =?us-ascii?Q?3A1z926RlMd2qH1KouF7WebCUD880fHkN6lgZsDjHF9PhK2rS/0k/VUa4for?= =?us-ascii?Q?d/zVINYU9E1sjWkX8evPGYDPs27jPeZYqTPJye9pHiqYBzFoIKrz1Wmk/L2g?= =?us-ascii?Q?5jZjftZruHfu2apwb93pB2p7Mp6B3WY0BeNRUtPpmwAdmckcOJuTX/0zPoq1?= =?us-ascii?Q?0ZAOj93MK5gWc/plmcdGMgcoCdSEINliOfXbKjV4fGJ7FbPx0Gg1DjCzmwJN?= =?us-ascii?Q?FjVjtw1+b+WrBs2ISXQpk+hrM6o/YYbRANSI1tqgMDF3v9bW1BKBjrAElP6Q?= =?us-ascii?Q?+PToBInk/WivHB6nhLmisOwFe0XVm6dmU8Bzv5Ft8TviqnEcbGeYy35/ioSy?= =?us-ascii?Q?R3b7NFMgoAnTgLYeddqrO+f3iw05zrhQ14yNgPRf1kqdv+1PDCIJyEXm921J?= =?us-ascii?Q?d4F+SuycYSNADGCOcI/pu3cFqEiE6T7CDk+V/b1WIlvlEDJ6yA3epD7xnZPl?= =?us-ascii?Q?w31rIIE5i6M1kVhGZOMidaYrQTnqd7XeE9ds12RmPLk1Q40TEWR0ns6iCLct?= =?us-ascii?Q?GQlAvFDRIa9485ejAOTzOo3oOIpGHeQHt5TUmGLYCfPQ/Qp8LQTmAByMfFq/?= =?us-ascii?Q?nbeD6Wv84un+5MsEWi4XzHHu?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82ef6d5c-1f0b-40dc-d86b-08d94b72fcff X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:39:09.4229 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TViTCxtqiJhqd6WZRQIG0kjAFk4FaMA7CH55n/7i1+ywV+pI+jm5As1BKOFF+1aDeSu6paTUM1KyJYbrucdVBazii9TBFgShoXB5sLSJ9lA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.136; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626782218627100001 Content-Type: text/plain; charset="utf-8" _qcow2_dump_header has filter for compression type, so this change makes test pass with IMGOPTS=3D'compression_type=3Dzstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/039 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039 index 8e783a8380..00d379cde2 100755 --- a/tests/qemu-iotests/039 +++ b/tests/qemu-iotests/039 @@ -142,7 +142,7 @@ $QEMU_IMG commit "$TEST_IMG" =20 # The dirty bit must not be set _qcow2_dump_header | grep incompatible_features -$PYTHON qcow2.py "$TEST_IMG".base dump-header | grep incompatible_features +_qcow2_dump_header "$TEST_IMG".base | grep incompatible_features =20 _check_test_img TEST_IMG=3D"$TEST_IMG".base _check_test_img --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626781580; cv=pass; d=zohomail.com; s=zohoarc; b=esEX94q5qAu5lPfNip++/fclRb+Z4EfigpXXevu3Rq4EJb4Y7nX1h82Ns/XAjf4GWmaUdhQf3EtSAaso5ZF2JZvZwG++E4w1LtGqnA2yRucJwtwVs7eFtjah9UXD64e7Oi4WXQnI20Zdwqwc/QiHx0V7Cu6AFx0t6e7uTKARp8Q= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626781580; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dR99mHHwsOQc5pdsQBk4io1kxe/OUYDa5scJJ/1+gAo=; b=RzYGeMF1HUjb3s+6i8ecaBI4zHECJxJ4BvRsUIVjulumOw3kqMBKIGA9prTEdCbpZwSCLtxOaOdMWybDLkS0T8QrBzs64TH0MTERIxsmPmRCQkZ9KxDv2zg7fs/3/ArXexr8h7Y4XBnGkB3wL1X+KbI2TS4JxdcVqB9UrmCsZlQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626781580930660.8644587423388; Tue, 20 Jul 2021 04:46:20 -0700 (PDT) Received: from localhost ([::1]:55842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oCZ-0005Px-JP for importer@patchew.org; Tue, 20 Jul 2021 07:46:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o67-0003by-0l; Tue, 20 Jul 2021 07:39:39 -0400 Received: from mail-db8eur05on2091.outbound.protection.outlook.com ([40.107.20.91]:40417 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o64-0007CC-GF; Tue, 20 Jul 2021 07:39:38 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:39:10 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:39:10 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:39:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UH7nd2OZN7ZujSZspP48aSklrU6Zd+dw5dy9e3QBnVgBP+Rmy4pQkVKNWvFQQ8cKG/S5Hm3jtugzoTnsGmpagthO75qAARGsEoddvE5FEdnzWi0ulMNvNcnlbNGyRdrf4cxWGL3TFJP3YbkTvxcYeJaoWZxH9WjgMGOTalrMvK2tRcQCIyY7ELNHUAdIm7cqKbuTXyFOK2zrBrayL6b9tNUks9v0qligRwKVk4xkx0bOiyTo19k4gfL6y5yC7+RPhtSWLvbyq0B6K3f8vn1MlotEpfzSyxyPXVcP6E2gxTOhzlJ/Ih1WRNSuafsn9aXS6OsZDP5P7QesSun80npH/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dR99mHHwsOQc5pdsQBk4io1kxe/OUYDa5scJJ/1+gAo=; b=ltrmKCaVPvbCo2OfUOuRRaCK/bS7+BPV8w1EqM16sKg5BTCSgIfz3wcPGw5cLJ8GC7cRfWQX+wKpmApeug5hzvIBtGHKxauPffnTeSsxO/dv7sZrZ+D3z/T8Wn6L44IPL1zZo+On3RpiFFRTgplBW84Y9D8MR06clwLdLpX4fT0x7HtaxvJJHv83SpjUF8mHE3uOVUx+s8xUsYtiaSUCN55jG0ftXTmNDlXRcGPcv5q0KrhfZYISpqLiXoVzyS2/IlpvEMhVXLLoEvt8jMOEFHTzGOV7wsHupliWWN8cXip057uyS/ixc7B8+jvPeHybb3+9Td16hlKBkEwy8JjQGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dR99mHHwsOQc5pdsQBk4io1kxe/OUYDa5scJJ/1+gAo=; b=ox7TtBi8NsXyhK9V7pEha6NVOXUDS6uWKsaITfsQg8cmJ8qk5BCyKW6+4noztwouAQQ8rqhC+f+kduQTyV058Us7SE+D/jNagfn3U3fEn3npA8gUIF2E8nTOuEVvknbbYkg1r8MHf9rOgvPcrIBsdMDjE4Ug3RiVhWG+edr5TRo= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 14/17] iotests: bash tests: filter compression type Date: Tue, 20 Jul 2021 14:38:29 +0300 Message-Id: <20210720113832.586428-15-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a327a1f6-cdf0-43e4-afe7-08d94b72fdd4 X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2201; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZRpoB5/ePZDtzUKHq7lvZMRzEK5/j3RnVP83Q/Z5isOAoBjSBzs53uTw/RlXlYVKDVYgrL3b72tWvjyOVQ9yGv/Eu/+A9CWWsQeuxOIVLemhiDiFSe598FFZZhoFBlsxBHW/L3JeBW9YbLBy70E4ZpJSfDoLfWW5JwNwbXh02XHPAYH4IGzTZtl5RiUblGju0rm88hrpJSpDbpR06/+KL0QWxf6UH4wIlasjlKiCBQNDyaAq6GARfViUyGacL7r1zuw8BfmKVPMZ/3VXCxcmrIJpG7nygy6uEsYkrgSj6qGx7XO3Nd1/eb7onhLX/Q1jApa4vSXGogCVoorqHihGEDjBR3B3HjsAyPLoE3mW0sudEY13dLryYCoD15OOhFqrGST0mCKeE0mBr9EGOYoNPAl1e05EdsHYVSkzU0h+IbA7NUe9aA0PVCmlyu2oKGTwbkrYb9z+OcSYprdbVsBASkewExRKfBBO6eoBkztBXePg1garkyoi+GW0VFtXw89kjjQIr3rJiJoUDQvRy5Sb1NCvgCA2Jv+1dJafNAv/I+H4Ik+mQi5FH01D5gav/xvc4cF4jHRgkVTq9GgmyMREJSRi5V+240eA+9VFEWvcqBe2NYiQu05dfC7VDSzwtrYMw3MC6WlZIGUAFYahEIghB4M7G2cvdw0R5UqeR5xqgKH83Og96wGXMf3UtF+SpJlrdsel1kE5v6yvC8Eu5kE9LA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wmLguXHpRJ3GMB2vSfyqPPltpes69U43Ntuhge5GxIDmPpLGFP8c1pVmKaVn?= =?us-ascii?Q?dXh+mDCw9fpCBdbPoGp9LD5WlTzTZsqSLp9d4Z29eEUk7lNvaqSMF6GEQpSS?= =?us-ascii?Q?8J1nioflzHODrdsoY2vMFpkKZQBDSILv7tixOGN2CbMV/e9AFMkTeohpSUPC?= =?us-ascii?Q?a/R4Wp1w/xcqpp3p+IoJsoAjxB4jmE02ZEPFpOeYNLlJ7NCxw8v0QaZM5jN0?= =?us-ascii?Q?+be05ZKIKA6f0ZmYHdxC5zZIn6rmf1F9fGSfA0XUu71c1wK6DyU3+5Hh/o5X?= =?us-ascii?Q?bjAiUUrjkBlHGOXY+vKJLgn8MN/Z5Oza2iTGgLeBWmzQhfdI4FnZoDk+0sRw?= =?us-ascii?Q?A7wIypvfzoanpfMyC2C45fm+ztgE5qjioIDjRSso/v91bHzigTSkhisCCBRF?= =?us-ascii?Q?d5N7JVEvpvDUqtRqYFWNjt0NSaTVBvSiX1NBhiom8QNe1KkjoU7y729Gdbbm?= =?us-ascii?Q?SMxjlBRnYWoy4o6eQRO133w3+2o25wH8Wd+lvNvFyQZtS50wee72qwB7RQA2?= =?us-ascii?Q?y7t6n7cK4ivkvQ64NVWPhgG/BjPdrUbHfdP6To/Kf42d9ooz44Y2Rupckyif?= =?us-ascii?Q?MzdZLnYHu2ORVPaNXT/i3YYHHtc367oxrpx60TK0v3/VXonxvrEllVfGdExR?= =?us-ascii?Q?wHRLNfOyJoTsMrYTiFTt+y6bEubeYUHKrg4JplvWZZ34CZb+MxI2RqaIPF2D?= =?us-ascii?Q?pw6zUj1Cks6lab8W4p4/eaOU1zA+jOpbaysZf8zGNbf7LZdY8Mw0vCP7Ms2i?= =?us-ascii?Q?XkoPxEyK3bQowMpW31/sHUPyuNRR2LR+fB80bHT42tTPAkDr+O9Y/83eOCnx?= =?us-ascii?Q?0MsC2ABf9LLq77T2a0rsRV+ToNiFqHj/cTU4iwb88Ke/n50wTsuGelImQGLf?= =?us-ascii?Q?wP+sC4lAnoTaMtpKJbW89FX2wSz/EMlgQT0cTEYb5gAp2+x0jsI8aVx84C6D?= =?us-ascii?Q?OPxHTmAKF9TSgFIxNlRjBTzmIxRHNJ/JsNvvA9XKpmP8o3GKAyyxjQFT834F?= =?us-ascii?Q?zr9CUnRr3063VY3l3oMyqjxMj/jUxpvJWntWg5l9AAoBR7rrEiqVbdeFIE1z?= =?us-ascii?Q?Fq1Dvrf20E0dEIlj2C6PX86e1jPrfYWWWAW/H/PIn/PbWCsrtTePNeps5AkB?= =?us-ascii?Q?7R8YJXGvACTdRERbnuSWyZIoJ+CyE7lIFIxuDwlQr2F/UAqnk/074AU4w4Uy?= =?us-ascii?Q?LRgMBr0Z7JZ1C324ubjyIE2wRmIXbbH3H8xDAOq98gTrD2DG5rDnL9fuLqnC?= =?us-ascii?Q?4DjQLJrt5M8fzvMrBPYVZjtSodaBkVXd23rPOrEyca3l+GYG5ESH56dUrHQr?= =?us-ascii?Q?ot/sl1heES6HgbXAhO0nCz6d?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a327a1f6-cdf0-43e4-afe7-08d94b72fdd4 X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:39:10.8486 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4c8oAY18M9QXazh3hQSabv3E2luMUAcvv/MpVGOjyHd4uuzZJcIVJWlHV/YAtjeQSP2F0bfh7sE/tiavAljcnpwVRLxBA/Mlzm5AseycMAc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.91; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626781583118100001 Content-Type: text/plain; charset="utf-8" We want iotests pass with both the default zlib compression and with IMGOPTS=3D'compression_type=3Dzstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type), so implement specific option for it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/qemu-iotests/060.out | 2 +- tests/qemu-iotests/061.out | 12 ++++++------ tests/qemu-iotests/082.out | 14 +++++++------- tests/qemu-iotests/198.out | 4 ++-- tests/qemu-iotests/287 | 8 ++++---- tests/qemu-iotests/common.filter | 8 ++++++++ tests/qemu-iotests/common.rc | 14 +++++++++++++- 7 files changed, 41 insertions(+), 21 deletions(-) diff --git a/tests/qemu-iotests/060.out b/tests/qemu-iotests/060.out index b74540bafb..329977d9b9 100644 --- a/tests/qemu-iotests/060.out +++ b/tests/qemu-iotests/060.out @@ -17,7 +17,7 @@ virtual size: 64 MiB (67108864 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 corrupt: true diff --git a/tests/qemu-iotests/061.out b/tests/qemu-iotests/061.out index 7ecbd4dea8..139fc68177 100644 --- a/tests/qemu-iotests/061.out +++ b/tests/qemu-iotests/061.out @@ -525,7 +525,7 @@ virtual size: 64 MiB (67108864 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 data file: TEST_DIR/t.IMGFMT.data @@ -552,7 +552,7 @@ virtual size: 64 MiB (67108864 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 data file: foo @@ -567,7 +567,7 @@ virtual size: 64 MiB (67108864 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 data file raw: false @@ -583,7 +583,7 @@ virtual size: 64 MiB (67108864 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 data file: TEST_DIR/t.IMGFMT.data @@ -597,7 +597,7 @@ virtual size: 64 MiB (67108864 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 data file: TEST_DIR/t.IMGFMT.data @@ -612,7 +612,7 @@ virtual size: 64 MiB (67108864 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 data file: TEST_DIR/t.IMGFMT.data diff --git a/tests/qemu-iotests/082.out b/tests/qemu-iotests/082.out index 077ed0f2c7..d0dd333117 100644 --- a/tests/qemu-iotests/082.out +++ b/tests/qemu-iotests/082.out @@ -17,7 +17,7 @@ virtual size: 128 MiB (134217728 bytes) cluster_size: 4096 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: true refcount bits: 16 corrupt: false @@ -31,7 +31,7 @@ virtual size: 128 MiB (134217728 bytes) cluster_size: 8192 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: true refcount bits: 16 corrupt: false @@ -329,7 +329,7 @@ virtual size: 128 MiB (134217728 bytes) cluster_size: 4096 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: true refcount bits: 16 corrupt: false @@ -342,7 +342,7 @@ virtual size: 128 MiB (134217728 bytes) cluster_size: 8192 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: true refcount bits: 16 corrupt: false @@ -639,7 +639,7 @@ virtual size: 128 MiB (134217728 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: true refcount bits: 16 corrupt: false @@ -652,7 +652,7 @@ virtual size: 130 MiB (136314880 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: false refcount bits: 16 corrupt: false @@ -665,7 +665,7 @@ virtual size: 132 MiB (138412032 bytes) cluster_size: 65536 Format specific information: compat: 1.1 - compression type: zlib + compression type: COMPRESSION_TYPE lazy refcounts: true refcount bits: 16 corrupt: false diff --git a/tests/qemu-iotests/198.out b/tests/qemu-iotests/198.out index 3952708444..805494916f 100644 --- a/tests/qemu-iotests/198.out +++ b/tests/qemu-iotests/198.out @@ -36,7 +36,7 @@ image: json:{ /* filtered */ } file format: IMGFMT virtual size: 16 MiB (16777216 bytes) Format specific information: - compression type: zlib + compression type: COMPRESSION_TYPE encrypt: ivgen alg: plain64 hash alg: sha256 @@ -81,7 +81,7 @@ virtual size: 16 MiB (16777216 bytes) backing file: TEST_DIR/t.IMGFMT.base backing file format: IMGFMT Format specific information: - compression type: zlib + compression type: COMPRESSION_TYPE encrypt: ivgen alg: plain64 hash alg: sha256 diff --git a/tests/qemu-iotests/287 b/tests/qemu-iotests/287 index 6716419da4..aab03fb973 100755 --- a/tests/qemu-iotests/287 +++ b/tests/qemu-iotests/287 @@ -61,13 +61,13 @@ echo echo "=3D=3D=3D Testing compression type incompatible bit setting for zlib= =3D=3D=3D" echo _make_test_img -o compression_type=3Dzlib 64M -_qcow2_dump_header | grep incompatible_features +_qcow2_dump_header --no-filter-compression | grep incompatible_features =20 echo echo "=3D=3D=3D Testing compression type incompatible bit setting for zstd= =3D=3D=3D" echo _make_test_img -o compression_type=3Dzstd 64M -_qcow2_dump_header | grep incompatible_features +_qcow2_dump_header --no-filter-compression | grep incompatible_features =20 echo echo "=3D=3D=3D Testing zlib with incompatible bit set =3D=3D=3D" @@ -75,7 +75,7 @@ echo _make_test_img -o compression_type=3Dzlib 64M $PYTHON qcow2.py "$TEST_IMG" set-feature-bit incompatible 3 # to make sure the bit was actually set -_qcow2_dump_header | grep incompatible_features +_qcow2_dump_header --no-filter-compression | grep incompatible_features =20 if $QEMU_IMG info "$TEST_IMG" >/dev/null 2>&1 ; then echo "Error: The image opened successfully. The image must not be open= ed." @@ -87,7 +87,7 @@ echo _make_test_img -o compression_type=3Dzstd 64M $PYTHON qcow2.py "$TEST_IMG" set-header incompatible_features 0 # to make sure the bit was actually unset -_qcow2_dump_header | grep incompatible_features +_qcow2_dump_header --no-filter-compression | grep incompatible_features =20 if $QEMU_IMG info "$TEST_IMG" >/dev/null 2>&1 ; then echo "Error: The image opened successfully. The image must not be open= ed." diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.f= ilter index 268b749e2f..447fec74df 100644 --- a/tests/qemu-iotests/common.filter +++ b/tests/qemu-iotests/common.filter @@ -247,6 +247,7 @@ _filter_img_info() -e "/block_state_zero: \\(on\\|off\\)/d" \ -e "/log_size: [0-9]\\+/d" \ -e "s/iters: [0-9]\\+/iters: 1024/" \ + -e 's/\(compression type: \)\(zlib\|zstd\)/\1COMPRESSION_TYPE/' \ -e "s/uuid: [-a-f0-9]\\+/uuid: 00000000-0000-0000-0000-00000000000= 0/" | \ while IFS=3D'' read -r line; do if [[ $format_specific =3D=3D 1 ]]; then @@ -332,5 +333,12 @@ for fname in fnames: sys.stdout.write(result)' } =20 +_filter_qcow2_compression_type_bit() +{ + $SED -e 's/\(incompatible_features\s\+\)\[3\(, \)\?/\1[/' \ + -e 's/\(incompatible_features.*\), 3\]/\1]/' \ + -e 's/\(incompatible_features.*\), 3\(,.*\)/\1\2/' +} + # make sure this script returns success true diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc index 8ffeb8692f..2a0375bac9 100644 --- a/tests/qemu-iotests/common.rc +++ b/tests/qemu-iotests/common.rc @@ -693,6 +693,7 @@ _img_info() -e "s#$TEST_DIR#TEST_DIR#g" \ -e "s#$SOCK_DIR/fuse-#TEST_DIR/#g" \ -e "s#$IMGFMT#IMGFMT#g" \ + -e 's/\(compression type: \)\(zlib\|zstd\)/\1COMPRESSION_TYPE/= ' \ -e "/^disk size:/ D" \ -e "/actual-size/ D" | \ while IFS=3D'' read -r line; do @@ -992,12 +993,23 @@ _require_one_device_of() =20 _qcow2_dump_header() { + if [[ "$1" =3D=3D "--no-filter-compression" ]]; then + local filter_compression=3D0 + shift + else + local filter_compression=3D1 + fi + img=3D"$1" if [ -z "$img" ]; then img=3D"$TEST_IMG" fi =20 - $PYTHON qcow2.py "$img" dump-header + if [[ $filter_compression =3D=3D 0 ]]; then + $PYTHON qcow2.py "$img" dump-header + else + $PYTHON qcow2.py "$img" dump-header | _filter_qcow2_compression_ty= pe_bit + fi } =20 # make sure this script returns success --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626782370; cv=pass; d=zohomail.com; s=zohoarc; b=Gg7tCT6w1hzaOJNlP1jz/SjF4PVzIbp6XEuvMTHAKziSruLmcZT/wY1pPKcJ/b1b5I8Tg1DOrDot+sRd+wW+vUHc5SaEqrbPqQnsJfxAxdkCntmH+PLGlxR1mL6NUIL+WTCHfyDKMpXAv8rA+1GR8oYdQg7F5tIG1c2wQavzbM4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626782370; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DflGnfCnKJ7R5aFFDbKXwyt7+W6Mg0/R8lONJLIquVM=; b=a3Cul9Fj24S71DxOWQKtXV6LszlYQpN9fNl5J8chbyYGRyX4pLee1FQzs0i+aRUZjLmAoqAlgIJriT3LEnjMUfvhOoXHplcPGeGc/PNuTxRMzJoa7eMWwLX2Al5gzvPSevEf6eUUrVnoQXdmc4CkTTX8uGM9MGTz6a3EBskyD9g= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626782370428716.5853901512853; Tue, 20 Jul 2021 04:59:30 -0700 (PDT) Received: from localhost ([::1]:43092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oPJ-0001RF-3w for importer@patchew.org; Tue, 20 Jul 2021 07:59:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o68-0003d6-FF; Tue, 20 Jul 2021 07:39:40 -0400 Received: from mail-db8eur05on2136.outbound.protection.outlook.com ([40.107.20.136]:65205 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o66-00077C-CS; Tue, 20 Jul 2021 07:39:39 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:39:12 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:39:12 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:39:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eiBY2WM/zUQnqcSpyEiqCH+SmKgCVPNkNFq9MLho/vF3PnPdq1KjSQYfFndIdR0QBimP+6bgXs77PcEvxe70cUVQGSTEizwvZ3ry8q8Op9dZTPI3JsUOfZkiajAR6Xia/ewW2EReTkqA5emFUPjANEaAi8BWkNbHnVn2xfZGfh/gpuedCXYkzoXjNgd0/nc7mdF2XcXlmEdneJB67x9k9Yvytf0eNLekcQUgmu8kmuhIiAsQ1an7HCRGiAMQR6agTx248FBUcyB2cLoFRzS3REnZEW4CJ2Tr5b9TsmBK4WTMvdziJjeq87B6TrbwGMs6TvPyZbxsr1f6FIVTW0s3sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DflGnfCnKJ7R5aFFDbKXwyt7+W6Mg0/R8lONJLIquVM=; b=aekM+MukEsGnp/rlGyHJfWcJmwgHwXVh6ncbSjKQLjCJHgnuTnywlPvDzEhYOb8Yu6BaNsuSffGgstK44IpmMY19lZEc3lim3Fy4Op4TmVgk/h/rr+8IAJG+fOCbSqoirGSwOp3bZDKlhcgZYFWS9+YNviBN/910Jjrk0EZcg1lzeUGD8uyiLbEo81ghNLYHVEzxeWoJKDh1tyD1z9hX26FvOlXT8RXdolrdnLyd5wpiDvxEFGqTzmUInihCAFCtSxHl4mVpWgxH9wNCf8BHNgDp+JWUk4n3PpHmMoskziKoPzntr4+7pyj0CGcAEMRROQnSCAYJuSn1qIAsllOxng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DflGnfCnKJ7R5aFFDbKXwyt7+W6Mg0/R8lONJLIquVM=; b=C8oamIfSUI78QSDcSbrUtAaPERLrbvH3Q4SVMs9+O9MUeuubaMY+k4UdjhFiZC/UltEORAu+wGhHlTtP5dKLbbDg3yw6H2CpJD461D9vbGiWpmRberVQF9EWNReWhWilGk9kb7h3rGMQhozve/rjEupjSaZfEDYVkHRA1hzxFE8= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 15/17] iotests 60: more accurate set dirty bit in qcow2 header Date: Tue, 20 Jul 2021 14:38:30 +0300 Message-Id: <20210720113832.586428-16-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf822160-d58e-49a4-4369-08d94b72feac X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:256; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cqo61eYN5LBWXLxznM8Su9NCJ+h5FwXJkWycMMZRD4xJBk2IXqk1cmcOc6XEz/IhcP2nFpoXAv0sA5r45k43YN03X0T0S4qbl882JblfqoEk8GmxuM1w05H4/pZ/nyCX5WM7R4AH/DjvqaxdSvLBu/3AgTB4K4WUVPntsxe6jk2gHMKtIS3m4EJqayP86W/Rt6sF8wpEV9jlHiqcBIs1Ul2UO/h8oEmiJwOeOHHdLxYHOBQqcWmfjVUCbT+JSmwOBqH9QvsZ6ZIZj5HhECS8KlsQv7hNuWmuF/Kv4z8dKhaK6MeS1IWK5Vo9Pb88vC39Gfe91z6dflz3gB3IfIMnDG8ucOQCZ95ll+CIiwumFOJQgSpoGudWkeThw+8nnpeIJccUaGWH0U7aqBpdQAgn63O7Uy881weHV5fxVvUfumvjXPMsN7FEeyRrrJKvRK1eLTjt/8GSE/TwH2iSD11HNQVWxkWF/ZjGLyjKbM2SRRQIGzkJKs1Vu3DuvbM3eIBVzPFP5ClrjY7tvnXWVt8ckd55EYUPwcKo46d/cp/ctIutoZg1ek3t/udkSa6e5E+7n4xm2MtebyBiO/f9n0jQvwkMl/jjklMrTGEmVS7lX4ES3WWkpMc06tyeDwFMpwlVT59y8iX7opvcKDuO015nKaqW8a1X1M1VG3jdwVcYnbM2B6rerNpRz8xDJ140o8tXKy0pCOtnOBCHEhc7H/l3HHVGnX6rIDu1cnkTR6ouHf4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(4744005)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007)(14143004); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nRllLqUH/+6SyXRe6S9W4fN8MBBjjfgv161kFB5yUV23qyVVqN1W1wG5DGuh?= =?us-ascii?Q?TfdGlXFzo67se2oRNP1n3gCab2LwfgUzBbbAEkFlEXUZz1k2k/01dhWaGAsw?= =?us-ascii?Q?r9F+12MqQgFqBz8fHY4CQBLnfVYdxUeFWeHxYBmsQqwN4iyLwld/A0ebVahH?= =?us-ascii?Q?Cvd/uz0Wc9w4dsI77nClfKgAXqBmmPSnlJr4SPQHGwmCePDLr68R9GqPzjQI?= =?us-ascii?Q?42y5zOHcEvAFSotGduwLVPC11XprA4wo/G+lCQYA/eFBOVNcSK1rxOVff951?= =?us-ascii?Q?hkzGXy27K/rbOqaznlTZxpRM0QSXFTdwKnQUpOg1HWJ6d/Z7w4VRCDeFe83T?= =?us-ascii?Q?ZK6TDfvJr+Z7VG0pElCaPdjNKf4AtEa0qj5YVgqrnbdfQ2AeXS1XxdcpsqNX?= =?us-ascii?Q?T4RjoqcYxd1VjmpbFmXoSacV5MsXUp9PVvnxVaXIKCGcifJh89yL9l3RlIc1?= =?us-ascii?Q?5hh2v+gwH5UotnSUz/pRar7e6Kh5pSQWQYKpzkDeLnDjG3huIL+eERLeWyuT?= =?us-ascii?Q?NQMK+wQ4RIIXCDw1pUmhUcLtCj8htd3V+QDJ2K4QB9eGVRJUY9F5kRmZp7DE?= =?us-ascii?Q?/kPX7xMwYiK49eVz31Auf3jiDEl5w56aZOaBdXyjwvHqYcBjHmU7xFEa5Vjf?= =?us-ascii?Q?ltNyiW3SCITMTde9/YrPCXGsgCw/ip66Ny43rB+xhSmcH+x+T5JuhBTK92R2?= =?us-ascii?Q?zh2s1nyVZSNQhxCbdAf4Xwxtc7WP6/2tZqNuj9hqtdbOblalRAgGJ/i07O9B?= =?us-ascii?Q?WZKFxyyAGa/FvxSID9Opwz508a6j+6w7d0qXNkkIg5s0l2VsJfLA4bN22bTS?= =?us-ascii?Q?a5/58X1n1V/2sk6yYKlW8jQaXOR1A4WT3Hnk2bZzK0CueuCpJX8tGrZw5+WV?= =?us-ascii?Q?jQnQn6lT+BpWpi07nLlwWxog98syLfcZvdKaaMdj5dBrqOFW1io/uCbgBVzG?= =?us-ascii?Q?AfLOI6rZnzQgvqmuth5GEg4uWcTLXgRh9fnkE7CDXCfLQDeAJM5UOp9lj8pd?= =?us-ascii?Q?J3uzTHKL4jxx2F9bmVin1KnFXtNT1cLUHtS01dJwu71uf/j2l7Sp0sqqyWOU?= =?us-ascii?Q?rwEaOm9R5t9t/OVK0JmhkyiuaXqS8cl2I482otJa9MDce3+Kce8ajfz5VcaW?= =?us-ascii?Q?T4r8EDNZd/I2QLsk9pai2SVuaIyf+kLlJ9UReTC4T+ubzcyEYJ5ty22XBQAn?= =?us-ascii?Q?zPlYeXFsnetl1z/IrCPo01WlwU8m2bmX6yItSG6LMuGpHgW/4IMe0XSUW499?= =?us-ascii?Q?/kDlLtwe2PowODKKjQR7x2/GSR92u9H2akbTLFWYVPuu2RgiyNAmrRvJdK8i?= =?us-ascii?Q?L8vtqRPtNO+6h18ApneMSPr8?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf822160-d58e-49a4-4369-08d94b72feac X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:39:12.2744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9KF7MMKLnrvIIA2v7KQLgnFPCJPsvoP+yaETlN0ZuBWtqiUTrhyGOzDyyHkq06QBsG6fnVzM7lQdYt6EpwS4BdV3OrEMW+r2JzIIXGacDFY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.136; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626782372832100001 Content-Type: text/plain; charset="utf-8" Don't touch other incompatible bits, like compression-type. This makes the test pass with IMGOPTS=3D'compression_type=3Dzstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/060 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/060 b/tests/qemu-iotests/060 index d1e3204d4e..df87d600f7 100755 --- a/tests/qemu-iotests/060 +++ b/tests/qemu-iotests/060 @@ -326,7 +326,7 @@ _make_test_img 64M # Let the refblock appear unaligned poke_file "$TEST_IMG" "$rt_offset" "\x00\x00\x00\x00\xff\xff\x2a\x0= 0" # Mark the image dirty, thus forcing an automatic check when opening it -poke_file "$TEST_IMG" 72 "\x00\x00\x00\x00\x00\x00\x00\x01" +$PYTHON qcow2.py "$TEST_IMG" set-feature-bit incompatible 0 # Open the image (qemu should refuse to do so) $QEMU_IO -c close "$TEST_IMG" 2>&1 | _filter_testdir | _filter_imgfmt =20 --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626782295; cv=pass; d=zohomail.com; s=zohoarc; b=cTRRJ3xHi9Rm3+kY6TkKVDsDTS1677hYsApa4eaESvh/yDpLufHLJtnq5jHGzjv4cY4lE7pNPSK/007amuQfp8ZUX+3mOKQielA5cddTRA9AkA1r0mOU0DM1Mg65V3F4S99GkfKPGSRk+bfad+dJ2jd2/IONINrashXS8haopec= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626782295; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fxKaLB/XgD+NXm2hC62O/cmA6Y+0xQ9MU6xjOOr886U=; b=ZY1e0ShDNXVwSj21XH93wbjqJaeseOZzxj8r0yNdkSJXd8Yc+lj8vksyaO0a+uTLdvddcZwd4eHGxEGixcojKchjHv06SrP1Exa8tLsCtpiWKl+DCN29AvRJ+rUi7dhydsdpQSdPIpvd80e1hjL2KQQPwF7fmo0x/N1oxhIQ9fs= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626782295824496.7043993047603; Tue, 20 Jul 2021 04:58:15 -0700 (PDT) Received: from localhost ([::1]:39100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oO6-0007BC-Kn for importer@patchew.org; Tue, 20 Jul 2021 07:58:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o69-0003dt-7H; Tue, 20 Jul 2021 07:39:41 -0400 Received: from mail-db8eur05on2091.outbound.protection.outlook.com ([40.107.20.91]:40417 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o67-0007CC-Iw; Tue, 20 Jul 2021 07:39:40 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AS8PR08MB6119.eurprd08.prod.outlook.com (2603:10a6:20b:290::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:39:13 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:39:13 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:39:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XP9vsBUYxWgwrhjiRu/0qD6sUWO10g/dwsUDhdjtg4V2pJN9Z+erYFMKuTYkBOXLhSyiR5U4eNFJEwB2eBR8W9w0H3Yu8X12mzKXb1GLn/fP/Dbek0dEXWsMTgDiKpco1aM6EO2L07cOlnfxYaz0VWhHxiPKAHxvWgl/WuQonzByfBX+pXC7oIvzlyEqBjF5b4rjrvtPG3nqoStWETN8LtgKxMnd87450kWzVR5lj+gn/doSr52L42fzJrf1U6j2Va8FxoWs0gHoi4sI0A0rhae/q6rgebzitimcUOJ9755DZ0+viZ2Mb79Sxsp6R7b5Ts1Gr0xgxNuj8fKSba5m+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fxKaLB/XgD+NXm2hC62O/cmA6Y+0xQ9MU6xjOOr886U=; b=j28wwHGps2/nWdBVcWPwZ0FtWr9V03ahRUm0+lqvVCeWAhGRq33ynRFMaw+L3mFnmaTIHzT0Bx0NMlLlhE2glSB28mEieQqf73B2qe1z+7VVlona3BbwJjiYepBF6vsj5fyZeB3+Z01XYL3fIn97m+IwTZa8O9dOPXfaSi79SaMkCPRtMc8dc5/W96fvzJYkuIiqxN4n1qF5EIHv1h3VotMX5C3Ed7rt26eMUWubji/YerCaOa+jU6pi1vO1fqTHhnqiGwhNUwQdcX9iuLFMck4vi2nlD5mOpxnnCuMS/Lc/NldWr8BRiP2bRObpHgVZH98MFY++4anb/xG1nHRrxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fxKaLB/XgD+NXm2hC62O/cmA6Y+0xQ9MU6xjOOr886U=; b=Sp6uj5LxIWbtKyR8pGxIopqfHuwiVCNvyvuzPg12+ivb96gHA39s8WV2L25EBvC6d6F080CBLSEHN0YiiF7202kxZayYpDvMvISYM1jADN4PEqscF+H0QkwxFZEoU2GSQdIywFpK3wWgitNbuk0nAy3beBRh4SxTWI0wxfbDLIo= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 16/17] iotest 214: explicit compression type Date: Tue, 20 Jul 2021 14:38:31 +0300 Message-Id: <20210720113832.586428-17-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 95bf5cd6-1dcb-4d31-92f8-08d94b72ff86 X-MS-TrafficTypeDiagnostic: AS8PR08MB6119: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3513; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wQIw8mVbF8crGhz2EXGEYVdVWNjsRrakdO5ohZqvgp+SpB1cYDx6X97hTx8inoUeigs0GM6klxD0ReeQLfdQgGEn9W8db0HYvz0bz+jp1Aie0eBG1mLduAyZzHZVaUAo8BMTbjg5WP1VnSz5e505Y9xWpkYPu/uvQbUSCa7bH7E5M8e0uZcq431oSzyxuzRvmrBXx4XliYKQzPTcnu9CR9l20iETqapoiBcl08PILblbh+JBQlNSNxttwRiw0lqhNBPooTOmH40c13ErgqX9xCPsFd3tOgMnIPAfqleTNedI7ksaNR5u0DwkeTySkn8XKmfMML6KqiqYm8Sd72iIWq2jhPGacRVkyACdplQXiANIXRxPJeSDVM0zjkecAyYrNNjC6cOUcbOG7nyuwUj8AyP0147SO0n/K468OvyLaVCZA4Pwsic13j4HzHFvh3mUdyiby+57wP+qTbc73NToBw/SXU/3KjPtFqnKmyPhT0I23HSoejp0UhF462TJ3h6kb81ibqEYmccq5TDdun1OiXyrB6eoH8K7oK1iNCUXjgoImJS/4RXL3KRynEQwtaTYtKpg7rBoM/9sabTyel7W8KnvjCGI0ypGdm/6O+dpHQFH3nopvgugB+S9/AxLL5lA+gPkiWzSGJdNZVI5shYiTQGxYCwQMgwaUzD85/X5MwkOdrblnV20EP4h8D5HzMCG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39840400004)(346002)(396003)(366004)(376002)(186003)(4744005)(1076003)(478600001)(5660300002)(6512007)(6486002)(2906002)(83380400001)(316002)(956004)(2616005)(86362001)(107886003)(4326008)(8676002)(6506007)(6916009)(8936002)(26005)(38100700002)(66556008)(38350700002)(6666004)(66476007)(36756003)(52116002)(66946007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?L1he8FTPklCqFuxbqmGS5RXd+I7YTNgRPayeozXzfQ96rpFzRCkkDHXBAaFD?= =?us-ascii?Q?x8qCJGwyV35xAN5ITw41yhQ/mFLj6KC59lSaAmIyK6uz5LhY6c/t9C35/I5j?= =?us-ascii?Q?0FrhYxWU5LN4Unr+IKE/T2uiG3z+gLhcUx2DMFP5SYb6RA2zRGcLw0ptReNT?= =?us-ascii?Q?hIuZASiAYrr9S1lPwEGjp0AAmb3ziGdBOie93dS1JrFrO7xCiDnonY/56wrh?= =?us-ascii?Q?4rFB5TXtSsOfet18axxfHnDdmzGNx/yLxjWJodq9kGWSX5qUPcrBwL4DMk8C?= =?us-ascii?Q?6mWVKKoe5S/ABpy1bWUm1sBMSaIVYxhrLULzrHmV0dT7LakVLQprPPrFb5xN?= =?us-ascii?Q?spa91ilBaYYMdLKevumFzCpEUFAPC8DwQUJ0yCJz7zkEumcHbrE6pyuCeAMT?= =?us-ascii?Q?hZ8BUw4UgZ2JRth8JF5Ypmz6wihL2pp5o5ic0WWurQF+Cgwbb1CZiHYOynD7?= =?us-ascii?Q?+QfL3vMZ4chNO6I2NyC+SoqGS5rrwaiHVDz4MEuTzSDUpQdtBVLm08aBqafP?= =?us-ascii?Q?seJJkadU0HKqsu41qEvbBYyczLkGOnY99z6pKp5n6vBDVoVrJgoX1FR58lOe?= =?us-ascii?Q?WfMLe7M/fiqNG1BS11OLFM0dUk/C8rl74ASZm++x8Sez3M0OCVUxcGrR/Hb7?= =?us-ascii?Q?bjDiFByE2F51n0mqRTqkNBL8af1CI8uUppPc7IH6hFI4iyV+ga2u6jbSuAbt?= =?us-ascii?Q?5NvHZniGauCeG/t2dgqjDH7kYUe3v0jjRzI8qUwdLWnvEpRHNtbJ3udSDbIg?= =?us-ascii?Q?RkHA4GtbeJLTfN7hfc19pKzEhZPCvJJT96mB2TnCkCcoelnQthTFklOwCKME?= =?us-ascii?Q?61cLBu2S68giMZv5T7pDSDXl2+mxy6LE4zrNJSi/lhsBDP9gyO/9Qt7B8OWx?= =?us-ascii?Q?qECpakQqwazpbeLKDd+ctW2xbVCc5GvEQDb30mADvurd2BTTqtPBND/xIREX?= =?us-ascii?Q?L08iMfMvHgeYEAvPmCaU59pvyq2E3CmmKQGQh0B2a8CqTBYlBJQGXm7ixEw3?= =?us-ascii?Q?BO5NSJTQFfVc7vGjIwhX4WDyyLIMiEb1B/0fWGCdd9TYCbO4ZG/vKAhD2MtN?= =?us-ascii?Q?ZWJPBlg0XArcFYgHqHxU7WaV5ac4t5hcD8Qyp+nA5bxwoyecQXGaljZ8vJ6W?= =?us-ascii?Q?n7DK7QOo6TcaMhPa06Jc7mswPNRWNp/Rd3CbHMny8z1fPDYjS/qI5OdJpP3k?= =?us-ascii?Q?ovSaICH+nVhxsyegI+nCD2PikE4Sevc91jITm1NnvpKq2JYz21V7vKMgOptY?= =?us-ascii?Q?q2s3M26WkgyUqxV3Vpy0q6vD1lkWPubRqU8pCEwM9VbnToEaPImWwEEDGCNj?= =?us-ascii?Q?wkFVIjIyYEMAa8/57CeGwmTF?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95bf5cd6-1dcb-4d31-92f8-08d94b72ff86 X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:39:13.6643 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M3qSzGGLsrHb/QUUyTnIlv6Z97SMfpSTxVxu8ZTGj9+JFyXrG3TEZwp3pYBYVn0JI+H6VG/TZBCxz9OplHKufHRjM3/NTFkRtSFIkIdwxL0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.20.91; envelope-from=vsementsov@virtuozzo.com; helo=EUR05-DB8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626782296414100001 Content-Type: text/plain; charset="utf-8" The test-case "Corrupted size field in compressed cluster descriptor" heavily depends on zlib compression type. So, make it explicit. This way test passes with IMGOPTS=3D'compression_type=3Dzstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/214 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/214 b/tests/qemu-iotests/214 index 0889089d81..c66e246ba2 100755 --- a/tests/qemu-iotests/214 +++ b/tests/qemu-iotests/214 @@ -51,7 +51,7 @@ echo # The L2 entries of the two compressed clusters are located at # 0x800000 and 0x800008, their original values are 0x4008000000a00000 # and 0x4008000000a00802 (5 sectors for compressed data each). -_make_test_img 8M -o cluster_size=3D2M +_make_test_img 8M -o cluster_size=3D2M,compression_type=3Dzlib $QEMU_IO -c "write -c -P 0x11 0 2M" -c "write -c -P 0x11 2M 2M" "$TEST_IMG= " \ 2>&1 | _filter_qemu_io | _filter_testdir =20 --=20 2.29.2 From nobody Sat May 18 10:30:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1626782048; cv=pass; d=zohomail.com; s=zohoarc; b=dNw09DhPEbO+c1E2MVgf4Ktn5scrM0q50Kho7jbvqlsaSJT32EvXgC1ER4/eSb0e9tQTFgzUpBbeevMzlNh+VZHDJUi7x4EHpGKhS/XUwvBeqF3jcHupN9DuKDC00d83p4cIencPaWBa5qM7p8hlXCoAmY53BNoSHN0lXJqHEH4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626782048; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CxpBY6HHc4j7HGyC4D+FSw2Qsz6v7ogAScznzsWoOa8=; b=TaumJ3XYJYl6zfJucQrGcbX7edtSdWPYCfsmSaOSEt6Ci0gUNYHD3cTqQ1MMPASBEM2AsVFwtEH21PGzOpHntbfEaSVvzkZUaK48VD+RpTFi/6eKMcC8ZiSrk2E1ZU+i0dUW74YaMiucNOjumxlFrnzEd+hB5uCY3Qs8eQQkPDk= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626782048161439.52886780844756; Tue, 20 Jul 2021 04:54:08 -0700 (PDT) Received: from localhost ([::1]:53372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5oK6-0005wM-US for importer@patchew.org; Tue, 20 Jul 2021 07:54:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5w-0003Oy-T6; Tue, 20 Jul 2021 07:39:29 -0400 Received: from mail-eopbgr60135.outbound.protection.outlook.com ([40.107.6.135]:17413 helo=EUR04-DB3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5o5p-0007L1-BS; Tue, 20 Jul 2021 07:39:26 -0400 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) by AM6PR08MB4535.eurprd08.prod.outlook.com (2603:10a6:20b:74::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Tue, 20 Jul 2021 11:39:15 +0000 Received: from AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c]) by AM7PR08MB5494.eurprd08.prod.outlook.com ([fe80::44b9:68ac:bdc7:e23c%6]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 11:39:15 +0000 Received: from localhost.localdomain (31.173.85.199) by HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.25 via Frontend Transport; Tue, 20 Jul 2021 11:39:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ng7dVKZPWpBAf1mq//zguSN6J/zE7nqi2CUexusnpRSqgEPy7CneiL5ty8tgk72bWT8Ksrf6zIzpyHilpd6Xr8Lwr6W9myPt6H0IdAG3jGt5P1dN7R9it5n2xTfQ7HuDEumCbsoeHa2NtJAFIoprUmzYdMU3hyojfJR+ZpB7XMdzVT4S6q20Le4FpZIdYM5omfKUY55gpaSP5HXFYP59E2CoL0GjdItKlwpn/yhICSfkwCu30B8P9UvhjqgPxVY0PiIEbNSzfSdcebzV/MIEvYnWVgwLZr+PmyXZwHkfBwufRI58mFJtWDGou1ssdvrAyIlXdLm64auHiLugXD8NHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CxpBY6HHc4j7HGyC4D+FSw2Qsz6v7ogAScznzsWoOa8=; b=PMb4JmTuQc29SjBJJyemVC75+cz0lHCk7fxqA0Vr0b1RcH9/21whgsCH708LEUkIx05Kb3+VmO250S5Q/6wl2MOnajJckLtzKkUwKrkMHWX1D9RSaGW5OOBBybhCcJXHv0sAS7ycMGo1yecLnHjVvyDEoaXNktay4jstdLWnkHTGd+KkKngJxTxWegiqCkwsIGctk/JAddRDHgEAJYbbLsubx82vWcPRIZ4/zFuRSkjPCliqfPtARqqM/LZA1XuYl6LTmbEmCF4clSJb91B7iiZz3zJpNipPUgcZla5+49PSjUkE+/qoFFloq+TVEoYXYtYtJi1Nictyp/ThAMEuvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CxpBY6HHc4j7HGyC4D+FSw2Qsz6v7ogAScznzsWoOa8=; b=Ov5CKmhIurPh6YbmCdiFLl8h5hTYuRQd3sdMfZwc0P+1e4bLcONGFuZsbG9R1AjYZt9AYLX+JSUOMxPg/Un5vyOZNzxBGfCB/2j3cJzqcgAkU95R23Um/nBRV8APY4UhKYybk553XN1HfcBwNO5ItPDI6XQDps+gkLWgPGF7LIw= Authentication-Results: nongnu.org; dkim=none (message not signed) header.d=none;nongnu.org; dmarc=none action=none header.from=virtuozzo.com; From: Vladimir Sementsov-Ogievskiy To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, mreitz@redhat.com, kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, vsementsov@virtuozzo.com Subject: [PATCH v2 17/17] iotests: declare lack of support for compresion_type in IMGOPTS Date: Tue, 20 Jul 2021 14:38:32 +0300 Message-Id: <20210720113832.586428-18-vsementsov@virtuozzo.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210720113832.586428-1-vsementsov@virtuozzo.com> References: <20210720113832.586428-1-vsementsov@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: HE1PR05CA0146.eurprd05.prod.outlook.com (2603:10a6:7:28::33) To AM7PR08MB5494.eurprd08.prod.outlook.com (2603:10a6:20b:dc::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6d50e8b3-42c4-4a18-cbdc-08d94b730061 X-MS-TrafficTypeDiagnostic: AM6PR08MB4535: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IZ0doY7Iux9G5/eij+wPP/igQ835nlwozN6sn8WdBeFHK0Cwlw6unlUCSvle2T8oTRvTLo5B3/uBJty8tjtPIqfFbt8/Uq/fqQJ9TDFu20hTdLfwM26myvjaeN0mGyfpxAqA36h6MRpJPG2CTnWOjGj2l5gO+jNG1cl8eQaOQgtVZ0ctwlnXJ0vfwkBO5DdVjx+AZj2nnRurOyYrv5bH4gviqwEGcfiHjPSWXc7LC3JzlUIb0jwc4R1GnXQSMXVDPruo5F6Vx2ew4cevrx0q/fSaIpcd4ys0YYCji0bVUwHlNWCzJ9rx3dHRCLiaJEux4dGM61d2xNmBe7FemA0GypI8AVj9/naau6+WL3xlVt9ECTXVip7vKrpKviYh46lVpZNQgdFJtMCyCAG/PRx1ww7cdZmMGyHQfFmt5b/FPSr9dCJ1kp8DSpbO5VoMH1KcYl86LW3eYYFdWXegHruFIr//4b2sZCe8L71o9s/nZ2fqMYGPJ3qpw7/Q3AANNhRmnoLvYG21xS1f8eerELUb3d7dyuq+ctVI0qei1WHQd0h1ywcVrjupntfYNgt46TuWsFQpVM1lHT3P0iTWUJxNVOSi4XS5qW4w0j9OlbMHlQUuINNummv4zt8NBSJ0+rdX+Ict5yvB5Je5BeKAylUE8JqmhzPL/BZjARpjIT14bBrcwxtlSdEwYPVHMtD1jyQ9sB+2ikbPYeaE8kP7MuYv+Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR08MB5494.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(346002)(396003)(136003)(39840400004)(956004)(38100700002)(6486002)(4326008)(6666004)(6916009)(36756003)(2616005)(478600001)(52116002)(6506007)(6512007)(186003)(38350700002)(5660300002)(26005)(8676002)(107886003)(2906002)(66946007)(66476007)(1076003)(66556008)(8936002)(86362001)(316002)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pVRBFldVydv6q5ZSDN63fOipCLaeuE94XCSetX1Rq6VhqXuuX5KG5HBzKBao?= =?us-ascii?Q?3G8c6jUPw3kL5EsaKoWlTdK262HwAAuf/bZXrJVhKCaSXq8dLEBBbH1g96Yg?= =?us-ascii?Q?nTvmLMapWl5Bd6bpmf/vhWSoyK30ckMmt/H1jdQTEqI/SvHVxIztr6o5C1mH?= =?us-ascii?Q?++c7AFzF4NivvAFhqvTx6+3E07K7KJ0+uzan6JBumy83W/ypQwe0kofLa1Mq?= =?us-ascii?Q?XyHE1JTEf/5iKCayYj87CLNiWWI7CBNmUbt9hPu9lhB0SwH90/Yj3th/N2Pc?= =?us-ascii?Q?U/crxvssv5UmpYQnY5FSWGp/onq55GRpO1z/DuEYqXbtXUiaB155IKghYBfr?= =?us-ascii?Q?rEJSNaOEo1B2gwp1u3llBufz2M/ak+rLPnfTd2JtsSYb9rF1qkJ5tCmRcRQS?= =?us-ascii?Q?JKJKlvnEhIh5Y+FX1BnTap0sHTa+v6/s05r85sbx5pulY619NQLUYJjrDkcw?= =?us-ascii?Q?COaiL2XvcfTJCz3QvpCSg0whf6GdzwBHNVmEMGLaIIf3rl0DSPJAYaISzRbm?= =?us-ascii?Q?ot+OplYFllKvwSTD3mNdJs2P+Hr5HROMw4LdYvpoGHYqlt0/ieZ6TGYeRhnK?= =?us-ascii?Q?uC81xcbLTVt8rWPMZVgHYz8mZraH8T5xgW0Z3gmzTpsv4OJO8XrLVaBdEST0?= =?us-ascii?Q?g3Y+U9MLV1PRHNtYJFazXo2MgUb6WlAeNgvrSpu0xhX9Tf/ejmW/RHgOIdlT?= =?us-ascii?Q?Ks/J1VSWxHe47XO1E+sdKiTsDh78O0ilTTjze0AavEVvsJUbXovMOOKM2fzy?= =?us-ascii?Q?de1yoM48CVLCLUM6Z9h01R8bbY0yNDSXIKvfoHhQzCMvcdxH0VuEk2fFfoSB?= =?us-ascii?Q?3TOmoPKj0ZyUG+2H+Wgly6/q2kGIFFGoWdZbV6EGmWzTOJ4KvkLsVsAYuPtq?= =?us-ascii?Q?jLwTNsj2IYQunBERX9Z/IxZ0jU2ENSdDdJ/ypLIu/oUw5XW8iOCmnOw3meQ9?= =?us-ascii?Q?C16pKBtX6+0mFaaNhNWZ3f7Y8Ty8R5ezdRUm1otfBdLdI5gJwsO14mg2Hn5l?= =?us-ascii?Q?WM4G0dA2wrcyjrg9k9WcPHgmwVsG2DgMQRP1/0eAUF6ZUAqJdyXhzk1TdI3+?= =?us-ascii?Q?YXvSW7AvnoB0NhVpu//rZV2HWnaFHxHg9GpwGxoxzqDFWozNF6CVvGERV6je?= =?us-ascii?Q?CAaiwUjmLwb9ab6jsi9ic9sVpQpL20qK7d7+ZXMNSLVIpUuIls5EwCKdu7Y1?= =?us-ascii?Q?S/+pxYGYYqUpEx8tyIlyV3rjRHoDYP38thi/vnUEnlzoiuWD22u0zMBMdHS9?= =?us-ascii?Q?tu2jtQYElOk3V2SRzb6cV9pQVmFaUnvBUOZRYvac2a5+4USewERDdLZAWea9?= =?us-ascii?Q?x5BHM+PQcFCMYvolr92whp19?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d50e8b3-42c4-4a18-cbdc-08d94b730061 X-MS-Exchange-CrossTenant-AuthSource: AM7PR08MB5494.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 11:39:15.1497 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C2aN7+0wMeRo4ak+RHefHVMhrPMD2af5JI4IPDP5QEEUhLxLFh5YGwKTfh34H4DKlCgk2ielbGGTPIejGgM0UN8HT0II38Rn/e4VejJ0DTo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4535 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.6.135; envelope-from=vsementsov@virtuozzo.com; helo=EUR04-DB3-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1626782049979100001 Content-Type: text/plain; charset="utf-8" compression_type can't be used if we want to create image with compat=3D0.10. So, skip these tests, not many of them. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Hanna Reitz --- tests/qemu-iotests/031 | 5 +++-- tests/qemu-iotests/051 | 5 +++-- tests/qemu-iotests/061 | 6 +++++- tests/qemu-iotests/112 | 3 ++- tests/qemu-iotests/290 | 2 +- 5 files changed, 14 insertions(+), 7 deletions(-) diff --git a/tests/qemu-iotests/031 b/tests/qemu-iotests/031 index 648112f796..ee587b1606 100755 --- a/tests/qemu-iotests/031 +++ b/tests/qemu-iotests/031 @@ -42,8 +42,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 _supported_fmt qcow2 _supported_proto file fuse # We want to test compat=3D0.10, which does not support external data -# files or refcount widths other than 16 -_unsupported_imgopts data_file 'refcount_bits=3D\([^1]\|.\([^6]\|$\)\)' +# files or refcount widths other than 16 or compression type +_unsupported_imgopts data_file compression_type \ + 'refcount_bits=3D\([^1]\|.\([^6]\|$\)\)' =20 CLUSTER_SIZE=3D65536 =20 diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 index 7bf29343d7..4832000fd5 100755 --- a/tests/qemu-iotests/051 +++ b/tests/qemu-iotests/051 @@ -41,8 +41,9 @@ _supported_fmt qcow2 _supported_proto file # A compat=3D0.10 image is created in this test which does not support any= thing # other than refcount_bits=3D16; -# it also will not support an external data file -_unsupported_imgopts 'refcount_bits=3D\([^1]\|.\([^6]\|$\)\)' data_file +# it also will not support an external data file and compression type +_unsupported_imgopts 'refcount_bits=3D\([^1]\|.\([^6]\|$\)\)' data_file \ + compression_type _require_drivers nbd =20 do_run_qemu() diff --git a/tests/qemu-iotests/061 b/tests/qemu-iotests/061 index 70edf1a163..513fbec14c 100755 --- a/tests/qemu-iotests/061 +++ b/tests/qemu-iotests/061 @@ -48,7 +48,11 @@ _supported_os Linux # not work with it; # we have explicit tests for various cluster sizes, the remaining tests # require the default 64k cluster -_unsupported_imgopts 'refcount_bits=3D\([^1]\|.\([^6]\|$\)\)' data_file cl= uster_size +# we don't have explicit tests for zstd qcow2 compression type, as zstd ma= y be +# not compiled in. And we can't create compat images with comression type +# extension +_unsupported_imgopts 'refcount_bits=3D\([^1]\|.\([^6]\|$\)\)' data_file \ + cluster_size compression_type =20 echo echo "=3D=3D=3D Testing version downgrade with zero expansion =3D=3D=3D" diff --git a/tests/qemu-iotests/112 b/tests/qemu-iotests/112 index 07ac74fb2c..5333212993 100755 --- a/tests/qemu-iotests/112 +++ b/tests/qemu-iotests/112 @@ -43,7 +43,8 @@ _supported_proto file fuse # This test will set refcount_bits on its own which would conflict with the # manual setting; compat will be overridden as well; # and external data files do not work well with our refcount testing -_unsupported_imgopts refcount_bits 'compat=3D0.10' data_file +# also, compression type is not supported with compat=3D0.10 used in test +_unsupported_imgopts refcount_bits 'compat=3D0.10' data_file compression_t= ype =20 print_refcount_bits() { diff --git a/tests/qemu-iotests/290 b/tests/qemu-iotests/290 index ed80da2685..776b59de1b 100755 --- a/tests/qemu-iotests/290 +++ b/tests/qemu-iotests/290 @@ -41,7 +41,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 _supported_fmt qcow2 _supported_proto file fuse _supported_os Linux -_unsupported_imgopts 'compat=3D0.10' refcount_bits data_file +_unsupported_imgopts 'compat=3D0.10' refcount_bits data_file compression_t= ype =20 echo echo "### Test 'qemu-io -c discard' on a QCOW2 image without a backing fil= e" --=20 2.29.2