From nobody Sat Feb 7 06:35:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626168862; cv=none; d=zohomail.com; s=zohoarc; b=LuheQJKB2/Ph0E7ueedVEf6k3Xz+orSDOUiJ+lqFKRWBPHwwx8wcsuww/Wozi7wlH1Y+qN2q9+A/fIZ1tZkgVnDclXn/dgsNryo2WkWf3OT8TRpVpX+VcsK8I0VQRFV2qOHIGIYKwa/SyXldcZxg6lYc30/B6uhtTJaVcQdLNY0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626168862; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PoifXsEARlE+hDkNjuTSVkIg29xuVTVXJBtuLIBRdnA=; b=ThDT8hH5dmCWy1zT8BElExuhZm6uP+L+2yXJOB7fkKNPyDP9dG7jKi2uDpTqI2NDM9rs5KaafCLWp1FyXW5rspiuSrI/il9CsJklTfTPDl5e0tuA8gmTsMHs8HXIgvfd0wc10l0o1NIXNtTgwp6QOgSApL6oPPHXqtmXerfhyIk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626168862511359.42521676859155; Tue, 13 Jul 2021 02:34:22 -0700 (PDT) Received: from localhost ([::1]:39736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3Eo1-00005R-8k for importer@patchew.org; Tue, 13 Jul 2021 05:34:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3Elr-00026M-40 for qemu-devel@nongnu.org; Tue, 13 Jul 2021 05:32:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3Elo-0001lH-MJ for qemu-devel@nongnu.org; Tue, 13 Jul 2021 05:32:06 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-91-H9DHTPIPPVu8Fn8bWvKASg-1; Tue, 13 Jul 2021 05:32:01 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A40D01934102 for ; Tue, 13 Jul 2021 09:32:00 +0000 (UTC) Received: from thuth.com (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id B71FD5D9CA; Tue, 13 Jul 2021 09:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626168722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PoifXsEARlE+hDkNjuTSVkIg29xuVTVXJBtuLIBRdnA=; b=FG6AHeS5uET6kDhZlh98RCMDb+7R8ZvGypzBXkbgFnreh9VJtAv3j/NACTbkIbDtNMtSDO TTu72UCA32rjzGRmRqW5IwD0alEdHMQ+fm7oe0A0ffv0IVOJvYoPUZjj+fd+LlvtsSG1PR dYlhBB7w2vB8c0mEcdGO1Ttg21/244k= X-MC-Unique: H9DHTPIPPVu8Fn8bWvKASg-1 From: Thomas Huth To: qemu-devel@nongnu.org, Paolo Bonzini Subject: [PATCH 1/4] configure: Fix --without-default-features propagation to meson Date: Tue, 13 Jul 2021 11:31:52 +0200 Message-Id: <20210713093155.677589-2-thuth@redhat.com> In-Reply-To: <20210713093155.677589-1-thuth@redhat.com> References: <20210713093155.677589-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cole Robinson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626168863060100001 Content-Type: text/plain; charset="utf-8" A typo prevents that many features get disabled when the user runs "configure" with the --without-default-features switch. Reported-by: Cole Robinson Signed-off-by: Thomas Huth --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 85db248ac1..229ea52516 100755 --- a/configure +++ b/configure @@ -5205,7 +5205,7 @@ if test "$skip_meson" =3D no; then -Ddocs=3D$docs -Dsphinx_build=3D$sphinx_build -Dinstall_blobs=3D$b= lobs \ -Dvhost_user_blk_server=3D$vhost_user_blk_server -Dmultiprocess=3D= $multiprocess \ -Dfuse=3D$fuse -Dfuse_lseek=3D$fuse_lseek -Dguest_agent_msi=3D$gue= st_agent_msi -Dbpf=3D$bpf\ - $(if test "$default_features" =3D no; then echo "-Dauto_features= =3Ddisabled"; fi) \ + $(if test "$default_feature" =3D no; then echo "-Dauto_features=3D= disabled"; fi) \ -Dtcg_interpreter=3D$tcg_interpreter \ $cross_arg \ "$PWD" "$source_path" --=20 2.27.0 From nobody Sat Feb 7 06:35:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626168800; cv=none; d=zohomail.com; s=zohoarc; b=bKsSjO4o92vuyz/scs19hjxaaeCGx+gu3AdcFi/i0FZennCi/1CWnzOqgBaGzw/54Ffx9D004Rj2GXuq55COAM6GcbtXwTGByPEV4E6oQnQSYTVQ1ec+5EDgp4VMu5faBa6BbwoXcV3wCg9Wb6VcfXd+DWf/TNwkE+rt4kgRC+g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626168800; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hIYsrOpqxvAbiZavlkHiYx+Dm+aeGDVjfN6/6O9RXIE=; b=U7yEOMTSnOgEk7ZmFw24LAe6aRR4Z8/2hWQ9bK3IVBzfwJKPBBAUOjUXGU4lOl0QefNe/mvYP2ZTsjdjE7IFPZCjzSK2FNwyaFNNGwO8x6juK9F80+lcuHHn8Zx7D/f76ahUYWeFFCE9lflbQqbYBffn35D5hl5qEjB4nYFwFuA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626168800045614.6876325580351; Tue, 13 Jul 2021 02:33:20 -0700 (PDT) Received: from localhost ([::1]:34150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3En0-0004qW-RH for importer@patchew.org; Tue, 13 Jul 2021 05:33:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3Elr-00026R-Ey for qemu-devel@nongnu.org; Tue, 13 Jul 2021 05:32:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:31572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3Elp-0001ma-6B for qemu-devel@nongnu.org; Tue, 13 Jul 2021 05:32:07 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-398-0ArlSNE7MgOTDoVMNdeGQQ-1; Tue, 13 Jul 2021 05:32:02 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 166CE100CCC5 for ; Tue, 13 Jul 2021 09:32:02 +0000 (UTC) Received: from thuth.com (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id F15145DAA5; Tue, 13 Jul 2021 09:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626168724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hIYsrOpqxvAbiZavlkHiYx+Dm+aeGDVjfN6/6O9RXIE=; b=ejyUYpm2pTSDPkPX8VM06kNhSHJCptUADv6fHkh1+mgit0Yt29pX2nHeobcfVj9vtegYTe D1GPYvmfcB9wXoO378cseMegr4Sfs89JszLkUfXyg+FDLLp1Liq7nGf6vCu/7hLTRHFo6S i+XA8SuddVdDf41BWhW+mpjcMIXimPA= X-MC-Unique: 0ArlSNE7MgOTDoVMNdeGQQ-1 From: Thomas Huth To: qemu-devel@nongnu.org, Paolo Bonzini Subject: [PATCH 2/4] configure: Allow vnc to get disabled with --without-default-features Date: Tue, 13 Jul 2021 11:31:53 +0200 Message-Id: <20210713093155.677589-3-thuth@redhat.com> In-Reply-To: <20210713093155.677589-1-thuth@redhat.com> References: <20210713093155.677589-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cole Robinson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626168801970100002 Content-Type: text/plain; charset="utf-8" There's no reason why we should keep VNC enabled when the user specified --without-default-features. Reported-by: Cole Robinson Signed-off-by: Thomas Huth --- configure | 2 +- meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 229ea52516..1974c46f6e 100755 --- a/configure +++ b/configure @@ -304,7 +304,7 @@ virtiofsd=3D"auto" virtfs=3D"auto" libudev=3D"auto" mpath=3D"auto" -vnc=3D"enabled" +vnc=3D"auto" sparse=3D"auto" vde=3D"$default_feature" vnc_sasl=3D"auto" diff --git a/meson.build b/meson.build index 6cd2dc582a..5dedaf73e3 100644 --- a/meson.build +++ b/meson.build @@ -900,7 +900,7 @@ vnc =3D not_found png =3D not_found jpeg =3D not_found sasl =3D not_found -if get_option('vnc').enabled() +if not get_option('vnc').disabled() vnc =3D declare_dependency() # dummy dependency png =3D dependency('libpng', required: get_option('vnc_png'), method: 'pkg-config', kwargs: static_kwargs) --=20 2.27.0 From nobody Sat Feb 7 06:35:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626168800; cv=none; d=zohomail.com; s=zohoarc; b=BelKgWDCJ0gNGnnmIjCuMyvQc1+PeTPkJASN3Yodz4+6SxeThLJyCuaUuhE7p31VMxjkpaCA3KJCpwlCTzj937vnYx1uwwXKejFc+a0ZY7aEFAQJnFlmfJBS5+TFcyGiTV09TXQqrU3hgZQgHRS2Cp4CWx8dKZaZ7CPoUiXuysI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626168800; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7gU7JvQMNAPyRLUMeCXKXca13jffBqCyiDPn8OaDu+c=; b=i2t0+yx0k1QkJ5PMCQtLZ/R8gPaw1RokyWHSmfERU3sVZaIuQxS5lebWCD920LAP5CSG2l8y6TsS5bEFP4C+gBzx826oH9/FY+uHEdB0ROE/H7LeAI9pOL5LbqajAM9QXnu28RSRYyD3Bzy9wgv4ZJb1v/A19sWhXxaNZfuwj3k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 162616880044084.7669909765898; Tue, 13 Jul 2021 02:33:20 -0700 (PDT) Received: from localhost ([::1]:34216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3En1-0004tA-Af for importer@patchew.org; Tue, 13 Jul 2021 05:33:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52934) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3Elu-000288-EU for qemu-devel@nongnu.org; Tue, 13 Jul 2021 05:32:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33224) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3Elt-0001pD-1d for qemu-devel@nongnu.org; Tue, 13 Jul 2021 05:32:10 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-6yP7UhgzM3uWclY9vA6W4w-1; Tue, 13 Jul 2021 05:32:07 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 509D91934105 for ; Tue, 13 Jul 2021 09:32:06 +0000 (UTC) Received: from thuth.com (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 77AE45D9CA; Tue, 13 Jul 2021 09:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626168728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7gU7JvQMNAPyRLUMeCXKXca13jffBqCyiDPn8OaDu+c=; b=Wr2tXPsUz4/DL0khBdQdDfmF9C+HhyJiibN6i2Ks6qJuS7nsC5pM6I2vtjabPNVJ3AePZi 9wUU04gvuaiDidfuMkmg6j2MfmSHn6nKn/Wdldjb8lqF3nEjA4e2nZ8/KIvGm0EE1qVIQg A9BD7keoPR3wd4w45fKchhT3zinrrI8= X-MC-Unique: 6yP7UhgzM3uWclY9vA6W4w-1 From: Thomas Huth To: qemu-devel@nongnu.org, Paolo Bonzini Subject: [PATCH 3/4] configure: Fix the default setting of the "xen" feature Date: Tue, 13 Jul 2021 11:31:54 +0200 Message-Id: <20210713093155.677589-4-thuth@redhat.com> In-Reply-To: <20210713093155.677589-1-thuth@redhat.com> References: <20210713093155.677589-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cole Robinson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626168801952100001 Content-Type: text/plain; charset="utf-8" The "xen" variable should either contain "enabled", "disabled" or nothing (for auto detection). But when the user currently runs the configure script with --without-default-features, it gets set to "no" instead. This does not work as expected, the feature will still be enabled if the Xen headers are present. Thus set the variable to "disabled" instead if default_feature switch has been set. Reported-by: Cole Robinson Signed-off-by: Thomas Huth --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1974c46f6e..6c7336b763 100755 --- a/configure +++ b/configure @@ -311,7 +311,7 @@ vnc_sasl=3D"auto" vnc_jpeg=3D"auto" vnc_png=3D"auto" xkbcommon=3D"auto" -xen=3D"$default_feature" +xen=3D${default_feature:+disabled} xen_ctrl_version=3D"$default_feature" xen_pci_passthrough=3D"auto" linux_aio=3D"$default_feature" --=20 2.27.0 From nobody Sat Feb 7 06:35:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1626168989; cv=none; d=zohomail.com; s=zohoarc; b=h+kE2F+YP4tgbe0jQMWIWjc9ACG5XzQwu8tMIwS2T43D7hSTX6MiVR+dZ2kW33M2a0CEcgedt47sRemYo76dSxAKRuMMYPyoyhEBDTKXkgh9X0HoTq7YL6ylOCd3NsttFNorUBpOHzNS0odLJQXdKYrOtKyFUduu2AXP54VLyHs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626168989; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FGkt2CEPta8MslrRwnqaK0IU8XII98o3qUzy/H1TYDw=; b=c2g4Lbe1sZ/spi+RSsKJRl2nd0I7/KkkrIRxmhw9lOrZJMy4hkGw5FM2U7RqPCJGmw1ML3Wugr/lrfb6UP6P2cCs0EMNb+x/emjjCkKyxa1v6d/ADa7cZOHvgt5EWAXA1m3nNvBOwBrq0tR+EvgU0BiIlTReiqj9YiEZqg5+sCs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1626168989232311.27547932255663; Tue, 13 Jul 2021 02:36:29 -0700 (PDT) Received: from localhost ([::1]:44126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m3Eq3-00039F-3X for importer@patchew.org; Tue, 13 Jul 2021 05:36:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3Elv-0002BD-MV for qemu-devel@nongnu.org; Tue, 13 Jul 2021 05:32:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:39652) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m3Elu-0001q3-99 for qemu-devel@nongnu.org; Tue, 13 Jul 2021 05:32:11 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-muTOt_vdNt6MzweeEMoaaw-1; Tue, 13 Jul 2021 05:32:08 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BCF81100CCC0 for ; Tue, 13 Jul 2021 09:32:07 +0000 (UTC) Received: from thuth.com (ovpn-112-56.ams2.redhat.com [10.36.112.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADE1F5D9CA; Tue, 13 Jul 2021 09:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626168729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FGkt2CEPta8MslrRwnqaK0IU8XII98o3qUzy/H1TYDw=; b=TFGjHUDQb7pd3n9iZv0ih5rl6R5BnCHPJI1dY5HyKzmmKHNRiItRiVu5ycqvwlttzJAShJ 1iI25RTz+UfsyE4xqaJPZ6gaRHkd5eCtOD1sOXBcQBazeyTWgUFJmmaNu+lsGKiPTdGAwv NbrcLKKHsvygbmvlIMZvguc5znWCkPA= X-MC-Unique: muTOt_vdNt6MzweeEMoaaw-1 From: Thomas Huth To: qemu-devel@nongnu.org, Paolo Bonzini Subject: [PATCH 4/4] configure: Let --without-default-features disable vhost-kernel and vhost-vdpa Date: Tue, 13 Jul 2021 11:31:55 +0200 Message-Id: <20210713093155.677589-5-thuth@redhat.com> In-Reply-To: <20210713093155.677589-1-thuth@redhat.com> References: <20210713093155.677589-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cole Robinson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1626168990630100001 Content-Type: text/plain; charset="utf-8" The vhost_kernel and vhost_vdpa variables should be pre-initialized with the $default_feature setting so that these features get disabled when the user runs the configure scripts with --without-default-features. Reported-by: Cole Robinson Signed-off-by: Thomas Huth --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index 6c7336b763..89cc9b24eb 100755 --- a/configure +++ b/configure @@ -321,6 +321,7 @@ attr=3D"auto" xfs=3D"$default_feature" tcg=3D"enabled" membarrier=3D"$default_feature" +vhost_kernel=3D"$default_feature" vhost_net=3D"$default_feature" vhost_crypto=3D"$default_feature" vhost_scsi=3D"$default_feature" @@ -328,6 +329,7 @@ vhost_vsock=3D"$default_feature" vhost_user=3D"no" vhost_user_blk_server=3D"auto" vhost_user_fs=3D"$default_feature" +vhost_vdpa=3D"$default_feature" bpf=3D"auto" kvm=3D"auto" hax=3D"auto" --=20 2.27.0