From nobody Tue Feb 10 00:59:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) client-ip=209.85.221.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1626037301; cv=none; d=zohomail.com; s=zohoarc; b=NuR9bGm+aoJKCf+3QZFkki31P2qZUwMfPagbJesf7AxhomJwtPYSti6o0SxJ2ZTtxI1klQZOLRHcLRvSuk5tqSuCswm0rk4l+wp6bfBQylMNcC32ffL2FO9J0kjceX4dSdmsqEldhl8VBg339PGYVdPbDDKmzSV0I0kEayhX2Lg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626037301; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ufOeAaz2SqyjCt5TYUAiTb6MTzHNseUPG7GdwxXaEHQ=; b=Gv3xoIoMMfOISoexs4G/NV6RS+XUFMo/q22qV11m4uCBKTbBg8QnVWzPsvElP+xCetZ+2UndQ1p7kjul8fw77YTeWLo3eknPxZzvv9NAODe9kgTGMixxjz8kPd+tNGD+XOaIsZnSYeW1rIV6bvngv+GeVz8cdYauMOIm+rN26RM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.zohomail.com with SMTPS id 16260373018227.04107490015781; Sun, 11 Jul 2021 14:01:41 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id r11so16824259wro.9 for ; Sun, 11 Jul 2021 14:01:41 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (abayonne-654-1-142-116.w86-222.abo.wanadoo.fr. [86.222.93.116]) by smtp.gmail.com with ESMTPSA id n18sm1763321wrt.89.2021.07.11.14.01.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jul 2021 14:01:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ufOeAaz2SqyjCt5TYUAiTb6MTzHNseUPG7GdwxXaEHQ=; b=jCc+Wf4wmfZiNHvQRU7I4bkPnu8HBrFoqN+k2aUn9A8vy2Caas/WGoWPqIyvlArWiD 8cDDMYYjEKtRhiPK89cn/PInFzgfSo3qsXog+isZF1MpU18wM0I05NNl/aN7tPn7G7Ep KT5qtgLqQCb+C9cjZlhcmXCW9bwivbBCZHr399tYyZ8D/9KYXjMtjv5UvTeXoIHyg3h2 Z1lIFv9EPBhd80C2cEZNe5KdgDaXf/giRJj8bNKU4lu6IEu0CYh+XKdlJlXmuZL48tA4 YN58fGuA1TR0M8GNDxbr/bUhMaXVljRKbJqpH/VC/Yxl15fodsVY2BLczirbwifXufUX jVaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ufOeAaz2SqyjCt5TYUAiTb6MTzHNseUPG7GdwxXaEHQ=; b=GzGIJ+3oM//75CRvMF6lJpFEf/y8dp17XPN4rS6S48zbGPDabTqcOb0/TbtSD+uXPR EDopTgXCAgx9a3PVmH9Kc5KSetZCNRsHgVVd3L/FY22VYQJdQQrDiMKX1ZiZpSIHBiMS U1GAkR7jM0vNJvwd9lLtovyuHats1e5eyb4lsfKYwFo5tRzJiuY/TranXo67sC0FJ4zi tPTxMmPRG/hffSXUYzvzP5X4Q2Ou8hs7NvE3JYmLFIG5F1PeZ5hXDHx0bAy84YWJBdSr 7EzrOhSvJTtotPxe9WsE9/9SpnXJVSTDNMCkoiHqxS0bdekRSYS1KcMon/qDvuDFQ7mY tkDQ== X-Gm-Message-State: AOAM532nBdJGcH0nWYgx3hdF1kQAW52QNQo6aPVLjh9bYZXdb3k8+GBS kmIBk4Nyj46kmFPYiP9ZGwI= X-Google-Smtp-Source: ABdhPJykLlvg9iVC+r17E+KeynZm7MXU6rsaIce1SbNGgIVJrF2EmTLFv3YfxsYuEtaXCGE6AyuZew== X-Received: by 2002:a5d:4086:: with SMTP id o6mr27490882wrp.379.1626037300007; Sun, 11 Jul 2021 14:01:40 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Fredrik Noring , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Finn Thain Subject: [PULL 15/19] dp8393x: Replace address_space_rw(is_write=1) by address_space_write() Date: Sun, 11 Jul 2021 23:00:12 +0200 Message-Id: <20210711210016.2710100-16-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210711210016.2710100-1-f4bug@amsat.org> References: <20210711210016.2710100-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1626037303860100001 Replace address_space_rw(is_write=3D1) by address_space_write() and remove pointless cast. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland Tested-by: Finn Thain Message-Id: <20210710174954.2577195-2-f4bug@amsat.org> Tested-by: Mark Cave-Ayland --- hw/net/dp8393x.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 11810c9b600..9118364aa33 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -816,8 +816,8 @@ static ssize_t dp8393x_receive(NetClientState *nc, cons= t uint8_t * buf, size =3D sizeof(uint16_t) * width; address =3D dp8393x_crda(s) + sizeof(uint16_t) * 6 * width; dp8393x_put(s, width, 0, 0); - address_space_rw(&s->as, address, MEMTXATTRS_UNSPECIFIED, - (uint8_t *)s->data, size, 1); + address_space_write(&s->as, address, MEMTXATTRS_UNSPECIFIED, + s->data, size); =20 /* Move to next descriptor */ s->regs[SONIC_CRDA] =3D s->regs[SONIC_LLFA]; @@ -846,8 +846,8 @@ static ssize_t dp8393x_receive(NetClientState *nc, cons= t uint8_t * buf, /* Pad short packets to keep pointers aligned */ if (rx_len < padded_len) { size =3D padded_len - rx_len; - address_space_rw(&s->as, address, MEMTXATTRS_UNSPECIFIED, - (uint8_t *)"\xFF\xFF\xFF", size, 1); + address_space_write(&s->as, address, MEMTXATTRS_UNSPECIFIED, + "\xFF\xFF\xFF", size); address +=3D size; } =20 --=20 2.31.1