From nobody Tue Feb 10 13:18:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) client-ip=209.85.128.48; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f48.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1626037281; cv=none; d=zohomail.com; s=zohoarc; b=YVfH1OeT2fPsShyN1Gj+ZoH8ohTlMSsh/I3MyuCb2OPBbFL/dv6qOq3jV95eMLiOg0TTfR9m8ZhGyrPJBJJ5vQyeIXmFmhtIZ4VRDncHZZWC+HL8kY0E6pEbSMuLqRCFFbYCwAfK+QqFECqixJwoXsPT73lhiHDkNP0GNNAuYjA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1626037281; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ioXSilflQ9D/7iC6aQQSA4Z9B5BUAvIuRmyKh4puuJM=; b=htQkPx6uE0bvU2YJtvzPTKcuhldoVTYY4Qsxt5gu+RzVEAXIIhepKF8vNrqWHUB2DyRv/OMJm2IBlOAp4Tt5J+ZBJ2XYJ/RlUh76UHUO24bQE+FHMc1xniA9DjqfA8we55bo9NzWHamLULUbqDOmixJnXAkpHH9iYoISajdcaqQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.48 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.zohomail.com with SMTPS id 162603728150256.61038366164928; Sun, 11 Jul 2021 14:01:21 -0700 (PDT) Received: by mail-wm1-f48.google.com with SMTP id g12so2129328wme.2 for ; Sun, 11 Jul 2021 14:01:20 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (abayonne-654-1-142-116.w86-222.abo.wanadoo.fr. [86.222.93.116]) by smtp.gmail.com with ESMTPSA id l16sm18868933wmj.47.2021.07.11.14.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jul 2021 14:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ioXSilflQ9D/7iC6aQQSA4Z9B5BUAvIuRmyKh4puuJM=; b=oSTnvDnhxqUIip049n/7PvJnoMGuGju5oL3f4sqqWNjDB/ZzWE9etBDq5YslZogBtV Y71HOVNpEtpyh7arIxbPzleQzYvz2qWoGIrVvaRsyUOmJ2Bb5poySx2uAfSFL0EdtaQf 6KLJ4eqEEnsjajQ2wtCogXYMn4dhizSdIBJs4i6IbJdgBP8RKIdhQwTNxO2qCRcsgHeB XMCgsSVxI2gu+RBiopz7uO7HOw4S8sxkSpSP435XAKFBK0WHl+ZbDtiUvrYX1PaxOuGm Z8HidoVLTaFpjIqQNtzF24IEe/ZGYOm/nCW3Qlj40cRWfdTJ9ktGvMqGBGkSte5MQ36p cURQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=ioXSilflQ9D/7iC6aQQSA4Z9B5BUAvIuRmyKh4puuJM=; b=DerikLhsqss31hsB/rKKldFJjjeh1hAR8cICLv/tUyKENqx6yjlZDAt6NycTJsboMf f5zdGnUcSnttI1oBNfaltz2Q4oj37Px2iI6qCM7NcFSjLOIAR79JcYGC1MTnY4XzN1uI wD1DO+ZYUUv+RzsjScV+eev1NM9G7B0sXQkRrVfi7+9wI45xOR1h4U7WexQfKekOkn+2 xxT9fp+bGXWhQ2IWVt3VlWq3IAAVS6lJE+onwXk14C5BmS1VVm8jVFjIe1qICQgMUdim HTvaL6wq2rSTMnzFZSc/W/U6VAvXRScRafz6Q42J45QSwR43lD5fWt8X/5wmIPlbhyGe 2cvw== X-Gm-Message-State: AOAM532LsObNVNp2KBzz7+veGlqdBKNHPI5CHUepsy/T6hfIT3ypwdRu kAC5nGhUQ9rdStyweHSFXbQ= X-Google-Smtp-Source: ABdhPJwZfgr87frmIRPdRX8Y+h9zV3mP4awbsewqYI9C7ao7cXTzSkubX1acK9T65xZIaXqAnsHAbw== X-Received: by 2002:a05:600c:2189:: with SMTP id e9mr10563064wme.35.1626037279696; Sun, 11 Jul 2021 14:01:19 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Fredrik Noring , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 11/19] target/mips/tx79: Introduce LQ opcode (Load Quadword) Date: Sun, 11 Jul 2021 23:00:08 +0200 Message-Id: <20210711210016.2710100-12-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210711210016.2710100-1-f4bug@amsat.org> References: <20210711210016.2710100-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1626037282867100001 Introduce the LQ opcode (Load Quadword) and remove unreachable code. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20210214175912.732946-26-f4bug@amsat.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/tx79.decode | 8 ++++++++ target/mips/tcg/translate.c | 16 ++------------- target/mips/tcg/tx79_translate.c | 35 ++++++++++++++++++++++++++++++++ 3 files changed, 45 insertions(+), 14 deletions(-) diff --git a/target/mips/tcg/tx79.decode b/target/mips/tcg/tx79.decode index 2f65dce2431..0af5c6d0ed1 100644 --- a/target/mips/tcg/tx79.decode +++ b/target/mips/tcg/tx79.decode @@ -13,6 +13,8 @@ =20 &rtype rs rt rd sa =20 +&itype base rt offset + ########################################################################### # Named instruction formats. These are generally used to # reduce the amount of duplication between instruction patterns. @@ -22,6 +24,8 @@ @rs ...... rs:5 ..... .......... ...... &rtype rt=3D0 rd= =3D0 sa=3D0 @rd ...... .......... rd:5 ..... ...... &rtype rs=3D0 rt= =3D0 sa=3D0 =20 +@ldst ...... base:5 rt:5 offset:16 &itype + ########################################################################### =20 MFHI1 011100 0000000000 ..... 00000 010000 @rd @@ -62,3 +66,7 @@ PCPYUD 011100 ..... ..... ..... 01110 101001 @= rs_rt_rd POR 011100 ..... ..... ..... 10010 101001 @rs_rt_rd PNOR 011100 ..... ..... ..... 10011 101001 @rs_rt_rd PCPYH 011100 00000 ..... ..... 11011 101001 @rt_rd + +# SPECIAL + +LQ 011110 ..... ..... ................ @ldst diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index ae33c75f088..82a7f2bcc63 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -1180,7 +1180,6 @@ enum { =20 enum { MMI_OPC_CLASS_MMI =3D 0x1C << 26, /* Same as OPC_SPECIAL2 */ - MMI_OPC_LQ =3D 0x1E << 26, /* Same as OPC_MSA */ MMI_OPC_SQ =3D 0x1F << 26, /* Same as OPC_SPECIAL3 */ }; =20 @@ -15179,11 +15178,6 @@ static void decode_mmi(CPUMIPSState *env, DisasCon= text *ctx) } } =20 -static void gen_mmi_lq(CPUMIPSState *env, DisasContext *ctx) -{ - gen_reserved_instruction(ctx); /* TODO: MMI_OPC_LQ */ -} - static void gen_mmi_sq(DisasContext *ctx, int base, int rt, int offset) { gen_reserved_instruction(ctx); /* TODO: MMI_OPC_SQ */ @@ -16082,14 +16076,8 @@ static bool decode_opc_legacy(CPUMIPSState *env, D= isasContext *ctx) gen_compute_branch(ctx, op, 4, rs, rt, offset, 4); } break; - case OPC_MDMX: /* MMI_OPC_LQ */ - if (ctx->insn_flags & INSN_R5900) { -#if defined(TARGET_MIPS64) - gen_mmi_lq(env, ctx); -#endif - } else { - /* MDMX: Not implemented. */ - } + case OPC_MDMX: + /* MDMX: Not implemented. */ break; case OPC_PCREL: check_insn(ctx, ISA_MIPS_R6); diff --git a/target/mips/tcg/tx79_translate.c b/target/mips/tcg/tx79_transl= ate.c index 402790249f3..d9193b4d86e 100644 --- a/target/mips/tcg/tx79_translate.c +++ b/target/mips/tcg/tx79_translate.c @@ -334,6 +334,41 @@ static bool trans_PCEQW(DisasContext *ctx, arg_rtype *= a) * SQ rt, offset(base) Store Quadword */ =20 +static bool trans_LQ(DisasContext *ctx, arg_itype *a) +{ + TCGv_i64 t0; + TCGv addr; + + if (a->rt =3D=3D 0) { + /* nop */ + return true; + } + + t0 =3D tcg_temp_new_i64(); + addr =3D tcg_temp_new(); + + gen_base_offset_addr(ctx, addr, a->base, a->offset); + /* + * Clear least-significant four bits of the effective + * address, effectively creating an aligned address. + */ + tcg_gen_andi_tl(addr, addr, ~0xf); + + /* Lower half */ + tcg_gen_qemu_ld_i64(t0, addr, ctx->mem_idx, MO_TEQ); + gen_store_gpr(t0, a->rt); + + /* Upper half */ + tcg_gen_addi_i64(addr, addr, 8); + tcg_gen_qemu_ld_i64(t0, addr, ctx->mem_idx, MO_TEQ); + gen_store_gpr_hi(t0, a->rt); + + tcg_temp_free(t0); + tcg_temp_free(addr); + + return true; +} + /* * Multiply and Divide (19 instructions) * ------------------------------------- --=20 2.31.1