From nobody Tue Feb 10 06:07:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) client-ip=209.85.128.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1625939402; cv=none; d=zohomail.com; s=zohoarc; b=WbBSF8kSRmJdom6OcDUlUUNK3qO8E8aejIG8o+Le7jFtO3vKhz8MYzY6Fq55Ry7STL6saE2oqdCXS3hp09SEDj+ngttQHlnZPv+rML/RF2xfn2nx58xoGNoxz4Z56uv9tlf7RhtO3ObAI0SUqMFrkAhfTQsp9j7RIEa9SlXjpfo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625939402; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=3MSEzATk19r9ft3099Sl+079BzMi8xPFVuglcUqce0A=; b=ljwGCl8yWQq/KI4bn8yh8moFtiKHNTqIc5rFm/rOSui2Ha1tsut/d3Adcwxbbt296NU4qZX1knTyVcfMj7roAvHdx3Ef1N43ArI8vD61KEeTwbrOHPiS4+wBWIfIz/xfrKFILy/XkmIYdcYYJY2ug8OAeTzn1Mlx1ZQjJ1AgtJs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mx.zohomail.com with SMTPS id 1625939402973937.8659317070824; Sat, 10 Jul 2021 10:50:02 -0700 (PDT) Received: by mail-wm1-f53.google.com with SMTP id a5-20020a7bc1c50000b02901e3bbe0939bso8361044wmj.0 for ; Sat, 10 Jul 2021 10:50:02 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id d24sm15256012wmb.42.2021.07.10.10.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Jul 2021 10:50:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3MSEzATk19r9ft3099Sl+079BzMi8xPFVuglcUqce0A=; b=qJkguGvVzi7FEApAaAcgwMnwJaM9Vpjt04icrlx4661EiitfEp6IsvHs7EzpBBdWAe IELhp0gF+CbsDnasAJsvaoK+kV0creI2ZzfCUT/SfLVqEIlcu30ME25zMnZLUAKOr/0A 9FnmzCwnUOrd4ILHwzrb9Tx9Knc+glaW/3Q4jlNErjKsyeRNGk5xte6+WQwWOQfhN6vN 45xZM4GFdW2hRZ1Gh18poxesxaMaTWv6jrKEa15tCdWsDddo3Ed3M1hgcBuQ9wG1ICg9 wso3biWogGNuAD0hccDE5CLNrQUCRGWG71Ljq9cxnfUnPWoyyOYJm5bIRyfRJEt5sAyM eYEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=3MSEzATk19r9ft3099Sl+079BzMi8xPFVuglcUqce0A=; b=IXJDbvoHZ0Y8A93p4azX6walq9NWcb7HqpgEP14JA2CEbQqSHQf0XP94scu4rvG1rG dUg+0njMc6dgrxhKepSpb8uwAhyiFTKalhR4CaMWJSX0aUo8cGVB7VwHg4Gigf01t7e3 ee7nrlB161binVhRJUsGmTHa0hEAed3Sp0L+XOufS+bdRVk+BELFq9sgTAPCRK4QdcUm EEZummC/GTKaKBmAc/GO9xua9u9hz/v2529eO6yebwHYjACnzAZ/doOFeiVOYjwA//VH LYct4mcStRd5UqBTFSO1+OvydFHwEfYT4W4IDtpOUxNSsZhrOm6xUH0cj/8QHaJ2cUHz lZww== X-Gm-Message-State: AOAM533UgOQs1v5ScbJAxFf5Hw5VUbmO71pJHVcPLy5UsCRJekZNxyet JDb516i1/stRIUsu2Bf4iYo= X-Google-Smtp-Source: ABdhPJz8LMWAQ6yp3Yim3aNFMwk23UJNcecX/C8uTCr1uKeSJ7ArKDW72RZysUefPQOSM/Il/TWdGQ== X-Received: by 2002:a1c:f616:: with SMTP id w22mr5401227wmc.73.1625939401220; Sat, 10 Jul 2021 10:50:01 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Finn Thain , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Laurent Vivier , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 1/8] dp8393x: Replace address_space_rw(is_write=1) by address_space_write() Date: Sat, 10 Jul 2021 19:49:47 +0200 Message-Id: <20210710174954.2577195-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210710174954.2577195-1-f4bug@amsat.org> References: <20210710174954.2577195-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1625939404544100001 Replace address_space_rw(is_write=3D1) by address_space_write() and remove pointless cast. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mark Cave-Ayland --- hw/net/dp8393x.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 11810c9b600..9118364aa33 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -816,8 +816,8 @@ static ssize_t dp8393x_receive(NetClientState *nc, cons= t uint8_t * buf, size =3D sizeof(uint16_t) * width; address =3D dp8393x_crda(s) + sizeof(uint16_t) * 6 * width; dp8393x_put(s, width, 0, 0); - address_space_rw(&s->as, address, MEMTXATTRS_UNSPECIFIED, - (uint8_t *)s->data, size, 1); + address_space_write(&s->as, address, MEMTXATTRS_UNSPECIFIED, + s->data, size); =20 /* Move to next descriptor */ s->regs[SONIC_CRDA] =3D s->regs[SONIC_LLFA]; @@ -846,8 +846,8 @@ static ssize_t dp8393x_receive(NetClientState *nc, cons= t uint8_t * buf, /* Pad short packets to keep pointers aligned */ if (rx_len < padded_len) { size =3D padded_len - rx_len; - address_space_rw(&s->as, address, MEMTXATTRS_UNSPECIFIED, - (uint8_t *)"\xFF\xFF\xFF", size, 1); + address_space_write(&s->as, address, MEMTXATTRS_UNSPECIFIED, + "\xFF\xFF\xFF", size); address +=3D size; } =20 --=20 2.31.1