From nobody Sat May 11 09:33:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16258626677491019.6127083096637; Fri, 9 Jul 2021 13:31:07 -0700 (PDT) Received: from localhost ([::1]:47868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1x9O-0000Tv-1O for importer@patchew.org; Fri, 09 Jul 2021 16:31:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x6y-00066x-Dn; Fri, 09 Jul 2021 16:28:36 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:43969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x6w-0007UH-I4; Fri, 09 Jul 2021 16:28:36 -0400 Received: from quad ([82.142.13.34]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MLi4c-1lkQE00oIS-00HdTf; Fri, 09 Jul 2021 22:28:28 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 1/9] qemu-option: Drop dead assertion Date: Fri, 9 Jul 2021 22:28:16 +0200 Message-Id: <20210709202824.578187-2-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210709202824.578187-1-laurent@vivier.eu> References: <20210709202824.578187-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:C85UoByGekINlbVDkwSfQpHnZimm1VjD1LIr83d6DbrBOeF4xjG WyFE4fASbiFJoV3e8ZzKwG49xZQiV6RPsJE0VSiJM7rxVegiQt7arG7uGTn8t5X+Q/ZC1jl 7sanuohN/pnquftTsMB3O9rqpttjysm2/YlKLxDyoWW/q178g375+wW0+3I5jyE+dv5FlhH RUZ1MaqN29Q5zM0d0qGSQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:wa+IYLq7/vE=:4PYa1i1jXL9JzyckMVveNo jCrati/28tczNPfVrA9uL3yQ0DrBhDlyAKjEtDDWgTzL4DrARuPGuvvcjxgMXUKZuqPXXbyT6 YEzB1ztGNmf5mQG00rCLDlpzzfgrKyxQvAm7/aZneDTGNh9TT2RboaLxshs8OTCWwRJLH3+5A R9y06WLJNA5djVhzgOvZ6XJPQxqvulu8Ch5oUS1NGPvS8M5cvinN4KePgoF2Rd8OSWGgzdNN8 VWGM04gNbN+ppeSoGwpUl+RQbA/dyF4yHtbfhSlmbGecjA6HQ8yzt8G1XVPdihBQ6fe5b4rey qcqC9JCSYIt2aQgok3j0zPN+xwn3FBprlUE3ZW9ZIPP0+Rd3UPqG//Zayqyc9oOAPFBxqha1f Ojml44VGZ93bN3B9bkWAlLkOImyNlljrobEnBjQOEe8ShAT60yM4r1esYn7omzBY88T9ZKXvg i+ogKMatLbI6SaH/mimjAY3zpqGgaO8dYwTE1sDuBLzJwVUnq8u3NlafdzET/5FIUDhbdmcW3 X8RfRpkz9ZQE+0SvX/UD9sHDCLGAYryN1X9kRl/qJ6b7mcQXbF1g+pWdPk5xUhW9cOA2yjLZH ujoLRxdq32YNOqzxvJjCQ/ai2DAwcoqhghnt5JSGfmQgodPRPiqOQfOliQvudOva+G0mQ3Fz5 WGR+opjEy4pfhT/8b2fJvRO7hf9SCqkGZZX1+8u5oAYCDnoNElYikoiQ5HmzGAZLVeow2TQ2Z wPq60EZUGfWXfWZokvgPvJEKqmBZhVXidb1r7P0c/pgSVNNsp06uQVjku56R9K9YHH5hGTxiw FDvo4eDb+4asx5v1Hqb1ikpVKHa93RumLgJ6rTBa6rzU6Nq/I3Y0EojTFtjjfcYVE1Z4tng Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Thomas Huth , Michael Tokarev , Laurent Vivier , Markus Armbruster Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1625862669463100003 Content-Type: text/plain; charset="utf-8" From: Markus Armbruster Commit c6ecec43b2 "qemu-option: Check return value instead of @err where convenient" simplified opts =3D qemu_opts_create(list, qdict_get_try_str(qdict, "id"), 1, &local_err); if (local_err) { error_propagate(errp, local_err); return NULL; } to opts =3D qemu_opts_create(list, qdict_get_try_str(qdict, "id"), 1, errp= ); if (!opts) { return NULL; } but neglected to delete assert(opts !=3D NULL); Do that now. Signed-off-by: Markus Armbruster Reviewed-by: Thomas Huth Message-Id: <20210610085026.436081-1-armbru@redhat.com> Signed-off-by: Laurent Vivier --- util/qemu-option.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/util/qemu-option.c b/util/qemu-option.c index ee78e42216cc..61cb4a97bdb6 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -997,8 +997,6 @@ QemuOpts *qemu_opts_from_qdict(QemuOptsList *list, cons= t QDict *qdict, return NULL; } =20 - assert(opts !=3D NULL); - for (entry =3D qdict_first(qdict); entry; entry =3D qdict_next(qdict, entry)) { --=20 2.31.1 From nobody Sat May 11 09:33:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625862667651472.905257141074; Fri, 9 Jul 2021 13:31:07 -0700 (PDT) Received: from localhost ([::1]:47882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1x9N-0000UC-Uj for importer@patchew.org; Fri, 09 Jul 2021 16:31:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x6z-00068l-0a; Fri, 09 Jul 2021 16:28:37 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:58073) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x6x-0007Ua-8D; Fri, 09 Jul 2021 16:28:36 -0400 Received: from quad ([82.142.13.34]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N79q6-1l5Y5g3Hmm-017Syl; Fri, 09 Jul 2021 22:28:28 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 2/9] memory: Display MemoryRegion name in read/write ops trace events Date: Fri, 9 Jul 2021 22:28:17 +0200 Message-Id: <20210709202824.578187-3-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210709202824.578187-1-laurent@vivier.eu> References: <20210709202824.578187-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:+JiSKhJQ1fkJGmI7CYC2rkPMuSlNEiCmDEycVEZ8IzliXYGVpLa Lfl1m0iSBOpTmjX7xoSKYQFHpx94cP+3rpR6GazCgg0fXRWdefHIj0r67PNgepoi+gaK9Xo +VAwhvFxryN5UTLimwHvnHA+HLy5uW718hvJAyQdz2aH5gvaXJWHaISxOubmuP77KQD5SL8 wj6ZKQIB6TuUd7cmvgl/g== X-UI-Out-Filterresults: notjunk:1;V03:K0:M+f8IyWKicg=:YRRcUhBgNKMQQiUaozo7AF 3zXHJerBYK3ywklh1rY8miDm9RVMz+GW8h4wmLbmuh+RXqrnac1RjexhePNxMW4xXGQ02+ZaT vwo/BVqn2LILcaE3QkFZr4lMw4hAykpGo+QbhHjZshII8C5/QgsP5ANUi+ReAvOhbzTamXM1Z dCh8pR7fMh6zqgGW66NxUY/cOTKrbIyvy3A6prhqu8UreO1lE1XNg21TF6a+ph73iZSR7Faw4 0EqaB9kxRIrw7vk+MBKbOiIt6XI0gvl8j0qIQ9iTNyn/VCF9iciUQ8//ozFISi+pAHedQn6Yi 23sUR4QNl4Nie40oMITNlT3FJmHJ5gsfIXJjz0cMs3HszuaJuX6fbuHHrNCt5L4GfUnr+mXdN tDMiuPA+2pBfgJRP0TkrA2RcN0FfB0NknCXnZdelhZidUmh9aF1BKrgjhYaIxPUeUnu/DyFd4 54GbzcgpT90l3cgvYqKPfXvZ+WzzjpGoB2Uypddc8ZRjRhaIRvnqIHJxig8nT/J6dL87y2ulz 5SH1cE+aaz+M2h4tmBMpckU9WjcoP6DV6CPDPD3dZURCl5/1esKjwpB8+c7gFklIkO7v9t4u/ mBpT1iHZ0V85P2RfV2g7iv2BagaSLxrorOKg0etAKooGgx8GhLrxzpA8rDQBgJG9uzGOiSzJQ Kg32gv3mbLDhKq8B3Q/W+7qDU3IOvgJRUBoSvdntUsdDEuEEdJfGLXMv4Q+NrjdP1B7gaH4eW Id8JravrSRMXcTIfV6UdX3k8a0tKgJNeUbY6M8B8XMVUwVVJN9WXYFyHPfe6DHxSuM3FDDV6s SwEYG7BW+38AhyaTppKQBHEs8/ZcjI3ar08tz3wdB/7LtiH26N/ABbCJeWb7MhArb/CAUK6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1625862669294100001 From: Philippe Mathieu-Daud=C3=A9 MemoryRegion names is cached on first call to memory_region_name(), so displaying the name is trace events is cheap. Add it for read / write ops. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier Message-Id: <20210307074833.143106-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- softmmu/memory.c | 12 ++++++++---- softmmu/trace-events | 4 ++-- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/softmmu/memory.c b/softmmu/memory.c index f0161515e96d..24a97c8b1f9a 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -442,7 +442,8 @@ static MemTxResult memory_region_read_accessor(MemoryR= egion *mr, trace_memory_region_subpage_read(get_cpu_index(), mr, addr, tmp, s= ize); } else if (trace_event_get_state_backends(TRACE_MEMORY_REGION_OPS_READ= )) { hwaddr abs_addr =3D memory_region_to_absolute_addr(mr, addr); - trace_memory_region_ops_read(get_cpu_index(), mr, abs_addr, tmp, s= ize); + trace_memory_region_ops_read(get_cpu_index(), mr, abs_addr, tmp, s= ize, + memory_region_name(mr)); } memory_region_shift_read_access(value, shift, mask, tmp); return MEMTX_OK; @@ -464,7 +465,8 @@ static MemTxResult memory_region_read_with_attrs_access= or(MemoryRegion *mr, trace_memory_region_subpage_read(get_cpu_index(), mr, addr, tmp, s= ize); } else if (trace_event_get_state_backends(TRACE_MEMORY_REGION_OPS_READ= )) { hwaddr abs_addr =3D memory_region_to_absolute_addr(mr, addr); - trace_memory_region_ops_read(get_cpu_index(), mr, abs_addr, tmp, s= ize); + trace_memory_region_ops_read(get_cpu_index(), mr, abs_addr, tmp, s= ize, + memory_region_name(mr)); } memory_region_shift_read_access(value, shift, mask, tmp); return r; @@ -484,7 +486,8 @@ static MemTxResult memory_region_write_accessor(MemoryR= egion *mr, trace_memory_region_subpage_write(get_cpu_index(), mr, addr, tmp, = size); } else if (trace_event_get_state_backends(TRACE_MEMORY_REGION_OPS_WRIT= E)) { hwaddr abs_addr =3D memory_region_to_absolute_addr(mr, addr); - trace_memory_region_ops_write(get_cpu_index(), mr, abs_addr, tmp, = size); + trace_memory_region_ops_write(get_cpu_index(), mr, abs_addr, tmp, = size, + memory_region_name(mr)); } mr->ops->write(mr->opaque, addr, tmp, size); return MEMTX_OK; @@ -504,7 +507,8 @@ static MemTxResult memory_region_write_with_attrs_acces= sor(MemoryRegion *mr, trace_memory_region_subpage_write(get_cpu_index(), mr, addr, tmp, = size); } else if (trace_event_get_state_backends(TRACE_MEMORY_REGION_OPS_WRIT= E)) { hwaddr abs_addr =3D memory_region_to_absolute_addr(mr, addr); - trace_memory_region_ops_write(get_cpu_index(), mr, abs_addr, tmp, = size); + trace_memory_region_ops_write(get_cpu_index(), mr, abs_addr, tmp, = size, + memory_region_name(mr)); } return mr->ops->write_with_attrs(mr->opaque, addr, tmp, size, attrs); } diff --git a/softmmu/trace-events b/softmmu/trace-events index d18ac41e4e34..7b278590a0e2 100644 --- a/softmmu/trace-events +++ b/softmmu/trace-events @@ -9,8 +9,8 @@ cpu_in(unsigned int addr, char size, unsigned int val) "add= r 0x%x(%c) value %u" cpu_out(unsigned int addr, char size, unsigned int val) "addr 0x%x(%c) val= ue %u" =20 # memory.c -memory_region_ops_read(int cpu_index, void *mr, uint64_t addr, uint64_t va= lue, unsigned size) "cpu %d mr %p addr 0x%"PRIx64" value 0x%"PRIx64" size %= u" -memory_region_ops_write(int cpu_index, void *mr, uint64_t addr, uint64_t v= alue, unsigned size) "cpu %d mr %p addr 0x%"PRIx64" value 0x%"PRIx64" size = %u" +memory_region_ops_read(int cpu_index, void *mr, uint64_t addr, uint64_t va= lue, unsigned size, const char *name) "cpu %d mr %p addr 0x%"PRIx64" value = 0x%"PRIx64" size %u name '%s'" +memory_region_ops_write(int cpu_index, void *mr, uint64_t addr, uint64_t v= alue, unsigned size, const char *name) "cpu %d mr %p addr 0x%"PRIx64" value= 0x%"PRIx64" size %u name '%s'" memory_region_subpage_read(int cpu_index, void *mr, uint64_t offset, uint6= 4_t value, unsigned size) "cpu %d mr %p offset 0x%"PRIx64" value 0x%"PRIx64= " size %u" memory_region_subpage_write(int cpu_index, void *mr, uint64_t offset, uint= 64_t value, unsigned size) "cpu %d mr %p offset 0x%"PRIx64" value 0x%"PRIx6= 4" size %u" memory_region_ram_device_read(int cpu_index, void *mr, uint64_t addr, uint= 64_t value, unsigned size) "cpu %d mr %p addr 0x%"PRIx64" value 0x%"PRIx64"= size %u" --=20 2.31.1 From nobody Sat May 11 09:33:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625863113302847.2123344607674; Fri, 9 Jul 2021 13:38:33 -0700 (PDT) Received: from localhost ([::1]:39564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1xGa-0005OT-04 for importer@patchew.org; Fri, 09 Jul 2021 16:38:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x77-0006Zq-TI; Fri, 09 Jul 2021 16:28:45 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:60251) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x75-0007ZC-Q9; Fri, 09 Jul 2021 16:28:45 -0400 Received: from quad ([82.142.13.34]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MLR5h-1llFRG2Ijb-00ISQK; Fri, 09 Jul 2021 22:28:29 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 3/9] misc: Fix "havn't" typo Date: Fri, 9 Jul 2021 22:28:18 +0200 Message-Id: <20210709202824.578187-4-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210709202824.578187-1-laurent@vivier.eu> References: <20210709202824.578187-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:fiji7J95S0VPK22FvbcrUoEtqfg2bHGGldJ4mXbCkcnKOud9wHH Hwown/70qQir91+ZBO9CHZ7CMSExUPD2EnlZsHh0G4qBak1Uc5S7MDlq4VPkn24rI8g5xKe UzVuce2+EMYKcaQwpky5nc1dYsHlBXFsR6seWCsjhA+wGilFNgJcL+VA3+v6LcUV/uThHXC ZRg5sbVRiY4WlKnPHWwhw== X-UI-Out-Filterresults: notjunk:1;V03:K0:4Fbirk5JePc=:1nSig/NJeYwQ/z1A5aTaAY Y0pAei8v3ZKkSY6bBPOUAhEbuabWIfCBaPeQbBp2wQv/WZOnhNQ9UpewRqDfsV3AvmuXLkLML A0UHqdKvmdIkEUxxggofMt/KUYoMh3ReIaUidbK4s2MkNsFHgLSYPIp7GmxIMA8IhSY1Wb1HP S5jsn7d98hHjExZq7oYtv37826w1jDPZ8ZimlUAsa3XbE60ir89UtOwLn/30xyaFEs8/KlwdT WGVVP/rtSL/QcqHPgJMWdOIfbAYmo8lNzZf58+2XCodOp1DO5bTcL3S7tKhkV2QFa+BtcAw+H U+RyzoAJV9N6/+VLzCepoMcVftr23tDSpr0SP1Ev5qGonzFAw5GjO73yZ54kM4Nuk2A45vZUj oCJLIThWfUE2RLgMe69ZRc4D+vH4YOhELMaJsI53UDg5+IkpSpNuQQJRcjFsZmB5DYv4VTo6r qX3q/vyMJlwNkWAxkVne/8AbCUf/XjcMyiDhEoaCq55mTLNnwZsbgh6kaxCBTNSMpVpc/eCH6 cXG6I3SfWBAlYbSrkbfuUNgrcbpAEb0/f8R5NH/Kcrq3hSldRn3a5JYtpHrXNT3TkIUMlOEgm aoemFoZ/TXaoW9zu99rvm4tAJEJh7wqa9VgZIYabaJC0hxphefPxHp3LShP1hvGoEgTrqpgAd EkPK6fMOax1RajYNx5JGoTwAeGxBFGSZJRbQrkIhQQPxnuLwCOKH4T3YBYBy9890KqxWtaB89 GAfawmZp/HFehTmhwgT6MAlSot+X5kF5oq+ypuvxjc1ZO0R8JB7MID+qn5KcAJIOz16AWIH93 FyBCuOrWSsNkWqDFGL7e8wKzqAfFmTWrU9KVjV7Ru0y5dVQ/92Tw88S/ijL/DSpr260duWL Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.73; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Luis Pires Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1625863115681100001 From: Philippe Mathieu-Daud=C3=A9 Fix "havn't (make)" -> "haven't (made)" typo. Reviewed-by: Luis Pires Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Message-Id: <20210629051400.2573253-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/usb/desc-msos.c | 2 +- target/s390x/translate.c | 6 ++++-- tcg/arm/tcg-target.c.inc | 6 ++++-- tcg/sparc/tcg-target.c.inc | 6 ++++-- tcg/tcg-op.c | 2 +- 5 files changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/usb/desc-msos.c b/hw/usb/desc-msos.c index 3a5ad7c8d0f8..836e38c67e1e 100644 --- a/hw/usb/desc-msos.c +++ b/hw/usb/desc-msos.c @@ -181,7 +181,7 @@ static int usb_desc_msos_prop(const USBDesc *desc, uint= 8_t *dest) =20 if (desc->msos->Label) { /* - * Given as example in the specs. Havn't figured yet where + * Given as example in the specs. Haven't figured yet where * this label shows up in the windows gui. */ length +=3D usb_desc_msos_prop_str(dest+length, MSOS_REG_SZ, diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 03dab9f3507a..8822603a6e7d 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -6270,8 +6270,10 @@ static void extract_field(DisasFields *o, const Disa= sField *f, uint64_t insn) abort(); } =20 - /* Validate that the "compressed" encoding we selected above is valid. - I.e. we havn't make two different original fields overlap. */ + /* + * Validate that the "compressed" encoding we selected above is valid. + * I.e. we haven't made two different original fields overlap. + */ assert(((o->presentC >> f->indexC) & 1) =3D=3D 0); o->presentC |=3D 1 << f->indexC; o->presentO |=3D 1 << f->indexO; diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc index 7a761a602e2c..007ceee68e23 100644 --- a/tcg/arm/tcg-target.c.inc +++ b/tcg/arm/tcg-target.c.inc @@ -2407,8 +2407,10 @@ static TCGConstraintSetIndex tcg_target_op_def(TCGOp= code op) =20 static void tcg_target_init(TCGContext *s) { - /* Only probe for the platform and capabilities if we havn't already - determined maximum values at compile time. */ + /* + * Only probe for the platform and capabilities if we haven't already + * determined maximum values at compile time. + */ #if !defined(use_idiv_instructions) || !defined(use_neon_instructions) { unsigned long hwcap =3D qemu_getauxval(AT_HWCAP); diff --git a/tcg/sparc/tcg-target.c.inc b/tcg/sparc/tcg-target.c.inc index a6ec94a094fa..688827968b02 100644 --- a/tcg/sparc/tcg-target.c.inc +++ b/tcg/sparc/tcg-target.c.inc @@ -1690,8 +1690,10 @@ static TCGConstraintSetIndex tcg_target_op_def(TCGOp= code op) =20 static void tcg_target_init(TCGContext *s) { - /* Only probe for the platform and capabilities if we havn't already - determined maximum values at compile time. */ + /* + * Only probe for the platform and capabilities if we haven't already + * determined maximum values at compile time. + */ #ifndef use_vis3_instructions { unsigned long hwcap =3D qemu_getauxval(AT_HWCAP); diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 44d711c0fc4a..58a34b5147b5 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -2741,7 +2741,7 @@ void tcg_gen_goto_tb(unsigned idx) /* We only support two chained exits. */ tcg_debug_assert(idx <=3D TB_EXIT_IDXMAX); #ifdef CONFIG_DEBUG_TCG - /* Verify that we havn't seen this numbered exit before. */ + /* Verify that we haven't seen this numbered exit before. */ tcg_debug_assert((tcg_ctx->goto_tb_issue_mask & (1 << idx)) =3D=3D 0); tcg_ctx->goto_tb_issue_mask |=3D 1 << idx; #endif --=20 2.31.1 From nobody Sat May 11 09:33:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16258629229751002.3750094756996; Fri, 9 Jul 2021 13:35:22 -0700 (PDT) Received: from localhost ([::1]:59988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1xDV-00005z-Ri for importer@patchew.org; Fri, 09 Jul 2021 16:35:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x71-0006GX-J2; Fri, 09 Jul 2021 16:28:40 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:40725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x6z-0007Vq-Vt; Fri, 09 Jul 2021 16:28:39 -0400 Received: from quad ([82.142.13.34]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MrQMz-1lQ6370lb5-00oY7A; Fri, 09 Jul 2021 22:28:30 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 4/9] virtiofsd: Add missing newline in error message Date: Fri, 9 Jul 2021 22:28:19 +0200 Message-Id: <20210709202824.578187-5-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210709202824.578187-1-laurent@vivier.eu> References: <20210709202824.578187-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:9Vian2QjcDtP8ThPcT0I0Nv37G1saVYZFgcuhQrH41Ob+pXtPso kq9jnV7PFRublPzdF+jx4UrPEhqFJaPpaJI4tHgNmI8xrCnIHWMvmmkxhoNVJzaaHovczeL P/+tOarETBAmsMHph4luDUAhhVEqSjC5FMvFoQuijpSEdG7nKdgh/loDSlpubmnr6OPj8tX w84wnyrR/FSKa801lXbNg== X-UI-Out-Filterresults: notjunk:1;V03:K0:G9c0xHWL4e0=:3R5vWFpzF68LH8IAD9pCS2 bGBNRNk/DA+V6sD7Sg9dVEChLkVZHtNUtYiPhOdyVH0Ox7Ne2Fr6IGh2kjlgDb1/aIettTRhT YtQFZ/vGM9sNMwX7+5NpTyau8cXmXo2f4boAgX7RGYmbZLH0SBo3l+1Kwdnit4CgHvKcmasfd I7zC+Z/TNnyLC2iFySwTYORSRTKUkWc6u1Q5JOM2tZKjjQ+2N7IlluItloDVBQ+xoJ05GanPR Z7f7gRrS4NxCRk+J1hxA9VTx7Wq9WRNURz/3hRegnIefstSQF3cul1mtRzlpwtAXkxfkChbwV ROjEcK6NCiTsbU4r+y1Tm7Sg/QDRIJXqw4RhBRqts19uujyoPgb5Qf5UaHNYagiG5m6QH8y2M 24qdxHYYNbK+nTcaiX8a3Ojc9hnNX+KJNoAQ3Qa+gY3Xrm8Dy8ubgO0qfZMzBs7nxeOm7si1O lLbADifOCE+eZiEW7UvONJFwzDSlAQpWxEj0I1oRWQ8HSEW8cOiWv/MZOVS0QwaMMB/XRHmLJ yLDlRzUpEg8uFVw/2wreeJ6b2281DUCcj5iXO1CRwhC2K2lTlRAc5g1QXFoTr+cufT5kGnOwy r9XqpcBqpL9GK5pGfpfVDw4rfh4Qq+bxorvxQSLeqKcTnWtNQLc7Xv4zu5SV3rlRRPxMmwYYC IDpIc/pxgUfz1DJF612y1sjf+ftLGvvnQiiVW1n69w/DjXVVms/QbUyotGapLpYYL0JJo140E +Tya4SqOF4MaEOJxCxg8A+P7Rg71u2IisCOwqYEVnPB2/UWlo87UQesYNBi+DVEOlhDD35lGI XRqI0i5fslW1umFuXuc5q0azg/au3NAkj0wdXu9zZXmsDoQxNvlHJMOei/VOw8Ve+FPiO6P Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_BL=0.001, RCVD_IN_MSPIKE_L3=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hubert Jasudowicz , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Stefan Hajnoczi , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1625862924091100001 From: Hubert Jasudowicz Signed-off-by: Hubert Jasudowicz Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stefan Hajnoczi Message-Id: Signed-off-by: Laurent Vivier --- tools/virtiofsd/fuse_virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index fa4aff9b0ee8..fc2564a6033d 100644 --- a/tools/virtiofsd/fuse_virtio.c +++ b/tools/virtiofsd/fuse_virtio.c @@ -917,7 +917,7 @@ static bool fv_socket_lock(struct fuse_session *se) dir =3D qemu_get_local_state_pathname("run/virtiofsd"); =20 if (g_mkdir_with_parents(dir, S_IRWXU) < 0) { - fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s", + fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s\n", __func__, dir, strerror(errno)); return false; } --=20 2.31.1 From nobody Sat May 11 09:33:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625862799743498.5255656512769; Fri, 9 Jul 2021 13:33:19 -0700 (PDT) Received: from localhost ([::1]:53224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1xBW-000466-G6 for importer@patchew.org; Fri, 09 Jul 2021 16:33:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x72-0006IV-Il; Fri, 09 Jul 2021 16:28:40 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:52357) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x70-0007WA-GZ; Fri, 09 Jul 2021 16:28:40 -0400 Received: from quad ([82.142.13.34]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mg6mG-1lWSuW3JIE-00hicH; Fri, 09 Jul 2021 22:28:30 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 5/9] misc: Remove redundant new line in perror() Date: Fri, 9 Jul 2021 22:28:20 +0200 Message-Id: <20210709202824.578187-6-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210709202824.578187-1-laurent@vivier.eu> References: <20210709202824.578187-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:J6kOkAk+oPhRqAsrle/AXdwElsBIWnS618TcwQy75zMPk9BFr4i 4sJmvBDz4Z19DDfBwdwbsjmMWy+fpGG0PBDTReYGVjyrhUHctInobqedb+yupm9OzkpG+VA rlSXRzuai0R6wT/NFWJTQjUuXRQcWDytiED0UiHJsonqDI7FW4YpzOIEXL4w7vSp7D/wrVr J+32R5sxmi/V8A2jQCZQA== X-UI-Out-Filterresults: notjunk:1;V03:K0:X7BHhnCPEis=:a06GWP/V0JyYbliN+ZJV7G MGkcVv57zfSvnVjvnLSMU1Od1JZED1sZLe7bjFntaWJ2qsXBfMEgsJnOfYPtoMiczUpeY8DhK iPfJxct9ZQmAz/mpnIcdSzbV6M7CwPBl6FOg3q3vPMwAXyPlPKj86hMI3gAOxw9BgCmzt9RX9 vNNmgNRvZW3n2QfOYr5TmKhwCbjjI4hwlwDeqbs7gEY+IG5GsViKMWpF4W9Eu0nY5gc5weo4b THrN3niKRPB25wDavg4McU1DZjWX7xSHjhBdX896S93XearD59+Ot73igC4KuE27YsbdgO1fm 2VZhrslgrF6X4K+3XlQ4sb6EVyIMK3b5FDmOJ8hbDqFE3f782/7//hRrBNxQHptrxhNlX08Cd Km8brrnwYmWdAoKY8RPwkGFVej4dqPwh6sJPYlOP8tJBtMlUUdSSNmGtEX07fMfYYYlG0Cm/j 99PreTqwr2OPCR/O5f+ID/DBFc3fjuTyMKU4dsIOpAMBeYrUiq3165K0rBiNNFT46VIVy0Gcg DzUKDJbDWcbCKsk+VyG9GzHKbOTgLqbJJGfQDgAayZhbw2qaCuTGlX5sFjByAXFv5NT30SLUO nsj4NW3LMMd+CFDUIMJyuvh0tH4Nefyc3ndyoNSsr7tNLgh8mGiM87dv2pkBYoWq9bSEoFryQ Rnbom0kjAkfVFz5fPoT5wYb3clnxeCvw0fKIcGMBNZO29YziHY+NuT2plR0qzH54mJtKp4v5Z fywdcDMb+ehh2N4ibC+KqLhFCRcD6utBmENPWig5Rvi9dQJHK7VxSQS+/emaOJpVf7RCcGCIS std9BbHxc6RWcFvoEY0xv0HvFqbHrwaN4AE0DwHokpUzbA/65XfRGRpKigPybQYLtJ28fec Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.13; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_BL=0.001, RCVD_IN_MSPIKE_L3=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Tokarev , Laurent Vivier , Li Zhijian Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1625862800757100001 From: Li Zhijian Signed-off-by: Li Zhijian Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210706094433.1766952-1-lizhijian@cn.fujitsu.com> Signed-off-by: Laurent Vivier --- migration/rdma.c | 2 +- softmmu/cpus.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index b6cc4bef4a8e..38a099f7eec0 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -1131,7 +1131,7 @@ static int qemu_rdma_reg_whole_ram_blocks(RDMAContext= *rdma) IBV_ACCESS_REMOTE_WRITE ); if (!local->block[i].mr) { - perror("Failed to register local dest ram block!\n"); + perror("Failed to register local dest ram block!"); break; } rdma->total_registrations++; diff --git a/softmmu/cpus.c b/softmmu/cpus.c index c3caaeb26ec1..071085f840b0 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -325,7 +325,7 @@ static void sigbus_reraise(void) sigaddset(&set, SIGBUS); pthread_sigmask(SIG_UNBLOCK, &set, NULL); } - perror("Failed to re-raise SIGBUS!\n"); + perror("Failed to re-raise SIGBUS!"); abort(); } =20 --=20 2.31.1 From nobody Sat May 11 09:33:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625862853585134.9999619317939; Fri, 9 Jul 2021 13:34:13 -0700 (PDT) Received: from localhost ([::1]:56500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1xCO-0006FZ-GV for importer@patchew.org; Fri, 09 Jul 2021 16:34:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x6z-0006AK-Jp; Fri, 09 Jul 2021 16:28:37 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:59801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x6x-0007Uw-FO; Fri, 09 Jul 2021 16:28:37 -0400 Received: from quad ([82.142.13.34]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MJV9S-1liEMh1MWu-00JqP5; Fri, 09 Jul 2021 22:28:31 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 6/9] hw/virtio: Document *_should_notify() are called within rcu_read_lock() Date: Fri, 9 Jul 2021 22:28:21 +0200 Message-Id: <20210709202824.578187-7-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210709202824.578187-1-laurent@vivier.eu> References: <20210709202824.578187-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:C6OHJj5D0XQZuQpLW3xomHX72aiL7JorBTC/WVgaq0MH8wBrb0r mPTs6ydho4Qw49cPUGzdnw6CCkFA1XaxflXBupKi7kTPwlPaZdl1RNDIK80XpoK9XZKVB/B mM6xeu/TlPYMD+XQCgcG/OjqHHOiNxC/oBzyhdcISoLDwI+DLjU6n4uHuMAgHFnjT/1dmY6 v5hBXee/fQ/ckSLEybVWA== X-UI-Out-Filterresults: notjunk:1;V03:K0:BsSTyS9ruLI=:bJF2ZR/aPVGzw2EloZbw8R vkYO7jCuSLYNu5W/1ky3ODeV/EPa9V/fBJItl6nA+Whj1guULZ683RO+4A/iDS383Juk3k5q3 5oAsWWgeiV6xFHezakbgUY7laOlKLERmi2xkTKxhFzSAz+AqP4GyVjJOuT84yKm6bVbDG/lUQ g7MAnAMMicI5WAnRnd0PgBLuvt9eLkVS96SxG4E7MjyO0+gut/2BK1FUa5Eugq2Qaskumq3Y5 LshgyptiaOaluAHKmbsyzLDXRMIQSwfN13Q7duCC5UMZnxHIHkKnVPmWEly+Mx26lpskeRRIg FFmR0mnzP5id3KKRA0HCcgqKUPn7k4UfOEHvd3b4Gi1Lu2VvZtzxRazXvvaSlpvw4otnkPujB B5yiA9Uzujszy4qojx3MZijk/a97E8839/jHVPTPOlrefSZtcHi45GiRtsct8VnjjUMs9hfPm RggYR4+xVMxralyGjevtZbhjwb9UaE4BNgMct5KoSjZfkEkbsYgstgti2uDzGnZFdDCBa8Lwu 1xb96h61vZIcAKDs9QDmWLHyNwIVawHgtkSFZNMpww+tniyad+jd5zo5Lf/53AedjLMhGS+DV 4IB/WC/nWot1TYFyJZBfN7UpV8EsLte5YR9ic0bsZ/Wu4gVVgfs2Y8xd4evWKo/99C+1ZyodL oX2mq1Wq/zRHaDah/Shsw5heH56dHqzow5484WDgA8XTCekYo0Eg2QpIAUdV2zfxgPsuFFay9 T8fA4PiI28zCyPTrdYxd0X3xB6rdvphGjlPjHYQWg3QDv+OFjFo3oJWXlAnuqYTrbbDElHKWr owM0wkftrLPJ/WrGVJvB7MlsGCY5uAjTjO3to3kUZA2M1OW7+Jlp+K5W9nyxEZqQh3bRzEJ Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.13; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_BL=0.001, RCVD_IN_MSPIKE_L3=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Tokarev , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1625862854874100001 From: Philippe Mathieu-Daud=C3=A9 Such comments make reviewing this file somehow easier. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier Message-Id: <20210523094040.3516968-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/virtio/virtio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 6dcf3baf56b7..874377f37a70 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -2447,6 +2447,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int va= lue) } } =20 +/* Called within rcu_read_lock(). */ static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq) { uint16_t old, new; @@ -2483,6 +2484,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bo= ol wrap, return vring_need_event(off, new, old); } =20 +/* Called within rcu_read_lock(). */ static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq) { VRingPackedDescEvent e; --=20 2.31.1 From nobody Sat May 11 09:33:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625862953418298.6972563574956; Fri, 9 Jul 2021 13:35:53 -0700 (PDT) Received: from localhost ([::1]:33690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1xE0-0001PM-DN for importer@patchew.org; Fri, 09 Jul 2021 16:35:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x73-0006MY-O6; Fri, 09 Jul 2021 16:28:42 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:35843) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x71-0007X0-Pq; Fri, 09 Jul 2021 16:28:41 -0400 Received: from quad ([82.142.13.34]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MWRZt-1lebal0N0V-00Xqe0; Fri, 09 Jul 2021 22:28:32 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 7/9] target/xtensa/xtensa-semi: Fix compilation problem on Haiku Date: Fri, 9 Jul 2021 22:28:22 +0200 Message-Id: <20210709202824.578187-8-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210709202824.578187-1-laurent@vivier.eu> References: <20210709202824.578187-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:MQSXHUsX0woclw4HIMUHiRVfSE/jYaJeaH1z0Cqytp1uvkj5Q05 +iv3ONPMHC5ZWAb+xRWAon3KOLa9VHCaA7qdRTL1cy5rFBjwDk+vZqpHckyQw5gmjGCsdcS MAJrkLJnDjzN+7PdAQ2M96N3jkGtme9R2HO0+vjGeb1KgWVig3CzIjPvU206ozOGltmEOXf nXMYujbGWaQ2lxLEm09iA== X-UI-Out-Filterresults: notjunk:1;V03:K0:NJgHbCqVIaY=:7eMEc4PRIw7F+9L6yyW2y2 l35OtEkLm97HBiOxX+snQLfVUeMdphDaY8d89i3G/Vt89USL0L1Ty+f1T/UBWIECklcdsjyvm BvbSGvPr1esRo10nTXBJoaiQqlcfc+BJpPrQUrhTOeczzg+PSq2Lhr+hQ2TGuKNw2MPdxXEO5 2u1l/iBwQbJ2HZblHWt3uS3bg9iXoEyExIUBpKhsXXbs/87bG2Qq9EaXcJuPSOkPyNeJ4uj4X SzxpMT4HwKKHlvlXB1HOsKJtZhJ/EOGBmQWGVjxn4wqICPcGsZygB9GYlrIKLtB69VgGVSJbB Vi57w7WimNZr6avivgZdxgNxckf4XISm6cr2tcAXhYIAg8MKXK/3BnaEkGzlpOk2j3RUHEjdg s11nfx9feDQhgh1osLGhLxa7Z4gKkq82N/0b68/wUA46audbgnQaywmcFTpahx0i9odZVPfav Pr80g3zs+JmD2Ca2QWIQOFAqJE+jpXQYZh2Eamgt9q5vueXbnsCWeaf6gs8AA54TvlMs2s3Qz 7nzPBUeDLG+kMYxQ3ZOZkIEJd0/Kj5aJQB8qqzXZqvgFaA2pEfOTwjxafhPdEDq4eb7N9nzso l0kHs/Th0afEjTQsFlaoAFqQPyPLxOpfjZ2766092B35H7+fpNNcpJZhRtSpCQbPsaHdx/znF Vmj5kGH7N3aoFqquHUcuXUZHtAdGA4asujuWv3jXFAmuKTL2OlJ9eTUPFT2/76SMDZrod8pXH zkUnmZuvLSUbUDdK7Fa93d2qLawPTTsT7AKzIDIpLk5BsrNcE77xsdzY9JqzuwcDFIVaU0K4b 9UsrFsaoL45oviX77sshV05vwpbO1GWPnfyD6lgvFveYCgq3A5lT8/QwQ6CNgRElPws2l7h Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.24; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_BL=0.001, RCVD_IN_MSPIKE_L3=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Max Filippov , qemu-trivial@nongnu.org, Richard Henderson , Michael Tokarev , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Zak Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1625862955104100001 From: Thomas Huth The errno numbers are very large on Haiku, so the linking currently fails there with a "final link failed: memory exhausted" error message. We should not use the errno number as array indexes here, thus convert the code to a switch-case statement instead. A clever compiler should be able to optimize this code in a similar way anway. Reported-by: Richard Zak Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Max Filippov Reviewed-by: Richard Henderson Message-Id: <20210706081822.1316551-1-thuth@redhat.com> Signed-off-by: Laurent Vivier --- target/xtensa/xtensa-semi.c | 84 +++++++++++++++++-------------------- 1 file changed, 39 insertions(+), 45 deletions(-) diff --git a/target/xtensa/xtensa-semi.c b/target/xtensa/xtensa-semi.c index 79f2b043f233..fa21b7e11fc2 100644 --- a/target/xtensa/xtensa-semi.c +++ b/target/xtensa/xtensa-semi.c @@ -95,59 +95,53 @@ enum { =20 static uint32_t errno_h2g(int host_errno) { - static const uint32_t guest_errno[] =3D { - [EPERM] =3D TARGET_EPERM, - [ENOENT] =3D TARGET_ENOENT, - [ESRCH] =3D TARGET_ESRCH, - [EINTR] =3D TARGET_EINTR, - [EIO] =3D TARGET_EIO, - [ENXIO] =3D TARGET_ENXIO, - [E2BIG] =3D TARGET_E2BIG, - [ENOEXEC] =3D TARGET_ENOEXEC, - [EBADF] =3D TARGET_EBADF, - [ECHILD] =3D TARGET_ECHILD, - [EAGAIN] =3D TARGET_EAGAIN, - [ENOMEM] =3D TARGET_ENOMEM, - [EACCES] =3D TARGET_EACCES, - [EFAULT] =3D TARGET_EFAULT, + switch (host_errno) { + case 0: return 0; + case EPERM: return TARGET_EPERM; + case ENOENT: return TARGET_ENOENT; + case ESRCH: return TARGET_ESRCH; + case EINTR: return TARGET_EINTR; + case EIO: return TARGET_EIO; + case ENXIO: return TARGET_ENXIO; + case E2BIG: return TARGET_E2BIG; + case ENOEXEC: return TARGET_ENOEXEC; + case EBADF: return TARGET_EBADF; + case ECHILD: return TARGET_ECHILD; + case EAGAIN: return TARGET_EAGAIN; + case ENOMEM: return TARGET_ENOMEM; + case EACCES: return TARGET_EACCES; + case EFAULT: return TARGET_EFAULT; #ifdef ENOTBLK - [ENOTBLK] =3D TARGET_ENOTBLK, + case ENOTBLK: return TARGET_ENOTBLK; #endif - [EBUSY] =3D TARGET_EBUSY, - [EEXIST] =3D TARGET_EEXIST, - [EXDEV] =3D TARGET_EXDEV, - [ENODEV] =3D TARGET_ENODEV, - [ENOTDIR] =3D TARGET_ENOTDIR, - [EISDIR] =3D TARGET_EISDIR, - [EINVAL] =3D TARGET_EINVAL, - [ENFILE] =3D TARGET_ENFILE, - [EMFILE] =3D TARGET_EMFILE, - [ENOTTY] =3D TARGET_ENOTTY, + case EBUSY: return TARGET_EBUSY; + case EEXIST: return TARGET_EEXIST; + case EXDEV: return TARGET_EXDEV; + case ENODEV: return TARGET_ENODEV; + case ENOTDIR: return TARGET_ENOTDIR; + case EISDIR: return TARGET_EISDIR; + case EINVAL: return TARGET_EINVAL; + case ENFILE: return TARGET_ENFILE; + case EMFILE: return TARGET_EMFILE; + case ENOTTY: return TARGET_ENOTTY; #ifdef ETXTBSY - [ETXTBSY] =3D TARGET_ETXTBSY, + case ETXTBSY: return TARGET_ETXTBSY; #endif - [EFBIG] =3D TARGET_EFBIG, - [ENOSPC] =3D TARGET_ENOSPC, - [ESPIPE] =3D TARGET_ESPIPE, - [EROFS] =3D TARGET_EROFS, - [EMLINK] =3D TARGET_EMLINK, - [EPIPE] =3D TARGET_EPIPE, - [EDOM] =3D TARGET_EDOM, - [ERANGE] =3D TARGET_ERANGE, - [ENOSYS] =3D TARGET_ENOSYS, + case EFBIG: return TARGET_EFBIG; + case ENOSPC: return TARGET_ENOSPC; + case ESPIPE: return TARGET_ESPIPE; + case EROFS: return TARGET_EROFS; + case EMLINK: return TARGET_EMLINK; + case EPIPE: return TARGET_EPIPE; + case EDOM: return TARGET_EDOM; + case ERANGE: return TARGET_ERANGE; + case ENOSYS: return TARGET_ENOSYS; #ifdef ELOOP - [ELOOP] =3D TARGET_ELOOP, + case ELOOP: return TARGET_ELOOP; #endif }; =20 - if (host_errno =3D=3D 0) { - return 0; - } else if (host_errno > 0 && host_errno < ARRAY_SIZE(guest_errno) && - guest_errno[host_errno]) { - return guest_errno[host_errno]; - } else { - return TARGET_EINVAL; - } + return TARGET_EINVAL; } =20 typedef struct XtensaSimConsole { --=20 2.31.1 From nobody Sat May 11 09:33:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 162586285392024.1333636207263; Fri, 9 Jul 2021 13:34:13 -0700 (PDT) Received: from localhost ([::1]:56494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1xCO-0006FL-Si for importer@patchew.org; Fri, 09 Jul 2021 16:34:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60486) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x71-0006GE-Di; Fri, 09 Jul 2021 16:28:40 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:38049) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x6z-0007Vo-MI; Fri, 09 Jul 2021 16:28:39 -0400 Received: from quad ([82.142.13.34]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MIdW7-1lysZ33D0P-00EfKg; Fri, 09 Jul 2021 22:28:32 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 8/9] migration: fix typo in mig_throttle_guest_down comment Date: Fri, 9 Jul 2021 22:28:23 +0200 Message-Id: <20210709202824.578187-9-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210709202824.578187-1-laurent@vivier.eu> References: <20210709202824.578187-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:oXVPglt6mps3jCSq/Q0dyi0M2/mgnhiADI7+fO2lNJrk05T9kBE U3Gpg/uxsPmryPX9L9aOhR/LSbwDSO6MqFJp4Afb/NoeEXnyL/yyxVTSISPU9ElroF5xUPz fPy423imEt7d9QEt+zJUg4kyKqEivN/w8xquIAHpH5FAEfmGBXWq4Ra+oR9vjAiqjOXtJuc IA2a4+uRz1xq+jFsmJeIA== X-UI-Out-Filterresults: notjunk:1;V03:K0:6gBIici6D+w=:HmcmZ9j8zVeMj8EE9Qzapg ObkcpCb8rjcWardFwjdmbjIToWzVq7q8dm88LtEYXYKLeIkYrFcI8jIM1ieB7FFnVIxeMRETb 9QTf2Qi9R+RDOoZ+zpgCvZ7J7E+YwNd7elOP/UxtjDMMu22HykiDdFMyHg/Mpo3ZV3GRD1qGc HUe+R3jdNzmjucvi3J0WzISXOD0FpcUSyadDwBxuL8GPIoRat1CUiiMAgdXc0wjGu1biERzFb +Ik2M+mb4o1UZp3IMSo8hci+DEMX3mEx0ReaZ2YC2LSxL2jxmSXXTNUCYA1yyjHhfIko3YRO8 gtaW9h6zAMSWCvaWwVnSU1evCbxhQycS+8cglMqDcFqD7l2GVdaOsNsxuxiti+zooHdrnrqDf uQPM5hjaj7nVgBn9WpwcK5U0dKH1/vKaxl9A31YlikpX5OgFACluESKQirE1yAerdNikugF1H 8PAabOfQGUvfGXvtC8nIOpupPEezIW8lW1+IPA0ZckCFNcqAMehBWW5BlDohNUPaH3zMJ0VJh rN3VbIm11ZlKOA3/dDKesBKWjk0i9lEDjEOm1u3RdN9hxPe5Tu88JnRMIYMJt8rwyaOYFVzsr JruK4glv+DLJ+NQA7rrt7YMnx2GqwI+LYWEPsTmhrsNM6Z6oyMM+vSbPCFo802ypb1/WDtt5K uveEQsiBbxeW3dEzUFrkYbrYvYwsYneBicYH45c91MIGeHQFJSWy7Bo9+G6wbVlG1Q4tq3Qhb soe+frNuMp18I/ZYMFMtKdLndhYwxQm4vfLFSAv86kjudggOCUtE7hQm7L8wAqNQOw68vuyMS OOlG+bXSh9zmlxrqiqgSWHSu054ioNuRagqdA3YxASq2trdnXLIcZVyhFgCZn2BeM/lpRNV Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.17.10; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Olaf Hering , qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , "Dr . David Alan Gilbert" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1625862855017100003 From: Olaf Hering Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update all functions comments") Signed-off-by: Olaf Hering Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210708162159.18045-1-olaf@aepfle.de> Signed-off-by: Laurent Vivier --- migration/ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 723af67c2e91..88ff34f57424 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *= f, RAMBlock *block, } =20 /** - * mig_throttle_guest_down: throotle down the guest + * mig_throttle_guest_down: throttle down the guest * * Reduce amount of guest cpu execution to hopefully slow down memory * writes. If guest dirty memory rate is reduced below the rate at --=20 2.31.1 From nobody Sat May 11 09:33:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625863088830320.4637284406149; Fri, 9 Jul 2021 13:38:08 -0700 (PDT) Received: from localhost ([::1]:38126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1xG7-0004Pt-L2 for importer@patchew.org; Fri, 09 Jul 2021 16:38:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x76-0006TL-7A; Fri, 09 Jul 2021 16:28:44 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:43447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1x72-0007X5-BK; Fri, 09 Jul 2021 16:28:43 -0400 Received: from quad ([82.142.13.34]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MStKq-1lb3MK0T8A-00UGGz; Fri, 09 Jul 2021 22:28:34 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 9/9] util/guest-random: Fix size arg to tail memcpy Date: Fri, 9 Jul 2021 22:28:24 +0200 Message-Id: <20210709202824.578187-10-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210709202824.578187-1-laurent@vivier.eu> References: <20210709202824.578187-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:AUse9cH1is9MEo3IktQmuLG8soA4mjG4Rk7m+Zn/OcPEpHKR+PO kkxiIiElz43QZOgvDAFKgjLMTfVpkJWxPm9wHdnxSvIR3pC6FpxvnOReOrBav2UIU20+GmE dH/O2o2JgrW07EpKGvv3X9bvPvCRY4TJDiLP01bWtEbKTeXKtXAs8kQfyojXBO5F6xJ+IxZ h+7XaOJijk4z9n07T3POQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:73VLRv3XisQ=:0z0ao/ne0UNIrwb+xEDVxG r/6lg+QLuHsnFvwJJLv9QQL8L6L/THxR2fmC5wW1dzTnnVhKU/PmFmG62AIjbDP7dGJHwirlQ ySnh0py1QXoIxjuO+OSqV0Z+ri8dzKU2Jj9u2lMqifVNRAjRnYIooKM8x6h41j3Et2eGi7Ic2 VjJMZq00uzT7JGH3s841WstBJyV+K1tEyc76IW/PWtgFR+07Vwroo067kMY9RyDv7vCoQrUuG B54GCpN05FfXCjny5Wlz5oBdbJL2AI0bKkFlq+6zhrsSZEmJGW8mfmco59CSAl9aOK++fKAkb bGvzntlBLmJU0SZ9wOJCjtQ/ogmtmzjhFpP6jfe4o6mE/T19HF0X9Xpju/nswjTEl6k320WJ4 H6ULORcJKrIn/DsUgErYXNuNfRTs06L1npeCzgVIGVtnV7hT33vtCPzC1FlxuE5bQYCiRhNWZ oK2T1IOYuUv4aIKFWP/ZfRwazfDAKiI8OBswGrppv+K7lEgpobAeEI33Sor6Y7bmlIB7S/rnX NlDm6DZkeTMYNvLzK7Y7kGpBbEX990YvQ9MN9DWpW/WgElyvmIAFzjnby8LMXXRwF+JbD6bYQ 9bD539eTvgoQRJKLkV7W3GbHwEvbWsXNtmvE943dpOK4I54VULOcOvhjbI68xS6UntOGsNtLw jBtry1OWRN41K8eLRRatF/C0L5c6u0VHG3Y4ku9HfmpypW9WB8r3OgNPJAfZ0CXV3t2RzO99t XXk9ByJEmfRsT5k3mNpIURv7pC8X+Pa30MvidahzZlJ6kiG+v65Ac4AVRuu0tuqvr54Brlzod lGEQ4F0ob/SPKrE6r19kEnKaK/3JESKA6JGYR4Sc2M+qo1yVEagwPRkHX4aOtJafNDsLjgG Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=217.72.192.74; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Nelson , qemu-trivial@nongnu.org, Michael Tokarev , Richard Henderson , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1625863089869100001 From: Mark Nelson We know that in the body of this if statement i is less than len, so we really should be copying len - i bytes not i - len bytes. Fix this typo. Fixes: 8d8404f1564 ("util: Add qemu_guest_getrandom and associated routines= ") Signed-off-by: Mark Nelson Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210709120600.11080-1-mdnelson8@gmail.com> Signed-off-by: Laurent Vivier --- util/guest-random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/guest-random.c b/util/guest-random.c index 086115bd6702..23643f86cc60 100644 --- a/util/guest-random.c +++ b/util/guest-random.c @@ -38,7 +38,7 @@ static int glib_random_bytes(void *buf, size_t len) } if (i < len) { x =3D g_rand_int(rand); - __builtin_memcpy(buf + i, &x, i - len); + __builtin_memcpy(buf + i, &x, len - i); } return 0; } --=20 2.31.1