From nobody Tue Apr 8 14:37:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625836005; cv=none; d=zohomail.com; s=zohoarc; b=ScAq4+FHsYauCn1pEFLEeBqgMYKyhvOtGpT/orVzTssx1K95sruga7/uKeyaToLZ+f+x56HvYMd0yagYnY11i08sbhcDwW90Zq4284WBS5pGVw0t9YX6Xr+7HeqIaNKsHdno89f98poVAsSv5mNpMCXOtcn/gkbPuFRvliAO7kQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625836005; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8MY/xeWLfazr5o2i186vnOVjNalQI1fbYoFiWVc9YIs=; b=mt1gQa7774OZlQfgc0EfJ/6Ugq4Tc2vuIZkFXz0EEd9ctC0LFJpFgKh3BYehvqWznXv7eUt+kSwRalJRVfB6ZasVpuvgL36EWfy+6ceVFIuZFD5zf0jRdFoMVnFeW72MKh8zTyBJIOICQnhA6hYBJdiYVGYPLfMXVD8pxytugbo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625836005734609.2772734323838; Fri, 9 Jul 2021 06:06:45 -0700 (PDT) Received: from localhost ([::1]:54736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1qDM-0005sf-ME for importer@patchew.org; Fri, 09 Jul 2021 09:06:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1pz9-0004nz-NB for qemu-devel@nongnu.org; Fri, 09 Jul 2021 08:52:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42978) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1pz5-0003gk-Qo for qemu-devel@nongnu.org; Fri, 09 Jul 2021 08:52:02 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-rYviBbMzN9CoLLHVBXIHCw-1; Fri, 09 Jul 2021 08:51:55 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A917F1084F54; Fri, 9 Jul 2021 12:51:54 +0000 (UTC) Received: from merkur.redhat.com (ovpn-113-203.ams2.redhat.com [10.36.113.203]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC56760843; Fri, 9 Jul 2021 12:51:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625835119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8MY/xeWLfazr5o2i186vnOVjNalQI1fbYoFiWVc9YIs=; b=AzqhId/53PsDbiOTmN6yq8DLPWMDAaifEf/+yzR46n8sF9eDzwRYGeaEP0djJ43OzkKFTf Lt+ELgEaGpbhzqzPrde5xRK4SkMYey/RDUzbrzxNDWOq8IrK9cTS+JRe1QxLVj/fXldj4M DCHnb1gxXHtCSzrKsH0jtBwFP7kN08E= X-MC-Unique: rYviBbMzN9CoLLHVBXIHCw-1 From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PULL 18/28] vhost-user: Fix backends without multiqueue support Date: Fri, 9 Jul 2021 14:50:25 +0200 Message-Id: <20210709125035.191321-19-kwolf@redhat.com> In-Reply-To: <20210709125035.191321-1-kwolf@redhat.com> References: <20210709125035.191321-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1625836006591100001 Content-Type: text/plain; charset="utf-8" dev->max_queues was never initialised for backends that don't support VHOST_USER_PROTOCOL_F_MQ, so it would use 0 as the maximum number of queues to check against and consequently fail for any such backend. Set it to 1 if the backend doesn't have multiqueue support. Fixes: c90bd505a3e8210c23d69fecab9ee6f56ec4a161 Signed-off-by: Kevin Wolf Message-Id: <20210705171429.29286-1-kwolf@redhat.com> Reviewed-by: Cornelia Huck Reviewed-by: Raphael Norwitz Signed-off-by: Kevin Wolf --- hw/virtio/vhost-user.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 1ac4a2ebec..29ea2b4fce 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -1913,7 +1913,10 @@ static int vhost_user_backend_init(struct vhost_dev = *dev, void *opaque, if (err < 0) { return -EPROTO; } + } else { + dev->max_queues =3D 1; } + if (dev->num_queues && dev->max_queues < dev->num_queues) { error_setg(errp, "The maximum number of queues supported by th= e " "backend is %" PRIu64, dev->max_queues); --=20 2.31.1