From nobody Tue Apr 8 13:51:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1625836301; cv=none; d=zohomail.com; s=zohoarc; b=YnIvxJf6/QMuXZ5lpaE48ej7uQmgtC9yIpiJ72gNu4m31Pvpk4aoP4Jj/6DkUwr+NvRuiA6+9sQr/WtT9fvAM/gGdzzyT1XUklqMdGhO3x1mLtAaYgdjWtnWCZnNgdEIy3DWWTpQ3kkBAFgTyWVKwncr1pAohNAd1+ambXVTzQ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625836301; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eNEeG1+kdgaWO7xARkwHEHrkDlaPiqzVvIaIOqASbeQ=; b=F/l2bj/zTjy3HmI+VjHKOEYHUYrAm14f+7bonXtL5YMRQTgyeoytlqwKrIU0lOngtAbu/EK0JEiWpka5dUEyX3BeLrlAkrCafq5VTyuHWm1CogGs25RofaMsXgYn+PflMzsdu4TCwnteZRJhCB4zmpIIJoTyDTZYKReM3py9eGA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625836301961225.49457333644034; Fri, 9 Jul 2021 06:11:41 -0700 (PDT) Received: from localhost ([::1]:37128 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1qI8-0004uA-Pq for importer@patchew.org; Fri, 09 Jul 2021 09:11:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1pya-0003zq-K3 for qemu-devel@nongnu.org; Fri, 09 Jul 2021 08:51:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54228) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1pyY-0003UG-Ad for qemu-devel@nongnu.org; Fri, 09 Jul 2021 08:51:28 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-169-5ZfRG1KVPdKHsydmlsWJ3A-1; Fri, 09 Jul 2021 08:51:24 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E46221084F5A; Fri, 9 Jul 2021 12:51:22 +0000 (UTC) Received: from merkur.redhat.com (ovpn-113-203.ams2.redhat.com [10.36.113.203]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27BD960843; Fri, 9 Jul 2021 12:51:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625835085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eNEeG1+kdgaWO7xARkwHEHrkDlaPiqzVvIaIOqASbeQ=; b=fc1tXmC6RedXIF0UYfNR5pO/t8KMaEKEOPsP7fDzJ26uQn689aBMpLP0LOXjEzmU18XBaH K6AA5PlyMoam+JH3D9YmoQN/Ot+Y8eMuWgmefFZCsoVXUcJ/ge10V2v/wBLAnD+ruAiQjH a9ijQXD46d0oAXjhYMK5B5Pxz2ue8vM= X-MC-Unique: 5ZfRG1KVPdKHsydmlsWJ3A-1 From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PULL 12/28] export/fuse: Give SET_ATTR_SIZE its own branch Date: Fri, 9 Jul 2021 14:50:19 +0200 Message-Id: <20210709125035.191321-13-kwolf@redhat.com> In-Reply-To: <20210709125035.191321-1-kwolf@redhat.com> References: <20210709125035.191321-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1625836304110100001 Content-Type: text/plain; charset="utf-8" From: Max Reitz In order to support changing other attributes than the file size in fuse_setattr(), we have to give each its own independent branch. This also applies to the only attribute we do support right now. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf Message-Id: <20210625142317.271673-4-mreitz@redhat.com> Signed-off-by: Kevin Wolf --- block/export/fuse.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/block/export/fuse.c b/block/export/fuse.c index 4068250241..26ad644cd7 100644 --- a/block/export/fuse.c +++ b/block/export/fuse.c @@ -417,20 +417,22 @@ static void fuse_setattr(fuse_req_t req, fuse_ino_t i= node, struct stat *statbuf, FuseExport *exp =3D fuse_req_userdata(req); int ret; =20 - if (!exp->writable) { - fuse_reply_err(req, EACCES); - return; - } - if (to_set & ~FUSE_SET_ATTR_SIZE) { fuse_reply_err(req, ENOTSUP); return; } =20 - ret =3D fuse_do_truncate(exp, statbuf->st_size, true, PREALLOC_MODE_OF= F); - if (ret < 0) { - fuse_reply_err(req, -ret); - return; + if (to_set & FUSE_SET_ATTR_SIZE) { + if (!exp->writable) { + fuse_reply_err(req, EACCES); + return; + } + + ret =3D fuse_do_truncate(exp, statbuf->st_size, true, PREALLOC_MOD= E_OFF); + if (ret < 0) { + fuse_reply_err(req, -ret); + return; + } } =20 fuse_getattr(req, inode, fi); --=20 2.31.1