From nobody Tue Feb 10 03:38:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625809387440610.6576011297124; Thu, 8 Jul 2021 22:43:07 -0700 (PDT) Received: from localhost ([::1]:47498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1jI2-0005ng-7x for importer@patchew.org; Fri, 09 Jul 2021 01:43:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1iuG-0002Pe-4Q; Fri, 09 Jul 2021 01:18:32 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:56113) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1iu9-00025C-HX; Fri, 09 Jul 2021 01:18:31 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4GLhHf5Zgmz9t8j; Fri, 9 Jul 2021 15:17:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1625807854; bh=FS0CXh5tr8em9jVtL2JvYY6xzmNt7xn81MDXwdvg4jI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bp4CMN9YWO95EDntamYVEB+ptAkX1bf/efkJk9cdYoI9hkkDovkcs81dRYHVSynvf I3KcQZCqUpT8Wx1/MffTfeQAMb4/dq8NJwL6xitsnCaV9h305Oi8jkFoTMw9ia8Cg3 gTtSO6plywaH6OD/Bkpc1TnpoGWt1mef3rCF/qFw= From: David Gibson To: peter.maydell@linaro.org, groug@kaod.org Subject: [PULL 28/33] ppc/pegasos2: Fix use of && instead of & Date: Fri, 9 Jul 2021 15:17:23 +1000 Message-Id: <20210709051728.170203-29-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210709051728.170203-1-david@gibson.dropbear.id.au> References: <20210709051728.170203-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aik@ozlabs.ru, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1625809387886100001 Content-Type: text/plain; charset="utf-8" This is obviously intended to be a mask, not a logical operation. Signed-off-by: David Gibson --- hw/ppc/pegasos2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c index f1741a4512..cf1dc53c83 100644 --- a/hw/ppc/pegasos2.c +++ b/hw/ppc/pegasos2.c @@ -584,7 +584,7 @@ static void add_pci_device(PCIBus *bus, PCIDevice *d, v= oid *opaque) pci_get_word(&d->config[PCI_SUBSYSTEM_VENDOR_ID]= )); cells[0] =3D pci_get_long(&d->config[PCI_CLASS_REVISION]); qemu_fdt_setprop_cell(fi->fdt, node->str, "class-code", cells[0] >> 8); - qemu_fdt_setprop_cell(fi->fdt, node->str, "revision-id", cells[0] && 0= xff); + qemu_fdt_setprop_cell(fi->fdt, node->str, "revision-id", cells[0] & 0x= ff); qemu_fdt_setprop_cell(fi->fdt, node->str, "device-id", pci_get_word(&d->config[PCI_DEVICE_ID])); qemu_fdt_setprop_cell(fi->fdt, node->str, "vendor-id", --=20 2.31.1