From nobody Mon Feb 9 23:02:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625808946376808.261893277955; Thu, 8 Jul 2021 22:35:46 -0700 (PDT) Received: from localhost ([::1]:33466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1jAv-0004Zi-83 for importer@patchew.org; Fri, 09 Jul 2021 01:35:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35284) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1itm-0001IE-Qp; Fri, 09 Jul 2021 01:18:02 -0400 Received: from ozlabs.org ([203.11.71.1]:60181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1itl-000233-4V; Fri, 09 Jul 2021 01:18:02 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4GLhHf35b0z9t5K; Fri, 9 Jul 2021 15:17:34 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1625807854; bh=fmtyaAfW8gexYPiNoF7QBDrbqMXBLaAkCCswKdWHVfQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WScZhKUPKG+fknTaSIHINkKtmFuDQZUa7P4O62Yu4PMZ1MHDA99KcgD1iojlPtTdN SAoiAIcKU35jFpKlop273oC1A+hSmwFlA0qxjeIh1M4zXT6UGigjgZpoLdE47APUi/ plsKVxplN95UDYL3+uSxrXzD3gmacOKwYj0rKoOk= From: David Gibson To: peter.maydell@linaro.org, groug@kaod.org Subject: [PULL 23/33] target/ppc: mtmsrd is an illegal instruction on BookE Date: Fri, 9 Jul 2021 15:17:18 +1000 Message-Id: <20210709051728.170203-24-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210709051728.170203-1-david@gibson.dropbear.id.au> References: <20210709051728.170203-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, Nicholas Piggin , qemu-ppc@nongnu.org, Christian Zigotzky , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1625808948164100001 Content-Type: text/plain; charset="utf-8" From: Nicholas Piggin MSR is a 32-bit register in BookE and there is no mtmsrd instruction. Cc: Christian Zigotzky Signed-off-by: Nicholas Piggin Message-Id: <20210706051321.609046-1-npiggin@gmail.com> Signed-off-by: David Gibson --- target/ppc/translate.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target/ppc/translate.c b/target/ppc/translate.c index f65d1e81ea..d1f482b0f3 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -4940,6 +4940,11 @@ static void gen_mtcrf(DisasContext *ctx) #if defined(TARGET_PPC64) static void gen_mtmsrd(DisasContext *ctx) { + if (unlikely(!is_book3s_arch2x(ctx))) { + gen_invalid(ctx); + return; + } + CHK_SV; =20 #if !defined(CONFIG_USER_ONLY) --=20 2.31.1