From nobody Mon Feb 9 21:40:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1625780634; cv=none; d=zohomail.com; s=zohoarc; b=NykJVnaaSzmxvjhYnuIDlVVu99J6lK7sqURcHgtrXjx626Zrc2sg6+BjiSov+jphO7/qskIjmC732qm0EV4cOPQF7QjHWITKyhMIoMa7A6askLDlwcdTBNx72mx/CL35/cDPgrtKP1lBnhOfcNQ5NyoxEmcbUU0Dq2jg+cEoPMo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625780634; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YI+k1eDoSKwErLE0nkT4pwOAj5SV9AI2zjTOQ0y/Zv8=; b=Eocfuyh9KL8BUltBbgqHkmBNfAy2muUljXwzhU/uRUlkGWlH/L/ajIX377JYEG35PCbepMm95wj9BBUwqlIwMfPgZaVzwLBclVvFhASVF1ZLGrQT/cGpvvlL2ybAgQ1fJKVPrf3NNu4+qvQgv2OsWrtJfonfRG3KdAUXISuod1Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 162578063468059.291212708310695; Thu, 8 Jul 2021 14:43:54 -0700 (PDT) Received: from localhost ([::1]:55040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1boH-0006Zc-NF for importer@patchew.org; Thu, 08 Jul 2021 17:43:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54414) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1big-0008Qt-Ly for qemu-devel@nongnu.org; Thu, 08 Jul 2021 17:38:06 -0400 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]:46751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1biY-0008LN-4r for qemu-devel@nongnu.org; Thu, 08 Jul 2021 17:38:06 -0400 Received: by mail-pg1-x52a.google.com with SMTP id w15so7732123pgk.13 for ; Thu, 08 Jul 2021 14:37:57 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id g27sm4322800pgl.19.2021.07.08.14.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 14:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YI+k1eDoSKwErLE0nkT4pwOAj5SV9AI2zjTOQ0y/Zv8=; b=lmzBocxvevDSY0OTN0mZZ5wg5Un1YYty6ezpRhfp6Cen7PSVuOCQGoOgEJStMxUjPJ 6rxw3iQh/ohEzsMpaW/yeskDPbbkCYZd/T5P2q/+fTj6ceVkM7fypZLr0FbI4y9u3cyP kngRJM44khlf9ulyQgKNK8MgE9nlhxqw9fmO3Bwzwtx2mmjBomW/rZHnrU7ubGBj902g /YOCYCoP8561+Bvoj9VLqtWjl7OPZBVJBGPzxJ3DbrYilRhKJwRNVjn5XMLkoiRUMRqD X4RRjFEU3SYUPgF53gOWcE37yBc2JYmeWL99D8/kfeRjAuWzUTHz89JhYYr7yNUkhoPP rw5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YI+k1eDoSKwErLE0nkT4pwOAj5SV9AI2zjTOQ0y/Zv8=; b=l7nEeemo0MHv0b+u83evOmqtlvzInXEMZbZ0nR754iwqSBqn648XjsSZIEsYQ3uLRb 7bHuerqMJrWcVMuVc4EtMDGWd+tGJJvD3d6nuS+sLaJuH61I9nFWldQMdDlFSk7hqokt x3cS0cR/+qXPS7YMcWJuG7ne3LVnWmV6VsNeIzYWDCozSaGFh3CNRtkrDkFX21V6GOIp 2iEtCAhFSz/Y6+tQIXzLodwAlxmMtn03EPm/pB9s0dCz+xjlYerZ/bcM3aJUuRHDG+kA CldA20x5v7i8xh896TeNEA1O6SfJinmrJxL1MCV0mYsSpJ0ihCR4zszUtov9WLMTpLZl WGpw== X-Gm-Message-State: AOAM531ZeCE4Lxq3voj3ADzCYjAM0lXAYVrMrSbu10p3pnMOiAhLHsr6 WCqIE2X7LBpGsdJdTpzdaDfSO/D6Iz18Lw== X-Google-Smtp-Source: ABdhPJx7HHc02YWmTNP14jJ7m2Iaz8/aj/2COuBV9q+ZtyTciEzKRjaKZjnzwG8NBTrCLTuRnyC4Vw== X-Received: by 2002:aa7:848a:0:b029:305:a6bf:f8ea with SMTP id u10-20020aa7848a0000b0290305a6bff8eamr33867433pfn.20.1625780276618; Thu, 08 Jul 2021 14:37:56 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 1/4] target/openrisc: Use tcg_constant_* Date: Thu, 8 Jul 2021 14:37:51 -0700 Message-Id: <20210708213754.830485-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210708213754.830485-1-richard.henderson@linaro.org> References: <20210708213754.830485-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shorne@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1625780636632100001 Content-Type: text/plain; charset="utf-8" Replace uses of tcg_const_* with the allocate and free close together. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/openrisc/translate.c | 42 ++++++++----------------------------- 1 file changed, 9 insertions(+), 33 deletions(-) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index a9c81f8bd5..1e437d2f9d 100644 --- a/target/openrisc/translate.c +++ b/target/openrisc/translate.c @@ -130,9 +130,7 @@ void openrisc_translate_init(void) =20 static void gen_exception(DisasContext *dc, unsigned int excp) { - TCGv_i32 tmp =3D tcg_const_i32(excp); - gen_helper_exception(cpu_env, tmp); - tcg_temp_free_i32(tmp); + gen_helper_exception(cpu_env, tcg_constant_i32(excp)); } =20 static void gen_illegal_exception(DisasContext *dc) @@ -539,13 +537,11 @@ static bool trans_l_extbz(DisasContext *dc, arg_da *a) =20 static bool trans_l_cmov(DisasContext *dc, arg_dab *a) { - TCGv zero; + TCGv zero =3D tcg_constant_tl(0); =20 check_r0_write(dc, a->d); - zero =3D tcg_const_tl(0); tcg_gen_movcond_tl(TCG_COND_NE, cpu_R(dc, a->d), cpu_sr_f, zero, cpu_R(dc, a->a), cpu_R(dc, a->b)); - tcg_temp_free(zero); return true; } =20 @@ -633,15 +629,11 @@ static bool trans_l_jal(DisasContext *dc, arg_l_jal *= a) static void do_bf(DisasContext *dc, arg_l_bf *a, TCGCond cond) { target_ulong tmp_pc =3D dc->base.pc_next + a->n * 4; - TCGv t_next =3D tcg_const_tl(dc->base.pc_next + 8); - TCGv t_true =3D tcg_const_tl(tmp_pc); - TCGv t_zero =3D tcg_const_tl(0); + TCGv t_next =3D tcg_constant_tl(dc->base.pc_next + 8); + TCGv t_true =3D tcg_constant_tl(tmp_pc); + TCGv t_zero =3D tcg_constant_tl(0); =20 tcg_gen_movcond_tl(cond, jmp_pc, cpu_sr_f, t_zero, t_true, t_next); - - tcg_temp_free(t_next); - tcg_temp_free(t_true); - tcg_temp_free(t_zero); dc->delayed_branch =3D 2; } =20 @@ -814,44 +806,28 @@ static bool trans_l_adrp(DisasContext *dc, arg_l_adrp= *a) =20 static bool trans_l_addi(DisasContext *dc, arg_rri *a) { - TCGv t0; - check_r0_write(dc, a->d); - t0 =3D tcg_const_tl(a->i); - gen_add(dc, cpu_R(dc, a->d), cpu_R(dc, a->a), t0); - tcg_temp_free(t0); + gen_add(dc, cpu_R(dc, a->d), cpu_R(dc, a->a), tcg_constant_tl(a->i)); return true; } =20 static bool trans_l_addic(DisasContext *dc, arg_rri *a) { - TCGv t0; - check_r0_write(dc, a->d); - t0 =3D tcg_const_tl(a->i); - gen_addc(dc, cpu_R(dc, a->d), cpu_R(dc, a->a), t0); - tcg_temp_free(t0); + gen_addc(dc, cpu_R(dc, a->d), cpu_R(dc, a->a), tcg_constant_tl(a->i)); return true; } =20 static bool trans_l_muli(DisasContext *dc, arg_rri *a) { - TCGv t0; - check_r0_write(dc, a->d); - t0 =3D tcg_const_tl(a->i); - gen_mul(dc, cpu_R(dc, a->d), cpu_R(dc, a->a), t0); - tcg_temp_free(t0); + gen_mul(dc, cpu_R(dc, a->d), cpu_R(dc, a->a), tcg_constant_tl(a->i)); return true; } =20 static bool trans_l_maci(DisasContext *dc, arg_l_maci *a) { - TCGv t0; - - t0 =3D tcg_const_tl(a->i); - gen_mac(dc, cpu_R(dc, a->a), t0); - tcg_temp_free(t0); + gen_mac(dc, cpu_R(dc, a->a), tcg_constant_tl(a->i)); return true; } =20 --=20 2.25.1 From nobody Mon Feb 9 21:40:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1625780393; cv=none; d=zohomail.com; s=zohoarc; b=bM+6P7OIzOdU54Zwj/cnkYe8CgT1IhNed97cCDKHODJ65QNwOYXnUBZN+2V+djmosIXjqmnW7av8U4e9OCHmVc5i5tjBfXtq8Gd0pmnd/ffICcUGgvUp57eFyT1lNnyshwKtFKWJ1IOQv/c8PGPtEZhue0JUI4mu/CnflKMT3Zw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625780393; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=asfzam4uxshAkMTtphuDnwfvWVKH3o+9edCCgJ8GjhQ=; b=MEe80bJ8+cpbPo6vfLDCftiMed8KGoJ/d09QGLjVZL07ypJ3DyUl9ns1b/hOJsXAaUVGIzDcRz+dplBUH3JJBQF0IYeLiYd6Dn+G4nZQXCQXbWvLXWECLK0XIB6cIzdoIKxauy6Qy5vOaimGBTJrUkkgWTZLvWWNwN+qBVsaM5A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625780393626392.52913610505016; Thu, 8 Jul 2021 14:39:53 -0700 (PDT) Received: from localhost ([::1]:48356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1bkO-00022g-B7 for importer@patchew.org; Thu, 08 Jul 2021 17:39:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1bia-0008PY-SB for qemu-devel@nongnu.org; Thu, 08 Jul 2021 17:38:01 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:41524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1biY-0008LQ-NR for qemu-devel@nongnu.org; Thu, 08 Jul 2021 17:38:00 -0400 Received: by mail-pl1-x632.google.com with SMTP id z2so998335plg.8 for ; Thu, 08 Jul 2021 14:37:58 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id g27sm4322800pgl.19.2021.07.08.14.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 14:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=asfzam4uxshAkMTtphuDnwfvWVKH3o+9edCCgJ8GjhQ=; b=mhOiG8XsljiOmtR8hr7vS8Mio9HzTexa/asLGDfTkCTr0VlzwYb6LwoaP9BIdBDdIA c9gk3aNSUdG4Tw2urYklIg2tspXW/1pwPRQojB3tbPTgX1/MDkb6/U8FOTVnG0mXDO0q wnhTHL7x1gEQHk7vTNRbtoYeg1hh/njae1zEjDpVZGh67Tz/m4FnEu4d8rMmOxP0qq+K lmzRmD+XEr9/OX52OQJEZqQIVJ4ZyEp15zddIxf6u8DeCF1E1ZwnsSlxgYI8bzjPrVkz Yrt9lPAMxnworgEXEdscRPXGqjYAxpM7Jqi6ZZ7nqk21fR5gaqwSC3P/9WiMXp00aVDW xjVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=asfzam4uxshAkMTtphuDnwfvWVKH3o+9edCCgJ8GjhQ=; b=oYYyLabzUOw3eAcCTI6bjNXivALuvlf/LoTW55zeEQ4ad2WS7dsHbGggihKRY24b2u GpXgWEtkqiebIHACZye9wlqZwXWRFKB6Q2z5FrU3E6UccKHn5RA9vQ80fWwd4hpKLzVO DeTLtMLPLPBKyKeZ325Cbvioye3hyGiYsbK/J5P1dyxnUfiSBWqENXfRDK0gx/R9Xpsl QZpnwwzy8yPSJmRX0UsEISQ+lcAXJuO5ixwOoNuFLNnUEI48lMBRUFUoQWnJVZyj6b4Q Qu1APka2kNblv3z03c7FjkAVNjTcua78thjh5xonRJvnohxVJ5scbir84jL5DjXxE6rC 44gA== X-Gm-Message-State: AOAM530I4azGNjqweAg7YSY2d/mLC1kAd4qQ+KHjNz9QwcPot8gtRTUT MvpUKnpWu42ZG4Auy6BgV6nIC/J3lHnnHw== X-Google-Smtp-Source: ABdhPJwz+OD3I6uyo8hE7XpXbR8/vFkQGvBx08srd6+sDVZTN4+Yk3wLS6vemvAiA8HQUTPeXDtSYQ== X-Received: by 2002:a17:90a:ec08:: with SMTP id l8mr9771317pjy.68.1625780277218; Thu, 08 Jul 2021 14:37:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 2/4] target/openrisc: Use tcg_constant_tl for dc->R0 Date: Thu, 8 Jul 2021 14:37:52 -0700 Message-Id: <20210708213754.830485-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210708213754.830485-1-richard.henderson@linaro.org> References: <20210708213754.830485-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shorne@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1625780395873100001 Content-Type: text/plain; charset="utf-8" The temp allocated for tcg_const_tl is auto-freed at branches, but pure constants are not. So we can remove the extra hoop jumping in trans_l_swa. Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne --- target/openrisc/translate.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index 1e437d2f9d..96df513fd3 100644 --- a/target/openrisc/translate.c +++ b/target/openrisc/translate.c @@ -733,12 +733,6 @@ static bool trans_l_swa(DisasContext *dc, arg_store *a) ea =3D tcg_temp_new(); tcg_gen_addi_tl(ea, cpu_R(dc, a->a), a->i); =20 - /* For TB_FLAGS_R0_0, the branch below invalidates the temporary assig= ned - to cpu_regs[0]. Since l.swa is quite often immediately followed by= a - branch, don't bother reallocating; finish the TB using the "real" R= 0. - This also takes care of RB input across the branch. */ - dc->R0 =3D cpu_regs[0]; - lab_fail =3D gen_new_label(); lab_done =3D gen_new_label(); tcg_gen_brcond_tl(TCG_COND_NE, ea, cpu_lock_addr, lab_fail); @@ -746,7 +740,7 @@ static bool trans_l_swa(DisasContext *dc, arg_store *a) =20 val =3D tcg_temp_new(); tcg_gen_atomic_cmpxchg_tl(val, cpu_lock_addr, cpu_lock_value, - cpu_regs[a->b], dc->mem_idx, MO_TEUL); + cpu_R(dc, a->b), dc->mem_idx, MO_TEUL); tcg_gen_setcond_tl(TCG_COND_EQ, cpu_sr_f, val, cpu_lock_value); tcg_temp_free(val); =20 @@ -1602,7 +1596,7 @@ static void openrisc_tr_tb_start(DisasContextBase *db= , CPUState *cs) /* Allow the TCG optimizer to see that R0 =3D=3D 0, when it's true, which is the common case. */ if (dc->tb_flags & TB_FLAGS_R0_0) { - dc->R0 =3D tcg_const_tl(0); + dc->R0 =3D tcg_constant_tl(0); } else { dc->R0 =3D cpu_regs[0]; } --=20 2.25.1 From nobody Mon Feb 9 21:40:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1625780392; cv=none; d=zohomail.com; s=zohoarc; b=bQbnf3/pOEJvgsqRNVReMwwgJklKRbuSPFbeZRAYQKLCbNqI/eNHUFr4QWXGnUPgtxmDUdZMFj0jlKbueEEv8I+pKVXoSf/U9RurkwqK78sTya6oFOxZ0gwqu5YzXvVr0VHwImSJWNX45QKje8ZW12rgy+xZ9YdstOe9lUgsbh4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625780392; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Kl6JnE7xohFEPb4Uv6igXK9acm2oRLRWePiQGSpIWy4=; b=LfKJo9yEWgRngiP3QlZq13Gln23kuOBa51ygusI00WVYNXyvjs+yQZgS94rlA+Syey5cefhwmrUcX+yW7w2LNP+LNgZ/Z18S63sWgaX33on+EaDgyP3OgJmIdSX4A/QLeLGV4oKuCA7HjccbEIpH6/z1Y8km5igY6YWUWFrRE9o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625780392277889.4816253844378; Thu, 8 Jul 2021 14:39:52 -0700 (PDT) Received: from localhost ([::1]:48320 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1bkM-00021K-P5 for importer@patchew.org; Thu, 08 Jul 2021 17:39:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1bib-0008PZ-C5 for qemu-devel@nongnu.org; Thu, 08 Jul 2021 17:38:01 -0400 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:45627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1biY-0008LW-Tq for qemu-devel@nongnu.org; Thu, 08 Jul 2021 17:38:01 -0400 Received: by mail-pf1-x434.google.com with SMTP id q10so6753456pfj.12 for ; Thu, 08 Jul 2021 14:37:58 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id g27sm4322800pgl.19.2021.07.08.14.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 14:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kl6JnE7xohFEPb4Uv6igXK9acm2oRLRWePiQGSpIWy4=; b=tyIOlqKFHNiQ3qDfZ+BfKFbFyuhmaA2T+sVffHQvfZoEv7iVXeFKd5uYuzXQnB8v6L rD7rD65ESGk0zRdZonAApD00cqPVKYeVjRYBHauqfNyi0ogrpOjgN+D6xnK9L39JlWG8 8hjoapyrEEOJzRhhpXIrOfpx4N3NaGm+c6+HYFu6j3ckUgesXpLlntW/08GSsyeFBxWw gRzcmX3HQ6BLkHRFIU8mC/rqugA/NTz5cREsLm3Vn6dN7WpJ3p8CXB+wuCkEyGEgADs7 UBdat+nVT1ovbKKhBS1RdtdqFdLR8yxGPV0ATAdl4+gBF6diTaxhLh0y/HdtdqjLsqPx nQwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kl6JnE7xohFEPb4Uv6igXK9acm2oRLRWePiQGSpIWy4=; b=cUpE7PNXIyOd7u5X/jIP0I+XqIPE9CVHJTuePOWSWHY+HeGPHa9BC1ttgLGVW2IHIS BmRcZamqTmjMbX9BbzKKZgV+UGVgALird6FqnCCaE5jgHekARdS9/7+St1X3vw8ejnyT emlis860pqoXOkd0/K57Ph7meJWsQrxFKuX09QKA4gS6vcBdygLNMUE5yQEy3jxUwJlS sJfjG+UDOx0bFcXArUrhGS7Me3BffInnbP6WIH95k3KJAnPPBkErg0xBAZulQrKcphLq FI12kHeWwH+hj6h+jgG6lcMxhm2ug7DP4+89OrLHitEFHywJH4ytK9/gcPf4rvHEULXv lNJA== X-Gm-Message-State: AOAM530GZ+VdRx2K0GT4D52AIXB3XvpmSawMo6GF3ywWQC8GOjtwBabq 3fbBuuiGDvidkeandZoOM8WdYFxn1HmD4g== X-Google-Smtp-Source: ABdhPJzdVMbpAxd24iMXVNUBkJIfuuVbrVvXqSzkx0fcnBr1lGKau6Itgz7youGBS26zPV0+tbsgoA== X-Received: by 2002:aa7:8158:0:b029:301:8d0b:3d09 with SMTP id d24-20020aa781580000b02903018d0b3d09mr32995086pfn.48.1625780277694; Thu, 08 Jul 2021 14:37:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 3/4] target/openrisc: Cache constant 0 in DisasContext Date: Thu, 8 Jul 2021 14:37:53 -0700 Message-Id: <20210708213754.830485-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210708213754.830485-1-richard.henderson@linaro.org> References: <20210708213754.830485-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shorne@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1625780393765100002 Content-Type: text/plain; charset="utf-8" We are virtually certain to have fetched constant 0 once, at the beginning of the TB, so we might as well use it elsewhere. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Stafford Horne --- target/openrisc/translate.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index 96df513fd3..3d86bdffaa 100644 --- a/target/openrisc/translate.c +++ b/target/openrisc/translate.c @@ -53,6 +53,8 @@ typedef struct DisasContext { =20 /* The temporary corresponding to register 0 for this compilation. */ TCGv R0; + /* The constant zero. */ + TCGv zero; } DisasContext; =20 static inline bool is_user(DisasContext *dc) @@ -537,10 +539,8 @@ static bool trans_l_extbz(DisasContext *dc, arg_da *a) =20 static bool trans_l_cmov(DisasContext *dc, arg_dab *a) { - TCGv zero =3D tcg_constant_tl(0); - check_r0_write(dc, a->d); - tcg_gen_movcond_tl(TCG_COND_NE, cpu_R(dc, a->d), cpu_sr_f, zero, + tcg_gen_movcond_tl(TCG_COND_NE, cpu_R(dc, a->d), cpu_sr_f, dc->zero, cpu_R(dc, a->a), cpu_R(dc, a->b)); return true; } @@ -631,9 +631,8 @@ static void do_bf(DisasContext *dc, arg_l_bf *a, TCGCon= d cond) target_ulong tmp_pc =3D dc->base.pc_next + a->n * 4; TCGv t_next =3D tcg_constant_tl(dc->base.pc_next + 8); TCGv t_true =3D tcg_constant_tl(tmp_pc); - TCGv t_zero =3D tcg_constant_tl(0); =20 - tcg_gen_movcond_tl(cond, jmp_pc, cpu_sr_f, t_zero, t_true, t_next); + tcg_gen_movcond_tl(cond, jmp_pc, cpu_sr_f, dc->zero, t_true, t_next); dc->delayed_branch =3D 2; } =20 @@ -1595,8 +1594,9 @@ static void openrisc_tr_tb_start(DisasContextBase *db= , CPUState *cs) =20 /* Allow the TCG optimizer to see that R0 =3D=3D 0, when it's true, which is the common case. */ + dc->zero =3D tcg_constant_tl(0); if (dc->tb_flags & TB_FLAGS_R0_0) { - dc->R0 =3D tcg_constant_tl(0); + dc->R0 =3D dc->zero; } else { dc->R0 =3D cpu_regs[0]; } --=20 2.25.1 From nobody Mon Feb 9 21:40:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1625780530; cv=none; d=zohomail.com; s=zohoarc; b=TmE8D1pFrTC4QJ9yhZgRjEkYBe78Nfvqz5+ZsO7Ub+7YRzJeBUPvXgfqc6jkJR+eLXrkmbZ9sy1GIdR4w2fHFN79dX4yW/EzhxncqZTabBcFpk6g4esysZDWhy5qRFwc/V/yTuJhI90afQ9836J4swR7kw6f+ZdAr8njPbhZXog= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625780530; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7ItSyYsGQ9A8At3Pt+haqUSVGcYkHH5NFOEM/YPqhl0=; b=Rk1vncFDCxX6HACYXIqAo/4akSbf4dVR4M8pDOqJqcXv4Z8J72VXGELuwPFlovu1ILKFoKb+bH9kbhAzjBwtrZ07t1eFcAGyjfVAnGWAfkqrCmFO98pnnbWKuvHLPv+X9XWfB69rux/tUfOfDh49nayqccccoNoNT9vg4b9EY/E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625780530067646.8310086377244; Thu, 8 Jul 2021 14:42:10 -0700 (PDT) Received: from localhost ([::1]:52824 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1bmb-000569-3Z for importer@patchew.org; Thu, 08 Jul 2021 17:42:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1bic-0008Q4-Bi for qemu-devel@nongnu.org; Thu, 08 Jul 2021 17:38:02 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:41871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1biZ-0008Lb-NS for qemu-devel@nongnu.org; Thu, 08 Jul 2021 17:38:02 -0400 Received: by mail-pj1-x1035.google.com with SMTP id oj10-20020a17090b4d8ab0290172f77377ebso4882021pjb.0 for ; Thu, 08 Jul 2021 14:37:59 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id g27sm4322800pgl.19.2021.07.08.14.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 14:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7ItSyYsGQ9A8At3Pt+haqUSVGcYkHH5NFOEM/YPqhl0=; b=ho224I1nZOS/iV0YylE4vpvOiCk3UgV6gZnYgP0jyY8NpPgkGfImIJ0o5dNlxt5qeb +XAoansdFcFnSzmAiYZF5WIb9Xu7S2JL+GvXdAczDILG3cJJ4ZvOYN5AwZ+0mCT0t9hQ 2b2XLS1ywtwuEGiTai2gWRit5X6w66l7qO+eAZX6SRiJdOSe8OGLG8/kCT4wmvADUx8W t/vcwiegkp/pK6vlZYe5qkbKErAOWmMeJuJGkt5HjFGevZ8h2N6Sj9snz+UODsMMOTd5 +G9ASXLgLxcylz82jsstjBrI19GSX7A19GKzXS0HXmbv/Z5lL5HRzty8CMdGeoN5Vn5K C1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7ItSyYsGQ9A8At3Pt+haqUSVGcYkHH5NFOEM/YPqhl0=; b=fiyzDaySa+b1hZDy7aQoWyJ2yjr7MZ1dmNwMRNjN7i0cgP3H737tTYht0RmaChmCA5 QR8hHLsYCsBK4pfcLX+XAfArJjv39lxgY6c+ihcexbJ7mMgF2VKsm1ulNt2N0242/dg8 Cl41syqgDlh43Y7Cflq4vrv987sc4yqm7OOKrCGke5rs38XYXsQetomuTBfM/GbMKMBe Zq4HMAI9QGnU//tgWH0Ttn8J8Scu43jR/tTu/J5xwZWSKXiPHcje6KB+5Csbvqv7I0iJ Wf9S/yyk4QGHq/kG3KSDvIoqbJ6CC5LfNej6PgwsPZ6ksIDnDO+HBUU80Cdw5bOWKvLd OJPQ== X-Gm-Message-State: AOAM533U/Kuwq+5nfuzki/ahq+uRzEjemctX5ffa5iLa5Oib7KnOss2r JjW3Z3sk48TGz+JTm25bpylPR4EqS6/7qA== X-Google-Smtp-Source: ABdhPJxRvJBpJiy/nHaN0TorYnMnlzZd4sE6dG+S/7h+AnBKPMuCFfbSIJxDlq/rPdaPScbQu4/rhA== X-Received: by 2002:a17:90a:420b:: with SMTP id o11mr33272029pjg.201.1625780278246; Thu, 08 Jul 2021 14:37:58 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 4/4] target/openrisc: Use dc->zero in gen_add, gen_addc Date: Thu, 8 Jul 2021 14:37:54 -0700 Message-Id: <20210708213754.830485-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210708213754.830485-1-richard.henderson@linaro.org> References: <20210708213754.830485-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1035.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shorne@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1625780531137100001 Content-Type: text/plain; charset="utf-8" We still need the t0 temporary for computing overflow, but we do not need to initialize it to zero first. Signed-off-by: Richard Henderson Reviewed-by: Stafford Horne --- target/openrisc/translate.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/openrisc/translate.c b/target/openrisc/translate.c index 3d86bdffaa..3425fd881e 100644 --- a/target/openrisc/translate.c +++ b/target/openrisc/translate.c @@ -200,10 +200,10 @@ static void gen_ove_cyov(DisasContext *dc) =20 static void gen_add(DisasContext *dc, TCGv dest, TCGv srca, TCGv srcb) { - TCGv t0 =3D tcg_const_tl(0); + TCGv t0 =3D tcg_temp_new(); TCGv res =3D tcg_temp_new(); =20 - tcg_gen_add2_tl(res, cpu_sr_cy, srca, t0, srcb, t0); + tcg_gen_add2_tl(res, cpu_sr_cy, srca, dc->zero, srcb, dc->zero); tcg_gen_xor_tl(cpu_sr_ov, srca, srcb); tcg_gen_xor_tl(t0, res, srcb); tcg_gen_andc_tl(cpu_sr_ov, t0, cpu_sr_ov); @@ -217,11 +217,11 @@ static void gen_add(DisasContext *dc, TCGv dest, TCGv= srca, TCGv srcb) =20 static void gen_addc(DisasContext *dc, TCGv dest, TCGv srca, TCGv srcb) { - TCGv t0 =3D tcg_const_tl(0); + TCGv t0 =3D tcg_temp_new(); TCGv res =3D tcg_temp_new(); =20 - tcg_gen_add2_tl(res, cpu_sr_cy, srca, t0, cpu_sr_cy, t0); - tcg_gen_add2_tl(res, cpu_sr_cy, res, cpu_sr_cy, srcb, t0); + tcg_gen_add2_tl(res, cpu_sr_cy, srca, dc->zero, cpu_sr_cy, dc->zero); + tcg_gen_add2_tl(res, cpu_sr_cy, res, cpu_sr_cy, srcb, dc->zero); tcg_gen_xor_tl(cpu_sr_ov, srca, srcb); tcg_gen_xor_tl(t0, res, srcb); tcg_gen_andc_tl(cpu_sr_ov, t0, cpu_sr_ov); --=20 2.25.1