From nobody Tue Feb 10 13:36:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1625768924; cv=none; d=zohomail.com; s=zohoarc; b=GYFT85GrD1bg3x6xKo/UX81QL9FBR6pWzUtvbcASYuZPzW1ovUAXLtTWqhbnx4R2TB8e3bM7Mb/ruiGCTgjklZwqjgCfRGLWWCWdWihkSevvbzZ+DD7uEn13qLKWA3mYTBSCYVAHwrZMJutcowwCA7ulx7lKWt9LDUEmK6AtPHA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625768924; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CQb7o+ET8OOl5+pKxHwa5BifFYk4we0KyRxLN1kjWhQ=; b=Ay2vJghTUDlKOzPw9Q9oKM2x/oKG/fpdDietCN+QVyZ730P8TO/DtGezk1YRfZ/7eltKjmONJWnyLKLEmFMtx+6EtEeZ+k86jyon2zipe5OZrbS9aKaep1Roz66Zls8zv1Nt1jIrbUBLq5tfHhLxerMwerJPbt2AaVNfnUBlojY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625768924299422.2884699829956; Thu, 8 Jul 2021 11:28:44 -0700 (PDT) Received: from localhost ([::1]:57784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1YlO-0003wg-1W for importer@patchew.org; Thu, 08 Jul 2021 14:28:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1YiQ-00018J-ME for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:25:45 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]:40645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1YiD-0007rW-UB for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:25:35 -0400 Received: by mail-pg1-x533.google.com with SMTP id k20so124549pgg.7 for ; Thu, 08 Jul 2021 11:25:23 -0700 (PDT) Received: from localhost.localdomain ([71.212.149.176]) by smtp.gmail.com with ESMTPSA id d67sm2751810pfd.81.2021.07.08.11.25.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 11:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=CQb7o+ET8OOl5+pKxHwa5BifFYk4we0KyRxLN1kjWhQ=; b=ABIgeEaPt3wTfJwQ06JYU8f9TQ5I/FsnhnvGq4OzcHAy7T4K/vH834gSG/Olxyxrtg Yg1Xn7VWDdau4vydhSL1hqB5Knm3R7khthwbO/K1qHcXiVmJmAXYhESIJXauyC5IViob ukJODSfVEgnF57VVX1W6WzL7sC29XbvNOp42HTZ5GZDplurOKlNLl5osqMfCKWt48gDI X6SAldtHJFNRWptw5BRoAPiO7YIGJgV3Ez7Jz/Oc8WmjKnLL/qY534m6VcUQdx6LstyD 6cXz/KvU8X76HrbS3cQFz3gXDavHPKKP0rv/xTUS0Odv/lXIYT2DQjSHvvc17mKOwhpl fTag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CQb7o+ET8OOl5+pKxHwa5BifFYk4we0KyRxLN1kjWhQ=; b=rKLU1O/dK3JgBXyhzjioC6nyu3D3djSFCCU7Mmz7PzCTQNI5Kt1dixoc3EEjYKj4Ix UN/XVZJasClRZpnoAKJi/IktF+GmG4bMicJJ1VBTJGmrqwyJuI0YQ8Yi5Sz5mIB3ax8R 1kb+Y2sQcfb8gE10xU4aR8oC6Jnm/ZtXDIbDE+Wh7O2cuBDvRJJpVBSO4Zo1rWBz2+ix oqxhB+leryj4lCUHqnvV2olEAKd3Z3lYcv81lqpBjr8j0fVrUzznAJOohi2TZD7pvoUt Svg8aoSQpaCmpKlk+23FYyFAowlTLVeZYwJbXE1SceXCxPJrDwPKiRJKZ2vLgz09MGZ8 1X+Q== X-Gm-Message-State: AOAM5328y9tNxVjKO+5ZUKT+47iBi0ryBmmtA9it3zlj5Uu2i7WFhbl3 fNfQBMTbAE2akTcG6unWg2aN1JAfXVcdXQ== X-Google-Smtp-Source: ABdhPJyt5jpMR5b0Tb4uvOBEcu/gh2urOEMS81kA23ew6Rs1qWv5paGY/GYCUWmZlM2rIVrdG1KtQQ== X-Received: by 2002:a62:f947:0:b029:2e9:c502:7939 with SMTP id g7-20020a62f9470000b02902e9c5027939mr32441608pfm.34.1625768722711; Thu, 08 Jul 2021 11:25:22 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH 4/4] target/alpha: Use tcg_constant_* elsewhere Date: Thu, 8 Jul 2021 11:25:19 -0700 Message-Id: <20210708182519.750626-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210708182519.750626-1-richard.henderson@linaro.org> References: <20210708182519.750626-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1625768926708100001 Content-Type: text/plain; charset="utf-8" Replace the remaining uses of tcg_const_*. These uses are all local, with the allocate and free close together. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/alpha/translate.c | 46 ++++++++++++---------------------------- 1 file changed, 14 insertions(+), 32 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 3fd66fb78d..cf5ad46853 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -251,11 +251,9 @@ static void gen_excp_1(int exception, int error_code) { TCGv_i32 tmp1, tmp2; =20 - tmp1 =3D tcg_const_i32(exception); - tmp2 =3D tcg_const_i32(error_code); + tmp1 =3D tcg_constant_i32(exception); + tmp2 =3D tcg_constant_i32(error_code); gen_helper_excp(cpu_env, tmp1, tmp2); - tcg_temp_free_i32(tmp2); - tcg_temp_free_i32(tmp1); } =20 static DisasJumpType gen_excp(DisasContext *ctx, int exception, int error_= code) @@ -506,15 +504,11 @@ static DisasJumpType gen_bcond_internal(DisasContext = *ctx, TCGCond cond, =20 return DISAS_NORETURN; } else { - TCGv_i64 z =3D tcg_const_i64(0); - TCGv_i64 d =3D tcg_const_i64(dest); - TCGv_i64 p =3D tcg_const_i64(ctx->base.pc_next); + TCGv_i64 z =3D load_zero(ctx); + TCGv_i64 d =3D tcg_constant_i64(dest); + TCGv_i64 p =3D tcg_constant_i64(ctx->base.pc_next); =20 tcg_gen_movcond_i64(cond, cpu_pc, cmp, z, d, p); - - tcg_temp_free_i64(z); - tcg_temp_free_i64(d); - tcg_temp_free_i64(p); return DISAS_PC_UPDATED; } } @@ -716,22 +710,19 @@ static void gen_fp_exc_raise(int rc, int fn11) if (!(fn11 & QUAL_I)) { ignore |=3D FPCR_INE; } - ign =3D tcg_const_i32(ignore); + ign =3D tcg_constant_i32(ignore); =20 /* ??? Pass in the regno of the destination so that the helper can set EXC_MASK, which contains a bitmask of destination registers that have caused arithmetic traps. A simple userspace emulation does not require this. We do need it for a guest kernel's entArith, or if we were to do something clever with imprecise exceptions. */ - reg =3D tcg_const_i32(rc + 32); + reg =3D tcg_constant_i32(rc + 32); if (fn11 & QUAL_S) { gen_helper_fp_exc_raise_s(cpu_env, ign, reg); } else { gen_helper_fp_exc_raise(cpu_env, ign, reg); } - - tcg_temp_free_i32(reg); - tcg_temp_free_i32(ign); } =20 static void gen_cvtlq(TCGv vc, TCGv vb) @@ -824,7 +815,7 @@ IEEE_INTCVT(cvtqt) =20 static void gen_cpy_mask(TCGv vc, TCGv va, TCGv vb, bool inv_a, uint64_t m= ask) { - TCGv vmask =3D tcg_const_i64(mask); + TCGv vmask =3D tcg_constant_i64(mask); TCGv tmp =3D tcg_temp_new_i64(); =20 if (inv_a) { @@ -836,7 +827,6 @@ static void gen_cpy_mask(TCGv vc, TCGv va, TCGv vb, boo= l inv_a, uint64_t mask) tcg_gen_andc_i64(vc, vb, vmask); tcg_gen_or_i64(vc, vc, tmp); =20 - tcg_temp_free(vmask); tcg_temp_free(tmp); } =20 @@ -1210,12 +1200,9 @@ static DisasJumpType gen_call_pal(DisasContext *ctx,= int palcode) =20 case 0x3E: /* WTINT */ - { - TCGv_i32 tmp =3D tcg_const_i32(1); - tcg_gen_st_i32(tmp, cpu_env, -offsetof(AlphaCPU, env) + - offsetof(CPUState, halted)); - tcg_temp_free_i32(tmp); - } + tcg_gen_st_i32(tcg_constant_i32(1), cpu_env, + -offsetof(AlphaCPU, env) + + offsetof(CPUState, halted)); tcg_gen_movi_i64(ctx->ir[IR_V0], 0); return gen_excp(ctx, EXCP_HALTED, 0); =20 @@ -1366,12 +1353,8 @@ static DisasJumpType gen_mtpr(DisasContext *ctx, TCG= v vb, int regno) =20 case 253: /* WAIT */ - { - TCGv_i32 tmp =3D tcg_const_i32(1); - tcg_gen_st_i32(tmp, cpu_env, -offsetof(AlphaCPU, env) + - offsetof(CPUState, halted)); - tcg_temp_free_i32(tmp); - } + tcg_gen_st_i32(tcg_constant_i32(1), cpu_env, + -offsetof(AlphaCPU, env) + offsetof(CPUState, halte= d)); return gen_excp(ctx, EXCP_HALTED, 0); =20 case 252: @@ -2744,9 +2727,8 @@ static DisasJumpType translate_one(DisasContext *ctx,= uint32_t insn) vb =3D load_gpr(ctx, rb); } tcg_gen_movi_i64(cpu_lock_addr, -1); + st_flag_byte(load_zero(ctx), ENV_FLAG_RX_SHIFT); tmp =3D tcg_temp_new(); - tcg_gen_movi_i64(tmp, 0); - st_flag_byte(tmp, ENV_FLAG_RX_SHIFT); tcg_gen_andi_i64(tmp, vb, 1); st_flag_byte(tmp, ENV_FLAG_PAL_SHIFT); tcg_temp_free(tmp); --=20 2.25.1