From nobody Tue Feb 10 04:07:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) client-ip=209.85.221.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1625324561; cv=none; d=zohomail.com; s=zohoarc; b=LXmODuOLnsKNTr7dxzvCJHKa6c/7HhzDu2XcH7srBTNXJ5ahe+I+Pg5P99T1lW3X6VaiyV9rj30zIjwWztWLdCeq6eRWFi7IxL9ca3vnweoZhMK+zAMaJfvbR2B+5AZyb5VzU1wD6DiC4++ry4iWPKPpV8UyB7QsmSfltCMzVCA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625324561; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Y6Aw6PBMKZRq1SU/fOrs7JqdxeS7L8PFTUoQh1plry8=; b=m0oXvhxPMBOnvpKvB33Lf5WkzuYSNDNO7INadZMlSzxUU4g2bkaRmFj+q/90sJ3ua0gIQ1bgv0UVe5VLG/w0+eWLaYz5rkgolyMqoQgpKWB9JTdXB1zxxGHWVyOVOIIqQre7lN56d3hG/MlviSxONnxyF2kIblHab08LuXHzAFs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.zohomail.com with SMTPS id 1625324561712100.1694319459665; Sat, 3 Jul 2021 08:02:41 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id a8so4536177wrp.5 for ; Sat, 03 Jul 2021 08:02:41 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (184.red-95-127-187.staticip.rima-tde.net. [95.127.187.184]) by smtp.gmail.com with ESMTPSA id h14sm7580629wro.32.2021.07.03.08.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jul 2021 08:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y6Aw6PBMKZRq1SU/fOrs7JqdxeS7L8PFTUoQh1plry8=; b=NrWII9E97pM4B44oJeeyyQgpfnpvK/30cdOHWiUFz7QYhq5NRvReCUxi09t+uD3VJX Zh9S/iqFSU9j/yVWUbiFgRB4F/hrTg4qCJdbZ5WUarxUos09d8a+5esCgUOy4Pzx9jXc 8iapNP9m0HmS8fHQpXsLVNOOAq2Tv1ex5Fyo0on3ZblVpfpG7wE4LYogMhb7SG38Z3ce l1/12/xnynNpr1mkevJJlCIFXfH/aH91aKlRpDhDfjejw7+9NcN3YVDDFxxqcMZRU0S7 0JhcVBKMhw2eS90GOC+safYmKaTk4TTEJwDx7BfuEm7pMpvZvvvK+jL08o7x9YyIt65D ASTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Y6Aw6PBMKZRq1SU/fOrs7JqdxeS7L8PFTUoQh1plry8=; b=lrGkRBROBxZNBsusAdlxvi+N5TgYIkbDy/rRfSvhXEF4/KDst88qnhaOuZs96L9xuh 7mw9hHxFxYfTKGn1ealu63Xy9Z8+qe2jt3jgDlnA5PgWgUfHsaO0lqPbCz4Z5QvZXSoi 8pWwEdnXtyJEaFcA1QuzoqsoIyDrLyELmvaxGH0XYAZ1JxwOK0UUFZ1ZCm7zNeRhmb+E C1aOtpKtvzCxZAujimBmCo/6y8ovqxqA2nYKMqSzoN6KpYodokWZNLbf3Oi1URIYWRE2 wXjaUYbETh+GL+h/kY7Pzu+X528lyW8FzcEx5hDXg80a6HsTtlnRwn/dY7p6MQ6D+g+E dQlQ== X-Gm-Message-State: AOAM5324wa56yWJxDyjv4CL8fVXF5eB2aQf9Rk4K1TIND2XbxGwqVFO3 XwpQ4r9PugwLM/RHqa9SWhs= X-Google-Smtp-Source: ABdhPJwZWG8YOjZo0Cg5vSdiUqohqb1MM11nS6fIdhXrgInRbco9prro8pBtx2jQupDXxvzjwkejvw== X-Received: by 2002:a5d:488a:: with SMTP id g10mr5626309wrq.402.1625324560007; Sat, 03 Jul 2021 08:02:40 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Mark Cave-Ayland , Jason Wang , Finn Thain , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH 3/3] dp8393x: Store CRC using device configured endianess Date: Sat, 3 Jul 2021 17:02:19 +0200 Message-Id: <20210703150219.364582-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210703150219.364582-1-f4bug@amsat.org> References: <20210703150219.364582-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1625324563394100001 Little-Endian CRC is dubious, and the datasheet does not specify it being little-endian. Proceed similarly with the other memory accesses, use the device endianess. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/dp8393x.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index dee8236400c..3a07f5c8ac9 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -817,8 +817,12 @@ static ssize_t dp8393x_receive(NetClientState *nc, con= st uint8_t * buf, checksum =3D crc32(0, buf, pkt_size); =20 /* Put frame checksum into RBA */ - address_space_stl_le(&s->as, address, checksum, MEMTXATTRS_UNSPECI= FIED, - NULL); + if (s->big_endian) { + address_space_stl_be(&s->as, address, checksum, + MEMTXATTRS_UNSPECIFIED, NULL); + } else { + address_space_stl_le(&s->as, address, checksum, + MEMTXATTRS_UNSPECIFIED, NULL); address +=3D sizeof(checksum); } =20 --=20 2.31.1