From nobody Tue Feb 10 15:45:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) client-ip=209.85.221.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1625324550; cv=none; d=zohomail.com; s=zohoarc; b=IWsqQ8IaBMWC4ANPjVw9worEHMEI7b0TFUkccJjXvSq6Y4y08uP74SzF7Eip6RP+9IBqAheG8s4rJehKhtzkJx7zRq5xJeCQ5FsYUzDg9BToEfzfLkfITQENBnD7D/GU92lUY67gsAKKUUwl/1DmahTNdI6Ma9wvUNIM9lKvAKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625324550; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GQ4gWC/7+gJn1oGuHn1HbyTnBxetQ7Db9hH6DyIPNbY=; b=jyyM/NKW1hhptSBlbNNn+B+CfLvfjH4lOEWFPgZMGUTRTFf81fF/bYot1tym3EoZTOnwvwiT3xkxWbZhFSn1KfS1QOpzhs4XnymkATm6EoP1Y4JYBI8JCz0ljbS0PGv4JUV4C5Gr9DSwflPuAAX5LAtOYB3YcfcvzSqkDvlRDuE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.zohomail.com with SMTPS id 1625324550515609.8527734984292; Sat, 3 Jul 2021 08:02:30 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id i8so3345207wrp.12 for ; Sat, 03 Jul 2021 08:02:29 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (184.red-95-127-187.staticip.rima-tde.net. [95.127.187.184]) by smtp.gmail.com with ESMTPSA id k15sm15798378wms.21.2021.07.03.08.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jul 2021 08:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GQ4gWC/7+gJn1oGuHn1HbyTnBxetQ7Db9hH6DyIPNbY=; b=G5mt2ZERc5lfg3ZwlmeZIRGwMg5T7/BY2g8yHNN1UP9A6lVOFXwQdWrV01cCNPjZpy Ky4xU8fXD+8pZB7HV8gncd6ME/YWctUgnvPSyInm+cdGw5OnRc1uG8Ym3nxJMqh3YuRC ITTrw92VkJAASXKuOASdI1sWayvrfTpW92yTIJrt3f/yZ/IUdcMKt+dW12RzLA+gAiD5 VWIX0CV5CMu/SA2JqTefz+8WR/OQ1uHWHyiIUh2b1HAQk65hDFap1zMJEXWMNJes54YX IvFO+K8+KWrepjlE1X7w6Ew/UJK6IFVjKgKxkysRfPugbNFTS2iAUqpd4KAlL0rnVAoB Daeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=GQ4gWC/7+gJn1oGuHn1HbyTnBxetQ7Db9hH6DyIPNbY=; b=Y0DKMoFONWPdKqUUrN+rQS3AHG6DDq5j31sr5DmwbqQnldSR9xwnOzk5qOZ2tdEOiK toqklm+eV5nJhDsSDujjQnwVT63psCj8N8P35Eqs5gBdJjUCum+6aP0pnYhOAjtgeztl FpT3Uy6ULG/iKyqNSO/vy0vgOpVIZptSSk9vyhGgq/H6QYh3rvA9iMCHrFJGrF/OcrBU 8bSdfh7x3Kuf2OqzQP6yClpQk8Q6nbtYfcXyNsA5ZH7bg0xOmclOtXXNTSTMFGlrSg7/ GONd5fiiYOC0wnKW6qwR1IjyFdQcFM9u0ul1vmdzXxnOX+wHKhbxR7HoQMKXeMUD7UKv SrWA== X-Gm-Message-State: AOAM530DmWiIC8NWZalvcrtLEUyYDEeMmICJ+mauZk7/gWCLmxDA2z0Z iIkbgaQy9QZxu0hU0r+1Z70= X-Google-Smtp-Source: ABdhPJy8z44Mh2CHsRD1QvUJ+JvvuxBe1pa4m49122ExX4W0aP8kNhMzGpX6obQwb4OxTi0eX92dDw== X-Received: by 2002:adf:fac7:: with SMTP id a7mr5636636wrs.384.1625324548789; Sat, 03 Jul 2021 08:02:28 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Mark Cave-Ayland , Jason Wang , Finn Thain , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH 1/3] dp8393x: Store CRC using address_space_stl_le() Date: Sat, 3 Jul 2021 17:02:17 +0200 Message-Id: <20210703150219.364582-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210703150219.364582-1-f4bug@amsat.org> References: <20210703150219.364582-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1625324552490100003 The address_space API can handle endianess conversion. Replace cpu_to_le32() + address_space_write() by a single address_space_stl_le() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/dp8393x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index db9cfd786f5..99e179a5e86 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -802,7 +802,7 @@ static ssize_t dp8393x_receive(NetClientState *nc, cons= t uint8_t * buf, s->regs[SONIC_TRBA0] =3D s->regs[SONIC_CRBA0]; =20 /* Calculate the ethernet checksum */ - checksum =3D cpu_to_le32(crc32(0, buf, pkt_size)); + checksum =3D crc32(0, buf, pkt_size); =20 /* Put packet into RBA */ trace_dp8393x_receive_packet(dp8393x_crba(s)); @@ -812,8 +812,8 @@ static ssize_t dp8393x_receive(NetClientState *nc, cons= t uint8_t * buf, address +=3D pkt_size; =20 /* Put frame checksum into RBA */ - address_space_write(&s->as, address, MEMTXATTRS_UNSPECIFIED, - &checksum, sizeof(checksum)); + address_space_stl_le(&s->as, address, checksum, MEMTXATTRS_UNSPECIFIED, + NULL); address +=3D sizeof(checksum); =20 /* Pad short packets to keep pointers aligned */ --=20 2.31.1