From nobody Mon Feb 9 08:36:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) client-ip=209.85.221.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1625324550; cv=none; d=zohomail.com; s=zohoarc; b=IWsqQ8IaBMWC4ANPjVw9worEHMEI7b0TFUkccJjXvSq6Y4y08uP74SzF7Eip6RP+9IBqAheG8s4rJehKhtzkJx7zRq5xJeCQ5FsYUzDg9BToEfzfLkfITQENBnD7D/GU92lUY67gsAKKUUwl/1DmahTNdI6Ma9wvUNIM9lKvAKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625324550; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GQ4gWC/7+gJn1oGuHn1HbyTnBxetQ7Db9hH6DyIPNbY=; b=jyyM/NKW1hhptSBlbNNn+B+CfLvfjH4lOEWFPgZMGUTRTFf81fF/bYot1tym3EoZTOnwvwiT3xkxWbZhFSn1KfS1QOpzhs4XnymkATm6EoP1Y4JYBI8JCz0ljbS0PGv4JUV4C5Gr9DSwflPuAAX5LAtOYB3YcfcvzSqkDvlRDuE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.zohomail.com with SMTPS id 1625324550515609.8527734984292; Sat, 3 Jul 2021 08:02:30 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id i8so3345207wrp.12 for ; Sat, 03 Jul 2021 08:02:29 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (184.red-95-127-187.staticip.rima-tde.net. [95.127.187.184]) by smtp.gmail.com with ESMTPSA id k15sm15798378wms.21.2021.07.03.08.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jul 2021 08:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GQ4gWC/7+gJn1oGuHn1HbyTnBxetQ7Db9hH6DyIPNbY=; b=G5mt2ZERc5lfg3ZwlmeZIRGwMg5T7/BY2g8yHNN1UP9A6lVOFXwQdWrV01cCNPjZpy Ky4xU8fXD+8pZB7HV8gncd6ME/YWctUgnvPSyInm+cdGw5OnRc1uG8Ym3nxJMqh3YuRC ITTrw92VkJAASXKuOASdI1sWayvrfTpW92yTIJrt3f/yZ/IUdcMKt+dW12RzLA+gAiD5 VWIX0CV5CMu/SA2JqTefz+8WR/OQ1uHWHyiIUh2b1HAQk65hDFap1zMJEXWMNJes54YX IvFO+K8+KWrepjlE1X7w6Ew/UJK6IFVjKgKxkysRfPugbNFTS2iAUqpd4KAlL0rnVAoB Daeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=GQ4gWC/7+gJn1oGuHn1HbyTnBxetQ7Db9hH6DyIPNbY=; b=Y0DKMoFONWPdKqUUrN+rQS3AHG6DDq5j31sr5DmwbqQnldSR9xwnOzk5qOZ2tdEOiK toqklm+eV5nJhDsSDujjQnwVT63psCj8N8P35Eqs5gBdJjUCum+6aP0pnYhOAjtgeztl FpT3Uy6ULG/iKyqNSO/vy0vgOpVIZptSSk9vyhGgq/H6QYh3rvA9iMCHrFJGrF/OcrBU 8bSdfh7x3Kuf2OqzQP6yClpQk8Q6nbtYfcXyNsA5ZH7bg0xOmclOtXXNTSTMFGlrSg7/ GONd5fiiYOC0wnKW6qwR1IjyFdQcFM9u0ul1vmdzXxnOX+wHKhbxR7HoQMKXeMUD7UKv SrWA== X-Gm-Message-State: AOAM530DmWiIC8NWZalvcrtLEUyYDEeMmICJ+mauZk7/gWCLmxDA2z0Z iIkbgaQy9QZxu0hU0r+1Z70= X-Google-Smtp-Source: ABdhPJy8z44Mh2CHsRD1QvUJ+JvvuxBe1pa4m49122ExX4W0aP8kNhMzGpX6obQwb4OxTi0eX92dDw== X-Received: by 2002:adf:fac7:: with SMTP id a7mr5636636wrs.384.1625324548789; Sat, 03 Jul 2021 08:02:28 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Mark Cave-Ayland , Jason Wang , Finn Thain , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH 1/3] dp8393x: Store CRC using address_space_stl_le() Date: Sat, 3 Jul 2021 17:02:17 +0200 Message-Id: <20210703150219.364582-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210703150219.364582-1-f4bug@amsat.org> References: <20210703150219.364582-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1625324552490100003 The address_space API can handle endianess conversion. Replace cpu_to_le32() + address_space_write() by a single address_space_stl_le() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/dp8393x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index db9cfd786f5..99e179a5e86 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -802,7 +802,7 @@ static ssize_t dp8393x_receive(NetClientState *nc, cons= t uint8_t * buf, s->regs[SONIC_TRBA0] =3D s->regs[SONIC_CRBA0]; =20 /* Calculate the ethernet checksum */ - checksum =3D cpu_to_le32(crc32(0, buf, pkt_size)); + checksum =3D crc32(0, buf, pkt_size); =20 /* Put packet into RBA */ trace_dp8393x_receive_packet(dp8393x_crba(s)); @@ -812,8 +812,8 @@ static ssize_t dp8393x_receive(NetClientState *nc, cons= t uint8_t * buf, address +=3D pkt_size; =20 /* Put frame checksum into RBA */ - address_space_write(&s->as, address, MEMTXATTRS_UNSPECIFIED, - &checksum, sizeof(checksum)); + address_space_stl_le(&s->as, address, checksum, MEMTXATTRS_UNSPECIFIED, + NULL); address +=3D sizeof(checksum); =20 /* Pad short packets to keep pointers aligned */ --=20 2.31.1 From nobody Mon Feb 9 08:36:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) client-ip=209.85.221.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1625324556; cv=none; d=zohomail.com; s=zohoarc; b=M5E4ZOHtSa+323tx4tV3HrejCt/dgDTd+W08HtGrgDePASW85FRtT3yNNBDvt67ui/OWST3IbvQMFhNXanAc1dS2jq1lkqbOb5mjuMJHw0MtdK9vZSk9PHLQRBDY1K73skWApQNFQe/yZ3Uh3bvp7cg7IBfdH/9eTO/zgt2DboU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625324556; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CD4705Cw8bDOEOSQX+bvLucda0Kfkxx7BdKEQvUolXw=; b=iCI9bYE9PF4O+gykJt+NO/Nto8T9rALwxnphefoQkXANOawFB+ROG6VhnKXYw/KOV00/cIpp5myRo6ErGertiUUYTSuYDCOx9w4sJqcJ6rFHFlOr38F+v7bV61iMaMkudpz5vQsqrkR1xo09zHBX4tb3MaFuQb5GtI2QaVqFZ6s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.zohomail.com with SMTPS id 1625324556168984.5985329985659; Sat, 3 Jul 2021 08:02:36 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id u8so16200384wrq.8 for ; Sat, 03 Jul 2021 08:02:35 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (184.red-95-127-187.staticip.rima-tde.net. [95.127.187.184]) by smtp.gmail.com with ESMTPSA id l20sm6614866wmq.3.2021.07.03.08.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jul 2021 08:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CD4705Cw8bDOEOSQX+bvLucda0Kfkxx7BdKEQvUolXw=; b=LvbGdsmzO58Gz/ms66ZnCG7bDEtBfqwyBZjWLM7au+7id4C0AEfeF2CmG3C5YafbsF 4TMwIsEctSr3/78C59luy/do38chw+pIwFS0HWFK8/0annYlzLv1h8FJz0DknvMagA/1 33E9KkIl5l0wFNVHu5arGiV/4JfiLgy9vx1KUh16Jusf/A3AWv/PCqnWD+SIAbrTpxKd CK0RgV+/iPZ+116bL38+sl9QqCoJmGriXiPl+lWYYVTNrQX9E0Uw00gM4a66P+VDY5Ki ZAsPfp82B/VGtzPblunaxnFdrA5AksvYDrmG9OdyTvGQRXONGw7H7Amne3/ze5Dt/xS0 I4jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=CD4705Cw8bDOEOSQX+bvLucda0Kfkxx7BdKEQvUolXw=; b=o33jrul9QcNPbIuPPmODVkLdpxw4hKqz/6xPXMdAK66dqdR/RRKU/YZ7VaruCjeOLA q8FHEoydR+mmstKpwT/AJUx70tOxC8C4Ql2cmbSQ51WK6JJP/+SDipGUCGNFLGHAuvlW T/8n5CMtw58mokZtw39vSYPB05dxLt97JnZ93tbTYWGw3AgQ1SLkVz6DdCWekwmcjfjm v7GWgdMOxxP8ua+oH4ErAqre8whqPm6hGFYKGSzfSLzo6U7Y/L1fa7evOV0y47ZxrsiM wLz/jNJPh6kGp0S+GzP0mF1z12nW9KIIYJYyPR9DLaWJbn9VyA2lGbXX2Op+bpZHRi/d nVdw== X-Gm-Message-State: AOAM533UowNpKfoL7nCEhID3XPj7mJJFSQSh2f/RD/4rXSUohTTM8e5s /tWPWkcWqOlhnoVV9GtQZ90= X-Google-Smtp-Source: ABdhPJyJA2clixyrBVs4M+brbdTzevWdRVzqOT7toWu0e9tDOzyBbQTzirUDhmEidPF13Y+hwt1Vjg== X-Received: by 2002:a05:6000:2c7:: with SMTP id o7mr1510481wry.0.1625324554454; Sat, 03 Jul 2021 08:02:34 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Mark Cave-Ayland , Jason Wang , Finn Thain , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH 2/3] dp8393x: Do not amend CRC if it is inhibited (CRCI bit set) Date: Sat, 3 Jul 2021 17:02:18 +0200 Message-Id: <20210703150219.364582-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210703150219.364582-1-f4bug@amsat.org> References: <20210703150219.364582-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1625324557386100001 When the CRCI (CRC INHIBIT) bit is set, the 4-byte FCS field is not transmitted. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/dp8393x.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 99e179a5e86..dee8236400c 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -472,6 +472,7 @@ static void dp8393x_do_transmit_packets(dp8393xState *s) */ } else { /* Remove existing FCS */ + /* TODO check crc */ tx_len -=3D 4; if (tx_len < 0) { trace_dp8393x_transmit_txlen_error(tx_len); @@ -758,7 +759,10 @@ static ssize_t dp8393x_receive(NetClientState *nc, con= st uint8_t * buf, return pkt_size; } =20 - rx_len =3D pkt_size + sizeof(checksum); + rx_len =3D pkt_size; + if (s->regs[SONIC_TCR] & SONIC_TCR_CRCI) { + rx_len +=3D sizeof(checksum); + } if (s->regs[SONIC_DCR] & SONIC_DCR_DW) { padded_len =3D ((rx_len - 1) | 3) + 1; } else { @@ -801,9 +805,6 @@ static ssize_t dp8393x_receive(NetClientState *nc, cons= t uint8_t * buf, s->regs[SONIC_TRBA1] =3D s->regs[SONIC_CRBA1]; s->regs[SONIC_TRBA0] =3D s->regs[SONIC_CRBA0]; =20 - /* Calculate the ethernet checksum */ - checksum =3D crc32(0, buf, pkt_size); - /* Put packet into RBA */ trace_dp8393x_receive_packet(dp8393x_crba(s)); address =3D dp8393x_crba(s); @@ -811,10 +812,15 @@ static ssize_t dp8393x_receive(NetClientState *nc, co= nst uint8_t * buf, buf, pkt_size); address +=3D pkt_size; =20 - /* Put frame checksum into RBA */ - address_space_stl_le(&s->as, address, checksum, MEMTXATTRS_UNSPECIFIED, - NULL); - address +=3D sizeof(checksum); + if (s->regs[SONIC_TCR] & SONIC_TCR_CRCI) { + /* Calculate the ethernet checksum */ + checksum =3D crc32(0, buf, pkt_size); + + /* Put frame checksum into RBA */ + address_space_stl_le(&s->as, address, checksum, MEMTXATTRS_UNSPECI= FIED, + NULL); + address +=3D sizeof(checksum); + } =20 /* Pad short packets to keep pointers aligned */ if (rx_len < padded_len) { --=20 2.31.1 From nobody Mon Feb 9 08:36:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) client-ip=209.85.221.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1625324561; cv=none; d=zohomail.com; s=zohoarc; b=LXmODuOLnsKNTr7dxzvCJHKa6c/7HhzDu2XcH7srBTNXJ5ahe+I+Pg5P99T1lW3X6VaiyV9rj30zIjwWztWLdCeq6eRWFi7IxL9ca3vnweoZhMK+zAMaJfvbR2B+5AZyb5VzU1wD6DiC4++ry4iWPKPpV8UyB7QsmSfltCMzVCA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625324561; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Y6Aw6PBMKZRq1SU/fOrs7JqdxeS7L8PFTUoQh1plry8=; b=m0oXvhxPMBOnvpKvB33Lf5WkzuYSNDNO7INadZMlSzxUU4g2bkaRmFj+q/90sJ3ua0gIQ1bgv0UVe5VLG/w0+eWLaYz5rkgolyMqoQgpKWB9JTdXB1zxxGHWVyOVOIIqQre7lN56d3hG/MlviSxONnxyF2kIblHab08LuXHzAFs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.zohomail.com with SMTPS id 1625324561712100.1694319459665; Sat, 3 Jul 2021 08:02:41 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id a8so4536177wrp.5 for ; Sat, 03 Jul 2021 08:02:41 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (184.red-95-127-187.staticip.rima-tde.net. [95.127.187.184]) by smtp.gmail.com with ESMTPSA id h14sm7580629wro.32.2021.07.03.08.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Jul 2021 08:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y6Aw6PBMKZRq1SU/fOrs7JqdxeS7L8PFTUoQh1plry8=; b=NrWII9E97pM4B44oJeeyyQgpfnpvK/30cdOHWiUFz7QYhq5NRvReCUxi09t+uD3VJX Zh9S/iqFSU9j/yVWUbiFgRB4F/hrTg4qCJdbZ5WUarxUos09d8a+5esCgUOy4Pzx9jXc 8iapNP9m0HmS8fHQpXsLVNOOAq2Tv1ex5Fyo0on3ZblVpfpG7wE4LYogMhb7SG38Z3ce l1/12/xnynNpr1mkevJJlCIFXfH/aH91aKlRpDhDfjejw7+9NcN3YVDDFxxqcMZRU0S7 0JhcVBKMhw2eS90GOC+safYmKaTk4TTEJwDx7BfuEm7pMpvZvvvK+jL08o7x9YyIt65D ASTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Y6Aw6PBMKZRq1SU/fOrs7JqdxeS7L8PFTUoQh1plry8=; b=lrGkRBROBxZNBsusAdlxvi+N5TgYIkbDy/rRfSvhXEF4/KDst88qnhaOuZs96L9xuh 7mw9hHxFxYfTKGn1ealu63Xy9Z8+qe2jt3jgDlnA5PgWgUfHsaO0lqPbCz4Z5QvZXSoi 8pWwEdnXtyJEaFcA1QuzoqsoIyDrLyELmvaxGH0XYAZ1JxwOK0UUFZ1ZCm7zNeRhmb+E C1aOtpKtvzCxZAujimBmCo/6y8ovqxqA2nYKMqSzoN6KpYodokWZNLbf3Oi1URIYWRE2 wXjaUYbETh+GL+h/kY7Pzu+X528lyW8FzcEx5hDXg80a6HsTtlnRwn/dY7p6MQ6D+g+E dQlQ== X-Gm-Message-State: AOAM5324wa56yWJxDyjv4CL8fVXF5eB2aQf9Rk4K1TIND2XbxGwqVFO3 XwpQ4r9PugwLM/RHqa9SWhs= X-Google-Smtp-Source: ABdhPJwZWG8YOjZo0Cg5vSdiUqohqb1MM11nS6fIdhXrgInRbco9prro8pBtx2jQupDXxvzjwkejvw== X-Received: by 2002:a5d:488a:: with SMTP id g10mr5626309wrq.402.1625324560007; Sat, 03 Jul 2021 08:02:40 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Laurent Vivier , Mark Cave-Ayland , Jason Wang , Finn Thain , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH 3/3] dp8393x: Store CRC using device configured endianess Date: Sat, 3 Jul 2021 17:02:19 +0200 Message-Id: <20210703150219.364582-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210703150219.364582-1-f4bug@amsat.org> References: <20210703150219.364582-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1625324563394100001 Little-Endian CRC is dubious, and the datasheet does not specify it being little-endian. Proceed similarly with the other memory accesses, use the device endianess. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/dp8393x.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index dee8236400c..3a07f5c8ac9 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -817,8 +817,12 @@ static ssize_t dp8393x_receive(NetClientState *nc, con= st uint8_t * buf, checksum =3D crc32(0, buf, pkt_size); =20 /* Put frame checksum into RBA */ - address_space_stl_le(&s->as, address, checksum, MEMTXATTRS_UNSPECI= FIED, - NULL); + if (s->big_endian) { + address_space_stl_be(&s->as, address, checksum, + MEMTXATTRS_UNSPECIFIED, NULL); + } else { + address_space_stl_le(&s->as, address, checksum, + MEMTXATTRS_UNSPECIFIED, NULL); address +=3D sizeof(checksum); } =20 --=20 2.31.1