From nobody Tue Feb 10 06:57:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) client-ip=209.85.221.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1625241550; cv=none; d=zohomail.com; s=zohoarc; b=XrQYZ5tgjTgXf6woX/ICKZEqEuNnC0paR+4CAsd/a6R+X9v1q/9VUkRFrXdX5yBo61hOXRQonZmrHGMZWjh7m1IlZK7ClQd/P2gKmT91AFtW58lC+f2y5HQVl4nM4h4qxAtXjZN90mCFqMY0/HIS761A3DLrnvMf8awQPzQNnvg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625241550; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=g3mXQWSPJFZt6+QzEux1hZKoh5RScSdBLOmydGx074Y=; b=DFnaosk0l93EK6+w8QlIE9uMXhqTqtGWcuQPWw/s/FPmFDF/FcGqsCIb0puD72PgQtiBIry+JkpA0GZ2q3CpSI15DxkWsd7Hn+X4Eu1DrbV1RxMKU1LH5uwM3AU00bdTP5EZQJkwXmf1j4PIgD8Hsr8Bf0fQwgkzjH9YgeO3WnE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.zohomail.com with SMTPS id 16252415502811012.1099509039495; Fri, 2 Jul 2021 08:59:10 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id a8so1364244wrp.5 for ; Fri, 02 Jul 2021 08:59:09 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.Ascou-CH1 (pop.92-184-108-23.mobile.abo.orange.fr. [92.184.108.23]) by smtp.gmail.com with ESMTPSA id w22sm13164965wmc.4.2021.07.02.08.59.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 08:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g3mXQWSPJFZt6+QzEux1hZKoh5RScSdBLOmydGx074Y=; b=oee057xoNxavxbV3w1EcDoSX+iZJ6ApdzqcFjJt1iDHkg9BaqS3Y0X3X+qoGkPesVJ kbowZ3I7FrsS9YEMOqH/8WFqYrUu3vAyrcpfYR0bnIz3sPEX+TU3kyVzxrf253FjtfEK GcO1fOiZUJziYHy27+Be2czKDowXvuR2O6jh2vF4Iy/G/u15I542+jW2spUXE0Eg10O/ /gvKEB9tRAzr0uBdfTbBKH/uKPykthQYTwoIL28ksI7lcrz6LC8YglYAYgWhSMGat8IQ Je4GbY8P3PWaxfqVBRPwfKYyKrqABYKsEIrfFJDB1gBzzUPf/PkXy5eBbh165pBycIzf 1Meg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=g3mXQWSPJFZt6+QzEux1hZKoh5RScSdBLOmydGx074Y=; b=D88Nsb/pR97oq/wpq/+Uh4YDq7Z3MULbHYxA+/ziAQ1xNCJH7dDD0f45jDs7bjcasG HKNWYUHB4l0k5UoGeSilAqK7V9vqnH3Vkix87bts1P/D74wESahJbNEEbUqUekakO8DP Ou6Sgxxa4pb3w5jE4bMX+We8c7y1WpxT70bar6ZQl5nwy5bDZnt4lBmxRYSQKgVBuhLO STQvNW+s7Eccn6DNaknoYqz1wK7mgyFaCi+U2EYRrLKRtx0Spd5Chxbe7lBMVXSsyl9k vmDkRC+JxoxxpdjTciZF4A5YeGM2tjzoNNg3gXpQBIXz5tmEwnvn8cEPPMz4gLGBLd6o cXSQ== X-Gm-Message-State: AOAM531UXb7iZX3nM+NEdw0wejFH+j0i2whurQWnl8Yz566vvX4/OLdW qheQQIZrkjsHeUZO+hTEXtU= X-Google-Smtp-Source: ABdhPJy2COYHmYt0mzeBI524gpiv2nXVcQmSZd0yi3aOFmCpFANUA1Xfl6iczGHWyzAIDXa389Y3Cg== X-Received: by 2002:a5d:62c2:: with SMTP id o2mr385964wrv.234.1625241548617; Fri, 02 Jul 2021 08:59:08 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Alexander Bulekov , Michael Olbrich , Bin Meng , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bin Meng Subject: [PATCH 1/3] hw/sd: When card is in wrong state, log which state it is Date: Fri, 2 Jul 2021 17:58:58 +0200 Message-Id: <20210702155900.148665-2-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210702155900.148665-1-f4bug@amsat.org> References: <20210702155900.148665-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1625241550761100001 We report the card is in an inconsistent state, but don't precise in which state it is. Add this information, as it is useful when debugging problems. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Bin Meng Message-Id: <20210624142209.1193073-2-f4bug@amsat.org> Reviewed-by: Alexander Bulekov --- hw/sd/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 282d39a7042..d8fdf84f4db 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1504,7 +1504,8 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, S= DRequest req) return sd_illegal; } =20 - qemu_log_mask(LOG_GUEST_ERROR, "SD: CMD%i in a wrong state\n", req.cmd= ); + qemu_log_mask(LOG_GUEST_ERROR, "SD: CMD%i in a wrong state: %s\n", + req.cmd, sd_state_name(sd->state)); return sd_illegal; } =20 --=20 2.31.1