From nobody Tue Feb 10 20:06:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) client-ip=209.85.221.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1625233043; cv=none; d=zohomail.com; s=zohoarc; b=ZNUS7lLnKq1ptMYeZcv+21tGVaoGuh6q3kKlpls5h334rfsRPhmd7D5r6SRJRNCSdIs4xVr8K+H9A0yqQkDJ3AEufVrmECvY4OZMucY4+wWsHYKiTn+7zp4W24tOkx9Uj/rikmulvY3r47k2R2nn8nZw2X6GcEAQ1634/8eUru8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625233043; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CpqtyrEBgGp2q4wqDOzQhvyghW20BSPg8kexiW49YjQ=; b=DRQd1ZVktsGihcBnBAwVZE4rYAiY5BCDpRyagIusl2woA8wAjfJrFRvzxW7t33KtJGNv9JDazUzcA8lhDXVLyXr6QMGvO3jOXlQGPzhe/mAFgbAqd+gbzCHaImQKbUdV/u6KgSIIj/VzlARlFK183O/LV3pt4gfjGSLc7+zM8Lo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by mx.zohomail.com with SMTPS id 1625233043846413.8555159383766; Fri, 2 Jul 2021 06:37:23 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id a13so12483265wrf.10 for ; Fri, 02 Jul 2021 06:37:23 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.Ascou-CH1 (pop.92-184-108-23.mobile.abo.orange.fr. [92.184.108.23]) by smtp.gmail.com with ESMTPSA id n12sm3782890wmq.5.2021.07.02.06.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 06:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CpqtyrEBgGp2q4wqDOzQhvyghW20BSPg8kexiW49YjQ=; b=brjstrgbDbMKkqR75WF8H/ykYRSyX1VZzBTJts8CHFOvXwcT/6rFHYDuIOYSY7R3Xj 7qEqCpzfVgwhoNaIXldQstroytDz9yvh2QK55FLaeMSUN820QaxAeX0D5q79QlC3enP9 H0PIthmmRCgyA3lF18ZcFaQJIdia0jzTOz9ZuRuRpef+opIaA4k4pELjAl8k4YzHKaBw kJhHQQ/Nx/7eqUeerxchAx9wYS+kZ5psU583ar6N/gLRnRbprzJK9jnK9+RwucgWHNkI A7dCvxt7V5e34LGYM9m7/WWDaltSkvANfmlVjcq7DITZ2wbokG5h9WjkD6VuQ44ehtDq T2gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=CpqtyrEBgGp2q4wqDOzQhvyghW20BSPg8kexiW49YjQ=; b=VWEjvqgkeN2aRHouRR8yhW2jpMiZT1dIltK2ol34I425zpUtV3aHx/Ffy3ijayXivW 9biDcLkwDRsS4EDmTeHvhryhvzemPN9CU2HzIvI4spNC9TGhOd+Dg8xJhibqizfmnJ8k 0KphibUMsEMy3xNyebvhHLdyqf21DnD1Kx56WqUEEM9lOTpOvl3QDcjop9rPoT65eHuz UtUI1NwqgtW/3rRNujvP07w+0auO1fPhiPSEE4bR1fnu2e3GE9uHOT3uYg7tTrGKpk8C WyrU8XOB5mIBkOXOow4YQdEzSNsHwgkfgSClhClmzugFNdextvDIy8SmbvvI8V4D0pmQ 77ZQ== X-Gm-Message-State: AOAM532mjUG1gfdwN5FLjmkBQ4Y7Wqo7i+yDgkU/CNgOTaAlcuFaQxQR hywK1dQR3vANiNNc3Zb/U9Zr2g3C9tC1cXnC X-Google-Smtp-Source: ABdhPJzAzFLDTf+pnaaSJqPc0qK4DsyEbvN2Gnlfr8IiI4ef5N6FeOjz0JPZJMT1cyjUTyi+M624TQ== X-Received: by 2002:a5d:524e:: with SMTP id k14mr6091871wrc.390.1625233042168; Fri, 02 Jul 2021 06:37:22 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mark Cave-Ayland , Finn Thain , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 14/18] dp8393x: remove onboard PROM containing MAC address and checksum Date: Fri, 2 Jul 2021 15:35:53 +0200 Message-Id: <20210702133557.60317-15-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210702133557.60317-1-f4bug@amsat.org> References: <20210702133557.60317-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1625233045715100001 From: Mark Cave-Ayland According to the datasheet the dp8393x chipset does not contain any NVRAM c= apable of storing a MAC address or checksum. Now that both the MIPS jazz and m68k = q800 boards generate the PROM region and checksum themselves, remove the generat= ed PROM from the dp8393x device itself. Signed-off-by: Mark Cave-Ayland Tested-by: Finn Thain Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210625065401.30170-6-mark.cave-ayland@ilande.co.uk> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/dp8393x.c | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index ea5b22f6802..252c0a26641 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -30,8 +30,6 @@ #include "qom/object.h" #include "trace.h" =20 -#define SONIC_PROM_SIZE 0x1000 - static const char *reg_names[] =3D { "CR", "DCR", "RCR", "TCR", "IMR", "ISR", "UTDA", "CTDA", "TPS", "TFC", "TSA0", "TSA1", "TFS", "URDA", "CRDA", "CRBA0", @@ -157,7 +155,6 @@ struct dp8393xState { NICConf conf; NICState *nic; MemoryRegion mmio; - MemoryRegion prom; =20 /* Registers */ uint8_t cam[16][6]; @@ -966,16 +963,12 @@ static void dp8393x_instance_init(Object *obj) dp8393xState *s =3D DP8393X(obj); =20 sysbus_init_mmio(sbd, &s->mmio); - sysbus_init_mmio(sbd, &s->prom); sysbus_init_irq(sbd, &s->irq); } =20 static void dp8393x_realize(DeviceState *dev, Error **errp) { dp8393xState *s =3D DP8393X(dev); - int i, checksum; - uint8_t *prom; - Error *local_err =3D NULL; =20 address_space_init(&s->as, s->dma_mr, "dp8393x"); memory_region_init_io(&s->mmio, OBJECT(dev), &dp8393x_ops, s, @@ -986,23 +979,6 @@ static void dp8393x_realize(DeviceState *dev, Error **= errp) qemu_format_nic_info_str(qemu_get_queue(s->nic), s->conf.macaddr.a); =20 s->watchdog =3D timer_new_ns(QEMU_CLOCK_VIRTUAL, dp8393x_watchdog, s); - - memory_region_init_rom(&s->prom, OBJECT(dev), "dp8393x-prom", - SONIC_PROM_SIZE, &local_err); - if (local_err) { - error_propagate(errp, local_err); - return; - } - prom =3D memory_region_get_ram_ptr(&s->prom); - checksum =3D 0; - for (i =3D 0; i < 6; i++) { - prom[i] =3D s->conf.macaddr.a[i]; - checksum +=3D prom[i]; - if (checksum > 0xff) { - checksum =3D (checksum + 1) & 0xff; - } - } - prom[7] =3D 0xff - checksum; } =20 static const VMStateDescription vmstate_dp8393x =3D { --=20 2.31.1