From nobody Wed May 7 09:44:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1625231749; cv=none; d=zohomail.com; s=zohoarc; b=Lcff2dznTiqGfPSIPYIZR4B+1oecn67BLMbvl/XFY1GNYfNq2W2h2nCcOhSd13dQygsH0TgEJzuaSYH6PThAQmqY3+9n4/sw6nnT9Qz2GGnR0OXUAyTDnRWRPpWAjxXSC3q0WZRwC7fUxkJsxA88w67UOPCvKpHXT9GUtVTTCdY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1625231749; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=a5BGw4PBnWJybzzHIxsr68yVDuDSz88IKUbflovVXW8=; b=S1lzju7JQXXHtH+jR7AVr3ftpTFJR+y4V0y2pFcUjQhXIcUdSty2j5pD++4NpjVTKjgseTv1PWxzZY3xsshSkIHOyF1smSqrSmlFEGEb93EPrFW09WqoFW5e/rrGwoRyUqfZTiR8U2WOxN1Obc8gyHywJOKOeRDPdLoIeuTC6Qc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from=<peter.maydell@linaro.org> (p=none dis=none) Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org> Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1625231749303310.728068362096; Fri, 2 Jul 2021 06:15:49 -0700 (PDT) Received: from localhost ([::1]:36318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <qemu-devel-bounces+importer=patchew.org@nongnu.org>) id 1lzJ1G-0000Le-8M for importer@patchew.org; Fri, 02 Jul 2021 09:15:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>) id 1lzImS-0007ja-7z for qemu-devel@nongnu.org; Fri, 02 Jul 2021 09:00:30 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]:35511) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>) id 1lzImG-0007jy-9g for qemu-devel@nongnu.org; Fri, 02 Jul 2021 09:00:27 -0400 Received: by mail-wr1-x431.google.com with SMTP id m18so12392742wrv.2 for <qemu-devel@nongnu.org>; Fri, 02 Jul 2021 06:00:10 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id s3sm3333351wro.30.2021.07.02.06.00.09 for <qemu-devel@nongnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 06:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=a5BGw4PBnWJybzzHIxsr68yVDuDSz88IKUbflovVXW8=; b=ywngBVnx+RMl0AjNwKqQs9pO4FZHOChEYQbVd0a0XMddjhbv4Pqarr9ien2Q4Gzjg4 PtEhuqOX1sQDGbtyMqSqQ5kyMxc/7Xpc/baN6rCvHMdimidhNv+GIwxz2B/2ufK/r/iX wX9G69TelJp7S8Kurqu3HacZPd+JP3H4dvrIQGww5NplY/m1DTnIUoCpeVwi6b/LLe/e abjntUHF+ApL+2ntwuvje/NGRlOT3eThRstj1ivAGNfhh1crh2AX43aDwgcXAm3i/oHh PVfZMGEmqoZD5+MD59whTW8TqX4ic6dncdo/uJC7dSvwCuAqnt5NGZiCo0xryFEDByNe FNVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a5BGw4PBnWJybzzHIxsr68yVDuDSz88IKUbflovVXW8=; b=Lgnslg26KbBvXHb4Gtb37rPcSN5piC2c3CS0TVo1cE8owoN76UcrZc+reU5rbgFCYY DtDceMmJPFqtylQtBiqnmbK5RXQoi24deCEHWZxGZV84Q1OCrTFxO45x6qTDw3Kq2244 pounUf+pSBs4FnK207QB/IgtmditwxEdtFWx/B+G9fEqRZeHmnFK7U3C1rMlzYDLHNpV yRb1IuDNfVkB2qxMAp3S0VcKSbifD5j1hDyrNsXt8eH0AbIBH2G2a07MJ8tKa/fNB8b5 mO1Joafx7gec+q4zVTL3ZwDgDPd9Brhvaokp7MvPBJMqSCXotUtOwoFxXX0ACzCagZF0 IiFQ== X-Gm-Message-State: AOAM531MDNa16Ggc0lrxhReKbAnU/qZm3G7aRf82iznm05lVQ5EhiR9/ otRn8omoJIXzUs5yI9Jz6Xq9/BKqxX9OF6CJ X-Google-Smtp-Source: ABdhPJykTJshYF40+skBZqUuDLGnU2pwRrIUOcKWZnhbTLfPEsxhj9zzpK4v1w4ynoEUozaJ2+5yPw== X-Received: by 2002:a5d:59a5:: with SMTP id p5mr5774057wrr.304.1625230810058; Fri, 02 Jul 2021 06:00:10 -0700 (PDT) From: Peter Maydell <peter.maydell@linaro.org> To: qemu-devel@nongnu.org Subject: [PULL 19/24] target/arm: Implement MVE VSHLC Date: Fri, 2 Jul 2021 13:59:49 +0100 Message-Id: <20210702125954.13247-20-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210702125954.13247-1-peter.maydell@linaro.org> References: <20210702125954.13247-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+importer=patchew.org@nongnu.org> X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1625231750013100001 Content-Type: text/plain; charset="utf-8" Implement the MVE VSHLC insn, which performs a shift left of the entire vector with carry in bits provided from a general purpose register and carry out bits written back to that register. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-id: 20210628135835.6690-14-peter.maydell@linaro.org --- target/arm/helper-mve.h | 2 ++ target/arm/mve.decode | 2 ++ target/arm/mve_helper.c | 38 ++++++++++++++++++++++++++++++++++++++ target/arm/translate-mve.c | 30 ++++++++++++++++++++++++++++++ 4 files changed, 72 insertions(+) diff --git a/target/arm/helper-mve.h b/target/arm/helper-mve.h index 96b4c0dfd34..d414b6309d5 100644 --- a/target/arm/helper-mve.h +++ b/target/arm/helper-mve.h @@ -444,3 +444,5 @@ DEF_HELPER_FLAGS_4(mve_vqrshrunbb, TCG_CALL_NO_WG, void= , env, ptr, ptr, i32) DEF_HELPER_FLAGS_4(mve_vqrshrunbh, TCG_CALL_NO_WG, void, env, ptr, ptr, i3= 2) DEF_HELPER_FLAGS_4(mve_vqrshruntb, TCG_CALL_NO_WG, void, env, ptr, ptr, i3= 2) DEF_HELPER_FLAGS_4(mve_vqrshrunth, TCG_CALL_NO_WG, void, env, ptr, ptr, i3= 2) + +DEF_HELPER_FLAGS_4(mve_vshlc, TCG_CALL_NO_WG, i32, env, ptr, i32, i32) diff --git a/target/arm/mve.decode b/target/arm/mve.decode index 1d11387bc07..914b108c379 100644 --- a/target/arm/mve.decode +++ b/target/arm/mve.decode @@ -419,3 +419,5 @@ VQRSHRUNB 111 1 1110 1 . ... ... ... 0 1111 1 1= . 0 ... 0 @2_shr_b VQRSHRUNB 111 1 1110 1 . ... ... ... 0 1111 1 1 . 0 ... 0 @2_shr_h VQRSHRUNT 111 1 1110 1 . ... ... ... 1 1111 1 1 . 0 ... 0 @2_shr_b VQRSHRUNT 111 1 1110 1 . ... ... ... 1 1111 1 1 . 0 ... 0 @2_shr_h + +VSHLC 111 0 1110 1 . 1 imm:5 ... 0 1111 1100 rdm:4 qd=3D%qd diff --git a/target/arm/mve_helper.c b/target/arm/mve_helper.c index 3e736e89095..9d4a07c1c0c 100644 --- a/target/arm/mve_helper.c +++ b/target/arm/mve_helper.c @@ -1468,3 +1468,41 @@ DO_VSHRN_SAT_UB(vqrshrnb_ub, vqrshrnt_ub, DO_RSHRN_U= B) DO_VSHRN_SAT_UH(vqrshrnb_uh, vqrshrnt_uh, DO_RSHRN_UH) DO_VSHRN_SAT_SB(vqrshrunbb, vqrshruntb, DO_RSHRUN_B) DO_VSHRN_SAT_SH(vqrshrunbh, vqrshrunth, DO_RSHRUN_H) + +uint32_t HELPER(mve_vshlc)(CPUARMState *env, void *vd, uint32_t rdm, + uint32_t shift) +{ + uint32_t *d =3D vd; + uint16_t mask =3D mve_element_mask(env); + unsigned e; + uint32_t r; + + /* + * For each 32-bit element, we shift it left, bringing in the + * low 'shift' bits of rdm at the bottom. Bits shifted out at + * the top become the new rdm, if the predicate mask permits. + * The final rdm value is returned to update the register. + * shift =3D=3D 0 here means "shift by 32 bits". + */ + if (shift =3D=3D 0) { + for (e =3D 0; e < 16 / 4; e++, mask >>=3D 4) { + r =3D rdm; + if (mask & 1) { + rdm =3D d[H4(e)]; + } + mergemask(&d[H4(e)], r, mask); + } + } else { + uint32_t shiftmask =3D MAKE_64BIT_MASK(0, shift); + + for (e =3D 0; e < 16 / 4; e++, mask >>=3D 4) { + r =3D (d[H4(e)] << shift) | (rdm & shiftmask); + if (mask & 1) { + rdm =3D d[H4(e)] >> (32 - shift); + } + mergemask(&d[H4(e)], r, mask); + } + } + mve_advance_vpt(env); + return rdm; +} diff --git a/target/arm/translate-mve.c b/target/arm/translate-mve.c index eef4f1f6ce3..460dff260fe 100644 --- a/target/arm/translate-mve.c +++ b/target/arm/translate-mve.c @@ -938,3 +938,33 @@ DO_2SHIFT_N(VQRSHRNB_U, vqrshrnb_u) DO_2SHIFT_N(VQRSHRNT_U, vqrshrnt_u) DO_2SHIFT_N(VQRSHRUNB, vqrshrunb) DO_2SHIFT_N(VQRSHRUNT, vqrshrunt) + +static bool trans_VSHLC(DisasContext *s, arg_VSHLC *a) +{ + /* + * Whole Vector Left Shift with Carry. The carry is taken + * from a general purpose register and written back there. + * An imm of 0 means "shift by 32". + */ + TCGv_ptr qd; + TCGv_i32 rdm; + + if (!dc_isar_feature(aa32_mve, s) || !mve_check_qreg_bank(s, a->qd)) { + return false; + } + if (a->rdm =3D=3D 13 || a->rdm =3D=3D 15) { + /* CONSTRAINED UNPREDICTABLE: we UNDEF */ + return false; + } + if (!mve_eci_check(s) || !vfp_access_check(s)) { + return true; + } + + qd =3D mve_qreg_ptr(a->qd); + rdm =3D load_reg(s, a->rdm); + gen_helper_mve_vshlc(rdm, cpu_env, qd, rdm, tcg_constant_i32(a->imm)); + store_reg(s, a->rdm, rdm); + tcg_temp_free_ptr(qd); + mve_update_eci(s); + return true; +} --=20 2.20.1