From nobody Sat May 18 22:54:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) client-ip=209.85.128.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1624945028; cv=none; d=zohomail.com; s=zohoarc; b=aWwFkC/EmcogPnopdVcOgjB2eSiheVyxmh+moWX6PMkbF1qTtBmUTr2F12tMrlVa5+PR6JSxSVnI2FPAYgcgkpqWx73D+1ixBsjitUdbP6VtgUaucxChjoXmcRrl0q26QnFIj3HB1I1Vxuux7Rv3vFjmIrSWxqG+q5MCNu51i2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624945028; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=/FIuf09EtyyMEtP9Q7uUQGr5VMb7Zl+JbrYKv0AQkHw=; b=fOrGHs9zsty2kR2dkrSnMLlJoef4+4tCwXtlaHRsSroLXRWzmxKmg4OTD9R9SydW28JPOy343uxGj55VvNVqEnzRdKxiiRAh9Vhe4RCdNlv+bZUF4r4H5pDMdQrEVq8rYbJSGYfyoMS1AwKuzlq4v4ORSlCu2e2DvZBY5YtAQ6o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx.zohomail.com with SMTPS id 1624945028434113.05641345272227; Mon, 28 Jun 2021 22:37:08 -0700 (PDT) Received: by mail-wm1-f52.google.com with SMTP id l1so495005wme.4 for ; Mon, 28 Jun 2021 22:37:07 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id c10sm8802969wmb.40.2021.06.28.22.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 22:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/FIuf09EtyyMEtP9Q7uUQGr5VMb7Zl+JbrYKv0AQkHw=; b=hGHDYYhPGdZXf1P4cRF43ymPf+FOPCUXaS4qnD2SqZ+SqfsYpjS8PmRA1F4dPTtw3+ JaITYefmdS9LCX9NSHPSIEGhZvzcEJ0L/W6vTpL3UBkrmpiYTM8kTw8NTyJDhg/gFNUK vnwi2UlVYZnmhjFcgllhZNK2NIy+VM8EBQBLxI/5+bsMPekeLMXuyq6gscgCmU3lF0dj H4rCCCbubuyIFNhQ/9aj63ZMiXMMAPFYU8mNJLR0DGH4E9IlMo4V6Aa7fdRKNJsBAiM0 d3HJSgDPANcFnDf5Es1ktLrlLgN1eDOX/qecp7jXQOx+T0s/+YHaI6BnxyV5csmQ4FKK 7fhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=/FIuf09EtyyMEtP9Q7uUQGr5VMb7Zl+JbrYKv0AQkHw=; b=Rq/Zidpowy+b/xCQj8s/1xE3T2C5DRsu/I/fq7l6rK0Jwld3hucv2ljh3e3Jo11lal kxtPd2F9WR+Uppe+ZJ3AVM1HNg5Kd9CxJwzv+SPLyonvRly5BdSNnub9lvRadMy7I7+w cOeqyXcYDQE1UnzGnBU/riO8SMu6rRzrY+iZkkkMcdgfPqK12nV5+3QcDGG4h+ZziXgi amv8hU53bkoFwxK/DYhO2K2RUozbOmAXl/7C/kyPzxYKncBzr3xAGy89kcp6+tFRG79u qPlFATFNCG8CNAfIH/zfmkbhugRSOAyUSCGpOEXZl2DcZuXJ072Umb1kj/G3TquXGMH4 0YHQ== X-Gm-Message-State: AOAM530qBq3ancJh+fyJ/CUfmog6LcY5vUXit4QuFX4myDPD+7xs864D gEPXPzM4rHkcy8ZzDMUwM4E= X-Google-Smtp-Source: ABdhPJwfK4femS8bgDLzYSWoe+Bfu3WHdVUqixx+h2KWqDNy+HzeYCx02fIoVOtuzFBAxrdvO0SrLw== X-Received: by 2002:a05:600c:3b28:: with SMTP id m40mr29973235wms.99.1624945026555; Mon, 28 Jun 2021 22:37:06 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Mark Cave-Ayland , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Peter Maydell , Jiaxun Yang Subject: [PATCH] hw/mips/jazz: Map the UART devices unconditionally Date: Tue, 29 Jun 2021 07:37:04 +0200 Message-Id: <20210629053704.2584504-1-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) When using the Magnum ARC firmware we can see accesses to the UART1 beeing rejected, because the device is not mapped: $ qemu-system-mips64el -M magnum -d guest_errors,unimp -bios NTPROM.RAW Invalid access at addr 0x80007004, size 1, region '(null)', reason: rejec= ted Invalid access at addr 0x80007001, size 1, region '(null)', reason: rejec= ted Invalid access at addr 0x80007002, size 1, region '(null)', reason: rejec= ted Invalid access at addr 0x80007003, size 1, region '(null)', reason: rejec= ted Invalid access at addr 0x80007004, size 1, region '(null)', reason: rejec= ted Since both UARTs are present (soldered on the board) regardless there are character devices connected, map them unconditionally. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- hw/mips/jazz.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/hw/mips/jazz.c b/hw/mips/jazz.c index 1e1cf8154e7..e33d639af63 100644 --- a/hw/mips/jazz.c +++ b/hw/mips/jazz.c @@ -333,16 +333,12 @@ static void mips_jazz_init(MachineState *machine, memory_region_add_subregion(address_space, 0x80005000, i8042); =20 /* Serial ports */ - if (serial_hd(0)) { - serial_mm_init(address_space, 0x80006000, 0, - qdev_get_gpio_in(rc4030, 8), 8000000 / 16, - serial_hd(0), DEVICE_NATIVE_ENDIAN); - } - if (serial_hd(1)) { - serial_mm_init(address_space, 0x80007000, 0, - qdev_get_gpio_in(rc4030, 9), 8000000 / 16, - serial_hd(1), DEVICE_NATIVE_ENDIAN); - } + serial_mm_init(address_space, 0x80006000, 0, + qdev_get_gpio_in(rc4030, 8), 8000000 / 16, + serial_hd(0), DEVICE_NATIVE_ENDIAN); + serial_mm_init(address_space, 0x80007000, 0, + qdev_get_gpio_in(rc4030, 9), 8000000 / 16, + serial_hd(1), DEVICE_NATIVE_ENDIAN); =20 /* Parallel port */ if (parallel_hds[0]) --=20 2.31.1