From nobody Mon Feb 9 19:05:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1624896586; cv=none; d=zohomail.com; s=zohoarc; b=N/h6FsPF0jBBipivVS657CLuOYiGAg34odczw03V6BdpZkq35LPqCNyOz8rCMsmz95QNXKkhmnyt1l3ts2h0z/AuQAtfBCsRAcgt4/s8LDCLG7/WNGWMRWWr8iERmq9HAJsKveuWrFxZ4zRNffz0LgQdEIvuXtOwQ9LkrJF/iCQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624896586; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=sBGvZXp052kEjTXJ7kkHWmWt6IWVNfRolcBLTV9KMRg=; b=ewaxmq/59RqzsiJvy9TjG1dk4/UDMOB8PZL2+ogxYefLW8WOB9NArIFalNW2dm4ob2wlrl3Pth9zAh6T9KgwQu8zwkT9T6cCu4Ys7SYaMJCMyLeYW/ukQz1ByoZjqb4SrLyeRSueuavRZLXo9r4IGk1LNVQuY3dbIVj9mWg1PD8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1624896586014492.1287860697122; Mon, 28 Jun 2021 09:09:46 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-393-OZE6kr0nM8CyRgKp07AKzQ-1; Mon, 28 Jun 2021 12:09:43 -0400 Received: by mail-wr1-f69.google.com with SMTP id i17-20020a5d43910000b02901258b767ad5so910941wrq.2 for ; Mon, 28 Jun 2021 09:09:43 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id a9sm14896918wrv.37.2021.06.28.09.09.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 09:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624896585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sBGvZXp052kEjTXJ7kkHWmWt6IWVNfRolcBLTV9KMRg=; b=JOUxtdnF1tRzdi7pfQZ95lxqCPSDRn6jOaA48XU9/M0wYeYAMnpCSJxNdJaPRJEl57+ZWL izT1ZA2DBQ55D+VUNx4zQQ64bJaau7siMy2o9W1ggqVShhulkvxpjGdyHidO909HNqHWxf SM9iCW60i70fHv+hE5nPwrf2IVV/7Ts= X-MC-Unique: OZE6kr0nM8CyRgKp07AKzQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sBGvZXp052kEjTXJ7kkHWmWt6IWVNfRolcBLTV9KMRg=; b=H4Abe/O84PZyu/3hkBuakk3ILyABJlyikQz/2/7TCkGISsxAd6PfS4OFRRFuIbHGZE L1V1aQWSmVxn/2q2wFUxhBfogS1H/hqbUZ8vPNif8igQU6ybdzmLTZWY3zJdlUrQloue QHxS60dS1vKbiCPid3Q8QXjNRn4w9WODbvVgVjj4VJ+Lv86E0BpBoZW3sfBqlayGlInn XWErgqfwa/ySgokRPCWGoq+CCGmOCpqgtWP9VsAfX1ldd8Z8OkvsJCvFOdR827+NDyjE daBq5dE0ELFd989OfUJbpwLtdrrqmi8tn4FeNWwnqJ20UpkTHeqOCPD2Vu5f/YJqFMo5 CmuQ== X-Gm-Message-State: AOAM532GY84ZtfEMrNAN2iymJmgNhluDNrJbZjm4aqV8YPUhdxcaMm+T m9B3n2gcZD3on7RUehl8oZ0PJEJ1eAG1CIjwcMroMlklWHx1pImze4LP/vDr0TSCNZdzMh47ttL U5EZ2mtuvPEkQKQ== X-Received: by 2002:a7b:cc09:: with SMTP id f9mr26961699wmh.104.1624896582576; Mon, 28 Jun 2021 09:09:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQ0YzFBUpwScrcSCK4j1u6w+wXm3cwdvfKYcec0UUGgSDVRRMl0kkrUZTyRyo9bZ5NXA0g8A== X-Received: by 2002:a7b:cc09:: with SMTP id f9mr26961681wmh.104.1624896582479; Mon, 28 Jun 2021 09:09:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-block@nongnu.org, Akihiko Odaki , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v6 6/7] ui/vnc: Use qcrypto_tls_creds_check_endpoint() Date: Mon, 28 Jun 2021 18:09:13 +0200 Message-Id: <20210628160914.2461906-7-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210628160914.2461906-1-philmd@redhat.com> References: <20210628160914.2461906-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Avoid accessing QCryptoTLSCreds internals by using the qcrypto_tls_creds_check_endpoint() helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- ui/vnc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index f0a1550d58c..0e5fcb278f3 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -46,6 +46,7 @@ #include "qapi/qapi-commands-ui.h" #include "ui/input.h" #include "crypto/hash.h" +#include "crypto/tlscreds.h" #include "crypto/tlscredsanon.h" #include "crypto/tlscredsx509.h" #include "crypto/random.h" @@ -4080,9 +4081,9 @@ void vnc_display_open(const char *id, Error **errp) } object_ref(OBJECT(vd->tlscreds)); =20 - if (vd->tlscreds->endpoint !=3D QCRYPTO_TLS_CREDS_ENDPOINT_SERVER)= { - error_setg(errp, - "Expecting TLS credentials with a server endpoint"); + if (!qcrypto_tls_creds_check_endpoint(vd->tlscreds, + QCRYPTO_TLS_CREDS_ENDPOINT_S= ERVER, + errp)) { goto fail; } } --=20 2.31.1