From nobody Tue Feb 10 20:47:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) client-ip=209.85.128.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1624613037; cv=none; d=zohomail.com; s=zohoarc; b=mRoCrRAAI0yVXKK2ZZ27hjbRtircLtzsPeJMbHwTlKSm20jiUsL/tpln047F8K7GT4tpYOfzHF4SXEtra4wMfIJPFNfV4gIIXV5EJ8cW3EIaRsoRkDwynM1/NwKSmAxuRi7GGSalYby0wBc7YpkBBVEwhZliO6Iqn0UO9vrj3q4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624613037; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WwdNN5kZV6nSH6AN6jmAvVVXJTDQlT1EEV5IustrciY=; b=DY5gEHi6N6wYKQ2+BIAUfAfK4YpvVCE793/sN7ntYAAs6R69ZLdU8OuVFr8lrIr3e8R8Y3IThDP8SwCkxrpNfQlWYNFJ3+2jV9YZpIX9eL63JdZChIowd30Do61mIXx+GzlupVgHTAktz26Mmky3VRrDWXfRfft7nFOGvOgkAlU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.zohomail.com with SMTPS id 1624613037912607.9925347105518; Fri, 25 Jun 2021 02:23:57 -0700 (PDT) Received: by mail-wm1-f46.google.com with SMTP id c84so5796343wme.5 for ; Fri, 25 Jun 2021 02:23:57 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id l20sm5193943wmq.3.2021.06.25.02.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 02:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WwdNN5kZV6nSH6AN6jmAvVVXJTDQlT1EEV5IustrciY=; b=Z4nJYjhuwtboGaNEHTYeeVwyneAGl4JaXan5YccRBwcmRZy3EhHdw/oVuTYcjZ0eM9 NOzRMeOys5XZD70MnQH404fdY5x5rnBdtmQzUzjTLQiUEjO3SAt+J3fLcxXkzlODkUsw XF9BLLNDrfhgzShSmGoLdc8YSnvswXdEzOV8uBRMvfYoED3+BpviDTrm4JNaTdr4vDN3 XhG05hsevSI7qGlF6yMI+fviQzduf3emOp8csqV6JvGiRXJ1cEYxGLJZjKCv25Hr2TxV e6jbcJEwwksL6KORCHGMam82ftXZGkAQoBdRyhhTuj8GF2jIvGOxT0EqBXad/FkjSTp6 knlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=WwdNN5kZV6nSH6AN6jmAvVVXJTDQlT1EEV5IustrciY=; b=JUqMbwx7SSy/SDqPxgYHB5MaDRSQrhSvSql5/0G9/XBvi8hR2PRoza8XtW14+rksAc St5FUmC8bqmyJ50UeoiQh9syC55k+uySOlKZhM/ht1a2RROKQ6sdI3NQZYzROmjPiNL2 cpPPPcjR5vd9ssB8EwOX914uZbg0qTgS5XljuhhdmNI+4SP6RdPrkks/Wb5uorRD4plU PaKOYU8glHwwwu6uAa1F0JzPmNvJM4Bk4oL7OtX5M43+Uo/3GQYpKtfcHFfg57tOktOX FUGqqkJAJKBl/iDDAb45cMfBeOII0tU3ymkKrNGuN8TDSFtItVj+FsXtODZb4Mx3ZSaw +zLQ== X-Gm-Message-State: AOAM533/UvYB/opMw+vuuT8/knqJ56E/aYehBEGg/+vbFPuE8Cb05HEX H4Q7Axh/Cs8Htn5v5BUBZUo= X-Google-Smtp-Source: ABdhPJyrWsp/NIkdhZK5ZdI4acH0v61Ub743RzxxNuwgrdIJ7mQC6EpEwe6H5ELUwWuD50LJ2GpwxA== X-Received: by 2002:a1c:1f54:: with SMTP id f81mr9250063wmf.121.1624613036258; Fri, 25 Jun 2021 02:23:56 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Jiaxun Yang , Aurelien Jarno , Richard Henderson Subject: [PULL 05/15] target/mips: Do not abort on invalid instruction Date: Fri, 25 Jun 2021 11:23:19 +0200 Message-Id: <20210625092329.1529100-6-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210625092329.1529100-1-f4bug@amsat.org> References: <20210625092329.1529100-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) On real hardware an invalid instruction doesn't halt the world, but usually triggers a RESERVED INSTRUCTION exception. TCG guest code shouldn't abort QEMU anyway. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20210617174323.2900831-2-f4bug@amsat.org> --- target/mips/tcg/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 3fd0c48d772..4b7229a868a 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -12151,8 +12151,8 @@ static void gen_branch(DisasContext *ctx, int insn_= bytes) tcg_gen_lookup_and_goto_ptr(); break; default: - fprintf(stderr, "unknown branch 0x%x\n", proc_hflags); - abort(); + LOG_DISAS("unknown branch 0x%x\n", proc_hflags); + gen_reserved_instruction(ctx); } } } --=20 2.31.1