From nobody Tue Feb 10 11:16:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1624566480; cv=none; d=zohomail.com; s=zohoarc; b=Uc2ToL07dDfepPAUioIop5b+BhFLOjLzyQvcXwYuWD+IPUOnd9JNn9r3DIibysPxk8/Wmp9USjYN/1dwu2XO3CY52JZ12BZUCFmpDopnZlKGCQbaFOxSdfQ2QAUN51UQg5DWRhkcHIegQsPkjfLDW4Khp3az1gr50S2W5s9i0nM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624566480; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iKx0S7FV6oTeEOOfKZInpp71T9Lkz8XufqA4Ci4D+Kg=; b=WAr71bEzSKh82kvF10Fjv9ID02NAHKpeFZK33JZSRhZexnwpKwrswXWDuKxNSjDd6W0KtUt5qYeS71A0uGMbLHy5cuAUGw9qcv+VPSXIxQIsIQPdVwWid9LZvv6HvioxbWtKYE4THVex1C77y/7kVy0NVI2ZGh73txX0Omm0BwM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1624566480808165.45089451079252; Thu, 24 Jun 2021 13:28:00 -0700 (PDT) Received: by mail-wr1-f52.google.com with SMTP id a11so8040967wrt.13 for ; Thu, 24 Jun 2021 13:28:00 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id b9sm4839310wrh.81.2021.06.24.13.27.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 13:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iKx0S7FV6oTeEOOfKZInpp71T9Lkz8XufqA4Ci4D+Kg=; b=evghU70l04Y1dug5YFAYhCB57pT7Q6ttjceOoyro68yc22oQjsnBd4kibtO9imsabG 5+6/wen/kxCFAbYVxU9eKp/C/r2QuRefSsCeJ0B71T3+9QAjqAUcDIxx4E/Wtez+QfFb +LbeHe/AJEGsuULGXJPud2+v3m8qGQwg+9aZDZDSNM/cW/QMi/zp0+0yaM98M90+TO2C /X01quQ+4nd5TFg/bmypiJHLX1iIykv0ZlWUfWHf5yYO6H5shuJmPeGJKOjt7XXRLeRS YWbGVH05Xv3GHmn982xeAdHNs/mGbzif3nv43ict1juoh5TuTjqHtccTWhj0ib/UM1s1 EcDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=iKx0S7FV6oTeEOOfKZInpp71T9Lkz8XufqA4Ci4D+Kg=; b=c0FjZwtqN6Q43kTgre+R3gQvDlnZu/Ae38OufnA1dsPwG0LzloVx2bauNHTMi3v49t savw54VqsUMxTBopFUg89vwkVb1CwcWFuTQRKEZDjeX31jHvWgyztsweeVKc/YeXMtOs ZpVtIG578tySTNy6wLVtqYT+wqjOzt5CaYNtFN27MEBN9t+IsPhyzDBHSkwrHAS4Sq9K 9LxZ+gb5+3kmb9yiWwkSuGu2nqS0vCR9iC+GyjyhX86mQKZVqzEJlWyyXT++0O4bJPFB taZ95FS6Raccl65sNpg5yvevtm3F3nFgUlMZ9sIE2C9FNvK2oCgpBgTYqiXyIjo++lTb Z+pw== X-Gm-Message-State: AOAM532eWSZLRbHZVsxxJhpkbb7Jk3M9s4Vt38YBzZRu8gNYOXjJshid pow8HW8OfUCY29fKool3ZfY= X-Google-Smtp-Source: ABdhPJzmczo9t6/5thbauIUh0hOGqCCvnDluSYVd9lPsxpyBohxBhYari1HckkvG08TTZZZjRFN0Ew== X-Received: by 2002:adf:e38c:: with SMTP id e12mr6831400wrm.404.1624566479127; Thu, 24 Jun 2021 13:27:59 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , BALATON Zoltan , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Aurelien Jarno , Cleber Rosa , Huacai Chen , Jiaxun Yang Subject: [PATCH 2/5] hw/pci-host/bonito: Trace PCI config accesses smaller than 32-bit Date: Thu, 24 Jun 2021 22:27:44 +0200 Message-Id: <20210624202747.1433023-3-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210624202747.1433023-1-f4bug@amsat.org> References: <20210624202747.1433023-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Per the datasheet section "5.7.5. Accessing PCI configuration space" the address must be 32-bit aligned. Trace eventual accesses not aligned to 32-bit. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/pci-host/bonito.c | 8 ++++++++ hw/pci-host/trace-events | 3 +++ 2 files changed, 11 insertions(+) diff --git a/hw/pci-host/bonito.c b/hw/pci-host/bonito.c index afb3d1f81d5..751fdcec689 100644 --- a/hw/pci-host/bonito.c +++ b/hw/pci-host/bonito.c @@ -52,6 +52,7 @@ #include "hw/misc/unimp.h" #include "hw/registerfields.h" #include "qom/object.h" +#include "trace.h" =20 /* #define DEBUG_BONITO */ =20 @@ -185,6 +186,7 @@ FIELD(BONGENCFG, PCIQUEUE, 12, 1) #define BONITO_PCICONF_IDSEL_OFFSET 11 #define BONITO_PCICONF_FUN_MASK 0x700 /* [10:8] */ #define BONITO_PCICONF_FUN_OFFSET 8 +#define BONITO_PCICONF_REG_MASK_DS (~3) /* Per datasheet */ #define BONITO_PCICONF_REG_MASK 0xFC #define BONITO_PCICONF_REG_OFFSET 0 =20 @@ -495,6 +497,9 @@ static void bonito_spciconf_write(void *opaque, hwaddr = addr, uint64_t val, if (pciaddr =3D=3D 0xffffffff) { return; } + if (addr & ~BONITO_PCICONF_REG_MASK_DS) { + trace_bonito_spciconf_small_access(addr, size); + } =20 /* set the pci address in s->config_reg */ phb->config_reg =3D (pciaddr) | (1u << 31); @@ -521,6 +526,9 @@ static uint64_t bonito_spciconf_read(void *opaque, hwad= dr addr, unsigned size) if (pciaddr =3D=3D 0xffffffff) { return MAKE_64BIT_MASK(0, size * 8); } + if (addr & ~BONITO_PCICONF_REG_MASK_DS) { + trace_bonito_spciconf_small_access(addr, size); + } =20 /* set the pci address in s->config_reg */ phb->config_reg =3D (pciaddr) | (1u << 31); diff --git a/hw/pci-host/trace-events b/hw/pci-host/trace-events index f4b3a50cb0b..630e9fcc5e7 100644 --- a/hw/pci-host/trace-events +++ b/hw/pci-host/trace-events @@ -1,5 +1,8 @@ # See docs/devel/tracing.rst for syntax documentation. =20 +# bonito.c +bonito_spciconf_small_access(uint64_t addr, unsigned size) "PCI config add= ress is smaller then 32-bit, addr: 0x%"PRIx64", size: %u" + # grackle.c grackle_set_irq(int irq_num, int level) "set_irq num %d level %d" =20 --=20 2.31.1