From nobody Tue Feb 10 16:44:15 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) client-ip=209.85.221.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1624544574; cv=none; d=zohomail.com; s=zohoarc; b=XNKb6rNRzbyKf8ij6/AFBd4G3VWpmWCm63X923ZZQ3NJ44r6RhA1L4Z+OcMd4L0f5fwMUI+bDnqC1dconbogG8mMZHmqmrHHmlV8f2TXpBIO+pv9pC6nS9CRJQDBQhGHRhTH+8cvdoFKZOcgZjAguLn/mXA2kNYgHgpwHeCABUg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1624544574; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=N8335+v657OPgDsK3i2XqXKBZf94tMX7vRL29WozTPg=; b=ZIlLAprgYF+c6Wx8TZkxA4AChpIR8qAkX8nmvsBqbn86QqqHmLoLOAWnk96MN7mvwv3rZa939MRAWfRrszHEJzNIfHqWsWPVUcBB8qcLXBiuPWHEHSJcdWzymgcFFAAQGW31EAso8BMvnZ+U2IpfH/VE63B9cankw56UE1ymoP0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by mx.zohomail.com with SMTPS id 1624544574105684.7217491790096; Thu, 24 Jun 2021 07:22:54 -0700 (PDT) Received: by mail-wr1-f46.google.com with SMTP id e22so6905354wrc.1 for ; Thu, 24 Jun 2021 07:22:53 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id n65sm8621361wme.21.2021.06.24.07.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Jun 2021 07:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=N8335+v657OPgDsK3i2XqXKBZf94tMX7vRL29WozTPg=; b=CLkN++yy9BXjHS2qH/B5E95OKZWRRN5saro1Wf67AuLEMJo80tNEDmLr7Ors8xQVQW VAFQDjLbYTsCupcrb4H9b6h5INNz+KFfBRqkopRrQ9yAiNbvhfoAQrfizky855FaJK7J lKMu5t6GX7wm5l3rOmcICtIGpR/4QXxhZngR6fadN4/7TkcYbD16qPMQcM0cqDd/M8Ci +pgRt6PIdlj7k432Em8ha+eVISpAvgA1Bl5o84mV4TtBfw0oFMV7hpB+fMKniFj/r63L yOeLo15mF+bAXJOGHZU0TTiyglcT2z0GMP5wpt6tDduShI7Hv3h+SYu0mRgBPMk5uwzv PJvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=N8335+v657OPgDsK3i2XqXKBZf94tMX7vRL29WozTPg=; b=fbe5/7TN2Hs6GYopUA5v3M7PpwBKUqVqYsadzrmmNRjNbf9bbhslfUnpi+Yp2d7yd/ sloSB2LHDJl+pU7eu2hC9pTVPqe6oIhO0UK6E/e0XSFMCt+TIGHqG39NI2rLnQpU3E5f JTUmlbd6RZv8jXLyoIpKw9rcNuAHAuLDopSQzFDevVA0S+vUBZqyu57hIQMDlOAV0fs+ QMkC73rgPxNKmwtz0ZNOIeWPzvPerpe94Sq5a/ItduZBHj1pC1Oyz5bej2nB8jd9LWRR MTBWjJm1h4YUJkyjX6SwEa+tIHhmDZXpjlHPhULZpAPCW5DE3ArL0gLEyZoifXOuxhUb FoMg== X-Gm-Message-State: AOAM532obhGTCiTS7DPXe6g46o52PfdlnN4aXzeogNjT6wYZH8AOi9mE szulBbEghDvulMXmmfLugpg= X-Google-Smtp-Source: ABdhPJx2tqlVjvLafFwiH8HczgnO6SstZ8R4E6rKVkEhI2aXimHZmll8dQtjHLJPJfODTdnMoMrEcg== X-Received: by 2002:adf:e112:: with SMTP id t18mr4847275wrz.46.1624544572324; Thu, 24 Jun 2021 07:22:52 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Andrew Jeffery , Bin Meng , Joel Stanley , qemu-block@nongnu.org, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [RFC PATCH 08/10] hw/sd: Add sd_cmd_SEND_OP_CMD() handler Date: Thu, 24 Jun 2021 16:22:07 +0200 Message-Id: <20210624142209.1193073-9-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210624142209.1193073-1-f4bug@amsat.org> References: <20210624142209.1193073-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/sd.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 3ef6aca89da..b63d99f7da0 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -992,6 +992,13 @@ static sd_rsp_type_t sd_cmd_GO_IDLE_STATE(SDState *sd,= SDRequest req) return sd->spi ? sd_r1 : sd_r0; } =20 +static sd_rsp_type_t sd_cmd_SEND_OP_CMD(SDState *sd, SDRequest req) +{ + sd->state =3D sd_transfer_state; + + return sd_r1; +} + static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req) { uint32_t rca =3D 0x0000; @@ -1031,10 +1038,6 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, = SDRequest req) =20 switch (req.cmd) { /* Basic commands (Class 0 and Class 1) */ - case 1: /* CMD1: SEND_OP_CMD */ - sd->state =3D sd_transfer_state; - return sd_r1; - case 2: /* CMD2: ALL_SEND_CID */ switch (sd->state) { case sd_ready_state: @@ -1579,11 +1582,6 @@ static sd_rsp_type_t sd_app_command(SDState *sd, break; =20 case 41: /* ACMD41: SD_APP_OP_COND */ - if (sd->spi) { - /* SEND_OP_CMD */ - sd->state =3D sd_transfer_state; - return sd_r1; - } if (sd->state !=3D sd_idle_state) { break; } @@ -2088,6 +2086,7 @@ static const SDProto sd_proto_spi =3D { .name =3D "SPI", .cmd =3D { [0] =3D sd_cmd_GO_IDLE_STATE, + [1] =3D sd_cmd_SEND_OP_CMD, [2 ... 4] =3D sd_cmd_illegal, [5] =3D sd_cmd_illegal, [7] =3D sd_cmd_illegal, @@ -2097,6 +2096,7 @@ static const SDProto sd_proto_spi =3D { }, .cmd =3D { [6] =3D sd_cmd_unimplemented, + [41] =3D sd_cmd_SEND_OP_CMD, }, }; =20 --=20 2.31.1