From nobody Tue Feb 10 20:31:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1623951849; cv=none; d=zohomail.com; s=zohoarc; b=RkNRZdvVtvevUibwCh04EwTK1wIHjPsDjZkRYsVJWuF4nSx7PyBdkbhlBvad+Vevx/Sa+1dPqL25V/GZ4z403bpHjVBEEUmMLAG3i+SrCwvrTCWCQMqOC6zMplKKgh3NJqKZ85HwJocxrzDf/BxnkIHFLEwaxTzhExLqEl4tCmU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623951849; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RoU+7ht74MR+uFQU3Fe913vTah/u1fs34mzDvWBnykU=; b=AUpcbE0EvcBzKC1tCKgrRP+nzue6yJvsxqXOlHyhyLu9om5jwgad074Dyx9q+H8Ahzu1dSyBhxRyi721TikVy8JWO2c+jnbZOwohPNEbyJCwzx+p+/kOxp/dzZ2jYTaS4XTpJ3jTnRlE5hVA0vXmmlfGQH5SC4IPZ8OvudSfyN4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1623951849692590.6077741722419; Thu, 17 Jun 2021 10:44:09 -0700 (PDT) Received: by mail-wr1-f50.google.com with SMTP id a11so7697003wrt.13 for ; Thu, 17 Jun 2021 10:44:09 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id v8sm6645721wrc.29.2021.06.17.10.44.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 10:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RoU+7ht74MR+uFQU3Fe913vTah/u1fs34mzDvWBnykU=; b=PFWA+9fPatF/9NJ95kCiwTEH+SgOOZzRg+Z2TkfGcqNKBr++fRBZCHM2F1UafxCXFJ hgVqYgdO+dLdIm4yBvfws5mQo/9GZuMqwqgo1d7xWygtBqR4RiPxDfIVO+ZDJWvbjkJJ FvZNKoCRa48hF4MTnn/ByQvtHsFN/tOcQl03uTJkMp15qXYCDw+fQ8UqIyWY1jWBIiZF yUoJrIQ14QraJBkiWGLvlKpwWHEhAegXI0nc0S4Qwa1bngAip3wgMAlvDBgExMTFnLmB GkMN4LLm2vBxVqb7TW1OYeYHZ/eRCrMooZ8mJ6pWqXMLpxXNhRtFVrTee4f87e3P6sDk ZeQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=RoU+7ht74MR+uFQU3Fe913vTah/u1fs34mzDvWBnykU=; b=UVBM3qGRETYe4b82hDy2Q1SWxcPr/tkfVNlqir2j+vSm7qLfPLEUgkuegyg0ZObPwn 132Rc32pPJHeNTuUrjR7s2yk2NIacdpZyjwYRMqwBqXm9sNFQ9whg72zi9Wp0qFQWM5r QkuS7T+HVlDBjQDfgkSf3fTXtgyoI5sV7/oP6xB/yRH2clOz5j1/ooAFtucd9BM0E2J6 QTBVmXXK+AcsUF6gNUvtBZtK53cTr5imhC7EVUeab7HXJ33MPKnUIiVX2vjpLf8s2Vic BSj8xEUN9uRo7abMhPMAjevn1ry+wS/6Hi3KZ012UQG6zjDkI1uJa8sAYRhZ710C2cj+ ORUw== X-Gm-Message-State: AOAM5314N0g7zQV7AtXKzfkToFnibkAL5an6aadKYjKHy2ikGIkOvf8x C+MjR3QOELOfAsBKg53Epis= X-Google-Smtp-Source: ABdhPJzM3qtaAu5eq0B0+9Uu2piNu4NBocIwXUSu57BL5+GFMsz83ivWyZfUSNP9b/LfGPgJfH5XBA== X-Received: by 2002:adf:a412:: with SMTP id d18mr7259901wra.49.1623951848000; Thu, 17 Jun 2021 10:44:08 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Richard Henderson , Aurelien Jarno , Jiaxun Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 9/9] target/mips: Optimize regnames[] arrays Date: Thu, 17 Jun 2021 19:43:23 +0200 Message-Id: <20210617174323.2900831-10-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210617174323.2900831-1-f4bug@amsat.org> References: <20210617174323.2900831-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Since all entries are no more than 3/4/6 bytes (including nul terminator), can save space and pie runtime relocations by declaring regnames[] as array of 3/4/6 const char. Inspired-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/internal.h | 2 +- target/mips/cpu.c | 2 +- target/mips/tcg/msa_translate.c | 2 +- target/mips/tcg/mxu_translate.c | 4 ++-- target/mips/tcg/translate.c | 4 ++-- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/target/mips/internal.h b/target/mips/internal.h index 18d5da64a57..eecdd101169 100644 --- a/target/mips/internal.h +++ b/target/mips/internal.h @@ -74,7 +74,7 @@ struct mips_def_t { int32_t SAARP; }; =20 -extern const char regnames[32][4]; +extern const char regnames[32][3]; extern const char fregnames[32][4]; =20 extern const struct mips_def_t mips_defs[]; diff --git a/target/mips/cpu.c b/target/mips/cpu.c index 96236abc006..d426918291a 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -35,7 +35,7 @@ #include "qapi/qapi-commands-machine-target.h" #include "fpu_helper.h" =20 -const char regnames[32][4] =3D { +const char regnames[32][3] =3D { "r0", "at", "v0", "v1", "a0", "a1", "a2", "a3", "t0", "t1", "t2", "t3", "t4", "t5", "t6", "t7", "s0", "s1", "s2", "s3", "s4", "s5", "s6", "s7", diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translat= e.c index b3b06352bf2..a2f7d6a1e08 100644 --- a/target/mips/tcg/msa_translate.c +++ b/target/mips/tcg/msa_translate.c @@ -255,7 +255,7 @@ enum { OPC_BINSRI_df =3D (0x7 << 23) | OPC_MSA_BIT_09, }; =20 -static const char * const msaregnames[] =3D { +static const char msaregnames[][6] =3D { "w0.d0", "w0.d1", "w1.d0", "w1.d1", "w2.d0", "w2.d1", "w3.d0", "w3.d1", "w4.d0", "w4.d1", "w5.d0", "w5.d1", diff --git a/target/mips/tcg/mxu_translate.c b/target/mips/tcg/mxu_translat= e.c index f70a8ca59f4..e336518cdea 100644 --- a/target/mips/tcg/mxu_translate.c +++ b/target/mips/tcg/mxu_translate.c @@ -447,9 +447,9 @@ enum { static TCGv mxu_gpr[NUMBER_OF_MXU_REGISTERS - 1]; static TCGv mxu_CR; =20 -static const char * const mxuregnames[] =3D { +static const char mxuregnames[][4] =3D { "XR1", "XR2", "XR3", "XR4", "XR5", "XR6", "XR7", "XR8", - "XR9", "XR10", "XR11", "XR12", "XR13", "XR14", "XR15", "MXU_CR", + "XR9", "XR10", "XR11", "XR12", "XR13", "XR14", "XR15", "XCR", }; =20 void mxu_translate_init(void) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 5d571d83c54..255f97fe9c1 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -1281,11 +1281,11 @@ TCGv_i64 fpu_f64[32]; #define DISAS_STOP DISAS_TARGET_0 #define DISAS_EXIT DISAS_TARGET_1 =20 -static const char * const regnames_HI[] =3D { +static const char regnames_HI[][4] =3D { "HI0", "HI1", "HI2", "HI3", }; =20 -static const char * const regnames_LO[] =3D { +static const char regnames_LO[][4] =3D { "LO0", "LO1", "LO2", "LO3", }; =20 --=20 2.31.1