Hi,
qemu-nbd.c still refers to members of QCryptoTLSCreds* and can't be
compiled.
Regards,
Akihiko Odaki
On 2021/06/17 21:18, Philippe Mathieu-Daudé wrote:
> Missing review: 5 & 6
>
> Follow Daniel suggestion to simplify qcrypto TLS implementations,
> aiming to solve the OSX build failure.
>
> Since v4:
> - Do not introduce qcrypto_tls_session_check_role (Richard, Daniel)
> - Added R-b tags
>
> Since v3:
> - Added missing @errp docstring description
>
> Since v2:
> - Add Error* argument (Daniel)
> - Move structure definitions to "tlscredspriv.h"
>
> Philippe Mathieu-Daudé (6):
> crypto/tlscreds: Introduce qcrypto_tls_creds_check_endpoint() helper
> block/nbd: Use qcrypto_tls_creds_check_endpoint()
> chardev/socket: Use qcrypto_tls_creds_check_endpoint()
> migration/tls: Use qcrypto_tls_creds_check_endpoint()
> ui/vnc: Use qcrypto_tls_creds_check_endpoint()
> crypto: Make QCryptoTLSCreds* structures private
>
> crypto/tlscredspriv.h | 45 ++++++++++++++++++++++++++++++
> include/crypto/tls-cipher-suites.h | 6 ----
> include/crypto/tlscreds.h | 30 ++++++++++----------
> include/crypto/tlscredsanon.h | 12 --------
> include/crypto/tlscredspsk.h | 12 --------
> include/crypto/tlscredsx509.h | 10 -------
> block/nbd.c | 6 ++--
> blockdev-nbd.c | 6 ++--
> chardev/char-socket.c | 18 ++++--------
> crypto/tls-cipher-suites.c | 7 +++++
> crypto/tlscreds.c | 12 ++++++++
> crypto/tlscredsanon.c | 2 ++
> crypto/tlscredspsk.c | 2 ++
> crypto/tlscredsx509.c | 1 +
> crypto/tlssession.c | 1 +
> migration/tls.c | 6 +---
> ui/vnc.c | 7 +++--
> 17 files changed, 101 insertions(+), 82 deletions(-)
>