From nobody Tue Feb 10 22:18:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) client-ip=209.85.128.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1623930832; cv=none; d=zohomail.com; s=zohoarc; b=g2F0UgZbu7j0dSnBZX2fefSWakhOzAxJ4jP7YX/iK7ZWnZZdfrmu9EnKBBu3DjFdFM9xXxGfXPA7jmzIrNQXpvkzozGYjQc16DXdScDWaZlFCOAmgO10QQ1aqHSyia7C309SzEot9gUI+EotOM12LGToEBKpY8j/784lZCsEAFs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623930832; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PLm+CAmE6exi2+6ozO8dDlwl9EePwAhLr88hp6FkarA=; b=ECOtYW+2F2sR+q+OJ8hcr8FfVaqVLKnXXG14rtVt5OvKa2kIptnYdFCW7LlU3yKxekbu+kPBJYF8+7yHFv7oHtN/uNWHqw5EERTQzFY1LoKHFaUyQZzEdff2xR7kMfzhNhEnkJKfDrplIM6/7m1IwHcS5Dq6OBuxk42CCv4KEng= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mx.zohomail.com with SMTPS id 16239308325451007.2046591852957; Thu, 17 Jun 2021 04:53:52 -0700 (PDT) Received: by mail-wm1-f41.google.com with SMTP id h11-20020a05600c350bb02901b59c28e8b4so6217445wmq.1 for ; Thu, 17 Jun 2021 04:53:52 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id w23sm8327291wmi.0.2021.06.17.04.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 04:53:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PLm+CAmE6exi2+6ozO8dDlwl9EePwAhLr88hp6FkarA=; b=l+gBpnNlmzIsLpjXsAuhDyV3cq1HN+KfsoUrZDhR12BdxXEM0XGEtXBjDh3T2wxPt/ 8SqbkLCpuwqUaIzrgI/3cXCHFuYm2B1cMcdqQ+UtRGmLFpkzoxkBGqqKAhsnc3hmr7sM c+eF6uVxpXhwCrvevcXAv4DRiGcokr5bzHNP+Lk2pRsV3jXzB8j7ArrdX2SqVgJ+GvnJ DH/pmwmgihkjtpYxp+ablnd1Bv3LOTbmX7tGFw5PyOW78GdNlJPhaDu9ERMV7gNjPgdF modpvAvHQqjYi1ube8PAE8gVt5mqEpsBlKK1akA9gofyyGxVa3+YOqqF3BeEzjp+pVuX Y2Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=PLm+CAmE6exi2+6ozO8dDlwl9EePwAhLr88hp6FkarA=; b=QfP8UanrmOOTPOF60kyvFXhO8Hr6+/tgZngcEZB4vD5XY7BwzgJAmszpPA247jrPpc bj5WYrlTHkpXjsISnxhKb+dNygQEZL+V7ADzr5RsMh4ZVaBRKxtEclohb1JFb7ga3GFV APrcMzIRytLvWriZL14qWuixg3T82jsmc55gv5UT+zUl0VgGgBkJOJolmcRM38IsWF8+ SUaE7GsefIIuXQ364X61Pl/D8q34jSIfmbDzNpG3ZNwDFRvyHbXWEhbPZRN9rnNeTv9Q w89ta23UWp8BxFZKD5u5eHsKxgBUeAlGOQ+4A/WDOTQL97zAZzwPeX8prc/7M7UY31nL 1bcw== X-Gm-Message-State: AOAM532MAGawuwZOKRAFvzA+9F4YV5YC1kZcBHu0jB/Fj212z3rviib+ AIJuS+junPwgMZFmfqRjfmM= X-Google-Smtp-Source: ABdhPJzXqa9Qfx2Bx1vEZJUy5ivkHoF4M4CDVTC9Z2dLTUqcQpfF2woEM6t6zxZlcCLY9ABe0Ss8Rw== X-Received: by 2002:a05:600c:2d45:: with SMTP id a5mr806266wmg.161.1623930830756; Thu, 17 Jun 2021 04:53:50 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Corey Minyard , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , BALATON Zoltan Subject: [PATCH v5 03/15] hw/display/sm501: Simplify sm501_i2c_write() logic Date: Thu, 17 Jun 2021 13:53:22 +0200 Message-Id: <20210617115334.2761573-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210617115334.2761573-1-f4bug@amsat.org> References: <20210617115334.2761573-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Reviewed-by: Richard Henderson Acked-by: Corey Minyard Reviewed-by: BALATON Zoltan Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/display/sm501.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 8789722ef27..f276276f7f1 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -1036,8 +1036,9 @@ static void sm501_i2c_write(void *opaque, hwaddr addr= , uint64_t value, int res =3D i2c_start_transfer(s->i2c_bus, s->i2c_addr >> 1, s->i2c_addr & 1); - s->i2c_status |=3D (res ? SM501_I2C_STATUS_ERROR : 0); - if (!res) { + if (res) { + s->i2c_status |=3D SM501_I2C_STATUS_ERROR; + } else { int i; for (i =3D 0; i <=3D s->i2c_byte_count; i++) { res =3D i2c_send_recv(s->i2c_bus, &s->i2c_data[i], --=20 2.31.1