From nobody Tue Feb 10 01:50:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) client-ip=209.85.221.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1623879795; cv=none; d=zohomail.com; s=zohoarc; b=akEbE1bVI6Dp1YuGdWRBJgduzqF9UGfcbmrKMvi71pdw5+61Mo7P8PxkoZjerIBlQ+GK4of5TYqc2d8keJRDbEdE1tnpl0Y+xfzkcfGWCtEegkbK+tUgjAtyNrS3mXIvf6ag/7ZofSHOYcqt1UnwLJ4smtH2n1E9VVPL6M2dQv0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623879795; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KW5lTjsputo7N25OpKrD+E7Eo0jAOCluFxXj3IjGob4=; b=h066MjUKrmVaJG/7ANXwT5ZhTZ6YBv+dg+qIWu7psjqSjyYKm+UHjszHdi260rtO6DLXed0wG59l7nROtXg3zForgzJBNPf/f7icQpzs0LYyWqoMGE4J/5xWrB97JCGZF+xXFHI3ipd4E9U1hjTUnM6V+Zz0AWGnWkMnyoOVGiI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.zohomail.com with SMTPS id 1623879795054765.4780989818432; Wed, 16 Jun 2021 14:43:15 -0700 (PDT) Received: by mail-wr1-f44.google.com with SMTP id f2so4229295wri.11 for ; Wed, 16 Jun 2021 14:43:14 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id l16sm6257864wmj.47.2021.06.16.14.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jun 2021 14:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KW5lTjsputo7N25OpKrD+E7Eo0jAOCluFxXj3IjGob4=; b=tMy4VHt4cCksI+edMUqDzMEwYxEhb9sNwPo6gTSjNBcXCCFuAFHDTD8zWcxZ0ByPPS U4tyU6SnDoT8+reloz2RWfUF+HZWwy4cAQ3flszzzpoJMURWEj5xHRcck2e60wJckVF3 OdHD4aUa3hDsGUwr9Y0CDJWte67UJUzKve2nqoHNKqxQj7pATwo1COD6hxuhXX6EUK6m R476B+f5fAcG76Ckie6Xde5bxk4DpNwnes0TppWsZ/2C2Db7gZ04kH+lkOkEKzt1/Mp+ chgG/dbfl2RKnaJv5Yjafz7H5tUNZKISzCsWMy/98jkHNnSjhnjECeAoXyAhvIawP+5s iNvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=KW5lTjsputo7N25OpKrD+E7Eo0jAOCluFxXj3IjGob4=; b=m6V1hR62shsU8xOu1rWB2/r88eUSnIbnMdruFekMIoCQaK/bOF1xB+5GSNm4IpyKb0 yg7DCh73UYf8E9wzopCcUvvm8SHogWEd5gjuUchUCSHVNcg4FRPDc+miX7ltpHuFA6Ma 7T/SvSrob93DjAWqDYftPSsBbQP5AyzUg/v1dNhR1BSkzgiLJA433fgZSenz0HWZaqVi 5/xdjhJh2EexTHrqXPbUjN5HcdTfNR4gWIn1SBd+iqFJFRqFZ1X3UzQ6C4HeTvyIWFe7 DVF5C+JJ9AAKhSldX4hGa/M9TU2yGzl1SlILWRFh80VgQdeXp3I4xiHf0MZ4c0xvHVUP GhAQ== X-Gm-Message-State: AOAM531wlcBIrEJmhSlevZQVH3LHXPrqW8NKl4o0JxPDhbi0nFhPq8Rf UT7n6O8BjkWQ5nNC9jwe8rM= X-Google-Smtp-Source: ABdhPJxk6iAa2/gl5WSyjWxP/h+RLiIYg2I/CkwdOJAz9BukIvRnALISjLvKixQo2zl5muPRD3D2ng== X-Received: by 2002:adf:deca:: with SMTP id i10mr1469987wrn.344.1623879793348; Wed, 16 Jun 2021 14:43:13 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Corey Minyard , qemu-ppc@nongnu.org, BALATON Zoltan , qemu-arm@nongnu.org, KONRAD Frederic , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH v4 03/15] hw/display/sm501: Simplify sm501_i2c_write() logic Date: Wed, 16 Jun 2021 23:42:42 +0200 Message-Id: <20210616214254.2647796-4-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210616214254.2647796-1-f4bug@amsat.org> References: <20210616214254.2647796-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Reviewed-by: Richard Henderson Acked-by: Corey Minyard Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: BALATON Zoltan --- hw/display/sm501.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 8789722ef27..f276276f7f1 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -1036,8 +1036,9 @@ static void sm501_i2c_write(void *opaque, hwaddr addr= , uint64_t value, int res =3D i2c_start_transfer(s->i2c_bus, s->i2c_addr >> 1, s->i2c_addr & 1); - s->i2c_status |=3D (res ? SM501_I2C_STATUS_ERROR : 0); - if (!res) { + if (res) { + s->i2c_status |=3D SM501_I2C_STATUS_ERROR; + } else { int i; for (i =3D 0; i <=3D s->i2c_byte_count; i++) { res =3D i2c_send_recv(s->i2c_bus, &s->i2c_data[i], --=20 2.31.1