From nobody Mon Feb 9 19:06:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623876264; cv=none; d=zohomail.com; s=zohoarc; b=X15PjocyYHi24OfLjAldSGPe9VXG50p8dJQSWiHlGzPr6E9Pyv0XoV9SkOgF01RM/p0qYRuZFRNnfZyQjlmCsTpsm9m8iaLn2NFM9KWfoS+7gCxJumA6t0REurZNN6LEH6eq9YTntWBm+7lK+1fq2+r9CJ9cpnYZqYFxfnhEkNw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623876264; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=KJdW6m0Ma56hwzjCy1teOEHrEH20tchf6AQogJnEfxU=; b=g2RYzKw16RCpHUfL7Peg8C6EC5nXZFHk+Frnj9IeweB/7PgYTbzcVXmCisT/OlbURD+iWT0kkAf8lsJP5w/SyFc06HO2eOWdWGq/65QnwkcB1BO06Nj9J/pe+UZ0d4T/uMxllCRP3kAT/ERX14iRbxcAjVBujNqRVGRHCxg9Lvw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1623876264255787.5368972240659; Wed, 16 Jun 2021 13:44:24 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-O6b_ktYsNyqV1DcNyQfoEQ-1; Wed, 16 Jun 2021 16:44:21 -0400 Received: by mail-wr1-f72.google.com with SMTP id h104-20020adf90710000b029010de8455a3aso1856338wrh.12 for ; Wed, 16 Jun 2021 13:44:20 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id b8sm6048742wmd.35.2021.06.16.13.44.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jun 2021 13:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623876263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KJdW6m0Ma56hwzjCy1teOEHrEH20tchf6AQogJnEfxU=; b=XNi7bsc9JAkY4XVunIZQSShOiZPLHLWX0CP0iaEjA0OQN9s/qdAHhstRcgTpqM5hV23DhU +1hTDNSl3+POUhfOD7kBM8qb3n6J2fi1viEsQz8CS5vJzME+FNOR07DQt0l58RvgTGiX71 w3UclG96NbmRrCI6o8nzzraJwainHts= X-MC-Unique: O6b_ktYsNyqV1DcNyQfoEQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KJdW6m0Ma56hwzjCy1teOEHrEH20tchf6AQogJnEfxU=; b=PYN8SKJkQqL2PTVd9ueSEo9TrTtdEEn/oFOmFVSBO5Xum4pcP9PasHthnsgh2wIo+k xQjSKDeoaDuBVW4P2jkYRnXmouVjMG6RvkIrw3HKawNDn2tTbThHgR5OqeGUnoZlmtGB muqZSAaea3obSa0GGtEcR7D+hLn8kHkkOBptUSpGH0TV3SfUE5AxzFzdnA/v6A8m/RIR FqhhMjEtzqbOIzg0VdOPp67yMZtth3ryDZNSVvoU1I4OmorWbGYstijCsogykN9jBXYG w45GJONMKdTJFsGjlmlVVRwSLXszXf7UjtxXWs86GACNLYISwytg6Nsz/j8LNcKc192J x8YQ== X-Gm-Message-State: AOAM532Cj1loxg8gmUWVmomOxNL0C2o7JjyO4TMrJXbdsH8u8lsiQDri aNAZJVxLdrnMBknP4weONix1IOvmJbR68Pg0IT/pgcTA3lovbpoFOAzTYCl5J0+HT8Wxvsj0nHO H7UUAaRuwMH81cw== X-Received: by 2002:a5d:60c8:: with SMTP id x8mr1208696wrt.382.1623876259405; Wed, 16 Jun 2021 13:44:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyixwQR7l27UKVWaZuT5XHYcGzirQFtRhxb+W0+ewb+ZpkQ+NgluuvAJoiytEWi2zigltASA== X-Received: by 2002:a5d:60c8:: with SMTP id x8mr1208682wrt.382.1623876259297; Wed, 16 Jun 2021 13:44:19 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Paolo Bonzini , Connor Kuehl , Gerd Hoffmann , Brijesh Singh , "Dr . David Alan Gilbert" , Eric Blake , Eduardo Habkost , Markus Armbruster , Igor Mammedov , James Bottomley , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Sergio Lopez , Marcel Apfelbaum , "Michael S. Tsirkin" , Laszlo Ersek , Dov Murik Subject: [PATCH v2 08/23] target/i386/sev: Mark unreachable code with g_assert_not_reached() Date: Wed, 16 Jun 2021 22:43:13 +0200 Message-Id: <20210616204328.2611406-9-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210616204328.2611406-1-philmd@redhat.com> References: <20210616204328.2611406-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The unique sev_encrypt_flash() invocation (in pc_system_flash_map) is protected by the "if (sev_enabled())" check, so is not reacheable. Replace the abort() call in sev_es_save_reset_vector() by g_assert_not_reached() which meaning is clearer. Reviewed-by: Connor Kuehl Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/sev-stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c index eb0c89bf2be..4668365fd3e 100644 --- a/target/i386/sev-stub.c +++ b/target/i386/sev-stub.c @@ -54,7 +54,7 @@ int sev_inject_launch_secret(const char *hdr, const char = *secret, =20 int sev_encrypt_flash(uint8_t *ptr, uint64_t len, Error **errp) { - return 0; + g_assert_not_reached(); } =20 bool sev_es_enabled(void) @@ -68,7 +68,7 @@ void sev_es_set_reset_vector(CPUState *cpu) =20 int sev_es_save_reset_vector(void *flash_ptr, uint64_t flash_size) { - abort(); + g_assert_not_reached(); } =20 SevAttestationReport * --=20 2.31.1