From nobody Tue Feb 10 01:16:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623860567; cv=none; d=zohomail.com; s=zohoarc; b=RYB2SXmVls9lO7jkxVzdaesQBb5iR6INBPfNq4LCResB1KJC2AA2I7+djNoxCm8si3evkpGvJoKJUHXBdBMJtD7L+wmUEyLEFyxBpYPYIT4E8tQZ15240HTSo6KpNoGYYRb398/nYs+letg+4sn0eQaxokvadNmJYjgHZNo+bcI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623860567; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=xExdDe4N+GemsTc4t2mEkAP+Zb7Tj4gyC4bIiLrVVZE=; b=kP1g05vpKz3aX98K5ECUcFubpR60/Zls7XZ4Re/9XXrphm79zz1PWhEk/QgORCvNFzkNBjk9iHnxHxxdvNZgfJA8N6Y4DWG89vc8h8XLwyv1nZ0259sThktbJaw4uDKDob2HGzcuChzh5xlDz9sZlaD7u5mgV0V6Ez1rXk8azSU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1623860567028711.645849214058; Wed, 16 Jun 2021 09:22:47 -0700 (PDT) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-145-yjsiqGEqMY2nD55_OSi3fg-1; Wed, 16 Jun 2021 12:22:44 -0400 Received: by mail-wr1-f71.google.com with SMTP id s8-20020adff8080000b0290114e1eeb8c6so1482839wrp.23 for ; Wed, 16 Jun 2021 09:22:44 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id z17sm2645973wrt.60.2021.06.16.09.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jun 2021 09:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623860566; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xExdDe4N+GemsTc4t2mEkAP+Zb7Tj4gyC4bIiLrVVZE=; b=P/gA7FaS+IDhv4AbbgRrkceU0efra7cMYOCMa530OP2DUW0BY47jzqpgzi9Ub+0abwE194 t3YMH4GqPauRTgLFO1J5IFIt7UMmOe74cED1oq3P8lCuiqackSMuWdprNgYRKE0z34KMoX QT+/THkF5UwFXliFbCchi6Kw5CL6Av8= X-MC-Unique: yjsiqGEqMY2nD55_OSi3fg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xExdDe4N+GemsTc4t2mEkAP+Zb7Tj4gyC4bIiLrVVZE=; b=FB1X30uX8M56lkftHKABZJscFw6hxNTL+f0hvis2v5leRycAsg1yfeMzuji2OlXN7Z OeDiS4VMFzR7EXBIeRQ1A87Sw5GNpZxJ4sjBAaWbsYdQP3W/OUEyzUeV9GEz+eYM4VUz 9yxF8uY371vsVxAU66rT0pHhbeExUk+ZlQhQBWdfd13cXqSMkZQ50Dll9/ra624oUNpB 91DPugz2AR5MWmxvtraTpyj5C2EG4fobCw6BOmP0h+27UsyZJtD4tc5/yg74hwoAng9C 9SldewxFKwMPArlj2ibSAt3rGP2iYJwYZlG4nAyj50CEukSN9cBL5IrTTAPNuW1xz5Z4 F0jw== X-Gm-Message-State: AOAM532IjViubHhTviDl9DzVM4HtcLbw49ddCJJpXd9GRoYqbZo5A4cs 2SdS0I8qz85AougNEiK145Gh5BdNOjKGdriSzxxFJHPmHquJc0nlTOFGd9v8O2WIQK1Uh60LWYB M/xnI0NPouutikw== X-Received: by 2002:adf:9084:: with SMTP id i4mr264045wri.23.1623860563690; Wed, 16 Jun 2021 09:22:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz4FWPI4rSW/7Fl3ABL8A5d3xEHe8JRbTVo85W7RW+Y/dZfWooCgU7n+1cEjvpIFpBs33cQ2Q== X-Received: by 2002:adf:9084:: with SMTP id i4mr264029wri.23.1623860563529; Wed, 16 Jun 2021 09:22:43 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 4/7] migration/tls: Use qcrypto_tls_creds_check_endpoint() Date: Wed, 16 Jun 2021 18:22:22 +0200 Message-Id: <20210616162225.2517463-5-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210616162225.2517463-1-philmd@redhat.com> References: <20210616162225.2517463-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Avoid accessing QCryptoTLSCreds internals by using the qcrypto_tls_creds_check_endpoint() helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Richard Henderson --- migration/tls.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/migration/tls.c b/migration/tls.c index abb149d8325..ca1ea3bbdd4 100644 --- a/migration/tls.c +++ b/migration/tls.c @@ -49,11 +49,7 @@ migration_tls_get_creds(MigrationState *s, s->parameters.tls_creds); return NULL; } - if (ret->endpoint !=3D endpoint) { - error_setg(errp, - "Expected TLS credentials for a %s endpoint", - endpoint =3D=3D QCRYPTO_TLS_CREDS_ENDPOINT_CLIENT ? - "client" : "server"); + if (!qcrypto_tls_creds_check_endpoint(ret, endpoint, errp)) { return NULL; } =20 --=20 2.31.1