From nobody Mon Feb 9 18:44:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623860558; cv=none; d=zohomail.com; s=zohoarc; b=jcVQq8kf5ZwIRubHOq7edyMieziYJlik0UVverlNL7xef46kxtc4bZGYFTes4xQS1AGBAh4P63xwIwlg8fCum0cEbkjEd7/lrq2K7TOyWqrxeoLUPQkltpD0FiWXiUQHH/vf+pdHscIl9SGnlYc70oOZOXEqdbbplUWjv3FYn20= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623860558; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=WUQdFiF4I9usEoqcWuw9jovz2j6QkV4ypfDpy+yQNBk=; b=XsjvRvr7DZNdRpZpwF8FV9ZXjAmLM4LeE1ENI1xkfStjgQ/mR2Wfjr6nJj7FYJULGWo3pTRwToJvovxed7Q/o7YOjuGNP5i+so9pp0Kn+pZ9QiDjMpyjhsbBjxXKLweLovnEJ8JgP5pmgFOfY2FmxzA0r3ZPTVTZe9ZVmk+Zl2E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1623860558560469.08403358625753; Wed, 16 Jun 2021 09:22:38 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-474-nKScMqxaO5mAvXxnPNmq-A-1; Wed, 16 Jun 2021 12:22:36 -0400 Received: by mail-wr1-f72.google.com with SMTP id d9-20020adffbc90000b029011a3b249b10so1503291wrs.3 for ; Wed, 16 Jun 2021 09:22:36 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id p11sm2597966wrx.85.2021.06.16.09.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jun 2021 09:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623860557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WUQdFiF4I9usEoqcWuw9jovz2j6QkV4ypfDpy+yQNBk=; b=N+FHnqhz+dD86n2H7pRHisHXOnGUcKVeKH1xY0gJc2N/nfwvzEnGGRMqfP9tQRrk8dsgt5 jxNrzw6LpMbGVWDlBpcdco0vpbXN46SsBgr4WZjJ+XWFk8iWrPgafgIwQb83ZEWf08hMKO BP9r4ZwTFQhxsmFY1PA2FD65H7e3pFM= X-MC-Unique: nKScMqxaO5mAvXxnPNmq-A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WUQdFiF4I9usEoqcWuw9jovz2j6QkV4ypfDpy+yQNBk=; b=r4S04emqCXg8Ex2rftWCzIKQDDNwCHfxLNE/k6yI6jqxnrAkXfa89a5W8cRE/ePFXD w95WOa5WG8784wWDC3KAmTsma1EOFOBSOkfVQY29ryJ2IZQOCjoQQ1EHIjgwpuo54HX1 jZaAQ/manZBlrXH80PA3WnxIlBuzwc66r733WoIsnOk6fZKEdI0O6+pm3nHMH1cycGq7 ff6ya/uVopr5kXsU3YJl4mbdos9z6jLxrSITze4lhSgaNittEuC4uq5JW9URDjA/ccMp 8dZRjGqkBJGxQz6tVRmY4IhChdXeRJyU+YD97cSROj9xGCs/e4MPO9dfyl8BF+hsdOKw v09Q== X-Gm-Message-State: AOAM532AOWun4opLsC4cgk1OyqTElV1NDos3UqouHIYAeyxkwC5GyFom n5q+lmYJ6Pi6hbTl8TJfnNb+DUv+SdEybbk6PySS8mxsj8egl/TdBSt6fiGGbNqSMIve9nvOuqF /JA1YWLnEKRt9og== X-Received: by 2002:adf:a284:: with SMTP id s4mr225635wra.397.1623860555385; Wed, 16 Jun 2021 09:22:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzerqdDFU+hrqhimAnDSgDiDsfgbQps0VofL3pbs+7SiCYB6M5sh6Z0xAMETkiwiKp9ceV3bA== X-Received: by 2002:adf:a284:: with SMTP id s4mr225615wra.397.1623860555199; Wed, 16 Jun 2021 09:22:35 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 2/7] block/nbd: Use qcrypto_tls_creds_check_endpoint() Date: Wed, 16 Jun 2021 18:22:20 +0200 Message-Id: <20210616162225.2517463-3-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210616162225.2517463-1-philmd@redhat.com> References: <20210616162225.2517463-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Avoid accessing QCryptoTLSCreds internals by using the qcrypto_tls_creds_check_endpoint() helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Richard Henderson --- block/nbd.c | 6 +++--- blockdev-nbd.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 616f9ae6c4d..b13a33c3d21 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -2159,9 +2159,9 @@ static QCryptoTLSCreds *nbd_get_tls_creds(const char = *id, Error **errp) return NULL; } =20 - if (creds->endpoint !=3D QCRYPTO_TLS_CREDS_ENDPOINT_CLIENT) { - error_setg(errp, - "Expecting TLS credentials with a client endpoint"); + if (!qcrypto_tls_creds_check_endpoint(creds, + QCRYPTO_TLS_CREDS_ENDPOINT_CLIEN= T, + errp)) { return NULL; } object_ref(obj); diff --git a/blockdev-nbd.c b/blockdev-nbd.c index b264620b98d..bdfa7ed3a5a 100644 --- a/blockdev-nbd.c +++ b/blockdev-nbd.c @@ -108,9 +108,9 @@ static QCryptoTLSCreds *nbd_get_tls_creds(const char *i= d, Error **errp) return NULL; } =20 - if (creds->endpoint !=3D QCRYPTO_TLS_CREDS_ENDPOINT_SERVER) { - error_setg(errp, - "Expecting TLS credentials with a server endpoint"); + if (!qcrypto_tls_creds_check_endpoint(creds, + QCRYPTO_TLS_CREDS_ENDPOINT_SERVE= R, + errp)) { return NULL; } object_ref(obj); --=20 2.31.1