From nobody Wed Feb 11 01:00:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) client-ip=209.85.221.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1623860081; cv=none; d=zohomail.com; s=zohoarc; b=nbN3ViDQqlfJR0Ladt8dEDogcsgJs9oGJhhzGn2vWVRpcJrqweaPQberwlkayKY/ao7gy+997CyXXo6AEQ5oSxrmSRTC4hDSyChIQX0c/NukspG07YyHmqUQLV4Wtc3Ofdzyz7YZhPlCOu39RI6VaQYtgqSr8VmC9Sk/X3XEgrU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623860081; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=13TAtltxyz3HRLnsPYZNhrV/l1rMyq15Cuna6JS4ElM=; b=d5dS6kh9BVcDTTXCmZyXCxew3iZDCtN1NdGjhqSPr8PPFIi4mq44YLIP/tE8uUBocG9JF6iiLhiyI57JDMX14Lc5ZqbKuHBUF1lHjiapapGAiJlusOzLxJDIX0vXvFBht4H9xWn6w3ET092eCdpKRhLogobF7OGbsYWsvAAbr8Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.zohomail.com with SMTPS id 1623860081734687.9150920884624; Wed, 16 Jun 2021 09:14:41 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id v9so3328589wrx.6 for ; Wed, 16 Jun 2021 09:14:41 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id 89sm2627574wrq.14.2021.06.16.09.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jun 2021 09:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=13TAtltxyz3HRLnsPYZNhrV/l1rMyq15Cuna6JS4ElM=; b=C+N4rBgUIQjK42/iEPG4IUufNCAfzXzl30XI1Dq3ehDFkcSLW5OWbkfL6nfgXltve/ 8sl5hmL3Sod+KOj6fFgHqnJ6Z12XDdqqA6tqivZenWO9oFMrI75pHcIBVSs+m/pqFnO0 /bCvsqU5073FJmregNgrbg3OPaDdGMISWXN6bjIqb9gwuftk+mQwOqWC6/6FPs07MtUc yqBj/GmGtKTU8dS6iEHUcWKaLl1agi3baf48xd6bWPtO9QJLTNf19dQw+KWn2t73yaT7 UzTylIpICCB0+SGcwzQVk5dYIM++MbuyqXqpVDIgtT1nsijR5Zc/NeABezWaTUUO0ZGD ugCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=13TAtltxyz3HRLnsPYZNhrV/l1rMyq15Cuna6JS4ElM=; b=NiKRkLyU6YpMQD9eozsJXw67Pa1gU7LGuLLeZw+jxbKEfb9bTpM+yDgckuOJ/a4Wlb Pwe3jLve2IYo2iKNy4o82CF4YGhduUwIGrYoLk1TmwA0AwIwfHqhiBvrmiKuWQ67n4Co v1D8nSUMIyWwt/rrPcY7MhhLUcRQh32gPJra+H70WeGImQ/ApOZHQAoReGxR9datUHxL ULkJLGV6deEzM3g16ofUTntkRrzbnMp8RRaueHDZnQqTmF8/JffuUh3GdR++0bD2HAdR dQCZZNUS/ltYufnI7Ty/Kw1pU4sDapZ1wWp12TXXc3GPoAzYvqNgGQ8IvYebPV/4UCCj iqAQ== X-Gm-Message-State: AOAM531kCkGauZUxEz7adBAxxzig1IoPEjRxWljWVU4/2V7XjNhJpgRK RrzsDECOFNSHpw56WVz9eQc= X-Google-Smtp-Source: ABdhPJwa0NRopmxNNvalRx5rUReJ8/RyWb4IBsiAqiqOvsE6mwG9BzWs9B5sjrgLepHKLQA1BqamXg== X-Received: by 2002:a05:6000:1a87:: with SMTP id f7mr245553wry.172.1623860079959; Wed, 16 Jun 2021 09:14:39 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Corey Minyard , qemu-ppc@nongnu.org, "Signed-off-by : Frederic Konrad" , BALATON Zoltan , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 04/13] hw/display/sm501: Replace i2c_send_recv() by i2c_recv() & i2c_send() Date: Wed, 16 Jun 2021 18:14:09 +0200 Message-Id: <20210616161418.2514095-5-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210616161418.2514095-1-f4bug@amsat.org> References: <20210616161418.2514095-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Instead of using the confuse i2c_send_recv(), rewrite to directly call i2c_recv() & i2c_send(), resulting in code easire to review. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/display/sm501.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index f276276f7f1..569661a0746 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -1033,17 +1033,18 @@ static void sm501_i2c_write(void *opaque, hwaddr ad= dr, uint64_t value, case SM501_I2C_CONTROL: if (value & SM501_I2C_CONTROL_ENABLE) { if (value & SM501_I2C_CONTROL_START) { + bool is_recv =3D s->i2c_addr & 1; int res =3D i2c_start_transfer(s->i2c_bus, s->i2c_addr >> 1, - s->i2c_addr & 1); + is_recv); if (res) { s->i2c_status |=3D SM501_I2C_STATUS_ERROR; } else { int i; for (i =3D 0; i <=3D s->i2c_byte_count; i++) { - res =3D i2c_send_recv(s->i2c_bus, &s->i2c_data[i], - !(s->i2c_addr & 1)); - if (res) { + if (is_recv) { + s->i2c_data[i] =3D i2c_recv(s->i2c_bus); + } else if (i2c_send(s->i2c_bus, s->i2c_data[i]) < = 0) { s->i2c_status |=3D SM501_I2C_STATUS_ERROR; return; } --=20 2.31.1