From nobody Tue Feb 10 01:31:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623778098; cv=none; d=zohomail.com; s=zohoarc; b=hRGhjPbK7+DwugGCnrUJiaIjLHCQynKX8ZhjuMqFRqazVG0QbcD3kHKgUaGy7WR1M5/DCCPzaAh4rZOUAQ1d3RtqZCKZviqlLqfUUeOLp5j6JFmKe+B6c6kbaf22fw+XbRaLNsnTkjT5jLu0oI+QB6beZXZ0kO6NTd+t5yQg8Jo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623778098; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=4C/sIPJIJ9x04mkRkFeW0rAiiCZBP7NEySvc0zgDkpg=; b=aj/JpxStATc694//tl9d+Dl3w0N7/Jo9tur5kXOWthSe2aDqZoUP3drGjRaRQ/dyIPShkqG55BIjRUFfLrmdpsB6r/yfFS84CwtFrmEnDmrR+66BRDuq99omulW3lEa6qo7xfkuEg4p4Ucf4YAQWM7EQJq/CrwLjBqzHhQiNa/g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 16237780988711016.8584036513433; Tue, 15 Jun 2021 10:28:18 -0700 (PDT) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-vEK4BLU5NSyDwNdrBuMI0g-1; Tue, 15 Jun 2021 13:28:14 -0400 Received: by mail-wr1-f71.google.com with SMTP id e9-20020a5d6d090000b0290119e91be97dso8944881wrq.1 for ; Tue, 15 Jun 2021 10:28:14 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id q5sm16204726wmc.0.2021.06.15.10.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 10:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623778097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4C/sIPJIJ9x04mkRkFeW0rAiiCZBP7NEySvc0zgDkpg=; b=SsZRNXpuswMlRY16kJXClBjmNzw/Qst207sdRZFeK3Y8vlPDLmRpaBmnXjzRj/5nSlW0QX Vo+FQmPso+B6/ZMCt6IMeHIf9nS7Laxjqqj1FpkTKxKGbu3O45SvaPa4Gx76WXH2TLk6Sm jX5fg6Q491HNYYldJB32RJIKG+TC04A= X-MC-Unique: vEK4BLU5NSyDwNdrBuMI0g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4C/sIPJIJ9x04mkRkFeW0rAiiCZBP7NEySvc0zgDkpg=; b=aZN4HbCBE40XfRQPK4qASAPF4ISd55K0ws+B+O1fA5i6vm/SUdXpJKOcIM5GBZzzjr F/Xfrapo1qqfJnacom/68VIhDs5oDUCoIdGt7Ji+GD8vgkDQl+kSYufwSirGamJ7dFJR s66hBUH3OjF89U/oLAjFjCsmYU5+Kp4hNAY6TwJCH9cu7C4dOHS+wdo1Ndn5zUrt/c4R 4EJFZVU1Fp019FQqd17rSWjsmNakKy92cNgj1pGCH0zc7lHkExUGbtr9prHR7lzt8Ra+ SnP3WR89/CLFXGVv77lquFTBEWbMc+u+wpulsqC1vC70KSO3GzigQNGK9hUNpJAr/l9v wxow== X-Gm-Message-State: AOAM530/iKPt2t/12tqvWRRO3mGNxHIniQ0kWudI2wLf02RTgOtidd+7 35VGIw/vXquJgV5zrN8PK0zqrj84dRUFP93QUN0D4Rq5NL3o5fLcBC43tr/oXI19XPobr1r07xc NKs/KPZsV0X0CtA== X-Received: by 2002:a7b:c206:: with SMTP id x6mr6480309wmi.26.1623778093489; Tue, 15 Jun 2021 10:28:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVhE4snd4Wo8U1+kBEFMYEhRwTltYtN0lJS/a+i6yHGkCF7q/HmdMzhy+UaDLJg+8hYMIWkw== X-Received: by 2002:a7b:c206:: with SMTP id x6mr6480292wmi.26.1623778093378; Tue, 15 Jun 2021 10:28:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Leonardo Bras , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 6/7] ui/vnc: Use qcrypto_tls_session_check_role() Date: Tue, 15 Jun 2021 19:27:45 +0200 Message-Id: <20210615172746.2212998-7-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210615172746.2212998-1-philmd@redhat.com> References: <20210615172746.2212998-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Avoid accessing QCryptoTLSCreds internals by using the qcrypto_tls_session_check_role() helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- ui/vnc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index b3d4d7b9a5f..c7c8454b873 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -4080,9 +4080,9 @@ void vnc_display_open(const char *id, Error **errp) } object_ref(OBJECT(vd->tlscreds)); =20 - if (vd->tlscreds->endpoint !=3D QCRYPTO_TLS_CREDS_ENDPOINT_SERVER)= { - error_setg(errp, - "Expecting TLS credentials with a server endpoint"); + if (!qcrypto_tls_session_check_role(vd->tlscreds, + QCRYPTO_TLS_CREDS_ENDPOINT_SER= VER, + errp)) { goto fail; } } --=20 2.31.1