From nobody Mon Feb 9 21:12:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623778091; cv=none; d=zohomail.com; s=zohoarc; b=PtmSjPfeqAYVeZTOtjVN24b7lB671dC3dJlpaVpnsLBXVvGj+Wekfn0M8SJXXqdAaA69RxylV88kZy2wmQTdGc1oKLDJRDnReWNteUMi2eZmpVqjkJtW/ArRTCskdXp5iflhS+UFaUVdQ08wcuna/ZZ+dibQ6aX4DEzSm+XZVUA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623778091; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=xExdDe4N+GemsTc4t2mEkAP+Zb7Tj4gyC4bIiLrVVZE=; b=gJCFB/AWclFPL+JT01CeQUTgNRuP/TmKfoZIuPWkXGPAM53PGCKzIyx4gKs0kPQzLg1oM0XgNqAZVhcAKKOQZoi2gPiyHEmOltfROlKH14/YISRIildeTR5tJtVgb6rv7hJxZWQNgGcXm4BSv6GOSW0Ud8JFzVl5qGV+GBgB3NE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1623778091253386.8779262518966; Tue, 15 Jun 2021 10:28:11 -0700 (PDT) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-37-k9zlElplMViJjnnRABJZLQ-1; Tue, 15 Jun 2021 13:28:06 -0400 Received: by mail-wr1-f71.google.com with SMTP id m27-20020a056000025bb0290114d19822edso8929414wrz.21 for ; Tue, 15 Jun 2021 10:28:05 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id u16sm20706326wru.56.2021.06.15.10.28.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 10:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623778090; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xExdDe4N+GemsTc4t2mEkAP+Zb7Tj4gyC4bIiLrVVZE=; b=hg4TkYzp2JS3gi3FiM4W1RHazjVQjo7nRjRsHTdqTY4zIj7zvujAk4A1JIyU4cwf/myW3L E7lBmDPEkJRbUUnIDV7THCHE821rSA1djKMHtrLLK5Vf2RCK+Hs6lO6UYu/4tMoRCWMelZ wB5ZWphjNI0tnSTWysy8THbHBvbZY5k= X-MC-Unique: k9zlElplMViJjnnRABJZLQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xExdDe4N+GemsTc4t2mEkAP+Zb7Tj4gyC4bIiLrVVZE=; b=ropzhJdHbVmvsoj5HbuktMg3Yj4tzJNQOI1h0zRk9RcrXDrVQOo3FnlHg0smj3AoOs PIr3ahiZI6HOkaIfzHn3VQxz16lo8DcvtJEQkxUJy6LWs9+H1xB+gI9gtHYZ2nAHqtbt d5Yw17uh8SBzrha+lz+kw8I2F5aLqkxvxr5cnGnS6zifgp3FIbDdnsjVRd4l3pa0uNjF LSHD3HsN5V4BGxgZH7aDFQdhPLzyoXiSxM6kk4NnIEKo6Igt57+9gTrIAc/+TDaRjwQL lzVGGBCZMg8uGcHFukXRCThxvZZPscP3qkTThqVPyXjdc2vSokZUUycFuw/U7fG6gYDu 8c+w== X-Gm-Message-State: AOAM5313XrBJrtCViiIMe6GjfoHy0cWQ6pa3eGsuoTtAn8TUVl9+vfYW w+gDbYEbGoySWD/ejSkqLGXLwrxF20gOiz+Pz5jd21CthpQ9acizYs8N73hrdUoz5XFMMV/G3hp j9mlakBJn2FfpEg== X-Received: by 2002:a7b:cd0f:: with SMTP id f15mr4969521wmj.177.1623778084855; Tue, 15 Jun 2021 10:28:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnJRJjJQbQOJLvD7kJ7YHhj7k+uyYgO74TNSkMeSILLIblRZBmFHpk6fdZXHKz8lUbeVjQ6g== X-Received: by 2002:a7b:cd0f:: with SMTP id f15mr4969506wmj.177.1623778084738; Tue, 15 Jun 2021 10:28:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Leonardo Bras , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 4/7] migration/tls: Use qcrypto_tls_creds_check_endpoint() Date: Tue, 15 Jun 2021 19:27:43 +0200 Message-Id: <20210615172746.2212998-5-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210615172746.2212998-1-philmd@redhat.com> References: <20210615172746.2212998-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Avoid accessing QCryptoTLSCreds internals by using the qcrypto_tls_creds_check_endpoint() helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- migration/tls.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/migration/tls.c b/migration/tls.c index abb149d8325..ca1ea3bbdd4 100644 --- a/migration/tls.c +++ b/migration/tls.c @@ -49,11 +49,7 @@ migration_tls_get_creds(MigrationState *s, s->parameters.tls_creds); return NULL; } - if (ret->endpoint !=3D endpoint) { - error_setg(errp, - "Expected TLS credentials for a %s endpoint", - endpoint =3D=3D QCRYPTO_TLS_CREDS_ENDPOINT_CLIENT ? - "client" : "server"); + if (!qcrypto_tls_creds_check_endpoint(ret, endpoint, errp)) { return NULL; } =20 --=20 2.31.1