From nobody Tue Feb 10 01:31:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623778079; cv=none; d=zohomail.com; s=zohoarc; b=QvAJAnlsEA6V5Wbwz0fouD8QcjSPKNUS4ZhvmUOwdu/Hai2DCoF/M+4QcZaHrNfqEQ6b+qeCGSxavbXaVknIMATV16x05yizkv18DIO9L8EWcFU1f7Y1tZ3agVJ+mffL1Acv+/DjaMRzqd9UK3Ar59uVv/6UIDrPXJCcWmP7w5g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623778079; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=WUQdFiF4I9usEoqcWuw9jovz2j6QkV4ypfDpy+yQNBk=; b=F0X1WT52EQ54xdtNZE+PFGIsbwhxnOBfFooYk3ChHDil6kFd+90sPUBMiGDgZkPrNQKUlnvnm/tEcIQVrDD/cNAonR7/95mGRqv4J9hiNSfcvMegjJUHM+Vo6cq0xC3Mh87jd9P+S1kuue0uEqwTfEuMG+Y8lpUdP697IvdJP24= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1623778079890670.7882755904644; Tue, 15 Jun 2021 10:27:59 -0700 (PDT) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-RTHr13LfMJOMqP9mnnIIqA-1; Tue, 15 Jun 2021 13:27:57 -0400 Received: by mail-wr1-f70.google.com with SMTP id x9-20020a5d49090000b0290118d8746e06so8956876wrq.10 for ; Tue, 15 Jun 2021 10:27:57 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id q11sm19148396wrx.80.2021.06.15.10.27.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 10:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623778078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WUQdFiF4I9usEoqcWuw9jovz2j6QkV4ypfDpy+yQNBk=; b=SJ7+4vBVYBrMqHL5UW3tMcZSk6iq+AywxgTGA0Z9zjeEE3pDTFWIThTbw0q8yZ7QYiHXeo ydaqmkmAuhaHQ1RYOb5UG1c3xscA01nClcZ8Jeo8NEbZwMTdnJPg7jRUFkfuvtE1lOv0kB +NtVqQdG22+w8+xfMGs85Vd2213G05Q= X-MC-Unique: RTHr13LfMJOMqP9mnnIIqA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WUQdFiF4I9usEoqcWuw9jovz2j6QkV4ypfDpy+yQNBk=; b=XMpsbPySKQgQGQE2EF6QcjAseBq3UKyXx0VtGaqSS1coQF5PYo+gc3geL2U9wXT130 l65tnni3deED8cCvoMvNMvxLg+4g1EGNoVBxn+7IalZXBRIHDrSGkUGbySI9z/ISOpLr hSKAf5d96jcjj3Gad1tSJVv5bp0ROytvp1s7dgcM8SjZUzxLbzSX1KSsbv0X0Obn4us7 4HhybEEy0/yUKj5ARwt0aO7QEvjcQGTui+RwRdm+ssXwIbkbHLY1wIKXgMt15NQ+mmfN XoZy7M1hMafwR9Xk1vHyXbybmv4hGFMJYFCbn7P+6XYbLM8LM7bgUegx9vN///gzXdC/ Qosg== X-Gm-Message-State: AOAM530toOT6//TClXeijXLNnFFtOfXw0i/xG7GZijisqgtzhJeCi1Bc hkh3QqVyy0y8+2Vhfmi+dnqRjp7k583m9hBJuc64ZuODhcBJuE9yQCnClZi6iduOVWGnE1dOk1D B1yMsX1oO0tShTQ== X-Received: by 2002:adf:f98a:: with SMTP id f10mr206636wrr.143.1623778076479; Tue, 15 Jun 2021 10:27:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwD25luI6BaUq5O8xs92TydzlNAefUIpxoQMfdTIII8D2KVHpx/IPA8Cua+hFqqcyFwCS6wWA== X-Received: by 2002:adf:f98a:: with SMTP id f10mr206622wrr.143.1623778076323; Tue, 15 Jun 2021 10:27:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Leonardo Bras , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 2/7] block/nbd: Use qcrypto_tls_creds_check_endpoint() Date: Tue, 15 Jun 2021 19:27:41 +0200 Message-Id: <20210615172746.2212998-3-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210615172746.2212998-1-philmd@redhat.com> References: <20210615172746.2212998-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Avoid accessing QCryptoTLSCreds internals by using the qcrypto_tls_creds_check_endpoint() helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- block/nbd.c | 6 +++--- blockdev-nbd.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 616f9ae6c4d..b13a33c3d21 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -2159,9 +2159,9 @@ static QCryptoTLSCreds *nbd_get_tls_creds(const char = *id, Error **errp) return NULL; } =20 - if (creds->endpoint !=3D QCRYPTO_TLS_CREDS_ENDPOINT_CLIENT) { - error_setg(errp, - "Expecting TLS credentials with a client endpoint"); + if (!qcrypto_tls_creds_check_endpoint(creds, + QCRYPTO_TLS_CREDS_ENDPOINT_CLIEN= T, + errp)) { return NULL; } object_ref(obj); diff --git a/blockdev-nbd.c b/blockdev-nbd.c index b264620b98d..bdfa7ed3a5a 100644 --- a/blockdev-nbd.c +++ b/blockdev-nbd.c @@ -108,9 +108,9 @@ static QCryptoTLSCreds *nbd_get_tls_creds(const char *i= d, Error **errp) return NULL; } =20 - if (creds->endpoint !=3D QCRYPTO_TLS_CREDS_ENDPOINT_SERVER) { - error_setg(errp, - "Expecting TLS credentials with a server endpoint"); + if (!qcrypto_tls_creds_check_endpoint(creds, + QCRYPTO_TLS_CREDS_ENDPOINT_SERVE= R, + errp)) { return NULL; } object_ref(obj); --=20 2.31.1