From nobody Mon Feb 9 16:01:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623775688; cv=none; d=zohomail.com; s=zohoarc; b=Aq5lg2UOCego1XSzQ8f+/ca8eYb0lTK3Wx9TS9sfhI1kAhJ0/6Ol+WPpv7Y5fdW918PEPm6UizWAd6u9lNwBRXD83+tVoO9Rp9UkmOpcIylL03z41jkTNq2mkuYHuOUu7PQcLN2IlZYAYhXVa8is+jSxJsEv9n1+X5gfFii13jc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623775688; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=0mRh7tvlatkuMCVBMr+kWyLCBcff/Kp/cdfu0ZIMjj4=; b=lHGTHnRTvmRuEGVh+bKrD713zZFpShaqqC/uBKCjL0T9wIBCCs9HW3TVPIct5NLLmEkra4h5fZ5t6c/1ZC5sLUr6iVqKNdh7xIqUOrtfyXBOhUAz2hUuhtSB9DO72fkKKH2/cJUxvMddF/kyFR1wmBgxTvXUHPtENnOaaRTdqK8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1623775688669607.2077620232757; Tue, 15 Jun 2021 09:48:08 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-AYJijBcQOs-SyKWFXcBA2A-1; Tue, 15 Jun 2021 12:48:06 -0400 Received: by mail-wr1-f72.google.com with SMTP id m27-20020a056000025bb0290114d19822edso8884347wrz.21 for ; Tue, 15 Jun 2021 09:48:06 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id m3sm20139429wrr.32.2021.06.15.09.48.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 09:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623775687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0mRh7tvlatkuMCVBMr+kWyLCBcff/Kp/cdfu0ZIMjj4=; b=ZkryVJ2G9LQ1V552YpzDfg5c3+8TxrwLM/cik3le4SvV476LeNoecShaoTBtsRU/n7DpVl AYrH+9uc9S7BfvK7jDR8NsFX3aPwnwBgouF5HssNhHw2zMqU0Nir2uVXlIsrMA1XnBK9YU 2F6oTe/Hxm89jQGqSc7BrnM9S8b9Qe8= X-MC-Unique: AYJijBcQOs-SyKWFXcBA2A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0mRh7tvlatkuMCVBMr+kWyLCBcff/Kp/cdfu0ZIMjj4=; b=UTVMQ8NfECoC0wTZS1iksksjgUxqkuR+jPTCKTC4pjNOyAtgsOl956z07HUD0S69Rh hQAl4npamrbSmA1pqxHuQb0xQ5IqG7UgI04G2CCIS+xWsJaAgrTqa0e9hCQFIYIarK/O trKqkgPo6gl0tqWWUa2U5or2cFc8JvRkQPgOy6+vVORjU6R/oLLKK78dbJkIkTA5iNok M/4H/VaIbWVTSuWXq/fAHqd2GiFYFFYmfrDV//AzK3I8HdNFztAh1YK24EkaRDI6+e1s +GyAg6/k7mnkS+O8P0pptFAucUkpRB8YY0KnTkeCjizt+cIWabQyBYndRZgdnsFf2QNZ 9XDg== X-Gm-Message-State: AOAM532JQHjc1FAQcrrccYqAgzRNNV7hUFTZHShreJoa9+r4pGVA+RDj 3e5Aul+ca6kdbaoPuoyeLumlsx3TEzcaL8e2L3MEcGmEWN+l2gUmyzjp8G7f0q3IZFUF2G5Wclz gVA89NkTl+BQDwQ== X-Received: by 2002:a5d:6d8c:: with SMTP id l12mr5834wrs.189.1623775685626; Tue, 15 Jun 2021 09:48:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUaqQvrvO6xkBnzLpZrDbpy/Ce/yfzmll5b3Wc17Qe9fv8icSjn7D4TWXDtcYK59AtzNKiEA== X-Received: by 2002:a5d:6d8c:: with SMTP id l12mr5817wrs.189.1623775685454; Tue, 15 Jun 2021 09:48:05 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Leonardo Bras , Lukas Straub , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 3/7] chardev/socket: Use qcrypto_tls_creds_check_endpoint() Date: Tue, 15 Jun 2021 18:47:47 +0200 Message-Id: <20210615164751.2192807-4-philmd@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210615164751.2192807-1-philmd@redhat.com> References: <20210615164751.2192807-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Avoid accessing QCryptoTLSCreds internals by using the qcrypto_tls_creds_check_endpoint() helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- chardev/char-socket.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index daa89fe5d1d..fe6b1fe2110 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -1403,13 +1403,15 @@ static void qmp_chardev_open_socket(Chardev *chr, } object_ref(OBJECT(s->tls_creds)); if (is_listen) { - if (s->tls_creds->endpoint !=3D QCRYPTO_TLS_CREDS_ENDPOINT_SER= VER) { + if (!qcrypto_tls_creds_check_endpoint(s->tls_creds, + QCRYPTO_TLS_CREDS_ENDPOINT_SERVER)= ) { error_setg(errp, "%s", "Expected TLS credentials for server endpoint"); return; } } else { - if (s->tls_creds->endpoint !=3D QCRYPTO_TLS_CREDS_ENDPOINT_CLI= ENT) { + if (!qcrypto_tls_creds_check_endpoint(s->tls_creds, + QCRYPTO_TLS_CREDS_ENDPOINT_CLIENT)= ) { error_setg(errp, "%s", "Expected TLS credentials for client endpoint"); return; --=20 2.31.1