From nobody Fri May 17 05:54:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) client-ip=209.85.221.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1623648389; cv=none; d=zohomail.com; s=zohoarc; b=ZAlkzL02+JQN1mqd9uEqAmyOZnig6rePouuCSKYIWyM3RrvoRcJre7UUp2H1KtRI74HOdd1m1zP73XpmrbnC0uuhO8nb3UaQAL8B8SUGDAbISGYplXEsHTge5kMdTJJniuZvmCZFmdnb527SxXmkdUvv2nZVTvTUUq3wX7FZKhk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623648389; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=nhR+JGOKSUCLxBZNtaVPLvIbdzNaBysFi3i6WyCcL84=; b=oHJLs5XrGiTua4zvNleRq/bNSUPzIgXYd1cPwnedrdB9C6JBXFccxsw+/wAkyGEPTcSVBwu/rApUxyo4blJrQQOAPfqF/pNpB5dAqOGGnhsP4AnuCWdRAoCjnctzsR1fyy8QtJLGG95lhN+Vy0p2Kq69UFlzlGblcc3FDHXp/eA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.zohomail.com with SMTPS id 1623648389481900.6424921269607; Sun, 13 Jun 2021 22:26:29 -0700 (PDT) Received: by mail-wr1-f51.google.com with SMTP id l2so13056115wrw.6 for ; Sun, 13 Jun 2021 22:26:26 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.. (93.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.93]) by smtp.gmail.com with ESMTPSA id i2sm11848444wmo.40.2021.06.13.22.26.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Jun 2021 22:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nhR+JGOKSUCLxBZNtaVPLvIbdzNaBysFi3i6WyCcL84=; b=Lxc8sYkXMX4J3LXUGzyQpmlqQL2U7J+4oVsG9HIgaSdDehgoT5l225c8ciWXraE31C uZp46/ymCl1FJzmgtMC4ugtT7v4Y3VrnDaK0diT1pL6Oa/o8zU0Yijx7JJarJLsQjyac nW5fmxalUeqljtBwuV4SuRqiRBqt643sC+gCB/xYomAkuuWPIfcBzQb6erc1qD3IiYAy QNljuuVOBH5nTuc00T6ehPBhmIxCN0WfyRZsjDppIfSjjjuITgq6CtePcVsO++tw93q4 OdIBpg9kDTNNBbw0/4vlGJImg247+TfOmUMIda3clatNWTuZvkyYZtN96I+UDphCNkuu pTwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=nhR+JGOKSUCLxBZNtaVPLvIbdzNaBysFi3i6WyCcL84=; b=Gpee/76G2/+ESJJifayuHmCCM5+jJs9MOAK0EdGS1CyzSi82HYrw91pxM4tlPHlI8n /vLNXBgIbnYbQOf/BVHWBryvMmQWb60FMCiNWtMjZYYQVbB8brSE9gaB07uqSgZVsre7 ldm9uwNrYKNHV6Rzm9dBSziL558Tmyctg6XAeAftrkRA10ry1fgMkUehn9CQcv1oknRA wzqiO/s2w3igxVtpdST4dpYcmVNwn0NE+9rsE3HxN3NU7TS/1ws8GMPZuYGx7YDCVxF5 6kp0AP8J5SCQwx7eEQRpAhz3szrkweEOVG/sUI7T9sHe2C6gQI/ycBczSd0vZkJLcaqU ZtvQ== X-Gm-Message-State: AOAM531vkhXybuwNpfDbx9h3oRWugrNos3tHb554Rvi4V4zjErIrTtjV r0Ym0n4wR42eNKvzPuttMRI= X-Google-Smtp-Source: ABdhPJw3HUv9ezhqJMztn8CGPwQQR7yHH0NexG6zy3pKkZekmbTCGzUKMvOapW+F7T56GgW4D0knSg== X-Received: by 2002:adf:f305:: with SMTP id i5mr17225899wro.29.1623648385618; Sun, 13 Jun 2021 22:26:25 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Juan Quintela , "Daniel P . Berrange" , Lukas Straub , "Dr. David Alan Gilbert" , Leonardo Bras , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Stefan Weil Subject: [RFC PATCH] migration: Add missing dependency on GNUTLS Date: Mon, 14 Jun 2021 07:26:23 +0200 Message-Id: <20210614052623.1657103-1-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Commit 7de2e856533 made migration/qemu-file-channel.c include "io/channel-tls.h" but forgot to add the new GNUTLS dependency on Meson, leading to build failure on OSX: [2/35] Compiling C object libmigration.fa.p/migration_qemu-file-channel.c= .o FAILED: libmigration.fa.p/migration_qemu-file-channel.c.o cc -Ilibmigration.fa.p -I. -I.. -Iqapi [ ... ] -o libmigration.fa.p/migra= tion_qemu-file-channel.c.o -c ../migration/qemu-file-channel.c In file included from ../migration/qemu-file-channel.c:29: In file included from include/io/channel-tls.h:26: In file included from include/crypto/tlssession.h:24: include/crypto/tlscreds.h:28:10: fatal error: 'gnutls/gnutls.h' file not = found #include ^~~~~~~~~~~~~~~~~ 1 error generated. Reported-by: Stefan Weil Resolves: https://gitlab.com/qemu-project/qemu/-/issues/407 Fixes: 7de2e856533 ("yank: Unregister function when using TLS migration") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- RFC: Not tested on OSX. Stefan, do you know why this isn't covered on Cirrus-CI? https://cirrus-ci.com/build/4876003651616768 --- migration/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/meson.build b/migration/meson.build index f8714dcb154..5b5a3f7b337 100644 --- a/migration/meson.build +++ b/migration/meson.build @@ -8,7 +8,7 @@ 'qemu-file.c', 'yank_functions.c', ) -softmmu_ss.add(migration_files) +softmmu_ss.add(migration_files, gnutls) =20 softmmu_ss.add(files( 'block-dirty-bitmap.c', --=20 2.31.1