From nobody Sun Feb 8 20:13:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623097709; cv=none; d=zohomail.com; s=zohoarc; b=M2/hDvJJKtUJ6ito2Id0u2UuAqGbR3wOQ6e3EfmFBh9Nikm2IBXqzARalRjF7vJIdPdteFjn2ERU6Up+jCIWrowMjw1mDqhVIpvwZvL20BlLxVcCYLTDTjzy4s8kWj4chlfot2bUovfEwA47vwhaxbiIqopvL18qbVAsnZ338Ns= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623097709; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6JFYZ5aWR4oY4cjKUnYQGoBn1ZloRqHNXwD6Qoqasz0=; b=ZNgvXOI2fUDkxLC8TOfzHkVPGXq5e7ve+i62Rpk1IjdzOt2FPCdzWcIqNPiQnqFzDB4RcmfW9hfCN4l/XieUwt6x75Lk4LRZl9HkzZo0f5987A7LSyLyiE/4UGd7a4vR/TMU2/xRrjf8aP98da58J/WJNW6iWRx7aHwy19naK1Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1623097709487920.1320737220482; Mon, 7 Jun 2021 13:28:29 -0700 (PDT) Received: from localhost ([::1]:52014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqLrI-00022C-Ag for importer@patchew.org; Mon, 07 Jun 2021 16:28:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqLXF-0004Xg-LS for qemu-devel@nongnu.org; Mon, 07 Jun 2021 16:07:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56919) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqLWz-0006YO-74 for qemu-devel@nongnu.org; Mon, 07 Jun 2021 16:07:45 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-fGPw07k0MDWeotn2hC3ahg-1; Mon, 07 Jun 2021 16:07:27 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 063BC106F8FB; Mon, 7 Jun 2021 20:07:16 +0000 (UTC) Received: from scv.redhat.com (ovpn-116-137.rdu2.redhat.com [10.10.116.137]) by smtp.corp.redhat.com (Postfix) with ESMTP id BCF485C1C2; Mon, 7 Jun 2021 20:07:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623096448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6JFYZ5aWR4oY4cjKUnYQGoBn1ZloRqHNXwD6Qoqasz0=; b=X4k62bnYkgYW8l3mktiv3tL6oQSqYG1MwbGyvy4y2gxAzkcXYdfsk2cpsL8CIyr+G9rN5i RgAZpld6YLnxFfMKv8S3hcl/vkVTja1oZQjeAHa/iOukLFj22B8wU9X/OhSR+oM9I6gIms FzVKtrF7ahFlkGOulNqMiDDBEs8w0OQ= X-MC-Unique: fGPw07k0MDWeotn2hC3ahg-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH 22/42] scripts/qmp-shell: move the REPL functionality into QMPShell Date: Mon, 7 Jun 2021 16:06:29 -0400 Message-Id: <20210607200649.1840382-23-jsnow@redhat.com> In-Reply-To: <20210607200649.1840382-1-jsnow@redhat.com> References: <20210607200649.1840382-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Niteesh G . S ." , Cleber Rosa , John Snow , Markus Armbruster , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Instead of doing this in main, move it into the class itself. (This makes it easier to put into the qemu.qmp package later by removing as much as we can from the main() function.) Signed-off-by: John Snow --- scripts/qmp/qmp-shell | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell index 31269859c4..aa148517a8 100755 --- a/scripts/qmp/qmp-shell +++ b/scripts/qmp/qmp-shell @@ -318,6 +318,12 @@ class QMPShell(qmp.QEMUMonitorProtocol): =20 return self._execute_cmd(cmdline) =20 + def repl(self): + self.show_banner() + while self.read_exec_command(): + yield + self.close() + =20 class HMPShell(QMPShell): def __init__(self, address, pretty=3DFalse, verbose=3DFalse): @@ -435,10 +441,8 @@ def main(): except OSError as err: die(f"Couldn't connect to {args.qmp_server}: {err!s}") =20 - qemu.show_banner() - while qemu.read_exec_command(): + for _ in qemu.repl(): pass - qemu.close() =20 =20 if __name__ =3D=3D '__main__': --=20 2.31.1