From nobody Sun Feb 8 22:07:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1623097045; cv=none; d=zohomail.com; s=zohoarc; b=XO0C64KPsWi8obar4Fh2CtokSCd9S2GlLyWrhU455j3ocmMvkXgG+KEsWNmmoKz2mpd1b0epI/iWSyqZHu3UjO0H6Au4xwPtYERGauo8Fh1xU750hmue7YiJZNHClfeVc++tVkhqv0h76X8da/qNnE4sPrxleqQsghbz0uDDR0Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623097045; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0yi3zJ/W406FA0wH8HIrQXSAWRKf9EFPpOyS7sMrer8=; b=VuW5YXz7eiHknmq9BvbV4KQa0ztXg1Z8u3hMXFOPmuy53y9gEyZ9M8iWtXUjiaOCjpJ7Js9bUVUulQpw9++gKFH6F7vzRNHAukRKxnH12Oy99xmt1wgyCjneRZtQou7lq8vAts4Tbgrq0ELz3TVB2nim8dLCEZGfV8US6v266h8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1623097045265616.2325651458968; Mon, 7 Jun 2021 13:17:25 -0700 (PDT) Received: from localhost ([::1]:33386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqLga-0004S9-6G for importer@patchew.org; Mon, 07 Jun 2021 16:17:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqLX0-00049s-8P for qemu-devel@nongnu.org; Mon, 07 Jun 2021 16:07:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:22147) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqLWt-0006V6-OO for qemu-devel@nongnu.org; Mon, 07 Jun 2021 16:07:30 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-AJR95NzSOy-r0Mag9JaFjQ-1; Mon, 07 Jun 2021 16:07:21 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 583451922987; Mon, 7 Jun 2021 20:07:12 +0000 (UTC) Received: from scv.redhat.com (ovpn-116-137.rdu2.redhat.com [10.10.116.137]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9B5725C1C2; Mon, 7 Jun 2021 20:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623096442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0yi3zJ/W406FA0wH8HIrQXSAWRKf9EFPpOyS7sMrer8=; b=UA+7PllmgkXkBBPvx1BqbnCBqs04BbkaloQR332d8RXiqfEYQC/0qdyeqQ/cagsvybaiXN IkJ513gNJzQQ6iN6fu5nEmyokA+NJjfhYN2/SoYygDl54MkAtbe0akApHOFKKKR4zThD9B EZAD14s49rCj+QkFhRyvxgnaW4QjAU8= X-MC-Unique: AJR95NzSOy-r0Mag9JaFjQ-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH 19/42] scripts/qmp-shell: Make verbose a public attribute Date: Mon, 7 Jun 2021 16:06:26 -0400 Message-Id: <20210607200649.1840382-20-jsnow@redhat.com> In-Reply-To: <20210607200649.1840382-1-jsnow@redhat.com> References: <20210607200649.1840382-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Niteesh G . S ." , Cleber Rosa , John Snow , Markus Armbruster , Eduardo Habkost Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" No real reason to hide this behind an underscore; make it part of the initializer and make it a regular RW attribute. Signed-off-by: John Snow --- scripts/qmp/qmp-shell | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell index de5fa189f0..cfcefb95f9 100755 --- a/scripts/qmp/qmp-shell +++ b/scripts/qmp/qmp-shell @@ -113,7 +113,7 @@ class FuzzyJSON(ast.NodeTransformer): # TODO: QMPShell's interface is a bit ugly (eg. _fill_completion() and # _execute_cmd()). Let's design a better one. class QMPShell(qmp.QEMUMonitorProtocol): - def __init__(self, address, pretty=3DFalse): + def __init__(self, address, pretty=3DFalse, verbose=3DFalse): super().__init__(self.parse_address(address)) self._greeting =3D None self._completer =3D None @@ -122,7 +122,7 @@ class QMPShell(qmp.QEMUMonitorProtocol): self._actions =3D list() self._histfile =3D os.path.join(os.path.expanduser('~'), '.qmp-shell_history') - self._verbose =3D False + self.verbose =3D verbose =20 def _fill_completion(self): cmds =3D self.cmd('query-commands') @@ -271,7 +271,7 @@ class QMPShell(qmp.QEMUMonitorProtocol): # For transaction mode, we may have just cached the action: if qmpcmd is None: return True - if self._verbose: + if self.verbose: self._print(qmpcmd) resp =3D self.cmd_obj(qmpcmd) if resp is None: @@ -317,13 +317,10 @@ class QMPShell(qmp.QEMUMonitorProtocol): =20 return self._execute_cmd(cmdline) =20 - def set_verbosity(self, verbose): - self._verbose =3D verbose - =20 class HMPShell(QMPShell): - def __init__(self, address, pretty=3DFalse): - super().__init__(address, pretty) + def __init__(self, address, pretty=3DFalse, verbose=3DFalse): + super().__init__(address, pretty, verbose) self.__cpu_index =3D 0 =20 def __cmd_completion(self): @@ -423,7 +420,7 @@ def main(): =20 shell_class =3D HMPShell if args.hmp else QMPShell try: - qemu =3D shell_class(args.qmp_server, args.pretty) + qemu =3D shell_class(args.qmp_server, args.pretty, args.verbose) except qmp.QMPBadPortError: parser.error(f"Bad port number: {args.qmp_server}") return # pycharm doesn't know error() is noreturn @@ -438,7 +435,6 @@ def main(): die(f"Couldn't connect to {args.qmp_server}: {err!s}") =20 qemu.show_banner() - qemu.set_verbosity(args.verbose) while qemu.read_exec_command(qemu.get_prompt()): pass qemu.close() --=20 2.31.1