From nobody Tue Feb 10 12:43:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1623087277; cv=none; d=zohomail.com; s=zohoarc; b=SNBfWjGFA+wzKUtLCZwDcQZr6b4ap0QelOYknr+81BhmIxhjqMtzf2w2zWz0M6APEi7nlawFt0DQeD1cqA+HOoVwf9VokH5T9aUrUbGArJiSu91qgMJPyDlSVckoJKHZlA2Qag7GAUIJEbVeQoiT/u3OJK2w4z9L0smM7VJRxGI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623087277; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=v6w6D3n71RpoUYab/m0xGRbMyYPeb8rynJ5A3BjU3ls=; b=OoJJNQjr3xr1mZ2AGz1Oy2BoF7R+6MGW2e+Lqu+k6DrJCI/l4/H7G8d25S30V6Om54hAaCRIyDSYt9iTCxlUT2nGTD6obuSH4qE3xun4L/w0fg7jnGE2w8JkDXW0y+Op2CbZcwPtje2d4pIM+hq4B7HN1M9S4oJQPN+PJl1WrqU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1623087277227132.46687579491606; Mon, 7 Jun 2021 10:34:37 -0700 (PDT) Received: from localhost ([::1]:49110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqJ92-0006Sx-2t for importer@patchew.org; Mon, 07 Jun 2021 13:34:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqIb2-0007uf-N0 for qemu-devel@nongnu.org; Mon, 07 Jun 2021 12:59:28 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:46671) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqIaX-0007z8-Qw for qemu-devel@nongnu.org; Mon, 07 Jun 2021 12:59:28 -0400 Received: by mail-wr1-x429.google.com with SMTP id a11so16558901wrt.13 for ; Mon, 07 Jun 2021 09:58:42 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id n10sm18891677wre.95.2021.06.07.09.58.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jun 2021 09:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=v6w6D3n71RpoUYab/m0xGRbMyYPeb8rynJ5A3BjU3ls=; b=EsEkyYC7Ayih1klwF1CkLCtrmCF7DH00AqEtcgitdJ1pHv5hqNGE5MVwlwOE3zi+oM lOUtBHubeQiAkyW6/BaiYo6tG7/lVZ6l6zVAQmgq0ww/HXzGAWjd551YzYvYczCJJy+N IYNljMbn+D0N6aLRncLdW5x3gu7VyBq97P0RFqRf3Aa2gPMnziRHaRZhDfUIvgJ+U3v/ dHUP0MAMv3mNnIC3ermJC/LRV79qy8fQmZdYBVbbyEBeL9zeZWAyP/G1Mbe3uxVh69zA G9zdPV974BRdTrfXKxR3OkU83zPD6rEbtjSG0ledb7dyTw2U1/hFG9JcQ7dbyQTNtnwv sRbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v6w6D3n71RpoUYab/m0xGRbMyYPeb8rynJ5A3BjU3ls=; b=tesMd2KJVbUJQ+DetljlzwVjcb2+G5BvQke1X/dkFdNL5mzcFG7LLCNjdbeF8xrqtB 0uGRytqo3CpNK2HNckXzz5V4WTPqT76S8H9lJ/bWgCbpD7fd1u2E2YMsEcT93mfOVBop GHnl3vTGGJDTRPxpOeAwq+Cg6GcL+w5Tp1VJvrDzDzoxyiaBK1TdX/0kzmRW3G8thD6h 1uGhIQFQjwkd9CbmCOBX2l3ZFhjgJF7RFQymZhiykuVK/imN/j//wai+A7Nv+Xdv9vBg 2kdXXDRU9P3z7jJCL+FVne+nUq/y/JJzvrpz+W0G6Q9KCOiwPGGRfNpSUDSIXJwpz9xj 8h3A== X-Gm-Message-State: AOAM532S5gNKSuG0Jy7/3ZpvYDVeIL1IdPZaB1xoIxYcTXYEJxZoZMje guO2/PHUT6izzWjRQrmfTqfQ/A== X-Google-Smtp-Source: ABdhPJxpR4Jk7zg598YFP7sQiMEyz7gtLNo5eRci2f/PpFnIIwLm83esk73lL/plUJk6caolOQDp2A== X-Received: by 2002:adf:cd82:: with SMTP id q2mr11678942wrj.258.1623085121510; Mon, 07 Jun 2021 09:58:41 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 22/55] target/arm: Implement MVE VADD, VSUB, VMUL Date: Mon, 7 Jun 2021 17:57:48 +0100 Message-Id: <20210607165821.9892-23-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210607165821.9892-1-peter.maydell@linaro.org> References: <20210607165821.9892-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Implement the MVE VADD, VSUB and VMUL insns. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/helper-mve.h | 12 ++++++++++++ target/arm/mve.decode | 5 +++++ target/arm/mve_helper.c | 14 ++++++++++++++ target/arm/translate-mve.c | 16 ++++++++++++++++ 4 files changed, 47 insertions(+) diff --git a/target/arm/helper-mve.h b/target/arm/helper-mve.h index ad09170c9cf..b7e9af2461e 100644 --- a/target/arm/helper-mve.h +++ b/target/arm/helper-mve.h @@ -71,3 +71,15 @@ DEF_HELPER_FLAGS_4(mve_vbic, TCG_CALL_NO_WG, void, env, = ptr, ptr, ptr) DEF_HELPER_FLAGS_4(mve_vorr, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr) DEF_HELPER_FLAGS_4(mve_vorn, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr) DEF_HELPER_FLAGS_4(mve_veor, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr) + +DEF_HELPER_FLAGS_4(mve_vaddb, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr) +DEF_HELPER_FLAGS_4(mve_vaddh, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr) +DEF_HELPER_FLAGS_4(mve_vaddw, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr) + +DEF_HELPER_FLAGS_4(mve_vsubb, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr) +DEF_HELPER_FLAGS_4(mve_vsubh, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr) +DEF_HELPER_FLAGS_4(mve_vsubw, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr) + +DEF_HELPER_FLAGS_4(mve_vmulb, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr) +DEF_HELPER_FLAGS_4(mve_vmulh, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr) +DEF_HELPER_FLAGS_4(mve_vmulw, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr) diff --git a/target/arm/mve.decode b/target/arm/mve.decode index 332e0b8d1d6..f7d1d303f17 100644 --- a/target/arm/mve.decode +++ b/target/arm/mve.decode @@ -33,6 +33,7 @@ =20 @1op .... .... .... size:2 .. .... .... .... .... &1op qd=3D%qd qm=3D%qm @1op_nosz .... .... .... .... .... .... .... .... &1op qd=3D%qd qm=3D%qm s= ize=3D0 +@2op .... .... .. size:2 .... .... .... .... .... &2op qd=3D%qd qm=3D%qm q= n=3D%qn @2op_nosz .... .... .... .... .... .... .... .... &2op qd=3D%qd qm=3D%qm q= n=3D%qn size=3D0 =20 # Vector loads and stores @@ -77,6 +78,10 @@ VORR 1110 1111 0 . 10 ... 0 ... 0 0001 . 1 .= 1 ... 0 @2op_nosz VORN 1110 1111 0 . 11 ... 0 ... 0 0001 . 1 . 1 ... 0 @2op_nosz VEOR 1111 1111 0 . 00 ... 0 ... 0 0001 . 1 . 1 ... 0 @2op_nosz =20 +VADD 1110 1111 0 . .. ... 0 ... 0 1000 . 1 . 0 ... 0 @2op +VSUB 1111 1111 0 . .. ... 0 ... 0 1000 . 1 . 0 ... 0 @2op +VMUL 1110 1111 0 . .. ... 0 ... 0 1001 . 1 . 1 ... 0 @2op + # Vector miscellaneous =20 VCLS 1111 1111 1 . 11 .. 00 ... 0 0100 01 . 0 ... 0 @1op diff --git a/target/arm/mve_helper.c b/target/arm/mve_helper.c index 6b3d4dbf2da..39ab684c0c3 100644 --- a/target/arm/mve_helper.c +++ b/target/arm/mve_helper.c @@ -323,6 +323,12 @@ DO_1OP(vfnegs, 4, uint32_t, H4, DO_FNEG) mve_advance_vpt(env); \ } =20 +/* provide unsigned 2-op helpers for all sizes */ +#define DO_2OP_U(OP, FN) \ + DO_2OP(OP##b, 1, uint8_t, H1, FN) \ + DO_2OP(OP##h, 2, uint16_t, H2, FN) \ + DO_2OP(OP##w, 4, uint32_t, H4, FN) + #define DO_AND(N, M) ((N) & (M)) #define DO_BIC(N, M) ((N) & ~(M)) #define DO_ORR(N, M) ((N) | (M)) @@ -334,3 +340,11 @@ DO_2OP(vbic, 1, uint8_t, H1, DO_BIC) DO_2OP(vorr, 1, uint8_t, H1, DO_ORR) DO_2OP(vorn, 1, uint8_t, H1, DO_ORN) DO_2OP(veor, 1, uint8_t, H1, DO_EOR) + +#define DO_ADD(N, M) ((N) + (M)) +#define DO_SUB(N, M) ((N) - (M)) +#define DO_MUL(N, M) ((N) * (M)) + +DO_2OP_U(vadd, DO_ADD) +DO_2OP_U(vsub, DO_SUB) +DO_2OP_U(vmul, DO_MUL) diff --git a/target/arm/translate-mve.c b/target/arm/translate-mve.c index 0e0fa252364..1b2c8cd5ff7 100644 --- a/target/arm/translate-mve.c +++ b/target/arm/translate-mve.c @@ -363,3 +363,19 @@ DO_LOGIC(VBIC, gen_helper_mve_vbic) DO_LOGIC(VORR, gen_helper_mve_vorr) DO_LOGIC(VORN, gen_helper_mve_vorn) DO_LOGIC(VEOR, gen_helper_mve_veor) + +#define DO_2OP(INSN, FN) \ + static bool trans_##INSN(DisasContext *s, arg_2op *a) \ + { \ + MVEGenTwoOpFn *fns[] =3D { \ + gen_helper_mve_##FN##b, \ + gen_helper_mve_##FN##h, \ + gen_helper_mve_##FN##w, \ + NULL, \ + }; \ + return do_2op(s, a, fns[a->size]); \ + } + +DO_2OP(VADD, vadd) +DO_2OP(VSUB, vsub) +DO_2OP(VMUL, vmul) --=20 2.20.1