From nobody Tue Feb 10 12:59:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1622756816; cv=none; d=zohomail.com; s=zohoarc; b=QW9sChwBsAlKt/5eCfoU1TKBsk3qPXnavTOXC2V3D1JcLaqQPG5gxj2XIKTp0oLAzCmLnbUMEcL4wUR656iCIW3epLo+5isn3rkSDxHvcStZCfG1TRd3sAnZJK6xREiCvJDqkNR/f1MtiLaloMzDsMX2l8qyvqKP3R8zYF/NDaY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622756816; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ppZ1jH79N3swPQMu5gvh4yX8BmZmZOhaiSlhleLfgRI=; b=cfEbY9I3sKJcOMn1u+1EQKEAKZXL359N7rBBTmdFmjoncTeEJ94gzzpRg0q2SgopaFbWAl3Odk4upc8Wjq7Skupu63rzi/Ua2RikWuHD0hUbAvoQzCiWbTYjmjqLnddRGi2DNsu2U8nYixsUty8cUslEu304aHQdrZmrFipQ+90= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1622756816096515.9078744050621; Thu, 3 Jun 2021 14:46:56 -0700 (PDT) Received: from localhost ([::1]:38300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lovB1-0007wi-1S for importer@patchew.org; Thu, 03 Jun 2021 17:46:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lov5z-0002Ex-Gq for qemu-devel@nongnu.org; Thu, 03 Jun 2021 17:41:43 -0400 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:44020) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lov5w-00014r-Km for qemu-devel@nongnu.org; Thu, 03 Jun 2021 17:41:43 -0400 Received: by mail-pl1-x630.google.com with SMTP id v12so3580090plo.10 for ; Thu, 03 Jun 2021 14:41:40 -0700 (PDT) Received: from localhost.localdomain (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id p65sm40115pfb.62.2021.06.03.14.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 14:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ppZ1jH79N3swPQMu5gvh4yX8BmZmZOhaiSlhleLfgRI=; b=WhqXS0Sn8Talgk2LHvsCcZ0eoJvIQSuH9KMIaqVPwzFt/CXUvmIBjNySjuzYC6Bogq mzuoosyX6GhaZa/e45hUP6GhjRRLYjmcE8kbu2kAtCeXxGasnunE/TZ8Gp6Nt5+x4nC6 /l3hecSz/CUQD8uMg+fkWJLW4xmSS8zd+MsMHlwoirJrpwMv0aslwqRChbgxPYznGaB1 8ZamjSTbe9x70w7cfCFtd4Pcu/DQDxbAiSEHLj1CS+9IVEsZLsRVL+Vy6CzdSomTAanR kQ6c40+jpsSRNhk9nqy4vbKOEqCZNqvNMe5n3pGq9t6fw7zocJ04O/1Uhmfn5Zq3Q7U7 d+bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ppZ1jH79N3swPQMu5gvh4yX8BmZmZOhaiSlhleLfgRI=; b=nizagitmPVRCXExu8KaGeqKtRZ8/9n0dG3GEaEZYWBNlKOSP2atWM8SONpzxr2lCM0 YuSEszSgsDJGw/ZnVKNI7iOSBc2EGeIPjV8Rf2YZSD54/wAz8Ahk+Cv89TzcbYjLWMnm H1SnBRGpKyuK9CHhbgO5BhzfYoMxIuoJtzR7K10GUAqzEtvk9PRr835kcAXJ/vwvzCD/ NxznkEBzxX8TvkxAJEjh2i6cIzaa4Bjz6q4xN8EReBiO1B7dEv8kFGCTlT7oVvVpX39+ Fot+OPdM6k9Npadlon8hKgDZHp5zPSJZtnbSwahw2+jzv5wkZBcz2y4yAsfekFG89b5L yl/w== X-Gm-Message-State: AOAM530cBmigjxrTy0eoPpST40iLSmmrzlioUJU+C2PBnQUOWXLniEzB +K8JB6V9BRGCDT5tGH3g1cakRWgvshyj2g== X-Google-Smtp-Source: ABdhPJwZa2oGLsIt0HYbKZNlbRPP5hcGj6plA0nu/zQhmMOoTPMHJZe1YVMtDjCAV1h2TPFWUSmKfg== X-Received: by 2002:a17:902:cec3:b029:10d:22fa:183c with SMTP id d3-20020a170902cec3b029010d22fa183cmr1189303plg.53.1622756499291; Thu, 03 Jun 2021 14:41:39 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PULL 10/29] softfloat: Reduce FloatFmt Date: Thu, 3 Jun 2021 14:41:12 -0700 Message-Id: <20210603214131.629841-11-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210603214131.629841-1-richard.henderson@linaro.org> References: <20210603214131.629841-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Remove frac_lsb, frac_lsbm1, roundeven_mask. Compute these from round_mask in parts$N_uncanon_normal. With floatx80, round_mask will not be tied to frac_shift. Everything else is easily computable. Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Richard Henderson --- fpu/softfloat.c | 29 ++++++++++++----------------- fpu/softfloat-parts.c.inc | 6 +++--- 2 files changed, 15 insertions(+), 20 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index ea7ee13201..741480c568 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -563,9 +563,7 @@ typedef struct { * frac_size: the size of the fraction field * frac_shift: shift to normalise the fraction with DECOMPOSED_BINARY_PO= INT * The following are computed based the size of fraction - * frac_lsb: least significant bit of fraction - * frac_lsbm1: the bit below the least significant bit (for rounding) - * round_mask/roundeven_mask: masks used for rounding + * round_mask: bits below lsb which must be rounded * The following optional modifiers are available: * arm_althp: handle ARM Alternative Half Precision */ @@ -575,24 +573,21 @@ typedef struct { int exp_max; int frac_size; int frac_shift; - uint64_t frac_lsb; - uint64_t frac_lsbm1; - uint64_t round_mask; - uint64_t roundeven_mask; bool arm_althp; + uint64_t round_mask; } FloatFmt; =20 /* Expand fields based on the size of exponent and fraction */ -#define FLOAT_PARAMS(E, F) \ - .exp_size =3D E, \ - .exp_bias =3D ((1 << E) - 1) >> 1, \ - .exp_max =3D (1 << E) - 1, \ - .frac_size =3D F, \ - .frac_shift =3D (-F - 1) & 63, \ - .frac_lsb =3D 1ull << ((-F - 1) & 63), \ - .frac_lsbm1 =3D 1ull << ((-F - 2) & 63), \ - .round_mask =3D (1ull << ((-F - 1) & 63)) - 1, \ - .roundeven_mask =3D (2ull << ((-F - 1) & 63)) - 1 +#define FLOAT_PARAMS_(E, F) \ + .exp_size =3D E, \ + .exp_bias =3D ((1 << E) - 1) >> 1, \ + .exp_max =3D (1 << E) - 1, \ + .frac_size =3D F + +#define FLOAT_PARAMS(E, F) \ + FLOAT_PARAMS_(E, F), \ + .frac_shift =3D (-F - 1) & 63, \ + .round_mask =3D (1ull << ((-F - 1) & 63)) - 1 =20 static const FloatFmt float16_params =3D { FLOAT_PARAMS(5, 10) diff --git a/fpu/softfloat-parts.c.inc b/fpu/softfloat-parts.c.inc index e05909db8c..a026581c33 100644 --- a/fpu/softfloat-parts.c.inc +++ b/fpu/softfloat-parts.c.inc @@ -145,10 +145,10 @@ static void partsN(uncanon_normal)(FloatPartsN *p, fl= oat_status *s, { const int exp_max =3D fmt->exp_max; const int frac_shift =3D fmt->frac_shift; - const uint64_t frac_lsb =3D fmt->frac_lsb; - const uint64_t frac_lsbm1 =3D fmt->frac_lsbm1; const uint64_t round_mask =3D fmt->round_mask; - const uint64_t roundeven_mask =3D fmt->roundeven_mask; + const uint64_t frac_lsb =3D round_mask + 1; + const uint64_t frac_lsbm1 =3D round_mask ^ (round_mask >> 1); + const uint64_t roundeven_mask =3D round_mask | frac_lsb; uint64_t inc; bool overflow_norm =3D false; int exp, flags =3D 0; --=20 2.25.1