From nobody Tue Feb 10 03:38:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.51 as permitted sender) client-ip=209.85.208.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1622711009; cv=none; d=zohomail.com; s=zohoarc; b=RnWu3RKdoCw/EWZwDS8NDg3txnFg1AHifb1sXSYVwOiITfv7hjPYUlscjP+rQomYxl/lOU5YgIPhJLzFQz7RJE8PMoCaM4/aXSyLsmNrFbSwp2XNjW5hWVDU1/xpZCDqNAeNnGlOXMRUbYfY2OC4fu7RpzgMqfXVQEFghkc0KeY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622711009; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5sevVFrnb8PFEJqb8tjfwJ5PpGOfYaPfNnd2GAELM28=; b=S73bHaOoqvqr/Yv/Eo06u+TLVsf67ght3WfpzkoYQQCqYwoWNGIg438kqAaenqgOTIdKaIB7zu2cCAd2CcL6g+qb6EMGCvonVBRa7wpr6G6njllNonszP9TeaYT1gybJ3ntI2BkdzLHWSbXLkkaCYEPZByD67qdDPU2EtjOV7kQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by mx.zohomail.com with SMTPS id 1622711009872129.36919144257354; Thu, 3 Jun 2021 02:03:29 -0700 (PDT) Received: by mail-ed1-f51.google.com with SMTP id t3so6216064edc.7 for ; Thu, 03 Jun 2021 02:03:28 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id i12sm1412143edx.13.2021.06.03.02.03.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 02:03:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5sevVFrnb8PFEJqb8tjfwJ5PpGOfYaPfNnd2GAELM28=; b=spT1DOgqGrG7fS96sbEzZX1jWqOkX2yKvAoAzo/hvMRUZkMejLSHUVomZU9dmDXk83 ySsS+9wV1BZrS3dtOPrronExChdfjh70HI8N8pkeXHduZP4CLl07xVYoWNnf0c5gOTst jL9pu2WCTaFKrdqRmVhKB8Sy302lGnnI1uobLGH9RaDhdcZ2S6S4neMBVRa/8uy8uCls jt7Ajotnu++pIHuK9VGw3lldH5ebGy5Ph3ZA/umO+yhMIQLXbL1CpaRMei4E9LvNJ4AH LtO91kbKzV4qvV252XgDgKiI9GrGqVkE3R7Bkc0kavQKepjcQy00NquCvU9P1t8ADyFU xKyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=5sevVFrnb8PFEJqb8tjfwJ5PpGOfYaPfNnd2GAELM28=; b=U16urkm5lfhaezUk+fdKGOr/iQfUZY7R7O+g+/68q+ZPwASy9lhYhS4UMfvLVtZPR8 t01OVGuv6+SbzvnTnmTPUnU/bj8vCfYy7Y/yEFKQrA0RNEqgrMAeyXjKOF3SgW/ZI4aY AIvD5u4WXANNJ70rfaZXBXH3vZ3sHZl6LPIzZ1RKGbVjlQHFE4m2MvOdwafO6lutkjB4 V8EQHm6J7oKHWVG4jnyRP3/dbf2ZOcXu4jQETZMwwWsvVggH1eGhbfucum8dOlgh6wpY HBWFi9CaNCuNdJG5zoHhu9AGueAOAw5LxZ8NMdnT31r4kmxNx+T5o8XiGmKlWeq9kjwX SUag== X-Gm-Message-State: AOAM533JxbkA0xY5fqp6jin5/zXO8FqulU3qD9lgQUUtk4lUGepNglWZ pgtNcj9CzEXgsf79HovHzvs= X-Google-Smtp-Source: ABdhPJw0l2ndqqHOCmeS+6Z9vZBweHDQFaWjuseXXATWzkfB7GmQ5MF7ZBMv8gmWSBMlKW2L9/tk2g== X-Received: by 2002:aa7:ca50:: with SMTP id j16mr11466174edt.158.1622711007594; Thu, 03 Jun 2021 02:03:27 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alistair Francis , "Edgar E. Iglesias" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/6] target/microblaze: Assert transaction failures have exception enabled Date: Thu, 3 Jun 2021 11:03:07 +0200 Message-Id: <20210603090310.2749892-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210603090310.2749892-1-f4bug@amsat.org> References: <20210603090310.2749892-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) If exceptions are disabled, we must not get a transaction failure. Assert they are enabled passed that point. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/microblaze/op_helper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/microblaze/op_helper.c b/target/microblaze/op_helper.c index 8d20522ee88..1048e656e27 100644 --- a/target/microblaze/op_helper.c +++ b/target/microblaze/op_helper.c @@ -122,9 +122,7 @@ void mb_cpu_transaction_failed(CPUState *cs, hwaddr phy= saddr, vaddr addr, access_type =3D=3D MMU_INST_FETCH ? "INST_FETCH" : (access_type =3D=3D MMU_DATA_LOAD ? "DATA_LOAD" : "DATA_= STORE")); =20 - if (!(env->msr & MSR_EE)) { - return; - } + assert(env->msr & MSR_EE); =20 if (access_type =3D=3D MMU_INST_FETCH) { if (!cpu->cfg.iopb_bus_exception) { --=20 2.26.3