From nobody Tue Feb 10 04:08:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1622708693; cv=none; d=zohomail.com; s=zohoarc; b=N/lRXtes4gkXwbOlWOfVxZ96jsv1nJv1rA+kCQAK80QlHbhStVDo8A2suT5BNrf6zZqVgP/C59br0o2mD56CSvKw8SvgCBvMkh3QiEgkpjyiJ4F35tN6GLd05ZIEW9EjHoYff9nUH7DEyGF7QSLL7cW+BtawqAtxjW3fHaH2rH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622708693; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=G8x5YIYmY90PaJLaDYzHo0x01UAyVjDUdAxDYa5Giv0=; b=XcvK7vTtzjLUvNwV+jnEIcIf3h9nebeqoWhLGhWw2SS25LImhTQA956gAEhtk1yG1lF5L3jtccHMKFfnkWBJA8YgYiaDo7bqHThSUWzCeul6nhFDYculF8QcqiXEcyUVwaGjwMsyjvu1nLXvtdqgYxz7czGfEtBfmvoBWhokAE4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1622708693064374.18614888439333; Thu, 3 Jun 2021 01:24:53 -0700 (PDT) Received: from localhost ([::1]:45426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loiep-0000rS-JF for importer@patchew.org; Thu, 03 Jun 2021 04:24:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loicv-000678-0k; Thu, 03 Jun 2021 04:22:55 -0400 Received: from ozlabs.org ([203.11.71.1]:45631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loics-0008Mr-5I; Thu, 03 Jun 2021 04:22:52 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4Fwf5l3TGpz9sX2; Thu, 3 Jun 2021 18:22:35 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1622708555; bh=+veWRm3qciPKOMdhHBBZez0+/vh39rCngCu+l7WZZ2Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fpvubgL5FhyN98jGHn37bjFhyIE72Nl516cWmFNNUDMh/JxsjRPvigjTgPW33pGqB dkHxR2ly2GrkGXqHqzlkPW75IBeqoq1zRaAIUi9xBuY6bm0Pu7h8CyN/QyAcYEetyl ERP6lWABg5fp7RG6RQKdKEnfBnm8yOH3fOkNU2xk= From: David Gibson To: peter.maydell@linaro.org, groug@kaod.org Subject: [PULL 03/42] target/ppc: reduce usage of fpscr_set_rounding_mode Date: Thu, 3 Jun 2021 18:21:52 +1000 Message-Id: <20210603082231.601214-4-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210603082231.601214-1-david@gibson.dropbear.id.au> References: <20210603082231.601214-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=203.11.71.1; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: "Bruno Larsen (billionai)" It is preferable to store the current rounding mode and retore from that than recalculating from fpscr, so we changed the behavior of do_fri and VSX_ROUND to do it like that. Suggested-by: Richard Henderson Signed-off-by: Bruno Larsen (billionai) Reviewed-by: Richard Henderson Message-Id: <20210521201759.85475-4-bruno.larsen@eldorado.org.br> Signed-off-by: David Gibson --- target/ppc/fpu_helper.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/ppc/fpu_helper.c b/target/ppc/fpu_helper.c index 44315fca0b..a4a283df2b 100644 --- a/target/ppc/fpu_helper.c +++ b/target/ppc/fpu_helper.c @@ -822,6 +822,7 @@ static inline uint64_t do_fri(CPUPPCState *env, uint64_= t arg, int rounding_mode) { CPU_DoubleU farg; + FloatRoundMode old_rounding_mode =3D get_float_rounding_mode(&env->fp_= status); =20 farg.ll =3D arg; =20 @@ -834,8 +835,7 @@ static inline uint64_t do_fri(CPUPPCState *env, uint64_= t arg, float_flag_inexact; set_float_rounding_mode(rounding_mode, &env->fp_status); farg.ll =3D float64_round_to_int(farg.d, &env->fp_status); - /* Restore rounding mode from FPSCR */ - fpscr_set_rounding_mode(env); + set_float_rounding_mode(old_rounding_mode, &env->fp_status); =20 /* fri* does not set FPSCR[XX] */ if (!inexact) { @@ -3136,8 +3136,10 @@ void helper_##op(CPUPPCState *env, ppc_vsr_t *xt, pp= c_vsr_t *xb) \ { \ ppc_vsr_t t =3D *xt; \ int i; \ + FloatRoundMode curr_rounding_mode; \ \ if (rmode !=3D FLOAT_ROUND_CURRENT) { \ + curr_rounding_mode =3D get_float_rounding_mode(&env->fp_status); \ set_float_rounding_mode(rmode, &env->fp_status); \ } \ \ @@ -3160,7 +3162,7 @@ void helper_##op(CPUPPCState *env, ppc_vsr_t *xt, ppc= _vsr_t *xb) \ * mode from FPSCR \ */ \ if (rmode !=3D FLOAT_ROUND_CURRENT) { \ - fpscr_set_rounding_mode(env); \ + set_float_rounding_mode(curr_rounding_mode, &env->fp_status); \ env->fp_status.float_exception_flags &=3D ~float_flag_inexact; \ } \ \ --=20 2.31.1