From nobody Mon Feb 9 18:18:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1622680722; cv=none; d=zohomail.com; s=zohoarc; b=FqaZjnR2XWiYFygf5NeUuWQR9pmQEmBt7emtdb6MWNuGUuStzfhCN/GA+1r0MLgvvIYmsE4eRdVSEeg5UKZBkUAka/xkugkB4N8o4z4uv4Hg73iJ+Gkjq75jp+H0aorbIxoj4RIiSD1dKeaxluxSnVv4ylOxFUt17x1NOzXp1Rc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622680722; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BlML2KWf7Wrpq1uH77fBgwovpRG+a87R9LrvHMGlJ6c=; b=iOUsM7y8HI4JZDltSPPg1gVq+OXLz9M9tY9Z+c76pLbsANJHUHqlN12B+29x/MuVjh5mkasdFuqBz86YXTdk5dLtPbK63T/PMTnsKezYQhuUvE9QdSb0kbofiMmi9ZRRsBcSY86TXdJo1VOlzLe/+UncirkDT5+9Qr3Re6mgcS8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1622680722969330.7012237519906; Wed, 2 Jun 2021 17:38:42 -0700 (PDT) Received: from localhost ([::1]:52012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lobNg-0006hz-RO for importer@patchew.org; Wed, 02 Jun 2021 20:38:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lobMW-00047s-1h for qemu-devel@nongnu.org; Wed, 02 Jun 2021 20:37:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55849) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lobMT-0004Tr-Q0 for qemu-devel@nongnu.org; Wed, 02 Jun 2021 20:37:27 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-411-V0Hsj7jUPVueAuygSmbWOQ-1; Wed, 02 Jun 2021 20:37:23 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6C141180FD62; Thu, 3 Jun 2021 00:37:22 +0000 (UTC) Received: from scv.redhat.com (ovpn-116-137.rdu2.redhat.com [10.10.116.137]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD2B810013D6; Thu, 3 Jun 2021 00:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622680644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BlML2KWf7Wrpq1uH77fBgwovpRG+a87R9LrvHMGlJ6c=; b=Q0OjIaq30PqYDaOHrX+miQoU8oesdCDdr5NsEQJyq42Z3ttx9TfJxpPnmePwpyit3IHrM3 8QSWAOhRTmodlQVBzbO8JYJS8KFmOMJ+F/7WbgCnT5gC/JdgdCQNINjZ6Q6F2LodURwPM7 Em9M2pO1SHNGI/KbetkstnhiXvzC8Qs= X-MC-Unique: V0Hsj7jUPVueAuygSmbWOQ-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v3 02/19] python/qmp: Fix type of SocketAddrT Date: Wed, 2 Jun 2021 20:37:02 -0400 Message-Id: <20210603003719.1321369-3-jsnow@redhat.com> In-Reply-To: <20210603003719.1321369-1-jsnow@redhat.com> References: <20210603003719.1321369-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster , John Snow , "Niteesh G . S ." , Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" In porting the qom tools, qmp-shell, etc; it becomes evident that this type is wrong. This is an integer, not a string. We didn't catch this before because none of QEMUMonitorProtocol's *users* happen to be checked, and the internal logic of this class is otherwise self-consistent. Additionally, mypy was not introspecting into the socket() interface to realize we were passing a bad type for AF_INET. Fixed now. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- python/qemu/qmp/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/qemu/qmp/__init__.py b/python/qemu/qmp/__init__.py index 9606248a3d2..5fb970f8a80 100644 --- a/python/qemu/qmp/__init__.py +++ b/python/qemu/qmp/__init__.py @@ -44,7 +44,7 @@ QMPMessage =3D Dict[str, Any] QMPReturnValue =3D Dict[str, Any] =20 -InternetAddrT =3D Tuple[str, str] +InternetAddrT =3D Tuple[str, int] UnixAddrT =3D str SocketAddrT =3D Union[InternetAddrT, UnixAddrT] =20 --=20 2.31.1