From nobody Tue Feb 10 05:44:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1622680732; cv=none; d=zohomail.com; s=zohoarc; b=gmiIYVyQhspH7qQ8KnRzw80pYSzcW4oYv4Ji+Tlvgwi8oxquIqaHN86JXiHLjLhsmIt6NJT5/+0Sad+iOIh6/2rTV5SHRT9rimwG8oYseOtLp4TaPn6P2mCN08QxYlCggpyrQxJG8COZ5WDPBEem89PhgSvcVJ9VPLzYTGa12Vs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622680732; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BcShfYPJMCAfGGa/wx/Z1T3yF3nL/JjQVhaObeoPp/s=; b=iBOXLnj+lxeAwK3DpYCGlViTi1Bytj9SmGXU0+DDAu1Xf3t3vgzKznytPjssb3iCVMUAp/yzQ1UkqqI3sgHQZjIOKhjCN629KAuMoSZWXBmi4vASnaqGVv76GqBwCSGbLQHrE07GGnZwzBQNCQ1K4sEsdMI7C+DinJ+Dhov46V0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1622680731964118.97538946673637; Wed, 2 Jun 2021 17:38:51 -0700 (PDT) Received: from localhost ([::1]:53104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lobNq-0007T1-RB for importer@patchew.org; Wed, 02 Jun 2021 20:38:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lobMg-0004bW-7I for qemu-devel@nongnu.org; Wed, 02 Jun 2021 20:37:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lobMe-0004hU-Ln for qemu-devel@nongnu.org; Wed, 02 Jun 2021 20:37:37 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-_vaTFtLVPM2m_rYnpY0h1Q-1; Wed, 02 Jun 2021 20:37:34 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4B802803620; Thu, 3 Jun 2021 00:37:33 +0000 (UTC) Received: from scv.redhat.com (ovpn-116-137.rdu2.redhat.com [10.10.116.137]) by smtp.corp.redhat.com (Postfix) with ESMTP id 74AA210013D6; Thu, 3 Jun 2021 00:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622680656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BcShfYPJMCAfGGa/wx/Z1T3yF3nL/JjQVhaObeoPp/s=; b=SnmQHoWhww2/beL42OB2WnGAWTuXYtKXKXtxQlufGpynzWljRw2CQJnRTjfiQi95mSJSdD z3nb2PhDoU6o+4DoYz6x/2XsCF8MpWXMWmhKptONWt+6gVE7PFHHgSjFtbdUMS2EXqqdCz e7PunyJc26pZmG0GQ0pJFF2as8eSaPg= X-MC-Unique: _vaTFtLVPM2m_rYnpY0h1Q-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v3 10/19] scripts/qom-fuse: Apply pylint rules Date: Wed, 2 Jun 2021 20:37:10 -0400 Message-Id: <20210603003719.1321369-11-jsnow@redhat.com> In-Reply-To: <20210603003719.1321369-1-jsnow@redhat.com> References: <20210603003719.1321369-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , John Snow , Markus Armbruster , "Niteesh G . S ." , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) - Catch specific exceptions from QMP - Reraise errors with explicit context - method parameters should match parent's names Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- scripts/qmp/qom-fuse | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/scripts/qmp/qom-fuse b/scripts/qmp/qom-fuse index ca30e928679..805e99c8ecd 100755 --- a/scripts/qmp/qom-fuse +++ b/scripts/qmp/qom-fuse @@ -23,7 +23,7 @@ from fuse import FUSE, FuseOSError, Operations =20 =20 sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'pytho= n')) -from qemu.qmp import QEMUMonitorProtocol +from qemu.qmp import QEMUMonitorProtocol, QMPResponseError =20 =20 fuse.fuse_python_api =3D (0, 2) @@ -47,7 +47,7 @@ class QOMFS(Operations): try: self.qmp.command('qom-list', path=3Dpath) return True - except: + except QMPResponseError: return False =20 def is_property(self, path): @@ -59,7 +59,7 @@ class QOMFS(Operations): if item['name'] =3D=3D prop: return True return False - except: + except QMPResponseError: return False =20 def is_link(self, path): @@ -73,10 +73,10 @@ class QOMFS(Operations): return True return False return False - except: + except QMPResponseError: return False =20 - def read(self, path, length, offset, fh): + def read(self, path, size, offset, fh): if not self.is_property(path): return -ENOENT =20 @@ -86,13 +86,13 @@ class QOMFS(Operations): try: data =3D self.qmp.command('qom-get', path=3Dpath, property=3Dp= rop) data +=3D '\n' # make values shell friendly - except: - raise FuseOSError(EPERM) + except QMPResponseError as err: + raise FuseOSError(EPERM) from err =20 if offset > len(data): return '' =20 - return bytes(data[offset:][:length], encoding=3D'utf-8') + return bytes(data[offset:][:size], encoding=3D'utf-8') =20 def readlink(self, path): if not self.is_link(path): --=20 2.31.1