From nobody Mon May 20 01:44:51 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1622538709; cv=none; d=zohomail.com; s=zohoarc; b=LTkFaAIB6P8mgQnLDS60MCZhLXYe4DA0bUpzftrjSE9vJyRaSMdE8Q1ruV3X1k5yN5wmbW48WAFnfImIUfa6jAN5qwHOwam132NbkHH4FMrLFOJsSBGTJ7m/AISQdr0+yi+e02SZ2Eg+5rVUD2K8SXKaifMnWDFXHrqRIK0nmas= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622538709; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=OQUrS1tZDptB7Sfh+dVZZrOUcLABv4RnyRL2OneaB3U=; b=KdTKyBDE/yWFUZQdu9dXug4XMZHj64SjqYC8m8tD/GZECCsBeSGJKJfKBlRps9GARNkHyH/a7r91HC3s1Gd3aWUjvs57GXVOJuJJ7+ctjIra3MJyWesB/HCTNnxZSunv6jcbDUXNiihrHlNOCh3QOMmHleBu9+y8CEuaBEDpYa4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1622538709617668.2272824449589; Tue, 1 Jun 2021 02:11:49 -0700 (PDT) Received: from localhost ([::1]:42646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lo0RA-0006jB-Hx for importer@patchew.org; Tue, 01 Jun 2021 05:11:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lo0N7-0004iY-81 for qemu-devel@nongnu.org; Tue, 01 Jun 2021 05:07:38 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]:34462) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lo0N1-0005Nz-9Y for qemu-devel@nongnu.org; Tue, 01 Jun 2021 05:07:36 -0400 Received: by mail-wr1-x432.google.com with SMTP id q5so2797100wrm.1 for ; Tue, 01 Jun 2021 02:07:28 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id h14sm2467620wmb.1.2021.06.01.02.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 02:07:25 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id F069B1FF7E; Tue, 1 Jun 2021 10:07:24 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OQUrS1tZDptB7Sfh+dVZZrOUcLABv4RnyRL2OneaB3U=; b=v8XJTAWzTUCr20VqsCwzWPfwzOWmbi3791twxDTncpefAByE3XLdi/pB2Wr+eT2Kfi XUuQFD0SR13BNHsuZdTKfw3RhcNOzKd+pljAI1mO5u3whKLHSbZOTyIynPb8vcp93abO +u9SzgBlSjFyUKMVx1YaYmi+iMfgQ6yfpy2oQFXSl9H+HHH9yq3wA/AosutdgXZar3yS ZzuUZ+VUoOIUSBk/cMW7t9i7ue1JnmHLVIsgVCDXABfn8fwXVFPqxx48c/jV59tvy17Z I3uO6j4WGsfU8/oAeSJ06lM4HgU9LXNsFRMP1urt6k9M+nzV41dL/WjrslvgICeyxoo7 wDBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=OQUrS1tZDptB7Sfh+dVZZrOUcLABv4RnyRL2OneaB3U=; b=bX78WTzFtCWZqv/B5mRtOqJxRyvc2K/x3gTBbIid67gJ7VJlbTHdZbILPzhGIqZsJu /LUdOXMfSD2Hr5RpniqiH7gjH/w7JiMFk9zIt9l/6/2t4qIFvRmHhSyiFkf4AOgezesv ZzhIqv+tsoIIZnRjUDERJRTvlZFL1BOrFy7K3BI8q4J2jlFJJ71Kgz4UiHhtXGzArXMZ FwVYCH0200EUCsNCFi2VjQzLXsJeeVSYe73j/XfuO7tbL9hhLIC+ykXOvrzP7t05eEkZ gj2qTWjJmvpWOwtGsBkjx841QdbGUXql73brXLlU9x6Is10kvFveBN4ZIOVvjweO/ix/ qg1Q== X-Gm-Message-State: AOAM532ShZCnwG4Qnk7uNbZawfqFDsOLdg2W9tLwgZc9G3M+QB8RYUG2 7bzupiPyX+bFQGscHWAYikmHWA== X-Google-Smtp-Source: ABdhPJxBRWX9ZDKccLiEXtSQ5NThelQM3kGlQouVma7uHHYd7lT7l4dSlHVpzfuVv/RppZfKR8Lwag== X-Received: by 2002:a5d:4203:: with SMTP id n3mr15067903wrq.132.1622538446656; Tue, 01 Jun 2021 02:07:26 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [RFC PATCH] semihosting/arm-compat: remove heuristic softmmu SYS_HEAPINFO Date: Tue, 1 Jun 2021 10:07:15 +0100 Message-Id: <20210601090715.22330-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew , qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The previous numbers were a guess at best. While we could extract the information from a loaded ELF file via -kernel we could still get tripped up by self decompressing or relocating code. Besides sane library code has access to the same symbols in run time to make a determination of the location of the heap. Signed-off-by: Alex Benn=C3=A9e Cc: Andrew Reviewed-by: Andrew Strauss Tested-by: Andrew Strauss --- semihosting/arm-compat-semi.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c index 1c29146dcf..041b4f6c04 100644 --- a/semihosting/arm-compat-semi.c +++ b/semihosting/arm-compat-semi.c @@ -1165,12 +1165,10 @@ target_ulong do_common_semihosting(CPUState *cs) case TARGET_SYS_HEAPINFO: { target_ulong retvals[4]; - target_ulong limit; int i; #ifdef CONFIG_USER_ONLY + target_ulong limit; TaskState *ts =3D cs->opaque; -#else - target_ulong rambase =3D common_semi_rambase(cs); #endif =20 GET_ARG(0); @@ -1201,12 +1199,15 @@ target_ulong do_common_semihosting(CPUState *cs) retvals[2] =3D ts->stack_base; retvals[3] =3D 0; /* Stack limit. */ #else - limit =3D current_machine->ram_size; - /* TODO: Make this use the limit of the loaded application. */ - retvals[0] =3D rambase + limit / 2; - retvals[1] =3D rambase + limit; - retvals[2] =3D rambase + limit; /* Stack base */ - retvals[3] =3D rambase; /* Stack limit. */ + /* + * Reporting 0 indicates we couldn't calculate the real + * values which should force most software to fall back to + * using information it has. + */ + retvals[0] =3D 0; /* Heap Base */ + retvals[1] =3D 0; /* Heap Limit */ + retvals[2] =3D 0; /* Stack base */ + retvals[3] =3D 0; /* Stack limit. */ #endif =20 for (i =3D 0; i < ARRAY_SIZE(retvals); i++) { --=20 2.20.1