From nobody Sun May 19 23:34:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) client-ip=209.85.128.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1622367942; cv=none; d=zohomail.com; s=zohoarc; b=nsZEaPdRB6521zzs1RCCDQ49DTlgdRHaSmju+nmlcEVq4X3YGUv+YvAT1A9whCusGxUi5r9bQUyXDNDj3rTFcYayQkx6RtIjUSLZUfAORPadjkRGEGOAUk9nnYsGTlR1AJzfs5IjI0YYJXk97/FPMMNKRo2+ze+QAWHgVwkznEA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622367942; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=2EC4J/erMubaOu3m1nON3gbxEnc3GwM9+fThrDD6RQA=; b=UHpC/yRHoe7ptBTjIaCTR0BICNdvUkrs66uN4yxuZd6VoYEvFKRxXBDuHo8Vi9zP/yi5atHbsjl9pzC9el298xEK4bt//o4i1f+m8fMYBNQXnKW0M1OdgqXIIi0xzH22qaNNgwkO5Zlik0TtkYAFEun9PLminC51t+UuQ9Vz8yY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mx.zohomail.com with SMTPS id 1622367942773429.40040134103253; Sun, 30 May 2021 02:45:42 -0700 (PDT) Received: by mail-wm1-f47.google.com with SMTP id l18-20020a1c79120000b0290181c444b2d0so4781954wme.5 for ; Sun, 30 May 2021 02:45:42 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id a11sm13099262wrr.48.2021.05.30.02.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 May 2021 02:45:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2EC4J/erMubaOu3m1nON3gbxEnc3GwM9+fThrDD6RQA=; b=e7J99iFVNn9j6qTqO84PEWYJMrmnFbJ97zQYHXSHBX6dI8dRQh1r9seD2vzHeZRpiB xv3btsI2x7vIKaRDIuvy+3jhdcsrCutbhaALSDbGSd7M+AXwWcU3BYKvoXInKTBkCa6V IpHoyWh8Me5qiSOhWUKE4v60z5BnX60HSq+hmpezDPtUbhwdFIbosx70B7Qele36n4wh KglN9yn7QmsMMdQ3Oa3coeDz3fUWqKLSRr04olB5CarRpuKjvgWjtdbWQ5iW46EzUPfL Xnq63iJXjqxpQhhXp+NSOPDVt0tag4tC8haPKR1IHIfSCNVKX6WuiwBdK2QTisH5hF/J svBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=2EC4J/erMubaOu3m1nON3gbxEnc3GwM9+fThrDD6RQA=; b=pDP8UdGBzx/h+/rQL9CPJ56BpI82Arshn+gHusyfpqpWZHmKPhe2hgMumt38X7CpXq m/TUC4j0QcfCr3blVY2F6kUK2vdhuos8fOtfbiuAfFTQr736B9b3NLHeVjHQZ0sZpaPq M8zGsxlsK0o2BENCwRQ78SOl/fnFi+Y8xGQ1bE2nY0+tgc3D4glRiiYPGQ16Bxwdl/ri fgGOIk95CI+nZB9DmjbYQ9otaHWZviErIsT7dqh7DcjzfUd1/l2tUUuOHzFgWwO5VkKa VWx2mal2Yt9suDvZfA5Hci0jKfWLhuoJQQgGwubFAYmW4vpjNxDvnnvkvJn12PYEueNn 2i+g== X-Gm-Message-State: AOAM533rqa+g6+ILqWT3BfbRz+XvCS5pc2w5IghUFlBpGM9nCGOScgvp 246LFIIHcSlg+wOXAm/Tcdk= X-Google-Smtp-Source: ABdhPJz64sHPtpoAMynOh/DxYmoEjc95oUptoZxVVVhwio0gGUxd4XyCLtwMrAYRJKge2zs4q0uJww== X-Received: by 2002:a7b:c749:: with SMTP id w9mr2889757wmk.3.1622367940871; Sun, 30 May 2021 02:45:40 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aurelien Jarno , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Jiaxun Yang Subject: [PATCH] target/mips: Fix TCG temporary leaks in gen_pool32a5_nanomips_insn() Date: Sun, 30 May 2021 11:45:37 +0200 Message-Id: <20210530094538.1275329-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Fix a pair of TCG temporary leak when translating nanoMIPS SHILO opcode. Fixes: 3285a3e4445 ("target/mips: Add emulation of DSP ASE for nanoMIPS") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index c03a8ae1fed..84c71a75c76 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -20177,16 +20177,18 @@ static void gen_pool32a5_nanomips_insn(DisasConte= xt *ctx, int opc, { TCGv tv0 =3D tcg_temp_new(); TCGv tv1 =3D tcg_temp_new(); int16_t imm =3D extract32(ctx->opcode, 16, 7); =20 tcg_gen_movi_tl(tv0, rd >> 3); tcg_gen_movi_tl(tv1, imm); gen_helper_shilo(tv0, tv1, cpu_env); + tcg_temp_free(tv1); + tcg_temp_free(tv0); } break; case NM_MULEQ_S_W_PHL: check_dsp(ctx); gen_helper_muleq_s_w_phl(v1_t, v1_t, v2_t, cpu_env); gen_store_gpr(v1_t, ret); break; case NM_MULEQ_S_W_PHR: --=20 2.26.3