From nobody Sun May 19 23:34:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) client-ip=209.85.128.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1622293525; cv=none; d=zohomail.com; s=zohoarc; b=gZxwg3aid5j+R/fZo85fUSYBx3xI67C83nNm8YUtuLgZcRydJXthIUKjtAo6Be9clRjMwlCXViX2GjVKht1oChpUXFjGdomXlikaSvw2lU+R9DJ+nKLtpDNNSNOxiiJMy8ayhT2gQbd7Qo1IXwqP4f6WHboSp8JQN2mDFZmHSq4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622293525; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=D39LBDTjVnFeFcVzucnITXqDwlPmZkN3o0zbJa8Rm3A=; b=KXwge+AWEVbmlgiIWkVR8hbuQNUhaJS/3LPA1KfuAizlTmnPk4s0m3Nh5qCck5TxWkANquUxo2Xolc8XTQrA0E166WUpLadZOvuPjK722NK3k8Oa3zvg/CPIo1vHjZylpy85XFIUoBZR3/FcaBbZ7Z/tKxNyTjPoW7YLGOshp6k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.zohomail.com with SMTPS id 162229352504559.1757746136218; Sat, 29 May 2021 06:05:25 -0700 (PDT) Received: by mail-wm1-f49.google.com with SMTP id n17-20020a7bc5d10000b0290169edfadac9so6045907wmk.1 for ; Sat, 29 May 2021 06:05:24 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id h9sm9489105wmb.35.2021.05.29.06.05.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 May 2021 06:05:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=D39LBDTjVnFeFcVzucnITXqDwlPmZkN3o0zbJa8Rm3A=; b=H6FRACHkUlx/jPbS0E2uWPFtQkDEk8c4ZLNgktzAGkdP37npdfEIhehE8zF7i4kHa7 xV3rdlZL7gs2kWJ9+XG9bM7tGIUhzfyv13AlA6LThNktuMZYYKs4DmMGT5W26lNQ4v/B +y5/NFlI6Ev/jRqjajrYUsx7u1xI5aISsLLqrLTQhiQivaKpcpB9Y99rpxIixLZ57VZN w2liB1uNMcRlmYq9SqwEMTA9YR6nxojFH3YKBxl1o+LiYtT+lxDvRfAu8HCwLQE0eGnp LxTD2ievc7dymPyTGsg30pPdWmKlpQxzwWLwGmaLSuzOyoSM2icPIMGpBRMsqXeXHjNt Ii8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=D39LBDTjVnFeFcVzucnITXqDwlPmZkN3o0zbJa8Rm3A=; b=eA/y/PUPY2y8wXrFPzs/5xh+pUS4+ynpOvtOZk9ugSVUwWad39ky1esI6lNv9eKjtV aZP/rsUueF84CMK6ExJTpwgT0rttQZp2Uk+ER8jXDdS+8kgr9YyARpUbsIKtvSiOR/pq 2uZe/LJkVGApGFUwSklomF8bn318nxWd8SBso+9aQaJzow0Yr9vnPFir4etwhJnHIXdR SN9QqIIQYJJQ1/GKFCXvPMkQ3Ul34WJhI/myBW1JfHFB2uThxaW8/OBGBr+wO6IyYpKt BZR0MVfCI9bvP6IBm7KphBLGLitaRf6Phl4DBJ/AQvdb3+yvKqtBXNn9U4GmvURmHKL4 zzDw== X-Gm-Message-State: AOAM532YAKslfNqw7zEYCoVqu69MW5uHn6jMRO/KpXbdBZO3qjfdWG/D DsGqDLYy6iXc/uaqtI7IVTw= X-Google-Smtp-Source: ABdhPJx4buMDjLpH+EtHOC0+yInh3rTxrS0/C+qeNNp8cncSwXAaji0ZH12OoygmUnbqCwgxpYb1WA== X-Received: by 2002:a1c:e284:: with SMTP id z126mr12790524wmg.108.1622293522885; Sat, 29 May 2021 06:05:22 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jiaxun Yang , Richard Henderson , Aurelien Jarno , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jia Liu Subject: [PATCH] target/mips: Fix DBALIGN DSP-R2 opcode 'byte position' field size Date: Sat, 29 May 2021 15:05:19 +0200 Message-Id: <20210529130520.1039274-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Per the "MIPS=C2=AE DSP Module for MIPS64 Architecture" manual (rev 3.02), Figure 5.12 "SPECIAL3 Encoding of APPEND/DAPPEND Instruction Sub-class" the byte position field ('bp') is 2 bits, not 3. Cc: Jia Liu Fixes: 26690560240 ("target-mips: Add ASE DSP compare-pick instructions") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index c03a8ae1fed..e68647ce14c 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -23016,8 +23016,8 @@ static void gen_mipsdsp_append(CPUMIPSState *env, D= isasContext *ctx, } break; case OPC_DBALIGN: - sa &=3D 7; - if (sa !=3D 0 && sa !=3D 2 && sa !=3D 4) { + sa &=3D 3; + if (sa !=3D 0 && sa !=3D 2) { tcg_gen_shli_tl(cpu_gpr[rt], cpu_gpr[rt], 8 * sa); tcg_gen_shri_tl(t0, t0, 8 * (8 - sa)); tcg_gen_or_tl(cpu_gpr[rt], cpu_gpr[rt], t0); --=20 2.26.3