From nobody Mon Feb 9 16:12:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1622048754; cv=none; d=zohomail.com; s=zohoarc; b=jyDu6fKnP4ZK2O8JP5wPsK+H8Y/tMy/SuMpnWFjLSILXoXkaOtq6nnGIpn0S9BmIvgmEXWYpnbhyqXm1uUBj9JFIS7ktYNQUB0moMPeGjwaisWdvF0XPbR6VGs9JNgmb9sJniJGFj1Z+SU52NPEjmxdnLjRivflvEqWSgE+kZM4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622048754; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=CIcR3Dg8r3/BLZX5s3uJXgxa95m9nxbDQsMDWt+Jqds=; b=PebErJy3oMbKbMDcoazJTNi25Gvf0lFPT8aq3SDMs0eaCzf/zkpTC1ADnBC/VdfRPO+fkwPoo0DopHTtzUq2mlWpv3vlRwJKvUchh5hg2zHk0kHrsPuZ/4JGLlsoWJsPcoHZ0bc/ZNcsOdfhnjlenHFy7qLYaHIqmFPGNDd1Rjc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1622048754634576.2015976945802; Wed, 26 May 2021 10:05:54 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-azUC5XwaNM6uLFnAeKTHyg-1; Wed, 26 May 2021 13:05:51 -0400 Received: by mail-wm1-f71.google.com with SMTP id l18-20020a05600c4f12b02901921c0f2098so763809wmq.0 for ; Wed, 26 May 2021 10:05:51 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (64.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.64]) by smtp.gmail.com with ESMTPSA id u8sm6728924wmq.29.2021.05.26.10.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 May 2021 10:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622048753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CIcR3Dg8r3/BLZX5s3uJXgxa95m9nxbDQsMDWt+Jqds=; b=TTNHOZa83fVY6eIvSWXMi08hy0bS4skdpLcIpbLdLK3uwP1qQCJ7Gba7u+zqAex95WoNcy MUGXOSEjd9U8Ky0vRkQ1bCdhhXIbjzCxBjCJRlpdI6AQU0swfOivdS+2OuzuJ6J1+LDM74 IJ+dkVs6UVtqx1ldNRJb1qhWDBlqXvk= X-MC-Unique: azUC5XwaNM6uLFnAeKTHyg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CIcR3Dg8r3/BLZX5s3uJXgxa95m9nxbDQsMDWt+Jqds=; b=Cia6fE1Aba2Ey2Q3fMYkEzmkxEi4HJYOeIW0x2UVFWIYYEqzuJsvlKg44bhumWunWx pwwjgz3ndjl9NuTBLzlvj9pod40fGWRXRJBJMOWJij+m0tiEB2JRkPT5u5nNHMS/AwqX iq6EwBq3nxI4jGtx9Qhlql42quPK5BS3Or6Ed1FlU4c24we/xu3sM9A+sRFrFuAAkMpb JHt1NBNgE+letN0yuycBstY4vUIZJco/3WI5Qg6xdabqT+OoIP3QLs6XPAknUtUode/1 qkDKfVo2T4ecxg50uhGtnrqD61p9BsQWAJJEs3KCI6mx90FC94PeG3yxOJtH2znzpB6O YK1g== X-Gm-Message-State: AOAM532DYL4bVq4I3GPqtE3dI5AHU1CAxHa5Cx3Pe9C3+ve7TjRsQj2a DQeXRLqu8q2dD3l5MZew/82QypIzYJac9sShe9EARVdvCVRx8ZAKpy8yOa4khbytaQYaLbuX2Bm Eb4xrjm19aFyOOg== X-Received: by 2002:a1c:e205:: with SMTP id z5mr3177883wmg.70.1622048750731; Wed, 26 May 2021 10:05:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwj4PizJCrJQJlSo/ySLsvv0tj5e6Z5qV1FcEphaUG4il7OPu6e6vZHZRXx2BjTcNzEqb6cww== X-Received: by 2002:a1c:e205:: with SMTP id z5mr3177867wmg.70.1622048750606; Wed, 26 May 2021 10:05:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Eric Blake , Markus Armbruster , Richard Henderson , Eduardo Habkost , Paolo Bonzini , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson , Greg Kurz , Cornelia Huck , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Juan Quintela , "Dr. David Alan Gilbert" , Thomas Huth , Laurent Vivier Subject: [PATCH v8 08/12] qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64 Date: Wed, 26 May 2021 19:04:28 +0200 Message-Id: <20210526170432.343588-9-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210526170432.343588-1-philmd@redhat.com> References: <20210526170432.343588-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) We might have a s390x/ppc64 QEMU binary built without the KVM accelerator (configured with --disable-kvm). Checking for /dev/kvm accessibility isn't enough, also check for the accelerator in the binary. Reviewed-by: David Gibson Reviewed-by: Greg Kurz Reviewed-by: Cornelia Huck Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 2b028df6875..102bc36b91c 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -1387,7 +1387,7 @@ int main(int argc, char **argv) */ if (g_str_equal(qtest_get_arch(), "ppc64") && (access("/sys/module/kvm_hv", F_OK) || - access("/dev/kvm", R_OK | W_OK))) { + access("/dev/kvm", R_OK | W_OK) || !qtest_has_accel("kvm"))) { g_test_message("Skipping test: kvm_hv not available"); return g_test_run(); } @@ -1398,7 +1398,7 @@ int main(int argc, char **argv) */ if (g_str_equal(qtest_get_arch(), "s390x")) { #if defined(HOST_S390X) - if (access("/dev/kvm", R_OK | W_OK)) { + if (access("/dev/kvm", R_OK | W_OK) || !qtest_has_accel("kvm")) { g_test_message("Skipping test: kvm not available"); return g_test_run(); } --=20 2.26.3